aboutsummaryrefslogtreecommitdiffstats
path: root/epan
AgeCommit message (Collapse)AuthorFilesLines
2013-07-16Move strnatcmp.{h,c} from epan into wsutil: there's nothing epan-specificJeff Morriss4-254/+0
there and moving it avoids having to recompile the file for use in editcap and mergecap (which don't link against libwireshark). svn path=/trunk/; revision=50650
2013-07-16A better method of avoiding the "ISO C restricts enumerator values to range ↵Chris Maynard1-1/+3
of 'int'" warning. svn path=/trunk/; revision=50649
2013-07-15Don't compare a guint32 against -1, compare it against 0xFFFFFFFFU.Guy Harris1-1/+1
svn path=/trunk/; revision=50643
2013-07-15Fix warning: ISO C restricts enumerator values to range of 'int'Chris Maynard4-5/+5
svn path=/trunk/; revision=50641
2013-07-15Fix warnings: comma at end of enumerator list.Chris Maynard12-36/+36
svn path=/trunk/; revision=50640
2013-07-15Fix warnings: format '%blah' expects argument of type 'foo', but argument ↵Chris Maynard3-7/+9
'i' has type 'bar' [-Wformat]. svn path=/trunk/; revision=50639
2013-07-15Fix warning: ISO C does not allow extra ';' outside of a function.Chris Maynard3-19/+18
svn path=/trunk/; revision=50638
2013-07-15Fix warning: ISO C does not support %n$ operand number formats.Chris Maynard1-1/+1
svn path=/trunk/; revision=50637
2013-07-15Fix bug #8934: Fuzz failure: seg-fault in tvb_new_proxy()Jakub Zawadzki1-1/+6
It is possible to have NULL reassembly data, support this case in tvb_new_proxy(). svn path=/trunk/; revision=50634
2013-07-15Fix bug #8936: Fuzz failure: attempt to allocate -1 bytes from ↵Jakub Zawadzki1-4/+33
packet-bacapp.c and/or tvb_generic_clone_offset_len() Revert r50556: Add new function: validate_offset() which checks if offset is within bounds of tvb. svn path=/trunk/; revision=50633
2013-07-15Fix some Dead Store (Dead assignement/Dead increment) Warning found by ClangAlexis La Goutte1-2/+1
svn path=/trunk/; revision=50632
2013-07-15Fix some Dead Store (Dead assignement/Dead increment) Warning found by ClangAlexis La Goutte1-4/+4
svn path=/trunk/; revision=50631
2013-07-15Fix some Dead Store (Dead assignement/Dead increment) Warning found by ClangAlexis La Goutte1-8/+8
svn path=/trunk/; revision=50630
2013-07-15Fix some Dead Store (Dead assignement/Dead increment) Warning found by ClangAlexis La Goutte1-2/+2
svn path=/trunk/; revision=50629
2013-07-15Fix some Dead Store (Dead assignement/Dead increment) Warning found by ClangAlexis La Goutte1-9/+9
svn path=/trunk/; revision=50628
2013-07-15Fix some Dead Store (Dead assignement/Dead increment) Warning found by ClangAlexis La Goutte1-1/+1
svn path=/trunk/; revision=50627
2013-07-15Fix some Dead Store (Dead assignement/Dead increment) Warning found by ClangAlexis La Goutte1-4/+4
svn path=/trunk/; revision=50626
2013-07-15Fix some Dead Store (Dead assignement/Dead increment) Warning found by ClangAlexis La Goutte1-6/+6
svn path=/trunk/; revision=50625
2013-07-15Use 2 Spaces indent and add modelines infoAlexis La Goutte1-50/+61
svn path=/trunk/; revision=50624
2013-07-15Fix warnings found by fix-encoding-args tools.(and remove some tabs also)Alexis La Goutte1-32/+32
svn path=/trunk/; revision=50623
2013-07-15Use 4 Spaces indent and add modelines infoAlexis La Goutte1-2326/+2340
svn path=/trunk/; revision=50622
2013-07-15Fix some Dead Store (Dead assignement/Dead increment) Warning found by ClangAlexis La Goutte1-1/+1
svn path=/trunk/; revision=50621
2013-07-15Fix some Dead Store (Dead assignement/Dead increment) Warning found by ClangAlexis La Goutte1-1/+1
svn path=/trunk/; revision=50620
2013-07-15Fix some Dead Store (Dead assignement/Dead increment) Warning found by ClangAlexis La Goutte2-4/+4
svn path=/trunk/; revision=50619
2013-07-15Fix some Dead Store (Dead assignement/Dead increment) Warning found by ClangAlexis La Goutte1-4/+0
svn path=/trunk/; revision=50618
2013-07-15Fix some Dead Store (Dead assignement/Dead increment) Warning found by ClangAlexis La Goutte1-4/+3
svn path=/trunk/; revision=50617
2013-07-15Fix some Dead Store (Dead assignement/Dead increment) Warning found by ClangAlexis La Goutte1-1/+2
svn path=/trunk/; revision=50616
2013-07-15Use "generic" tfs (tfs_set_notset)Alexis La Goutte1-70/+15
svn path=/trunk/; revision=50615
2013-07-15Fix error from checkAPI.plAlexis La Goutte1-1/+1
Error: Found non-ASCII characters on line 871 of packet-scsi-osd.c svn path=/trunk/; revision=50608
2013-07-15From Javier Godoy:Anders Broman1-22/+232
adds support for the OSD-2 CREATE USER TRACKING COLLECTION service action, following the approach described in bug 8832. It also implements dissection of the CDB continuation segment. Change in scsi_osd_extra_data_t: - Add a continuation_length field (we need that value from the CDB when later dissecting the Data In buffer) The following fields were added: - hf_scsi_osd2_cdb_continuation_length - hf_scsi_osd2_cdb_continuation_format - hf_scsi_osd2_continued_service_action - hf_scsi_osd2_cdb_continuation_descriptor_type - hf_scsi_osd2_cdb_continuation_descriptor_pad_length - hf_scsi_osd2_cdb_continuation_descriptor_length - hf_scsi_osd2_source_collection_object_id The following expert_info fields were added: - ei_osd2_cdb_continuation_format_unknown (PI_UNDECODED, PI_ERROR) - ei_osd2_continued_service_action_mismatch (PI_PROTOCOL, PI_WARN) - ei_osd2_cdb_continuation_descriptor_type_unknown (PI_UNDECODED, PI_WARN) - ei_osd2_cdb_continuation_descriptor_length_invalid (PI_PROTOCOL, PI_ERROR) - ei_osd2_cdb_continuation_length_invalid (PI_PROTOCOL, PI_ERROR) The following value_string arrays were added: - scsi_osd2_cdb_continuation_format_val (OSD2r4 Table 69) - scsi_osd2_cdb_continuation_descriptor_type_val (OSD2r4 Table 71) The following functions were added: - dissect_osd2_cdb_continuation_length (dissect the cdb continuation length field in cdb and save continuation_length in extra_data) - dissect_osd2_cdb_continuation (dissect the cdb continuation segment from the data out buffer; currently, descriptor-specific fields are not dissected) - dissect_osd2_create_user_tracking_collection Changes in dissect_osd_collection_object_id - add an int hfindex parameter - the return type was made void (previously it returned int, but the return type was unused) - this function is used for filling collection_id related fields (there are several flavors of them) and may be modified for displaying creation/removal information (à la dissect_osd_partition_id) - one call to dissect_osd_requested_collection_object_id was replaced by dissect_osd_collection_object_id(...,hf_scsi_osd_requested_collection_object_id) - two calls to dissect_osd_collection_object_id were updated with the new signature https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=8922 svn path=/trunk/; revision=50605
2013-07-15Update dissection.Anders Broman1-43/+37
svn path=/trunk/; revision=50604
2013-07-15From Javier Godoy:Anders Broman1-2/+2
fix partitions being inadvertently set as removed. In dissect_osd_get_attributes and dissect_osd_set_attributes there were calls to dissect_osd_partition_id with the last parameter (is_removed) set to TRUE instead of FALSE. That caused dissect_osd_partition_id reporting the partitions as "removed". The only service action where is_removed must be TRUE is dissect_osd_remove_partition. https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=8927 svn path=/trunk/; revision=50603
2013-07-15From Cal Turney via https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=8920 :Jeff Morriss1-19/+19
Changed FATTR4_DISSECT_VALUES arg to FATTR4_BITMAP_ONLY in calls to dissect_nfs4_fattrs() in cases NFS4_OP_OPEN and NFS4_OP_CREATE of dissect_nfs4_response_op(). svn path=/trunk/; revision=50602
2013-07-15Restore inclusion of report_err.hJeff Morriss1-0/+2
svn path=/trunk/; revision=50599
2013-07-15Move report_err.{h,c} from epan into wsutil: there's nothing epan-specific ↵Jeff Morriss20-200/+18
there and moving it avoids having to recompile the file for use in editcap and capinfos (which don't link against libwireshark). svn path=/trunk/; revision=50598
2013-07-15Fix up some white space.Jeff Morriss1-17/+18
svn path=/trunk/; revision=50597
2013-07-14Fix assertion failed: ERROR:print.c:823:const guint8 *get_field_data(GSList ↵Jakub Zawadzki1-1/+5
*, field_info *): code should not be reached svn path=/trunk/; revision=50593
2013-07-14All routines taking an offset and length that want to access the data inGuy Harris1-1/+1
the backing tvbuff must add the subset tvbuff's offset to the offset argument, to skip to the subset. svn path=/trunk/; revision=50591
2013-07-14A bit more comment updating.Guy Harris1-1/+1
svn path=/trunk/; revision=50590
2013-07-14Fix incorrect use of dlsw.frame_direction for capability exchangeGuy Harris1-3/+4
frames; that should be a separate dlsw.capex_type field. dlsw.error_cause is a numeric field, so it needs a base; the values in the value_string table are in hex, so show it in hex. svn path=/trunk/; revision=50589
2013-07-14Fix a comment.Guy Harris1-4/+4
svn path=/trunk/; revision=50588
2013-07-14Get rid of duplicate "Old message type" field.Guy Harris1-1/+0
svn path=/trunk/; revision=50587
2013-07-14Make pointers to raw packet data pointers to guint8, not pointers toGuy Harris1-2/+2
char; they're chunks of raw octets, not characters. svn path=/trunk/; revision=50586
2013-07-14Cast the result of g_malloc(), to avoid warnings about trying to compileGuy Harris1-4/+4
this code as C++. Make pointers to raw packet data pointers to guint8, not pointers to char, as they're octets, not characters. svn path=/trunk/; revision=50583
2013-07-14fix: ../../asn1/t38/packet-t38-template.c:346: warning: request for implicit ↵Jakub Zawadzki1-1/+1
conversion from 'gpointer' to 'char *' not permitted in C++ svn path=/trunk/; revision=50582
2013-07-14fix: packet-mp2t.c:489: warning: implicit declaration of function ↵Jakub Zawadzki1-0/+2
'tvb_new_proxy' svn path=/trunk/; revision=50581
2013-07-14Rewrite reassemble API to use TVBs instead of raw data.Jakub Zawadzki30-235/+226
(it seems to be working for TCP ^^) svn path=/trunk/; revision=50580
2013-07-14Export tvb_free_chain() so that tvbtest can use it.Guy Harris2-4/+6
As on Windows with MSVC, and as with reassemble_test, link tvbtest with libwireshark and the libraries it requires. svn path=/trunk/; revision=50575
2013-07-14Squelch a "not permitted in C++" warning.Guy Harris1-1/+1
svn path=/trunk/; revision=50574
2013-07-14Build tvbtest the same way we build reassemble_test; see whether thatGuy Harris1-8/+20
fixes the build errors we're seeing, with complaints about tvbtest.obj : warning LNK4217: locally defined symbol tvb_XX imported in function test tvbtest.obj : error LNK2019: unresolved external symbol __imp_tvb_XXX referenced in function run_tests tvbuff.obj : error LNK2019: unresolved external symbol tvb_XXX referenced in function tvb_new_YYY svn path=/trunk/; revision=50573