Age | Commit message (Collapse) | Author | Files | Lines |
|
https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=4422
From me: Fix a number of instances where the function prototype or
the function definition wasn't changed so there was a mismatch
thus causing Windows (but not gcc) compilation errors.
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@32365 f5534014-38df-0310-8fa8-9805f1628bb7
|
|
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@32361 f5534014-38df-0310-8fa8-9805f1628bb7
|
|
https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=4422
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@32360 f5534014-38df-0310-8fa8-9805f1628bb7
|
|
Clean up white space.
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@32149 f5534014-38df-0310-8fa8-9805f1628bb7
|
|
About GSM system information type 2quater
Modified to use newly defined tvb_get_bits() in tvbuff.c
https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=4219
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@30962 f5534014-38df-0310-8fa8-9805f1628bb7
|
|
remove the argument completely. It seems that the second argument only acts as an accumulator allowing offset_from_real_beginning() to call itself recursively. To be consistent offset_from_real_beginning() is renamed to tvb_offset_from_real_beginning().
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@29844 f5534014-38df-0310-8fa8-9805f1628bb7
|
|
version of tvb_new_subset(). The latter can be mapped to the former by tvb_new_subset(tvb, offset, -1 /* backing_length */, -1 /* reported_length */). We can disable some bounds checking because 'backing_length' and 'reported_length' are hardcoded to -1.
The current implementation of tvb_new_subset_remaining() only has the THROW_ON(reported_length < 1) check removed when compared to tvb_new_subset(). So there's room for improvement in this function. We should be able to disable some more (redundant) bounds checking.
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@29445 f5534014-38df-0310-8fa8-9805f1628bb7
|
|
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@29379 f5534014-38df-0310-8fa8-9805f1628bb7
|
|
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@28140 f5534014-38df-0310-8fa8-9805f1628bb7
|
|
be so size_t-happy.
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@27962 f5534014-38df-0310-8fa8-9805f1628bb7
|
|
packet-wcp.c: Add size_t casts.
packet-x11.c: Use string buffers.
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@27959 f5534014-38df-0310-8fa8-9805f1628bb7
|
|
not uncommon to pass them the result of pointer arithmetic. Add size_t
casts in other areas.
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@27941 f5534014-38df-0310-8fa8-9805f1628bb7
|
|
tvb_child_uncompress()
tvb_new_child_real_data()
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@27924 f5534014-38df-0310-8fa8-9805f1628bb7
|
|
tvb_get_seasonal_string();
tvb_get_seasonal_stringz();
.. which work the same as the ephemeral versions of the functions, but use
se_alloc() instead of ep_alloc().
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@27868 f5534014-38df-0310-8fa8-9805f1628bb7
|
|
#ifdef NEED_G_ASCII_STRCASECMP_H
#include "g_ascii_strcasecmp.h"
#endif
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@24859 f5534014-38df-0310-8fa8-9805f1628bb7
|
|
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@23818 f5534014-38df-0310-8fa8-9805f1628bb7
|
|
est. Use g_ascii_strcasecmp() and g_ascii_strncasecmp(), and supply our
own versions if they're missing from GLib (as is the case with GLib
1.x).
In the code to build the list of named fields for Diameter, don't use
g_strdown(); do our own g_ascii_-style upper-case to lower-case mapping
in the hash function and use g_ascii_strcasecmp() in the compare
function.
We do this because there is no guarantee that toupper(), tolower(), and
functions that use them will, for example, map between "I" and "i" in
all locales; in Turkish locales, for example, there are, in both
upper case and lower case, versions of "i" with and without a dot, and
the upper-case version of "i" is "I"-with-a-dot and the lower-case
version of "I" is "i"-without-a-dot. This causes strings that should
match not to match.
This finishes fixing bug 2010 - an earlier checkin prevented the crash
(as there are other ways to produce the same crash, e.g. a bogus
dictionary.xml file), but didn't fix the case-insensitive string matching.
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@23623 f5534014-38df-0310-8fa8-9805f1628bb7
|
|
tvb_get_bits64
and use them in proto_tree_add_bits_ret_val().
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@21828 f5534014-38df-0310-8fa8-9805f1628bb7
|
|
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@21610 f5534014-38df-0310-8fa8-9805f1628bb7
|
|
proto_tree_add_bits_ret_val()
tvb_get_bits()
And modify
proto_tree_add_bits() not to return a value.
little endian is not yet implemented.
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@21607 f5534014-38df-0310-8fa8-9805f1628bb7
|
|
tvb_memcpy() be similar, to avoid unnecessarily alignment warnings.
Do the same with "ep_tvb_memdup()".
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@21554 f5534014-38df-0310-8fa8-9805f1628bb7
|
|
--enable-extra-gcc-checks set.
If we turn on -pedantic, try turning on -Wno-long-long as well, so that
it's not *so* pedantic that it rejects the 64-bit integral data types
that we explicitly require.
Constify a bunch of stuff, and make some other changes, to get rid of
warnings.
Clean up some indentation.
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@21526 f5534014-38df-0310-8fa8-9805f1628bb7
|
|
to space
before output.
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@18519 f5534014-38df-0310-8fa8-9805f1628bb7
|
|
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@18197 f5534014-38df-0310-8fa8-9805f1628bb7
|
|
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@17566 f5534014-38df-0310-8fa8-9805f1628bb7
|
|
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@15941 f5534014-38df-0310-8fa8-9805f1628bb7
|
|
and that extract IPv6 addresses into a "struct e_in6_addr", with
tvb_get_ipv4() and tvb_get_ipv6() calls - except for some that we
remove, by using proto_tree_add_item(), rather than replacing.
Have epan/tvbuff.h include epan/ipv6-utils.h, to define "struct
e_in6_addr" (not necessary to declare the tvbuff routines, but including
it there means "struct e_in6_addr" is guaranteed to be defined before
those declarations, so we don't get compiler complaints if we define it
*after* those declarations).
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@15758 f5534014-38df-0310-8fa8-9805f1628bb7
|
|
IPv6 addresses. Use "tvb_get_ipv4()" in the WINS Replication dissector,
so that it gets the right answer on little-endian *AND* big-endian
machines.
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@15753 f5534014-38df-0310-8fa8-9805f1628bb7
|
|
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@15398 f5534014-38df-0310-8fa8-9805f1628bb7
|
|
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@15273 f5534014-38df-0310-8fa8-9805f1628bb7
|
|
the README file.
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@15271 f5534014-38df-0310-8fa8-9805f1628bb7
|
|
documentation in README.developer
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@15270 f5534014-38df-0310-8fa8-9805f1628bb7
|
|
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@15128 f5534014-38df-0310-8fa8-9805f1628bb7
|
|
ep_tvb_memdup()
ep_alloc0()
ep_strsplit()
add all of the ep_ allocators to libethereal.def
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@15100 f5534014-38df-0310-8fa8-9805f1628bb7
|
|
ep_tvb_get_string
that acts the same as tvb_get_string but the buffer returned need not be freed.
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@15024 f5534014-38df-0310-8fa8-9805f1628bb7
|
|
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@12980 f5534014-38df-0310-8fa8-9805f1628bb7
|
|
"bytes_to_str_punct()", and use it instead of extracting the bytes and
formatting them by hand.
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@12876 f5534014-38df-0310-8fa8-9805f1628bb7
|
|
integers.
Make FT_INT64 and FT_UINT64 add numerical values, rather than byte-array
values, to the protocol tree, and add routines to add specified 64-bit
integer values to the protocol tree.
Use those routines in the RSVP dissector.
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@11796 f5534014-38df-0310-8fa8-9805f1628bb7
|
|
they have LF at the end of the line on UN*X and CR/LF on Windows;
hopefully this means that if a CR/LF version is checked in on Windows,
the CRs will be stripped so that they show up only when checked out on
Windows, not on UN*X.
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@11400 f5534014-38df-0310-8fa8-9805f1628bb7
|
|
- Helper functions for uncompressing compressed tvbuffers.
- Compressed content coding dissection in HTTP.
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@10799 f5534014-38df-0310-8fa8-9805f1628bb7
|
|
characters.
Some strings appear to be null-padded; add a "tvb_format_stringzpad()"
routine to handle them, so that we don't show the padding characters as
"\000".
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@10461 f5534014-38df-0310-8fa8-9805f1628bb7
|
|
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@10106 f5534014-38df-0310-8fa8-9805f1628bb7
|
|
string argument.
Add some casts to squelch compiler warnings.
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@9951 f5534014-38df-0310-8fa8-9805f1628bb7
|
|
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@9938 f5534014-38df-0310-8fa8-9805f1628bb7
|
|
Remove now unnecessary casts in two files.
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@9801 f5534014-38df-0310-8fa8-9805f1628bb7
|
|
replace tvb_raw_offset() which is essentially a simple assignment and which
is called a lot with a macro.
this makes my tethereal testcase 2-3% faster.
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@9152 f5534014-38df-0310-8fa8-9805f1628bb7
|
|
so that we can change tvb_get_ds_tvb() into a macro.
This function was a single line assignment and was called a lot.
This made tethereal ~2.5% faster in one testcase I use.
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@9141 f5534014-38df-0310-8fa8-9805f1628bb7
|
|
The search uses a naive approach; more work is required to add a
Boyer-Moore Search algorithm.
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@8280 f5534014-38df-0310-8fa8-9805f1628bb7
|
|
tvb_get_string() - takes a tvbuff, an offset, and a length as
arguments, allocates a buffer big enough to hold a string with
the specified number of bytes plus an added null terminator
(i.e., length+1), copies the specified number of bytes from the
tvbuff, at the specified offset, to that buffer and puts in a
null terminator, and returns a pointer to that buffer (or throws
an exception before allocating the buffer if that many bytes
aren't available in the tvbuff);
tvb_get_stringz() - takes a tvbuff, an offset, and a pointer to
a "gint" as arguments, gets the size of the null-terminated
string starting at the specified offset in the tvbuff (throwing
an exception if the null terminator isn't found), allocates a
buffer big enough to hold that string, copies the string to that
buffer, and returns a pointer to that buffer and stores the
length of the string (including the terminating null) in the
variable pointed to by the "gint" pointer.
Replace many pieces of code allocating a buffer and copying a string
with calls to "tvb_get_string()" (for one thing, "tvb_get_string()"
doesn't require you to remember that the argument to
"tvb_get_nstringz0()" is the size of the buffer into which you're
copying the string, which might be the length of the string to be copied
*plus 1*).
Don't use fixed-length buffers for null-terminated strings (even if the
code that generates those packets has a #define to limit the length of
the string). Use "tvb_get_stringz()", instead.
In some cases where a value is fetched but is only used to pass an
argument to a "proto_tree_add_XXX" routine, use "proto_tree_add_item()"
instead.
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@7859 f5534014-38df-0310-8fa8-9805f1628bb7
|
|
Things can happen if we pass a zero buffer length to tvb_get_nstringz0().
Throw an exception if this happens.
In various dissectors make sure the tvb_get_nstringz0()'s buffer length
is greater than zero.
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@7688 f5534014-38df-0310-8fa8-9805f1628bb7
|