aboutsummaryrefslogtreecommitdiffstats
path: root/epan/prefs.c
AgeCommit message (Collapse)AuthorFilesLines
2015-10-27Add preferences for related packets and the scroll bar minimap.Gerald Combs1-0/+12
Add gui.packet_list_show_related and gui.packet_list_show_minimap. Show_related enables and disables the related packet delegate. Show_minimap enables and disables the minimap. Start calling it the "intelligent scroll bar" since that's the best suggestion for a name I've seen so far. Leave them out of the Appearance preference pane for now. Change-Id: I5869c446fda5c8e62d6b1e49a74d63ba3b117b0f Reviewed-on: https://code.wireshark.org/review/11332 Petri-Dish: Gerald Combs <gerald@wireshark.org> Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org> Reviewed-by: Gerald Combs <gerald@wireshark.org>
2015-10-04Fix various memleaksPeter Wu1-0/+1
Found by starting Wireshark within an empty profile, opening Preferences, search for Protocol "IEEE 802.11" (because it has radio buttons), then close everything again. Many fixes are trivial, but the various recent_read_* functions in recent.c were changed to return a boolean such that the result can always be checked even if errno==0. QButtonGroup leak was hinted by Clang Static Analyzer, all other memleaks were found using ASAN/LSan. Change-Id: Ia73f5d4c09d92f22e72377be59e23342f8ad7211 Reviewed-on: https://code.wireshark.org/review/10776 Reviewed-by: Michael Mann <mmann78@netscape.net> Petri-Dish: Michael Mann <mmann78@netscape.net> Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org> Reviewed-by: Alexis La Goutte <alexis.lagoutte@gmail.com>
2015-09-02The official #define for 32-bit and 64-bit Windows is _WIN32.Guy Harris1-1/+1
It's _WIN32, with a leading underscore, not WIN32. See, for example: https://sourceforge.net/p/predef/wiki/OperatingSystems/ and https://msdn.microsoft.com/en-us/library/b0084kay.aspx *Some* environments may also define WIN32, but we shouldn't depend on that. Replace all-caps "WIN32" referring to Windows in comments and other text with "Windows" or "Win32". (The two are pretty much equivalent, these days; nobody much cares about Win16, not that we ever ran on it, and 64-bit Windows is just a 64-bitified Win32.) Change-Id: Id327bcd4b1e9baa4f27055eff08c2d9e594d6f70 Reviewed-on: https://code.wireshark.org/review/10367 Petri-Dish: Guy Harris <guy@alum.mit.edu> Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org> Reviewed-by: Guy Harris <guy@alum.mit.edu>
2015-08-11Added Reload Lua plugins.Stig Bjørlykke1-0/+31
This is initial support for reloading Lua plugins without restarting the application. Still todo: - Deregister FileHandlers - Support deregister ProtoField with existing abbrev (same_name_hfinfo) - Add a progress dialog when reloading many plugins - Search for memory leakages in wslua functions Change-Id: I48870d8741251705ca15ffe1068613fcb0cb18c1 Reviewed-on: https://code.wireshark.org/review/5028 Reviewed-by: Stig Bjørlykke <stig@bjorlykke.org>
2015-08-06Add an elide mode preference for the Qt packet list.Gerald Combs1-0/+14
Change-Id: I081cc1e9b2a0eea7f0a3ef1157561c50beb4c4db Reviewed-on: https://code.wireshark.org/review/9902 Petri-Dish: Gerald Combs <gerald@wireshark.org> Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org> Reviewed-by: Gerald Combs <gerald@wireshark.org>
2015-07-25DNS: move DNS name resolution pref to Name Resolution prefsHadriel Kaplan1-8/+5
Move the boolean flag for using captured DNS packet info for name resolution to the Name Resolution preferences settings, as it was rather surprising to disable Name Resolution preferences and still have names being resolved. Also disble them all if the '-n' command line switch is used, and re-enable it for a 'd' character in the '-N' option. Bug: 10337 Change-Id: Ie4d47bab0100db3360cc447cd3e446b2e39aa917 Reviewed-on: https://code.wireshark.org/review/9786 Petri-Dish: Hadriel Kaplan <hadrielk@yahoo.com> Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org> Reviewed-by: Hadriel Kaplan <hadrielk@yahoo.com>
2015-07-20Qt: Add option to back white line separator for packet list itemsMichal Labedzki1-0/+8
This uses one line (on bottom) of items and makes it white. Seen in Wireshark on some configurations of GTK 2 on Linux, so backports it to Qt for people who like it. In my opinion it helps if you use packet list background colors for frames and you have a lot of following frames with the same background color. Bug: 10954 Change-Id: Id8f58520d7224db4eb8181bcc04febd7416a8578 Reviewed-on: https://code.wireshark.org/review/7293 Petri-Dish: Michal Labedzki <michal.labedzki@tieto.com> Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org> Reviewed-by: Michal Labedzki <michal.labedzki@tieto.com>
2015-07-17Remove all preferences related to enabling/disabling heuristic dissectors.Michael Mann1-0/+74
The preferences are still supported for backwards compatibility, but the heuristic_protos file has final say on the "preference" to enable/disable a heuristic dissector. Also add parameter to heur_dissector_add() for the "default" enable/disable of a heuristic dissector. With this parameter, a few more (presumably weak) heuristic dissectors have been "registered" but of course default to being disabled. Change-Id: I51bebb2146ef3fbb8418d4f5c7f2cb2b58003a22 Reviewed-on: https://code.wireshark.org/review/9610 Petri-Dish: Michael Mann <mmann78@netscape.net> Reviewed-by: Roland Knall <rknall@gmail.com> Reviewed-by: Hadriel Kaplan <hadrielk@yahoo.com> Reviewed-by: Michael Mann <mmann78@netscape.net>
2015-07-06prefs: fix memory leak reading capture columnsEvan Huus1-3/+5
Change-Id: I925ec3329cc099a5f3d2ae66e43b06fc52309dc8 Reviewed-on: https://code.wireshark.org/review/9504 Reviewed-by: Michael Mann <mmann78@netscape.net> Petri-Dish: Michael Mann <mmann78@netscape.net> Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org> Reviewed-by: Evan Huus <eapache@gmail.com>
2015-06-25Fix a memory leak registering prefsEvan Huus1-1/+21
Built-in string prefs have to be dynamic, but get overwritten by the registration routine, so we have to save and then free them after-the-fact. Change-Id: Ib418b14296391dd198a8b49b0c99c5f697d8050f Reviewed-on: https://code.wireshark.org/review/9132 Reviewed-by: Evan Huus <eapache@gmail.com>
2015-06-24Initialize default stats before using themEvan Huus1-1/+5
Quick hack fix for bug 11275. The longer fix I am still thinking about, but it goes something like this: we have a terribly confusing dependency graph in ordering our various preferences, so it's fragile and needs refactoring. 1. We must call epan_init before we read the preferences files, since dissectors register many preferences. 2. We must call pre_init_prefs before we call prefs_register_modules, since that inits the default values of the "global" preferences structure. `init_prefs()` handles this normally. 3. We must call epan_init before we call init_prefs since init_prefs depends on UATs being initialized (which is something epan_init does). 4. We must call prefs_register_modules before we call epan_init since that generates the `protocols` subtree which is needed for registering dissector-specific preferences. The above graph has a cycle, which I *think* can be solved by splitting prefs_register_modules? Bug: 11275 Change-Id: I08dae6a7ade178896e0de5e5091f7eeaca95846f Reviewed-on: https://code.wireshark.org/review/9098 Reviewed-by: Evan Huus <eapache@gmail.com>
2015-06-23prefs: fix memleakPeter Wu1-40/+12
Calling g_list_remove_link(link, llink) does not free the removed last link llink. g_list_next or g_list_foreach+g_free followed by g_list_free should be used instead such that the data is freed before and then dropped from the list. This fixes a memleak in tshark -r dns.pcap detected by ASAN (single packet). Set pref->default_val.list = NULL just in case, and with symmetry with capture_columns handling. Change-Id: I3cc52e275784037ab40c0b42c68d0dd83b73cd98 Reviewed-on: https://code.wireshark.org/review/9026 Reviewed-by: Evan Huus <eapache@gmail.com> Reviewed-by: Peter Wu <peter@lekensteyn.nl>
2015-03-25Have a #define for whether the capture buffer size can be set.Guy Harris1-2/+2
It can be set if either 1) this is Windows (where we're assumed to be using WinPcap, which includes calls to set the buffer size) or 2) we have pcap_create() (in which case we also have pcap_set_buffer_size(), at least in a normal libpcap release). Use that rather than testing "defined(_WIN32) || defined(HAVE_PCAP_CREATE)"; that makes it a bit more obvious what's being tested. Change-Id: Id9f8455019d19206b04dd6820a748cb97ae5ad12 Reviewed-on: https://code.wireshark.org/review/7816 Reviewed-by: Guy Harris <guy@alum.mit.edu>
2015-02-27Qt: Automatically scroll the packet list.Michal Labedzki1-0/+1
Add an "Auto Scroll in Live Capture" action to the Go menu. It's in the View menu in the GTK+ UI but it seems to make more sense as a navigation item. Use a timeout interval for automatic scrolling. I haven't run any tests to see if this makes a difference but it would seem that the less drawing we do during a high speed capture the better, particularly for remote displays. Update the x-stay-last icons. Note that we might want to make prefs.capture_auto_scroll a "recent" setting. Mark auto_scroll_live and packet_list_check_end GTK+ only. Bug: 10601 Co-authored-by: Gerald Combs <gerald@wireshark.org> Change-Id: I645d27c0814f0e4a0d5b01ae68be366847e2522d Reviewed-on: https://code.wireshark.org/review/7292 Reviewed-by: Gerald Combs <gerald@wireshark.org>
2015-02-21Fix GTK-sharkMichal Labedzki1-1/+1
Looks like a copy/paste issue. ERROR: wireshark/color_filters.c:100:color_filters_add_tmp: assertion failed: (strlen(prefs.gui_colorized_fg)==69) Change-Id: I7b8309cfc178fd834951078a098bbce986639ed2 Reviewed-on: https://code.wireshark.org/review/7286 Reviewed-by: Michal Labedzki <michal.labedzki@tieto.com>
2015-02-21Call pre_init_prefs each time our profile changes.Gerald Combs1-47/+60
Manually back out gafa96c3 so that we can set our preferences to their default values each time we switch profiles. Zero the prefs struct at startup. Change-Id: Ic28db44cd0c4cdf640e977d7277f7357db10ebe8 Reviewed-on: https://code.wireshark.org/review/7282 Petri-Dish: Gerald Combs <gerald@wireshark.org> Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org> Reviewed-by: Gerald Combs <gerald@wireshark.org>
2015-02-20Clear the filter expression list in prefs.c.Gerald Combs1-0/+7
Move filter_expression_nuke from ui/gtk to epan and rename it to filter_expression_free. Call it in prefs_reset along with the other preference reset routines. This keeps the Qt filter toolbar from filling up with duplicate expressions when the profile changes. Change-Id: I9fae9a7b48944079ea342a126979d9e79af0d22b Reviewed-on: https://code.wireshark.org/review/7281 Petri-Dish: Gerald Combs <gerald@wireshark.org> Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org> Reviewed-by: Gerald Combs <gerald@wireshark.org>
2015-02-12Support for looking for incomplete dissectors.Dario Lombardo1-0/+5
Change-Id: I03e592dd3d54fc0e1c4af09d5d5336dda93f950e Reviewed-on: https://code.wireshark.org/review/6978 Reviewed-by: Evan Huus <eapache@gmail.com> Petri-Dish: Evan Huus <eapache@gmail.com> Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org> Reviewed-by: Alexis La Goutte <alexis.lagoutte@gmail.com>
2015-01-12Remove emem APIs from UAT functionality.Michael Mann1-7/+11
Change-Id: I009c09f25d170e5c9aaaef713eaacb3252817856 Reviewed-on: https://code.wireshark.org/review/6460 Petri-Dish: Michael Mann <mmann78@netscape.net> Reviewed-by: Evan Huus <eapache@gmail.com> Petri-Dish: Anders Broman <a.broman58@gmail.com> Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org> Reviewed-by: Michael Mann <mmann78@netscape.net>
2015-01-10Add preference to display spaces between bytes for FT_BYTES fields.Michael Mann1-0/+6
I think this can make fields more readable (for a small amount of bytes). Converted DeviceNet dissector to use proto_tree_add_item for some FT_BYTES field as tvb_bytes_to_str_punct was used to create this effect "manually". Change-Id: I59e2acf9b00a4eb1279e6c2b2b7bd8ecef20db9b Reviewed-on: https://code.wireshark.org/review/6304 Reviewed-by: Michael Mann <mmann78@netscape.net>
2014-12-31prefs: fix typoAlexis La Goutte1-1/+1
Change-Id: Ic4dbbab5e53b5745cb703e6e30b2dc6251c3918e Reviewed-on: https://code.wireshark.org/review/6161 Reviewed-by: Michael Mann <mmann78@netscape.net>
2014-11-04Qt: Dynamic languagesMichal Labedzki1-18/+0
- get language as soon as possible (before creating any Qt objects) to make all translations working - dynamic list of supported languages - runtime change of GUI language (no need to restart application) - add flags icons support - search for *.qm languages in buildin resources, then data dir called "languages" (main directory in sources or /usr/share/wireshark/languages), then user directory (UNIX: ~/.wireshark/languages); "languages" directory should contains files wireshark_xx.qm where xx is language code (en, en_GB, etc.), and optional xx.svg for flag icon - try to fix some untranslated manually-created UI items (need manual reset text of those components) Change-Id: I62ca8a8cddce47cec9dbcad6b0bd68b6cfd92229 Reviewed-on: https://code.wireshark.org/review/5041 Tested-by: Michal Labedzki <michal.labedzki@tieto.com> Reviewed-by: Michal Labedzki <michal.labedzki@tieto.com>
2014-10-28Pref: Remove unsued functionAlexis La Goutte1-0/+2
Fix also warning: no previous prototype for 'prefs_get_uint_preference' [-Wmissing-prototypes] Change-Id: I4626372a9c131584c515a43e73aa019e2f696d29 Reviewed-on: https://code.wireshark.org/review/4960 Reviewed-by: Anders Broman <a.broman58@gmail.com>
2014-10-17Don't use ctype.h routines.Guy Harris1-12/+9
That avoids locale dependency and handles possibly-signed chars (which we weren't always doing before). Change-Id: Ieceb93029252f646397b6488f2df8a57c6d2a23d Reviewed-on: https://code.wireshark.org/review/4794 Reviewed-by: Guy Harris <guy@alum.mit.edu>
2014-10-16Added italian translation to qt.Dario Lombardo1-0/+1
Change-Id: If58ed29e78a9994fc488a4d01cf665f7e8d82830 Reviewed-on: https://code.wireshark.org/review/4707 Reviewed-by: Alexis La Goutte <alexis.lagoutte@gmail.com>
2014-09-24Qt: Fix preference bugs.Gerald Combs1-10/+3
Make sure we set the "resolved" member of the column fmt_data struct. Emitting WiresharkApplication::AppSignals from a modal dialog can cause event loop problems on OS X. Queue them up in PreferencesDialog and emit them after closing. Change-Id: I2de77778a0448db3b87d402e431b8e5f325cbbda Reviewed-on: https://code.wireshark.org/review/4274 Reviewed-by: Gerald Combs <gerald@wireshark.org>
2014-08-05Fix whitespace/indentation to match editor modelines.Bill Meier1-1155/+1155
Change-Id: I3445ae22f10584582d465bf632942e016f5f70ca Reviewed-on: https://code.wireshark.org/review/3452 Reviewed-by: Bill Meier <wmeier@newsguy.com>
2014-07-21[WIP] Add a conversation dialog.Gerald Combs1-11/+5
Items are sorted by value. Move common conversation code to ui/conversation_hash.[ch]. Add a conversation_type_e enum along with convenience functions for fetching titles, tap names, etc. We have a single main dialog instead of a main dialog + individual protocol dialogs. It de-clutters the statistics menu and results in simpler code. Conversation type tabs can be added and removed within the dialog itself. The tab list is sticky and saved with the current profile when the dialog closes. Data can be copied as CSV or YAML. Add a FilterAction class and a corresponding filterAction slot to MainWindow. Use it for the Conversations context menu. Add an addressResolutionChanged signal and related plumbing. Get rid of the iterator members in the conversation item struct. Update the GTK+ code accordingly. Excercise for the reader: - Update TShark to use the common hash code. Ping-Bug: 9231 Ping-Bug: 8703 Ping-Bug: 6727 Change-Id: I8728d771fc5b1a85937bed9d898e53c3ecc3a544 Reviewed-on: https://code.wireshark.org/review/2987 Reviewed-by: Michael Mann <mmann78@netscape.net>
2014-07-20start support for the Japanese language in the Qt versionMartin Kaiser1-0/+1
just the framework and some simple translations Change-Id: I7653a9c6ab26b391bfe2942d088d233996030576 Reviewed-on: https://code.wireshark.org/review/3134 Reviewed-by: Martin Kaiser <wireshark@kaiser.cx> Tested-by: Martin Kaiser <wireshark@kaiser.cx>
2014-07-15Make the state variable an enum, and add a case for the IN_SKIP value.Guy Harris1-2/+10
Also indicate what the states mean. Change-Id: Ie1701bb2fb33334bcd66d325d1368c2a15cbb7e8 Reviewed-on: https://code.wireshark.org/review/3061 Reviewed-by: Guy Harris <guy@alum.mit.edu>
2014-07-14Treat CR-LF at the end of a line like LF.Guy Harris1-1/+14
That way, if we're reading a Windows-format file on UN*X, we handle it the same way we'd handle a UN*X-format file. This handles bug 10272 for the preference file and the "recent" files; there are other configuration files that may need code changes as well. Change-Id: Iec15a8fac276929ce8b53ae16070e9f2855f574c Reviewed-on: https://code.wireshark.org/review/3042 Reviewed-by: Guy Harris <guy@alum.mit.edu>
2014-07-11As opposed to *loudly* silently?Guy Harris1-4/+4
Change-Id: I5c6843ac2c665a4c8c8822084377fee661405d34 Reviewed-on: https://code.wireshark.org/review/2992 Reviewed-by: Guy Harris <guy@alum.mit.edu>
2014-07-11Change comments to reflect current reality.Guy Harris1-5/+13
Change-Id: If4e220457d2040eaa35dd5e55a0f43fc9da5e347 Reviewed-on: https://code.wireshark.org/review/2991 Reviewed-by: Guy Harris <guy@alum.mit.edu>
2014-06-23[WIP] qt: Add support for Polish languageMichal Labedzki1-0/+1
Change-Id: Ib63937e741b737f171a9b383a9cbabb55dfdd8ef Reviewed-on: https://code.wireshark.org/review/2553 Reviewed-by: Jörg Mayer <jmayer@loplof.de>
2014-06-12Capture Interfaces Dialog:Irene Ruengeler1-0/+4
- allow to change the interface options in the table - save the options to preferences when the dialog is left - add a field for setting a capture filter for all selected interfaces - add a "Compile BPF" button and a window to show the compiled filter output - try to address Alexis' and Evan's comments Change-Id: Ic1272e29183ec80e2d2f4b3e494c79dabe2c3b6f Reviewed-on: https://code.wireshark.org/review/1946 Reviewed-by: Alexis La Goutte <alexis.lagoutte@gmail.com> Tested-by: Alexis La Goutte <alexis.lagoutte@gmail.com> Reviewed-by: Anders Broman <a.broman58@gmail.com>
2014-06-04(Trivial) Fix a typo.Bill Meier1-1/+1
Change-Id: I111d3af8d9f1a96ebbe3f4b19ab1597a93348058 Reviewed-on: https://code.wireshark.org/review/1952 Reviewed-by: Bill Meier <wmeier@newsguy.com>
2014-04-29prefs: prevent double-free on changing prefsPeter Wu1-0/+2
Prevent double-free when changing profiles. After switching from the default profile to a profile without a preferences file, saved_at_version will be freed, but a new version will not be inserted (because the prefs file is empty). On a subsequent switch to another profile, the saved_at_version field is freed again leading to a crash. Bug: 9463 Change-Id: Ia9e0936e32603b4676a37dc428bda40c264a6eaa Reviewed-on: https://code.wireshark.org/review/1425 Reviewed-by: Anders Broman <a.broman58@gmail.com>
2014-04-29prefs: spelling fix, simplify codePeter Wu1-11/+4
Found spelling error "a another". All those dynamic allocations and magic numbers are horrible and unnecessary. Simplify the gtk code rewording the message and merging strings. Simplify the version code by using fscanf to take care of matching the first line of a preference file. Change-Id: I1e75803aacaa494ba5005791bcbd023e0807aaaa Reviewed-on: https://code.wireshark.org/review/1424 Reviewed-by: Anders Broman <a.broman58@gmail.com>
2014-04-27prefs: fix ASAN error due to invalid indirectionPeter Wu1-29/+14
For pref_current, indirection of pref->varp.string will cause a read of size 8. This will cause a global buffer overflow error for all smaller types, for example lbmc_use_heuristic_subdissectors (size 4). Reproduce: compile Wireshark with -fsanitize=address, open Preferences and select OK or Apply. Result: ASAN crash. To fix this, only indirect a pointer if the storage size is known, a void pointer stores the address of the constant value (pref_default, pref_stashed) or the address to the value (pref_current). Note that pointers of different types are of equal size, I could take valp.pref_(anything). While at it, remove superfluous 'break' keywords where a 'return' keyword is present. Change-Id: I05a69e8f14a1ecb4e5d2a0c0f0b71ed3f0a41d70 Reviewed-on: https://code.wireshark.org/review/1286 Reviewed-by: Evan Huus <eapache@gmail.com> Reviewed-by: Michael Mann <mmann78@netscape.net>
2014-03-08Do not try to use unknown/non-existent webbrowserMichal Labedzki1-0/+4
Some systems do not have webbrowser or have strange browser. Do not try to use it and dislayed URL for user information. Change-Id: I3f5bcca6701b20cafa942629cbee78aa1fc689b1 Reviewed-on: https://code.wireshark.org/review/516 Reviewed-by: Evan Huus <eapache@gmail.com>
2014-03-04Remove all $Id$ from top of fileAlexis La Goutte1-2/+0
(Using sed : sed -i '/^ \* \$Id\$/,+1 d') Fix manually some typo (in export_object_dicom.c and crc16-plain.c) Change-Id: I4c1ae68d1c4afeace8cb195b53c715cf9e1227a8 Reviewed-on: https://code.wireshark.org/review/497 Reviewed-by: Anders Broman <a.broman58@gmail.com>
2014-02-28Fix bug which (somewhat) randomly caused UAT pref to not display on a proto ↵Bill Meier1-0/+1
pref page. Introduced in ga2b2dd4b (SVN #53880) Change-Id: I3dd24ab5e1b45367b03b8096a5892f346782217f Reviewed-on: https://code.wireshark.org/review/433 Reviewed-by: Bill Meier <wmeier@newsguy.com> Tested-by: Bill Meier <wmeier@newsguy.com>
2014-02-27Fix prefs.c: Argument with 'nonnull' attribute passed null (redux)Hadriel Kaplan1-10/+15
Change-Id: I795df36039278283008132d647aaf51e76dbe218 Reviewed-on: https://code.wireshark.org/review/424 Reviewed-by: Gerald Combs <gerald@wireshark.org>
2014-02-25Remove trailing whitespaceBill Meier1-4/+4
Change-Id: I8116f63ff88687c8db3fd6e8e23b22ab2f759af0 Reviewed-on: https://code.wireshark.org/review/385 Reviewed-by: Bill Meier <wmeier@newsguy.com> Tested-by: Bill Meier <wmeier@newsguy.com>
2014-01-14Don't cast away constness.Guy Harris1-1/+1
svn path=/trunk/; revision=54802
2013-12-10Get the "Decode As" dialog working, albeit with a few warts. It differsGerald Combs1-5/+1
from the GTK flavor in two major ways: - The "Decode As" and "User Specified Decodes" dialog have been unified. - You can modify the decode as behavior at any time, not just when you have a packet selected. Revert part of 53498 so that we can move items marked /*** THE FOLLOWING SHOULD NOT BE USED BY ANY DISSECTORS!!! ***/ from epan/decode_as.h to ui/decode_as_utils.h. Move "save" code from decode_as_dlg.c to decode_as_utils.c as well. In packet-dcerpc.c don't register a table named "ethertype". We might want to add checks for duplicate table names. To do: - Add support for ranges? - Either add support for DCERPC or make DCERPC use a regular dissector table. - Fix string selectors (i.e. BER). svn path=/trunk/; revision=53910
2013-12-09Add a function and an enum to register an uat preference for QT only.Irene Rüngeler1-0/+17
svn path=/trunk/; revision=53880
2013-11-29Stats_tree enhancements for sorting, averages and burst rate. Bug 9452 ↵Michael Mann1-1/+104
(https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=9452) From Deon van der Westhuysen - Bug fix: object leak in stats_tree after a tap reset (for example apply statistics preferences with a stats_tree window open) - Bug fix: correct sample code in README.stats_tree - Add: slash in plug-in name now creates submenu as docs describe (was a bug?) - Add: menu separator before the stat_tree registered plug-ins - Add: stats_tree can now calculate averages for nodes; automatically calculated for range nodes. Add section in README.stats_tree describing averages. - Add: stats_tree can now calculate burst rate of each node (like rate but with a shorter, sliding time window) - Add: sorting for stats_tree plug-ins. Can sort on node name, count, average, min, max values and burst rate. - Add: preferences for stats_tree system (default sort column, burst calc params) - Add: stats_tree window copy to clipboard and export and plain text, csv and XML. - Added sample of new functionality in $srcdir/plugins/stats_tree/pinfo_stats_tree.c - Moved all stats_tree sample plug-ins to "IP Statistics" submenu. svn path=/trunk/; revision=53657
2013-11-22Move common "decode as" preference code to epan.Gerald Combs1-0/+5
We presumably want "decode as" behavior to be consistent across UIs so call load_decode_as_entries() from read_prefs(). svn path=/trunk/; revision=53498
2013-11-17Move the epan/filesystem.c routines to wsutil; they're not specific toGuy Harris1-1/+1
packet dissection, they're specific to the entire Wireshark suite of programs. svn path=/trunk/; revision=53377
generated by cgit v1.2.3 (git 2.25.1) at 2024-07-07 22:57:23 +0000