aboutsummaryrefslogtreecommitdiffstats
path: root/epan/expert.c
AgeCommit message (Collapse)AuthorFilesLines
2013-08-05Completely remove support for proto_item_set_expert_flags.Michael Mann1-3/+11
svn path=/trunk/; revision=51144
2013-07-06Remove unused data structures from new expert code. Cleans up another ~17KBEvan Huus1-29/+1
of leaks, and I suspect they won't be necessary (we can always add them back using wmem if they do turn out to be needed). svn path=/trunk/; revision=50409
2013-07-06Allocate expert protocol structs with wmem, cleans up a few KB of leaks inEvan Huus1-1/+2
epan_cleanup(). svn path=/trunk/; revision=50406
2013-07-05Fix the use of va_args in the new expert code. Passing a va_list to a ... isEvan Huus1-1/+5
valid, but doesn't do what you actually want most of the time. svn path=/trunk/; revision=50392
2013-07-02Differentiate "Disabled" from "Unknown" and provide macros for the ↵Michael Mann1-4/+4
enumerated values. svn path=/trunk/; revision=50323
2013-07-02Add proto_tree_add_expert and proto_tree_add_expert_format. This was added ↵Michael Mann1-2/+44
to expert.h instead of proto.h because the underlying code to process expert info is static (and should probably remain so). Also, proto_tree_add_expert and proto_tree_add_expert_format follow "expert info" rules in that they should be called regardless of tree status (even though they take a tree as an argument), unlike the functions in proto.h Also added an enumeration for checksum validation status, as verifying checksums is considered "expert" functionality. svn path=/trunk/; revision=50322
2013-07-02Cache the malformed filter instead of looking it up each time a malformed ↵Michael Mann1-1/+4
packet comes in. This drastically speeds up the load time of captures with lots of malformed packets (ie fuzztesting). svn path=/trunk/; revision=50313
2013-06-20inform expert info layer about the current number of packet commentsMartin Kaiser1-0/+7
when the last comment is removed and we have no other expert info, the maximum severity is changed from comment to none svn path=/trunk/; revision=50091
2013-05-24Ensure most severe is displayed in expert column. Bug 7733 ↵Michael Mann1-1/+4
(https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=7733) #BACKPORT svn path=/trunk/; revision=49565
2013-05-24expert_add_info(): we can't use va_start()/va_end() so don't try to use a ↵Jeff Morriss1-3/+1
va_list (which isn't used by the called function) either. svn path=/trunk/; revision=49564
2013-05-24expert_add_info() doesn't take a variable number of args; don't use ↵Jeff Morriss1-4/+2
va_start()/va_end(). svn path=/trunk/; revision=49563
2013-05-24Add expert info configuration framework. Bug 2412 ↵Michael Mann1-7/+194
(https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=2412). Expert info "fields" can now be registered/addressed by name. Right now, the basic framework allows expert info fields to become "display filters". However more could be done, like user preferences overriding default severity level, speeding up expert info dialog load time by not needing to redissect a file, etc. Long term goal is to have all expert_info filterable and have the functionality of expert_add_info_format() include the "registered index". expert_add_info_format_text() is the workaround until all current calls to expert_add_info_format() have been updated with either expert_add_info() or expert_add_info_format_text(). Then the remaining expert_add_info_format_text() will be renamed to expert_add_info_format(). svn path=/trunk/; revision=49559
2013-03-20 From beroset:Bill Meier1-1/+1
remove C++ incompatibilities https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=8416 attachment #10397 svn path=/trunk/; revision=48438
2013-03-02Move expert_group_vals expert_severity_vals constant definitions to expert.hBalint Reczey1-25/+0
svn path=/trunk/; revision=47995
2012-09-20We always HAVE_CONFIG_H so don't bother checking whether we have it or not.Jeff Morriss1-3/+1
svn path=/trunk/; revision=45016
2012-08-10Add a missing NULL check pointed out by Jakub.Gerald Combs1-1/+1
svn path=/trunk/; revision=44437
2012-08-10Make the corresponding packet_info available to each tree item. ThisGerald Combs1-2/+5
lets us pass a NULL pinfo to expert_add_info_format() and expert_add_undecoded_item(), which makes it possible to use those routines deep in the bowels of many dissectors. As a proof of concept remove the recent pinfo additions to packet-afp.c. This should also make it easier to fix bug 3884. svn path=/trunk/; revision=44435
2012-06-28Update Free Software Foundation address.Jakub Zawadzki1-1/+1
(COPYING will be updated in next commit) svn path=/trunk/; revision=43536
2012-06-27Fix compiler warning: "format not a string literal and no format arguments"Bill Meier1-2/+2
svn path=/trunk/; revision=43509
2012-06-27Don't show (essentially meaningless) numeric values of the expert codes.Bill Meier1-2/+5
svn path=/trunk/; revision=43508
2012-06-26Display expert codes in hexadecimal (less painful for my eyes :))Pascal Quantin1-2/+2
svn path=/trunk/; revision=43497
2012-06-20Followup to r43176, r43177, r43178, and r43179: prohibit FT_*INT*Jeff Morriss1-2/+2
with BASE_NONE (or other future display values). Don't use BASE_NONE with FT_UINT32s in the expert info fields. svn path=/trunk/; revision=43412
2012-03-02Use the expert system to show packet comments.Anders Broman1-0/+2
The packet comment widget should be replaced by a ListView with two columns, packet no and Comment. svn path=/trunk/; revision=41322
2011-12-14Treat expert info as a <field> instead of a <proto> when exporting to pdml.Chris Maynard1-1/+4
svn path=/trunk/; revision=40204
2011-07-19Use ENC_NA for FT_PROTOCOL.Stig Bjørlykke1-1/+1
svn path=/trunk/; revision=38125
2011-06-19Revert r37702 in favour of r37705 for bug 6035.Stig Bjørlykke1-2/+2
svn path=/trunk/; revision=37706
2011-06-18Use BASE_DEC for expert.group and expert.severity.Stig Bjørlykke1-2/+2
This fixes bug 6035. svn path=/trunk/; revision=37702
2011-05-25Use PI_UNDECODED instead.Anders Broman1-1/+1
svn path=/trunk/; revision=37392
2011-05-25Add a convinience function to add expert warnings for not dissected items.Anders Broman1-0/+12
svn path=/trunk/; revision=37391
2010-07-16Make frames containing Malformed expert items match with "malformed" display ↵Martin Mathieson1-0/+7
filter. svn path=/trunk/; revision=33551
2010-02-27Clean up implementation.Jaap Keuter1-48/+42
svn path=/trunk/; revision=32039
2010-01-19Fix a double-free bug which was causing a crash. Our decryption bufferGerald Combs1-2/+2
length doesn't change, so allocate it just once. Add an expert item for a successful decryption. svn path=/trunk/; revision=31571
2009-12-18Added expert info group PI_PROTOCOL.Stig Bjørlykke1-0/+1
svn path=/trunk/; revision=31308
2009-09-30Whitespace changesBill Meier1-21/+22
svn path=/trunk/; revision=30210
2009-09-13Modified extarct from Didier Gautheron:Anders Broman1-17/+26
optimizations patch http://wiki.wireshark.org/Development/Optimization 'patch.29854.diff.gz" - ei->protocol is a constant. - Don't setup expert tap data if there's no tap. svn path=/trunk/; revision=29873
2009-09-06Split a bunch of init routines into init() and cleanup(). This allows us to ↵Kovarththanan Rajaratnam1-6/+4
free memory properly on shutdown. This is an initial step. There's still some work to do. svn path=/trunk/; revision=29754
2009-08-09Add PTREE_FINFO and use PITEM_FINFO when possible.Kovarththanan Rajaratnam1-1/+1
svn path=/trunk/; revision=29355
2009-06-04Added missing PI_DEBUG to expert_group_vals[].Stig Bjørlykke1-1/+2
svn path=/trunk/; revision=28636
2009-03-18From Jakub Zawadzki: g_gnprintf & etc: Use size of buffer [not size -1];Bill Meier1-4/+1
- As suggested actually use sizeof(...) rather than a numeric constant. - g_snprintf() and g_vsnprintf() since glib 1.3.12 do not return -1. svn path=/trunk/; revision=27772
2009-03-09From Jakub Zawadzki and me (bug 3283):Stig Bjørlykke1-0/+55
Added display filter for packets with expert info. svn path=/trunk/; revision=27668
2007-07-23- add a column for the expert info severity levelUlf Lamping1-0/+3
- fix a column related bug introduced in SVN 20118 svn path=/trunk/; revision=22387
2007-03-23Fix about 150 warnings new to gcc 4.0 in the error on warning directories.Stephen Fisher1-1/+1
Comment out -Werror in plugins/asn1/ until warnings can be fixed. svn path=/trunk/; revision=21158
2006-08-31move value_strings from expert_dialogs into expert.c to remove duplicatesUlf Lamping1-1/+39
keep the highest severity level of the current file (experimental) svn path=/trunk/; revision=19104
2006-05-21name changeRonnie Sahlberg1-2/+2
svn path=/trunk/; revision=18197
2006-03-12Assure that pinfo is a valid pointer. Related to Coverity CID 112Jaap Keuter1-2/+2
svn path=/trunk/; revision=17601
2006-02-13Don't se_leak expert_info records.Luis Ontanon1-3/+3
se_alloc them where and if needed, not every time expert_set_info_vformat is called. svn path=/trunk/; revision=17293
2005-11-25from Greg Morris:Ulf Lamping1-0/+2
Composite Expert statistics, see: http://www.ethereal.com/lists/ethereal-dev/200511/msg00002.html and the following discussions svn path=/trunk/; revision=16593
2005-09-11Frame numbers are unsigned, and they start at 1; 0 is what's used forGuy Harris1-2/+2
"unknown" for frame numbers. Note that in epan/frame_data.h, and make the frame number in experts unsigned, and use 0 for "unknown", and display it as an unsigned number - and, if it's 0, don't display it at all. Fix the signature of "expert_dlg_draw()" to match what a tap's draw routine's signature is expected to be. svn path=/trunk/; revision=15760
2005-09-11I'm adding the "Expert Info" prototype now, as it seems to be in a state ↵Ulf Lamping1-0/+117
where others might have a look and probably already find it useful :-). Anyway, we can easily disable it at one or two places in the code if it get's in our way of a new release. Please see: http://wiki.ethereal.com/Development/ExpertInfo for a complete overview of the intended feature and it's current state of implementation. While I'm working on this, I've also added some more status result codes to the DCE/RPC and DCOM dissectors. svn path=/trunk/; revision=15754
generated by cgit v1.2.3 (git 2.25.1) at 2024-09-28 13:44:31 +0000