Age | Commit message (Collapse) | Author | Files | Lines |
|
svn path=/trunk/; revision=47794
|
|
CAPWAP Header dissector returns invalid length
The problem is when Wireshark dissect CAPWAP packets from Cisco without preference "Cisco Wireless Controller Support"
In this case the whole packet decoded wrong, not only Wireless Specific Information field in CAPWAP header
I suggest following patch to dissect_capwap_header function to always return correct length of CAPWAP header based on HLEN header field
From me:
Add expert info to display a warning about Calculate length and Header length are different (and suggest to activate Cisco Wireless Controller Support Preference)
svn path=/trunk/; revision=47793
|
|
Add GSMTAP support for UMTS RRC captures
svn path=/trunk/; revision=47792
|
|
svn path=/trunk/; revision=47791
|
|
1) hf_reload_dmflags is 8 bytes, not 64 bytes.
2) Swap dissection order of dmflags and length.
3) Register ett_reload_self_tuning_data and ett_reload_diagnosticrequest.
#BACKPORT(1.8)
svn path=/trunk/; revision=47789
|
|
http://www.wireshark.org/download/automated/analysis/scan-build-2013-02-20-2/report-OsH7hZ.html#EndPath
svn path=/trunk/; revision=47782
|
|
add modelines
svn path=/trunk/; revision=47781
|
|
Bail out if length is less than the minimum required length.
svn path=/trunk/; revision=47776
|
|
Prevent an infinite loop if we don't recognize the param type and
the length is 0.
svn path=/trunk/; revision=47775
|
|
Add text/parameters
Fixes https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=5714
If we need something better we should make a text/parameters dissector I suppose.
svn path=/trunk/; revision=47772
|
|
In fixing this bug, also fix another: Be sure to use tvb_length() and not tvb_reported_length() in get_utp_version(), since this is essentially where the heuristics are being applied to decide whether to accept the packet or not.
svn path=/trunk/; revision=47761
|
|
Reformat the hf[] array to be consistent, and get rid of some bogus
blurbs (probably copy-and-pasteos).
svn path=/trunk/; revision=47759
|
|
an exception, not how it happens to be implemented currently.
svn path=/trunk/; revision=47755
|
|
svn path=/trunk/; revision=47754
|
|
tvbuff and runs to the end of the tvbuff? Let me count the ways....
Replace a bunch of different ways of doing that (some incorrect, in that
they're not properly handling tvbuffs where the captured and reported
lengths are different) with tvb_new_subset_remaining().
svn path=/trunk/; revision=47751
|
|
svn path=/trunk/; revision=47747
|
|
svn path=/trunk/; revision=47746
|
|
checksummed, which is the length of the TPDU, not that length + 1.
Calculate the TPDU length correctly - use
tvb_reported_length_remaining(), not tvb_length_remaining() (we want the
*actual* length, not the amount of captured data we have), and take the
offset handed to the dissector routine into account. Don't take the
length indicator into account for TPDUs with user data, as they run to
the end of the lower-level packet containing the TPDU(s). The CLTP UD
TPDU contains user data.
Note that this dissects both COTP *and* CLTP (that's why it's
"packet-ositp.c", not "packet-cotp.c").
Separate some groups of #includes with blank lines.
svn path=/trunk/; revision=47745
|
|
svn path=/trunk/; revision=47744
|
|
svn path=/trunk/; revision=47743
|
|
Misc. whitespace changes, remove tabs, add modelines to match current scheme.
svn path=/trunk/; revision=47742
|
|
case of multiple TPDU's per frame.
Bug 8293 (https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=8293)
svn path=/trunk/; revision=47741
|
|
it's been used in an rtp_set_address() or srtp_set_address() call and,
if that Boolean is set, don't free the hash table; this fixes a case
where the hash table was freed while it was in use.
svn path=/trunk/; revision=47740
|
|
accordingly.
Various cleanup to use proto_tree_add_item more often.
svn path=/trunk/; revision=47739
|
|
svn path=/trunk/; revision=47738
|
|
an int, so don't use enums for special values of the PLP length field.
In addition, use G_GINT64_CONSTANT() to tag them as appropriate for a
guint64.
svn path=/trunk/; revision=47737
|
|
Misc. fixes to the SML dissector:
- one more define added
- removed data_handle (unused)
- removed "check = tvb_get_guint8(tvb, temp_offset);" (value hasn't changed)
- added PI_NOTE
- CRC fixed, calculation now correct if CRC is transmitted as UINT8
From me:
- clean up indentation
- change modelines to actually match the indentation most commonly used
svn path=/trunk/; revision=47736
|
|
svn path=/trunk/; revision=47734
|
|
svn path=/trunk/; revision=47733
|
|
svn path=/trunk/; revision=47732
|
|
svn path=/trunk/; revision=47731
|
|
Feed the tap before trying to dissect the payload. This prevents a malformed
payload from blocking the tap, resulting in incorrect RTP statistics.
svn path=/trunk/; revision=47729
|
|
Stream"
From Joe McEachern, bug 6434 (https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=6434)
svn path=/trunk/; revision=47725
|
|
throwing the "packet count" off.
Bug 5064 (https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=5064)
svn path=/trunk/; revision=47723
|
|
Additionally:
1) Remove check_col()'s
2) Don't call expert_add_info_format() from within an if (tree) {} block.
3) tvb_reported_length_remaining() can return -1; be sure to handle it.
4) Misc. whitespace changes.
svn path=/trunk/; revision=47722
|
|
Also addresses an implicit cast in the epan/uat.h file
Bug 8342 (https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=8342)
svn path=/trunk/; revision=47721
|
|
svn path=/trunk/; revision=47720
|
|
svn path=/trunk/; revision=47717
|
|
svn path=/trunk/; revision=47716
|
|
Negotiation
From Stefan Allers. Bug 8347 (https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=8347)
svn path=/trunk/; revision=47715
|
|
svn path=/trunk/; revision=47714
|
|
dissected as QSIG or ETSI.
Add the ISUP Supplementary services dissector.
svn path=/trunk/; revision=47713
|
|
(https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=8346)
svn path=/trunk/; revision=47708
|
|
caught at a higher layer (SIP), but the safety net should be there.
Also, cleanup SIP "response error" range.
Fixes crash in bug 8343 (https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=8343)
svn path=/trunk/; revision=47705
|
|
Cleans up many valgrind errors, since we were losing our pointers to
the arrays before shutdown.
svn path=/trunk/; revision=47702
|
|
With small additional changes by me
Make many of the length and offset fields in the websocket dissector unsigned.
This fixes a case where we could attempt to malloc (unsigned)-1 bytes of memory.
Also fix one small copy-paste string typo.
svn path=/trunk/; revision=47700
|
|
svn path=/trunk/; revision=47696
|
|
New dissector for the SML protocol.
svn path=/trunk/; revision=47695
|
|
Request-response tracking and response-time calculation for HTTP.
svn path=/trunk/; revision=47694
|
|
svn path=/trunk/; revision=47693
|