aboutsummaryrefslogtreecommitdiffstats
path: root/epan/dissectors
AgeCommit message (Collapse)AuthorFilesLines
2013-02-21Fix CheckAPI about trailing spaceAlexis La Goutte1-1/+1
svn path=/trunk/; revision=47794
2013-02-21From Paul via https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=8319 ↵Alexis La Goutte1-6/+13
CAPWAP Header dissector returns invalid length The problem is when Wireshark dissect CAPWAP packets from Cisco without preference "Cisco Wireless Controller Support" In this case the whole packet decoded wrong, not only Wireless Specific Information field in CAPWAP header I suggest following patch to dissect_capwap_header function to always return correct length of CAPWAP header based on HLEN header field From me: Add expert info to display a warning about Calculate length and Header length are different (and suggest to activate Cisco Wireless Controller Support Preference) svn path=/trunk/; revision=47793
2013-02-21From Harald Welte via https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=8365 :Pascal Quantin1-4/+157
Add GSMTAP support for UMTS RRC captures svn path=/trunk/; revision=47792
2013-02-21I'm pretty sure that reassembled IPv6 data does not fit in a uint32.Jaap Keuter1-1/+1
svn path=/trunk/; revision=47791
2013-02-21Misc. fixes while looking at bug 8364 (which this patch does NOT address):Chris Maynard1-3/+5
1) hf_reload_dmflags is 8 bytes, not 64 bytes. 2) Swap dissection order of dmflags and length. 3) Register ett_reload_self_tuning_data and ett_reload_diagnosticrequest. #BACKPORT(1.8) svn path=/trunk/; revision=47789
2013-02-20fix dead assignmentMartin Kaiser1-1/+0
http://www.wireshark.org/download/automated/analysis/scan-build-2013-02-20-2/report-OsH7hZ.html#EndPath svn path=/trunk/; revision=47782
2013-02-20TABs -> spacesMartin Kaiser1-580/+594
add modelines svn path=/trunk/; revision=47781
2013-02-20From Chris Maynard via https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=8360Evan Huus1-1/+3
Bail out if length is less than the minimum required length. svn path=/trunk/; revision=47776
2013-02-20Fix https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=8359Evan Huus1-0/+7
Prevent an infinite loop if we don't recognize the param type and the length is 0. svn path=/trunk/; revision=47775
2013-02-20From Michael Mann:Anders Broman1-0/+1
Add text/parameters Fixes https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=5714 If we need something better we should make a text/parameters dissector I suppose. svn path=/trunk/; revision=47772
2013-02-20Fix Coverity CID 751720: Logically dead code.Chris Maynard1-18/+17
In fixing this bug, also fix another: Be sure to use tvb_length() and not tvb_reported_length() in get_utp_version(), since this is essentially where the heuristics are being applied to decide whether to accept the packet or not. svn path=/trunk/; revision=47761
2013-02-20Clean up white space - get rid of 4-space tabs.Guy Harris1-168/+178
Reformat the hf[] array to be consistent, and get rid of some bogus blurbs (probably copy-and-pasteos). svn path=/trunk/; revision=47759
2013-02-20Improve a comment - what matters is that tvb_new_real_data() can throwGuy Harris1-4/+1
an exception, not how it happens to be implemented currently. svn path=/trunk/; revision=47755
2013-02-20Fix Coverity CID 984638: Unused pointer value.Chris Maynard1-1/+1
svn path=/trunk/; revision=47754
2013-02-19How can I get a new tvbuff that starts at an offset within a givenGuy Harris41-91/+68
tvbuff and runs to the end of the tvbuff? Let me count the ways.... Replace a bunch of different ways of doing that (some incorrect, in that they're not properly handling tvbuffs where the captured and reported lengths are different) with tvb_new_subset_remaining(). svn path=/trunk/; revision=47751
2013-02-19Remove experiment with global codeAnders Broman1-34/+1
svn path=/trunk/; revision=47747
2013-02-19Add the remaining asn1 files "CODE global" not handled yet.Anders Broman1-10/+121
svn path=/trunk/; revision=47746
2013-02-19calc_checksum() should be passed the length of the block to beGuy Harris1-11/+42
checksummed, which is the length of the TPDU, not that length + 1. Calculate the TPDU length correctly - use tvb_reported_length_remaining(), not tvb_length_remaining() (we want the *actual* length, not the amount of captured data we have), and take the offset handed to the dissector routine into account. Don't take the length indicator into account for TPDUs with user data, as they run to the end of the lower-level packet containing the TPDU(s). The CLTP UD TPDU contains user data. Note that this dissects both COTP *and* CLTP (that's why it's "packet-ositp.c", not "packet-cotp.c"). Separate some groups of #includes with blank lines. svn path=/trunk/; revision=47745
2013-02-19According to wikipedia, the A6M was outdated by 1944. Let it rest in peace.Chris Maynard2-19/+15
svn path=/trunk/; revision=47744
2013-02-19Whitespace tweaks.Guy Harris1-5/+6
svn path=/trunk/; revision=47743
2013-02-19Don't call expert_add_info_format() from within an if (tree) {} block.Chris Maynard1-94/+93
Misc. whitespace changes, remove tabs, add modelines to match current scheme. svn path=/trunk/; revision=47742
2013-02-19Bugfix OSITP - Incorrect TP4 checksum calculation (ATN extended checksum) in ↵Michael Mann1-24/+31
case of multiple TPDU's per frame. Bug 8293 (https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=8293) svn path=/trunk/; revision=47741
2013-02-18For each dynamic-payload hash table, keep a Boolean indicating whetherGuy Harris1-16/+36
it's been used in an rtp_set_address() or srtp_set_address() call and, if that Boolean is set, don't free the hash table; this fixes a case where the hash table was freed while it was in use. svn path=/trunk/; revision=47740
2013-02-18Use tcp_dissect_pdus for better dissection on TCP. Adjusted UDP dissection ↵Michael Mann1-149/+160
accordingly. Various cleanup to use proto_tree_add_item more often. svn path=/trunk/; revision=47739
2013-02-18Dissect more supplementarry servicesAnders Broman1-16/+1751
svn path=/trunk/; revision=47738
2013-02-18Enums aren't guaranteed to be able to hold a value that doesn't fit inGuy Harris1-1/+3
an int, so don't use enums for special values of the PLP length field. In addition, use G_GINT64_CONSTANT() to tag them as appropriate for a guint64. svn path=/trunk/; revision=47737
2013-02-18From Alex Gaertner via https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=8313Evan Huus1-19/+22
Misc. fixes to the SML dissector: - one more define added - removed data_handle (unused) - removed "check = tvb_get_guint8(tvb, temp_offset);" (value hasn't changed) - added PI_NOTE - CRC fixed, calculation now correct if CRC is transmitted as UINT8 From me: - clean up indentation - change modelines to actually match the indentation most commonly used svn path=/trunk/; revision=47736
2013-02-18Fix small typo in TPC Report IEAlexis La Goutte1-2/+2
svn path=/trunk/; revision=47734
2013-02-18Fix some Dead Store (Dead assignement/Dead increment) Warning found by ClangAlexis La Goutte1-1/+1
svn path=/trunk/; revision=47733
2013-02-18From 802.11-2012.pdf Update Reason Code and Status Code fieldsAlexis La Goutte1-2/+36
svn path=/trunk/; revision=47732
2013-02-18Display Power Constraint in DEC (and fix a small typo)Alexis La Goutte1-2/+2
svn path=/trunk/; revision=47731
2013-02-18Fix for bug 8321:Jaap Keuter1-4/+9
Feed the tap before trying to dissect the payload. This prevents a malformed payload from blocking the tap, resulting in incorrect RTP statistics. svn path=/trunk/; revision=47729
2013-02-18Bugfix data combined via ssl_desegment_app_data not visible via "Follow SSL ↵Michael Mann1-0/+1
Stream" From Joe McEachern, bug 6434 (https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=6434) svn path=/trunk/; revision=47725
2013-02-17Improve SSH state machine so IGNORED messages don't upset the dissection by ↵Michael Mann1-232/+162
throwing the "packet count" off. Bug 5064 (https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=5064) svn path=/trunk/; revision=47723
2013-02-17Fix Coverity CID 981983: Unused pointer value.Chris Maynard1-268/+125
Additionally: 1) Remove check_col()'s 2) Don't call expert_add_info_format() from within an if (tree) {} block. 3) tvb_reported_length_remaining() can return -1; be sure to handle it. 4) Misc. whitespace changes. svn path=/trunk/; revision=47722
2013-02-17Remove C++ incompatibilities in c1222 dissector.Michael Mann1-22/+14
Also addresses an implicit cast in the epan/uat.h file Bug 8342 (https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=8342) svn path=/trunk/; revision=47721
2013-02-17Update ITU-T E.212 to bulletin 1019 (01.I.2013)Pascal Quantin1-218/+398
svn path=/trunk/; revision=47720
2013-02-17Squelch some more warnings.Guy Harris1-2/+6
svn path=/trunk/; revision=47717
2013-02-17Squelch some warnings.Guy Harris1-73/+11
svn path=/trunk/; revision=47716
2013-02-17Support for SCU/SCP Role Selection and Asynchronous Operations Window ↵Michael Mann1-53/+377
Negotiation From Stefan Allers. Bug 8347 (https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=8347) svn path=/trunk/; revision=47715
2013-02-17Try to fix merge problem.Anders Broman1-1593/+10
svn path=/trunk/; revision=47714
2013-02-17Add a preferense to the Q.932 dissector wether facility messages should be ↵Anders Broman3-14/+3233
dissected as QSIG or ETSI. Add the ISUP Supplementary services dissector. svn path=/trunk/; revision=47713
2013-02-17Bugfix DoS in CIMD dissector. Bug 8346 ↵Michael Mann1-3/+3
(https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=8346) svn path=/trunk/; revision=47708
2013-02-17Only allow one packet to act as an SDP response. This should probably be ↵Michael Mann2-3/+4
caught at a higher layer (SIP), but the safety net should be there. Also, cleanup SIP "response error" range. Fixes crash in bug 8343 (https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=8343) svn path=/trunk/; revision=47705
2013-02-17Use wmem memory to build most of the diameter hf and ett arrays.Evan Huus1-9/+10
Cleans up many valgrind errors, since we were losing our pointers to the arrays before shutdown. svn path=/trunk/; revision=47702
2013-02-17From Alyssa Milburn via https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=8341Evan Huus1-11/+11
With small additional changes by me Make many of the length and offset fields in the websocket dissector unsigned. This fixes a case where we could attempt to malloc (unsigned)-1 bytes of memory. Also fix one small copy-paste string typo. svn path=/trunk/; revision=47700
2013-02-16Add missing G_GUINT64_CONSTANT for 32-bit platforms.Evan Huus1-2/+2
svn path=/trunk/; revision=47696
2013-02-16From Alex Gaertner via https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=8313Evan Huus2-0/+3034
New dissector for the SML protocol. svn path=/trunk/; revision=47695
2013-02-16From Dirk via https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=8287Evan Huus2-3/+191
Request-response tracking and response-time calculation for HTTP. svn path=/trunk/; revision=47694
2013-02-16Fix typo errorPascal Quantin1-2/+2
svn path=/trunk/; revision=47693