aboutsummaryrefslogtreecommitdiffstats
path: root/epan/dissectors
AgeCommit message (Collapse)AuthorFilesLines
2018-02-17Don't gratuitously cast away constness.Guy Harris1-2/+2
Change-Id: I5c80e50c524db6ee80e1529af447db9a26e02f48 Reviewed-on: https://code.wireshark.org/review/25849 Reviewed-by: Guy Harris <guy@alum.mit.edu>
2018-02-17Don't gratuitiously cast constness away.Guy Harris1-3/+3
Change-Id: Ie373b7e1079092e01c99939f29d7afdbf465bd8b Reviewed-on: https://code.wireshark.org/review/25848 Reviewed-by: Guy Harris <guy@alum.mit.edu>
2018-02-17Don't gratuitiously cast constness away.Guy Harris1-2/+2
Change-Id: Ibd43d689cd4d00c26440589a772a818f6c5905c3 Reviewed-on: https://code.wireshark.org/review/25847 Reviewed-by: Guy Harris <guy@alum.mit.edu>
2018-02-17Put back casts needed for C++ compatibility.Guy Harris1-2/+2
Change-Id: Ia83d08f62e97478f532da9af0c1cbfef7532b1c7 Reviewed-on: https://code.wireshark.org/review/25846 Reviewed-by: Guy Harris <guy@alum.mit.edu>
2018-02-17Don't gratuitously cast away constness.Guy Harris1-3/+3
Change-Id: I51e7207835190fc87cf7c7cb0cf3a09a0588629a Reviewed-on: https://code.wireshark.org/review/25845 Reviewed-by: Guy Harris <guy@alum.mit.edu>
2018-02-17Constify a pointer to squelch a warning.Guy Harris1-1/+1
Change-Id: I3e83f79227b080d336b5fef14df1ea75a13238de Reviewed-on: https://code.wireshark.org/review/25844 Reviewed-by: Guy Harris <guy@alum.mit.edu>
2018-02-17Constify a bunch of pointers and some casts.Guy Harris1-13/+13
This squelches a bunch of "constness casted away" warnings. Change-Id: I95949ccbecceea651e7e4acb99f8e69ee0bfc475 Reviewed-on: https://code.wireshark.org/review/25843 Reviewed-by: Guy Harris <guy@alum.mit.edu>
2018-02-17Use appropriate pointer types rather than guint8 *.Guy Harris1-7/+10
This means we don't lose alignment information that causes spurious compiler warnings. Change-Id: I721f180c137bcffbcf7edf88cf8caf52c33fa545 Reviewed-on: https://code.wireshark.org/review/25842 Reviewed-by: Guy Harris <guy@alum.mit.edu>
2018-02-17dcerpc_decode_as_change() doesn't need to change the old binding.Guy Harris1-8/+8
The search doesn't use the fields we change (if it did, we probably shouldn't change them, as the old binding might not be found), so don't change them. Instead, when we allocate a *new* binding structure, put the new values into *that* structure. Squelches a "casting away constness" warning. Change-Id: I6dbd1a4cbc2415373f4926f443f9756c8113c0be Reviewed-on: https://code.wireshark.org/review/25841 Reviewed-by: Guy Harris <guy@alum.mit.edu>
2018-02-17No need to cast away constness.Guy Harris1-1/+1
Change-Id: I9778f2bf867539f83835d6c04bac201e66b1e5ee Reviewed-on: https://code.wireshark.org/review/25838 Reviewed-by: Guy Harris <guy@alum.mit.edu>
2018-02-17The CRC8 routines don't modify the buffer; make the pointers to it const.Guy Harris1-11/+11
This lets us get rid of some casts that provoke "drops const qualifier" warnings. Change-Id: Ia7e0863bd97bc20dbbb810e13778ec78d0cf3c91 Reviewed-on: https://code.wireshark.org/review/25837 Reviewed-by: Guy Harris <guy@alum.mit.edu>
2018-02-17wisun: Add EDFE supportRobert Sauter1-4/+80
During an EDFE exchange the source addresses are omitted after the first frame. Restore the information to enable decryption and 6LoWPAN reassembly. Change-Id: I9660c81e0536cea56caf104a16e41eaf6c123e09 Reviewed-on: https://code.wireshark.org/review/25819 Reviewed-by: Michael Mann <mmann78@netscape.net> Petri-Dish: Michael Mann <mmann78@netscape.net> Tested-by: Petri Dish Buildbot Reviewed-by: Stig Bjørlykke <stig@bjorlykke.org>
2018-02-17ldap: Format text used in COL_INFOStig Bjørlykke2-6/+6
Use format_text() on strings from packet used in COL_INFO to show non-printable characters as C-style escapes. Bug: 14424 Change-Id: Ibeb18958e0c5877681a18873377ad96d7237490c Reviewed-on: https://code.wireshark.org/review/25808 Petri-Dish: Stig Bjørlykke <stig@bjorlykke.org> Tested-by: Petri Dish Buildbot Reviewed-by: Michael Mann <mmann78@netscape.net>
2018-02-17Thread: use wider variables to prevent overflow and infinite loopsPascal Quantin1-4/+4
Bug: 14428 Change-Id: I5536bdca23b24e41c13c0837d1f50d9db26f864a Reviewed-on: https://code.wireshark.org/review/25832 Reviewed-by: Pascal Quantin <pascal.quantin@gmail.com> Petri-Dish: Pascal Quantin <pascal.quantin@gmail.com> Tested-by: Petri Dish Buildbot Reviewed-by: Michael Mann <mmann78@netscape.net>
2018-02-17Use -Werror except for explicitly listed dirty dissectors.Guy Harris1-1/+1
Use AM_CFLAGS for everything except for libdirtydissectors in epan/dissectors. Rename GENERATED_CFLAGS/GENERATED_CXXFLAGS to DIRTY_CFLAGS/DIRTY_CXXFLAGS, as it doesn't apply to all generated files. Change-Id: I702b53e185d6972c08d68ef31c05df7b03669daa Reviewed-on: https://code.wireshark.org/review/25829 Petri-Dish: Guy Harris <guy@alum.mit.edu> Tested-by: Petri Dish Buildbot Reviewed-by: Guy Harris <guy@alum.mit.edu>
2018-02-16[PFCP] Added dissect function for User Plane Inactivity Timer IEMatej Tkac1-0/+34
in accordance with 3GPP 29.244 v15.0.0 Change-Id: I27d65d591976edfef13a713cf3a0768915e29256 Reviewed-on: https://code.wireshark.org/review/25803 Petri-Dish: Anders Broman <a.broman58@gmail.com> Tested-by: Petri Dish Buildbot Reviewed-by: Anders Broman <a.broman58@gmail.com>
2018-02-16mac-lte: fix memory leak of mac_lte_msg3_cr_hashPeter Wu1-0/+1
Found by LeakSanitizer with "tshark -i dbus-session -c1". Change-Id: Icef967755088ef25a9b1f2cd7def97078b274966 Fixes: v2.5.0rc0-1865-g52365a55e4 ("LTE L2 protocols: add FT_FRAMENUM_TYPE for most FT_FRAMENUM fields.") Reviewed-on: https://code.wireshark.org/review/25818 Petri-Dish: Peter Wu <peter@lekensteyn.nl> Tested-by: Petri Dish Buildbot Reviewed-by: Martin Mathieson <martin.r.mathieson@googlemail.com>
2018-02-16[Diameter] Gx Supported-Features AVP, List-ID 2Joakim Karlsson1-136/+204
Change-Id: I5cf5adf8c8ae8cbfb9c4c6369454ab4b3ee230a4 Reviewed-on: https://code.wireshark.org/review/25816 Petri-Dish: Alexis La Goutte <alexis.lagoutte@gmail.com> Tested-by: Petri Dish Buildbot Reviewed-by: Anders Broman <a.broman58@gmail.com>
2018-02-15Fix a case of copy - too little modify - pasteJoerg Mayer1-1/+1
Change-Id: I4c9ef6b89e0a07d2f9cac59221e0a8ac8f907883 Reviewed-on: https://code.wireshark.org/review/25809 Reviewed-by: Jörg Mayer <jmayer@loplof.de>
2018-02-15Put some info into the INFO columnJoerg Mayer1-64/+102
Change-Id: I4ee22454d45edb382a76603fe21360719c5fa27f Reviewed-on: https://code.wireshark.org/review/25805 Reviewed-by: Jörg Mayer <jmayer@loplof.de>
2018-02-15Move hkdf_extract to wsgcrypt.hPeter Wu1-11/+0
HKDF-Extract is not used in TLS, but in QUIC. For reuse in OSCORE, move it to wsutil. Adjust comments slightly to emphasize precondition. Change-Id: I5105e7416037697b383ad58f62be285c2b7ab8b7 Reviewed-on: https://code.wireshark.org/review/25802 Petri-Dish: Peter Wu <peter@lekensteyn.nl> Reviewed-by: Mališa Vučinić <malishav@gmail.com> Tested-by: Petri Dish Buildbot Reviewed-by: Alexis La Goutte <alexis.lagoutte@gmail.com>
2018-02-15steam-ihs: Add dissector for the Steam IHS Discovery ProtocolJan Holthuis3-0/+1478
This adds a dissector for the Steam In-Home Streaming Discovery Protocol by Valve Software. Useful documentation can be found at: https://codingrange.com/blog/steam-in-home-streaming-discovery-protocol Change-Id: I26a79e201cfb0aad0ca702ac962e1e7b1b541517 Reviewed-on: https://code.wireshark.org/review/23615 Petri-Dish: Alexis La Goutte <alexis.lagoutte@gmail.com> Tested-by: Petri Dish Buildbot Reviewed-by: Anders Broman <a.broman58@gmail.com>
2018-02-15DCT2000: read new LTE MAC outheader valuesMartin Mathieson3-40/+59
Also extend the carrier id enum to r10 levels. Change-Id: I1eac50c54801010f0ad7408debb80ad811e03fbe Reviewed-on: https://code.wireshark.org/review/25793 Petri-Dish: Martin Mathieson <martin.r.mathieson@googlemail.com> Reviewed-by: Anders Broman <a.broman58@gmail.com>
2018-02-14SIGCOMP: check operand offset when accessing UDVM memoryPascal Quantin1-18/+180
Bug: 14398 Change-Id: Iae786d6766f63926766ab6139d76bdc24fa37103 Reviewed-on: https://code.wireshark.org/review/25790 Petri-Dish: Pascal Quantin <pascal.quantin@gmail.com> Tested-by: Petri Dish Buildbot Reviewed-by: Anders Broman <a.broman58@gmail.com>
2018-02-14[nb_rtpmux] Register dissector by name.AndersBroman1-0/+1
Change-Id: I6aca4e84e44cad42bff969d55371d6ac6c5e9600 Reviewed-on: https://code.wireshark.org/review/25788 Petri-Dish: Anders Broman <a.broman58@gmail.com> Tested-by: Petri Dish Buildbot Reviewed-by: Anders Broman <a.broman58@gmail.com>
2018-02-14OpenFlow 1.5: add extra property length checksPascal Quantin1-10/+85
Bug: 14420 Change-Id: I1813bc6285f950d86dc569f4286bf34c120b5e3c Reviewed-on: https://code.wireshark.org/review/25780 Reviewed-by: Pascal Quantin <pascal.quantin@gmail.com> Petri-Dish: Pascal Quantin <pascal.quantin@gmail.com> Tested-by: Petri Dish Buildbot Reviewed-by: Anders Broman <a.broman58@gmail.com>
2018-02-14packet-mq: Code reformatRobert Grange4-667/+667
Only reformated code (VS2017 with Ctrl K + Ctrl D) No code logic change Change-Id: If574c50cf0efb75984beb45df958be991ea63819 Reviewed-on: https://code.wireshark.org/review/25771 Reviewed-by: Alexis La Goutte <alexis.lagoutte@gmail.com> Petri-Dish: Alexis La Goutte <alexis.lagoutte@gmail.com> Tested-by: Petri Dish Buildbot Reviewed-by: Anders Broman <a.broman58@gmail.com>
2018-02-13OpenFlow: update openflow_version_values value_stringPascal Quantin1-5/+6
Change-Id: I0552770981d56c1a530b65e755146ec1314fccd8 Reviewed-on: https://code.wireshark.org/review/25781 Reviewed-by: Pascal Quantin <pascal.quantin@gmail.com>
2018-02-13XRA: protect against potential infinite loops and add protocol to release notesPascal Quantin1-6/+6
Change-Id: Ib1dc560e0c0c83ada668ada2da799808d5d10fc2 Reviewed-on: https://code.wireshark.org/review/25776 Petri-Dish: Pascal Quantin <pascal.quantin@gmail.com> Reviewed-by: Guy Harris <guy@alum.mit.edu>
2018-02-13Add the Excentis XRA DOCSIS header dissector to CMake.Guy Harris1-0/+1
All changes to the set of Wireshark source files must be done in both Makefile.am and CMakeLists.txt files. Change-Id: Iad0db912dcfd149d0f5acbb38489e0a34c6dac89 Reviewed-on: https://code.wireshark.org/review/25778 Reviewed-by: Guy Harris <guy@alum.mit.edu>
2018-02-13Update the introductory comment.Guy Harris1-7/+4
Update the URL for the Cisco CMTS. Remove the stuff about the Arris devices; the link doesn't work, their site doesn't seem to mention "Cadant", and the C4 page I did find doesn't say anything about how to do captures (that's probably hidden behind a customerwall). Emphasize that, if you can, and do, select "DOCSIS" as the link-layer type when capturing on an Ethernet, the file (for pcap) or interface (for pcapng) will be handled as DOCSIS, even if you don't set the "force all frames to be dissected as DOCSIS" preference. Change-Id: Iec44d4b9c6af231e9b7f36962515b566b3433fb4 Reviewed-on: https://code.wireshark.org/review/25777 Reviewed-by: Guy Harris <guy@alum.mit.edu>
2018-02-13ieee80211: Correct the actual bit positions of the reserved bits.Richard Sharpe1-3/+3
The reserved bit positions should match the bit positions of the fields that are reserved. Also, the hf_he_srg_information_present bit was nibble reversed. Errors found by George Baltatanu. Change-Id: I218ff9aa7bdabc4ec6e470c3ef1be230ce341b34 Reviewed-on: https://code.wireshark.org/review/25760 Reviewed-by: Anders Broman <a.broman58@gmail.com>
2018-02-13Added dissector for Excentis DOCSIS31 XRA header. DLT 273. Builtin version.Bruno Verstuyft2-0/+1212
Change-Id: I7d4a9cf094e8ae6af05d5599489fc609456c5645 Reviewed-on: https://code.wireshark.org/review/25768 Petri-Dish: Anders Broman <a.broman58@gmail.com> Tested-by: Petri Dish Buildbot Reviewed-by: Anders Broman <a.broman58@gmail.com>
2018-02-13cms: Add support for RFC 4108Robert Sauter6-18/+1136
Change-Id: I1ab32240e00c7682074e7bc9d1b05e6daa6b69b4 Reviewed-on: https://code.wireshark.org/review/25769 Petri-Dish: Anders Broman <a.broman58@gmail.com> Tested-by: Petri Dish Buildbot Reviewed-by: Anders Broman <a.broman58@gmail.com>
2018-02-13Make the DOCSIS dissector a built-in dissector.Guy Harris7-0/+17675
Stuff that calls it is built in, and stuff it calls is built in, so there's not much point in having it be a plugin; we already have examples of plugin dissectors. Change-Id: I512e0fda62faedb5f03f476fbece2e267e1d644f Reviewed-on: https://code.wireshark.org/review/25775 Petri-Dish: Guy Harris <guy@alum.mit.edu> Tested-by: Petri Dish Buildbot Reviewed-by: Guy Harris <guy@alum.mit.edu>
2018-02-13Fix the "pointer to function that generates a label" values.Guy Harris12-12/+12
build_label_func is a pointer type, pointing to a function that can be used to generate a label for a "Decode As" entry. There's no need to have pointers to those pointers; have register_decode_as_next_proto() take a build_label_func, not a build_label_func *, as its last argument, assign that value rather than dereferencing it, get rid of unnecessary casts, and fix the comment in epan/decode_as.h for that argument. Change-Id: Idc3cf18204c543a2191b122c8129b362562c0ecd Reviewed-on: https://code.wireshark.org/review/25773 Reviewed-by: Guy Harris <guy@alum.mit.edu>
2018-02-13ssl: Add session ticket lifetime units in secondsStig Bjørlykke2-3/+11
Also show the seconds in a human readable string. Change-Id: I124bfc12954fb7c2c65777c028986d18c5686c7b Reviewed-on: https://code.wireshark.org/review/25772 Petri-Dish: Stig Bjørlykke <stig@bjorlykke.org> Tested-by: Petri Dish Buildbot Reviewed-by: Alexis La Goutte <alexis.lagoutte@gmail.com> Reviewed-by: Peter Wu <peter@lekensteyn.nl>
2018-02-13data: Add option to uncompress compressed dataStig Bjørlykke1-1/+35
Change-Id: I7bb212a9638c7b946294b7c805d9167ce7235e90 Reviewed-on: https://code.wireshark.org/review/25761 Petri-Dish: Stig Bjørlykke <stig@bjorlykke.org> Tested-by: Petri Dish Buildbot Reviewed-by: Anders Broman <a.broman58@gmail.com>
2018-02-13IPv6: SLAAC ether address is 8 bytesStig Bjørlykke1-1/+1
Change-Id: Id1ea9bb985b0e83c11d64cce4bb33ea7a65c794f Reviewed-on: https://code.wireshark.org/review/25763 Petri-Dish: Stig Bjørlykke <stig@bjorlykke.org> Tested-by: Petri Dish Buildbot Reviewed-by: Stig Bjørlykke <stig@bjorlykke.org>
2018-02-13Update couchbase dissector with 'flexible framing extras'Jim Walker1-9/+166
Add support to decode the new response message and then decode the array of flexible frames, currently only the "tracing" durations ID is fully decoded. See: https://github.com/couchbase/kv_engine/blob/master/docs/BinaryProtocol.md#response-header-with-flexible-framing-extras Change-Id: I9ea1e3bb898d9c4dd3b30cd1109b7b70fc17b19e Reviewed-on: https://code.wireshark.org/review/25613 Petri-Dish: Alexis La Goutte <alexis.lagoutte@gmail.com> Tested-by: Petri Dish Buildbot Reviewed-by: Anders Broman <a.broman58@gmail.com>
2018-02-13WMEM: Add strjoin routines.Craig Jackson1-14/+6
Add wmem versions corresponding to g_strjoin() and g_strjoinv(). Modify packet-rtps.c to use wmem routines_ where it is now using g_ routines causing mallocs. Change-Id: I92c890a8b8f29a973e103676d8e5a681ee5abd50 Reviewed-on: https://code.wireshark.org/review/25764 Reviewed-by: Anders Broman <a.broman58@gmail.com>
2018-02-13NBAP: Fix and enhance SIB parsingNick James8-453/+925
1. Parsing of complete-sib-short was wrong - did not consider the 8 bits of length in the begining 2. Added re-assembly logic for SIBs segmented into first/subsequent/last payloads Change-Id: I2c4aab2cace795c3e47a22921a34efc4ee26a25f Reviewed-on: https://code.wireshark.org/review/25598 Petri-Dish: Anders Broman <a.broman58@gmail.com> Tested-by: Petri Dish Buildbot Reviewed-by: Anders Broman <a.broman58@gmail.com>
2018-02-12[PFCP] Fixed a typo in Outer Header Creation IEMatej Tkac1-11/+11
Corrected octet order 3GPP TS 29.244 V15.0.0 Section 8.2.56 Change-Id: I9d4795641749481d7efea0b9b1743a0a94044aa2 Reviewed-on: https://code.wireshark.org/review/25759 Petri-Dish: Anders Broman <a.broman58@gmail.com> Tested-by: Petri Dish Buildbot Reviewed-by: Anders Broman <a.broman58@gmail.com>
2018-02-12dissectors: use SPDX identifiers.Dario Lombardo1844-24020/+1846
Change-Id: I92c94448e6641716d03158a5f332c8b53709423a Reviewed-on: https://code.wireshark.org/review/25756 Petri-Dish: Dario Lombardo <lomato@gmail.com> Reviewed-by: Anders Broman <a.broman58@gmail.com>
2018-02-12h225: Fix use after free.Jakub Zawadzki2-5/+29
next_tvb_add_handle() allocates memory in packet scope. When dissecting another packet from dissect_h225_h225_RasMessage() handler [it don't call next_tvb_init()] next_tvb_add_handle() will write to freed pointer. Fix by calling next_tvb_init() after leaving scope in order to clear list->last pointer. ASAN report: ERROR: AddressSanitizer: heap-use-after-free on address 0x6070000854f0 at pc 0x00000208574a bp 0x7ffca839cf00 sp 0x7ffca839cef8 WRITE of size 8 at 0x6070000854f0 thread T0 #0 0x2085749 in next_tvb_add_handle /src/wireshark/epan/next_tvb.c #1 0xef8728 in dissect_h225_ParallelH245Control_item /src/wireshark/epan/dissectors/./asn1/h225/h225.cnf:368:3 (...) #21 0x168f460 in dissect_per_sequence /src/wireshark/epan/dissectors/packet-per.c:1920:12 #22 0xef31d3 in dissect_h225_InfoRequestResponse /src/wireshark/epan/dissectors/./asn1/h225/h225.cnf:910:12 #23 0x168e7db in dissect_per_choice /src/wireshark/epan/dissectors/packet-per.c #24 0xeed6e3 in dissect_h225_RasMessage /src/wireshark/epan/dissectors/./asn1/h225/h225.cnf:298:12 #25 0xef97af in dissect_RasMessage_PDU /src/wireshark/epan/dissectors/./asn1/h225/h225.cnf:339:12 #26 0xeef872 in dissect_h225_h225_RasMessage /src/wireshark/epan/dissectors/./asn1/h225/packet-h225-template.c:385:12 0x6070000854f0 is located 0 bytes inside of 72-byte region [0x6070000854f0,0x607000085538) freed by thread T0 here: #0 0x4e2528 in __interceptor_cfree.localalias.0 /src/llvm/projects/compiler-rt/lib/asan/asan_malloc_linux.cc:76 #1 0x21263a1 in wmem_simple_free_all /src/wireshark/epan/wmem/wmem_allocator_simple.c:107:9 #2 0x205aa4d in wmem_leave_packet_scope /src/wireshark/epan/wmem/wmem_scopes.c:81:5 (...) previously allocated by thread T0 here: #0 0x4e26e8 in __interceptor_malloc /src/llvm/projects/compiler-rt/lib/asan/asan_malloc_linux.cc:88 #1 0x225c588 in g_malloc (/out/fuzzshark_test+0x225c588) #2 0x20855e0 in next_tvb_add_handle /src/wireshark/epan/next_tvb.c:40:10 #3 0xef8728 in dissect_h225_ParallelH245Control_item /src/wireshark/epan/dissectors/./asn1/h225/h225.cnf:368:3 Found by oss-fuzz/5921 Change-Id: Iea006914a9e0c433d2073f6f4c7a2973d5a33a11 Link: https://bugs.chromium.org/p/oss-fuzz/issues/detail?id=5921 Reviewed-on: https://code.wireshark.org/review/25593 Petri-Dish: Jakub Zawadzki <darkjames-ws@darkjames.pl> Tested-by: Petri Dish Buildbot Reviewed-by: Anders Broman <a.broman58@gmail.com>
2018-02-12NBAP: copy address in pinfo->poolPascal Quantin2-10/+10
They are copied in structures using pinfo lifetime. Let's use the same scope. Bug: 14416 Change-Id: I5f8ee6fff49d63584a246936f551db1803ff9816 Reviewed-on: https://code.wireshark.org/review/25748 Reviewed-by: Pascal Quantin <pascal.quantin@gmail.com> Petri-Dish: Pascal Quantin <pascal.quantin@gmail.com> Tested-by: Petri Dish Buildbot Reviewed-by: Anders Broman <a.broman58@gmail.com>
2018-02-12Extract HKDF-Expand from TLS 1.3 dissectorPeter Wu3-60/+59
HKDF (RFC 5869) is a standard construct used in TLS 1.3, QUIC and OSCORE, generalize it for use outside the TLS dissector. Since none of the users need the "context" (formerly "hash_value") field, remove the parameter. Change-Id: Id952de8cb3000f6f6eda844d17c78bbd3906a84d Reviewed-on: https://code.wireshark.org/review/25723 Petri-Dish: Peter Wu <peter@lekensteyn.nl> Tested-by: Petri Dish Buildbot Reviewed-by: Alexis La Goutte <alexis.lagoutte@gmail.com> Reviewed-by: Anders Broman <a.broman58@gmail.com>
2018-02-12RPC Netlogon: do not leak memory each time a hash is generatedPascal Quantin1-12/+17
Use copy_address_swallow() instead of copy_address(). When inserting the key in the hash map, copy it in wmem file scope. Bug: 14407 Change-Id: Ida524d314c943f480dd0e1bf44fd0ded01aafaeb Reviewed-on: https://code.wireshark.org/review/25731 Petri-Dish: Pascal Quantin <pascal.quantin@gmail.com> Tested-by: Petri Dish Buildbot Reviewed-by: Pascal Quantin <pascal.quantin@gmail.com>
2018-02-12packet-ipmi-picmg.c: Add NULL check in rq17.Michael Mann1-1/+5
Crafted packets may not have ipmi_header. Bug: 14409 Change-Id: Ib6a8eceab13525c6c8dca5cef8bce3532dc50911 Reviewed-on: https://code.wireshark.org/review/25745 Petri-Dish: Michael Mann <mmann78@netscape.net> Tested-by: Petri Dish Buildbot Reviewed-by: Anders Broman <a.broman58@gmail.com>
2018-02-12WCCP: Prevent very long loop in dissect_wccp2_alternate_mask_value_set_elementMichael Mann1-0/+2
Sanity check the total_length to make sure it doesn't go negative. Bug: 14412 Change-Id: I87e38f6c792fa81184e4c412d6433fbbf2060f28 Reviewed-on: https://code.wireshark.org/review/25744 Reviewed-by: Michael Mann <mmann78@netscape.net> Petri-Dish: Michael Mann <mmann78@netscape.net> Tested-by: Petri Dish Buildbot Reviewed-by: Anders Broman <a.broman58@gmail.com>
generated by cgit v1.2.3 (git 2.25.1) at 2024-07-02 07:52:21 +0000