Age | Commit message (Collapse) | Author | Files | Lines |
|
don't dissect attributes if there aren't any;
put each attribute into a subtree;
register the dissector by name.
Use "match_strval()" to check whether the message type is a known STUN
message type, and to generate the message type for the Info column.
Don't use "tvb_bytes_exist()" to check when we run out of data - use the
length fields from the packet. Check the sanity of those lengths, too.
svn path=/trunk/; revision=13063
|
|
come directly from packet data, so don't abort if they define a sequence
of keycodes that goes past 255 - just report errors for the keycodes
past 255.
Clean up indentation.
svn path=/trunk/; revision=13059
|
|
svn path=/trunk/; revision=13058
|
|
the modifier name for every keycode, just give the modifier name once
and then show all the keycodes), and use "proto_item_append_text()"
rather than building a string.
Clean up white space.
svn path=/trunk/; revision=13057
|
|
Fix 1:
Offset not incremented for relative type
Fix 2:
Semioctets not reversed for HHMMSS relative type
svn path=/trunk/; revision=13056
|
|
updates and enhancements:
- Added Cookie and L2-Specific sublayer support via preferences dialog.
- Added carried payload dissecting support from draft-ietf-l2tpext-pwe3-*
and draft-townsley-l2tpv3-mpls-02.txt
- Completed missing message types (call types) and result codes for stopccn
and cdn.
- Fixed conditionals for avp_vendor_id (Vendor-Specific AVPs)
- Changed Pseudowire Capabilities List AVPs to use subtree instead of tab
- Added numeric value of result and error codes
- Added Session ID for v3 data packets and missing flags and reserved
- Added version to the L2TPv3 protocol tree
- Changed `Tunnel Id' to `Control Connection Id' for v3
- Fixed offset for ctrl_tree on L2TPv3 over UDP
- Added `L2TPv3' in the COL_PROTOCOL and fixed handling of L2TP version
svn path=/trunk/; revision=13055
|
|
message length.
svn path=/trunk/; revision=13044
|
|
svn path=/trunk/; revision=13042
|
|
that doesn't mean it's padding at the end of a previous item - it might,
for example, be the *first* item in the chunk. Don't treat it as
padding.
Do, however, treat an item that begins with a zero byte as an item, but
break out of the loop processing items as soon as the item type is put
into the protocol tree, as there's no length field or data in an
RTCP_SDES_END item. Fix the comment for that loop to indicate that the
loop checks both for end-of-frame and for an RTCP_SDES_END item.
svn path=/trunk/; revision=13040
|
|
but the field is integral, not Boolean, so it's clearer if it's passed
as 0).
svn path=/trunk/; revision=13039
|
|
svn path=/trunk/; revision=13034
|
|
Catch size values >= 0x80000000 and throw an exception rather than
crashing with an assertion.
svn path=/trunk/; revision=13032
|
|
- Fix partly wrong cause values in the gmm (found by Miklos Szurdi)
- Fix high/low nibble swap of the force to standby field (found by
Miklos Szurdi)
- Dissect all elements
svn path=/trunk/; revision=13030
|
|
svn path=/trunk/; revision=13029
|
|
for H245
svn path=/trunk/; revision=13024
|
|
Have the DLSw dissector reject packets with an unknown version field.
Leave out some more fields when dissecting Capability Exchange packets,
as they're not used in those packets.
Show numbers in hex when appropriate.
Show the individual subfields of the flow control and SSP flags fields.
Show the frame direction field with val_to_str(), and show the raw
value.
Clean up indentation.
svn path=/trunk/; revision=13019
|
|
Remove bogus boilerplate from introductory comment.
svn path=/trunk/; revision=13018
|
|
svn path=/trunk/; revision=13016
|
|
Clean up indentation.
svn path=/trunk/; revision=13015
|
|
Transfer-Encoding header.
svn path=/trunk/; revision=13014
|
|
svn path=/trunk/; revision=13013
|
|
svn path=/trunk/; revision=13012
|
|
svn path=/trunk/; revision=13006
|
|
Add VENDOR_IETF to <epan/sminmpec.h>, and add an entry for it to
sminmpec_values[], so that the L2TP dissector can use them rather than
defining its own copy of the private enterprise number values and table
- and make it do so.
svn path=/trunk/; revision=12999
|
|
nothing.
svn path=/trunk/; revision=12998
|
|
and de-boilerplate another part of the comment.
Fix a test of "octet_aligned" that was setting it to false rather than
testing whether it was false.
svn path=/trunk/; revision=12996
|
|
svn path=/trunk/; revision=12994
|
|
svn path=/trunk/; revision=12993
|
|
generator.
Regenerate with latest asn2eth compiler.
svn path=/trunk/; revision=12992
|
|
svn path=/trunk/; revision=12987
|
|
Clean up indentation.
The signatures are 4-byte strings - treat them as such.
Don't hide fields - dissectors should show what all bytes, other than
perhaps padding bytes, are.
Don't use the tvb_format_text-ified versions of strings as the value -
Ethereal already deals with non-printable characters when displaying
them.
When creating a subset tvbuff that runs to the end of the parent, use -1
as the length, don't calculate the length ourselves.
Use "tvb_reported_length()", not "tvb_length()", in loops that parse the
entire packet.
svn path=/trunk/; revision=12986
|
|
svn path=/trunk/; revision=12984
|
|
svn path=/trunk/; revision=12982
|
|
o BGPv4 SAFI-Specific Attribute support
- draft-kapoor-nalawade-idr-bgp-ssa-00.txt
o Tunnel SAFI support for BGP
- draft-nalawade-kapoor-tunnel-safi-02.txt
o Small length fix
svn path=/trunk/; revision=12977
|
|
we're done with them.
svn path=/trunk/; revision=12974
|
|
(There's still the risk of a leak if we throw an exception before we
free the string.)
Clean up indentation.
svn path=/trunk/; revision=12973
|
|
Use "format_text()" or "tvb_format_text()" with the %s format, to handle
non-printable characters.
When uncompressing data into a new tvbuff, add it to the list of data
sources as we do elsewhere.
When putting items into the protocol tree from an uncompressed tvbuff,
use the offset into the tvbuff and the length of the item.
Fetch string lengths into a variable and use the variable rather than
repeatedly fetching the length from a tvbuff.
Use -1 rather than tvb_length_remaining() when putting a "to the end of
the tvbuff" item into the protocol tree.
Use "proto_tree_add_item()" to put items into the tree, rather than
"proto_tree_add_xxx" calls with a "tvb_get_yyy" call as the argument.
If we've fetched a value into a variable, don't re-fetch it in
"proto_tree_add_xxx" calls.
svn path=/trunk/; revision=12971
|
|
can register an OUI, and PIDs for that OUI, in the same fashion that
they can do so for SNAP (after which the 802a OUI Extended Ethertype is
clearly modeled).
svn path=/trunk/; revision=12967
|
|
thus null.
svn path=/trunk/; revision=12966
|
|
"tvb_get_string()" wasn't freed. (It appears there can also be leaks if
an exception is thrown while dissecting.)
svn path=/trunk/; revision=12965
|
|
characters.
Clean up indentation.
svn path=/trunk/; revision=12964
|
|
we're not going to use them, and free them when we're done with them.
Clean up white space.
svn path=/trunk/; revision=12963
|
|
we're done with them.
svn path=/trunk/; revision=12962
|
|
we're done with them.
svn path=/trunk/; revision=12961
|
|
Don't assign the result of a routine that mallocates data to a const
pointer - that forces us to cast the pointer when freeing the data.
svn path=/trunk/; revision=12960
|
|
protocol tree.
svn path=/trunk/; revision=12959
|
|
svn path=/trunk/; revision=12956
|
|
don't leak it (even if we throw an exception processing the image).
svn path=/trunk/; revision=12955
|
|
tvb_get_string().
svn path=/trunk/; revision=12954
|
|
Also, move up the freeing of the tag string to immediately after we're
done with it, so we don't leak it if we throw an exception getting the
value.
svn path=/trunk/; revision=12953
|