aboutsummaryrefslogtreecommitdiffstats
path: root/epan/dissectors
AgeCommit message (Collapse)AuthorFilesLines
2012-12-26Fix a bunch of warnings.Guy Harris141-1424/+1334
Cast away some implicit 64-bit-to-32-bit conversion errors due to use of sizeof. Cast away some implicit 64-bit-to-32-bit conversion errors due to use of strtol() and strtoul(). Change some data types to avoid those implicit conversion warnings. When assigning a constant to a float, make sure the constant isn't a double, by appending "f" to the constant. Constify a bunch of variables, parameters, and return values to eliminate warnings due to strings being given const qualifiers. Cast away those warnings in some cases where an API we don't control forces us to do so. Enable a bunch of additional warnings by default. Note why at least some of the other warnings aren't enabled. randpkt.c and text2pcap.c are used to build programs, so they don't need to be in EXTRA_DIST. If the user specifies --enable-warnings-as-errors, add -Werror *even if the user specified --enable-extra-gcc-flags; assume they know what they're doing and are willing to have the compile fail due to the extra GCC warnings being treated as errors. svn path=/trunk/; revision=46748
2012-12-25bssmap_msg_fcn[] is a dense array, not a sparse array, so *every* entryGuy Harris1-6/+7
must be filled in - even if we don't happen to have dissectors for particular message types. Just put NULL in there, so we don't index past the end of the array, grab a random location in memory's contents as a function pointer, and crash when we call through that pointer. svn path=/trunk/; revision=46747
2012-12-25More checks to make sure pinfo->private_data is not null.Guy Harris1-68/+71
svn path=/trunk/; revision=46746
2012-12-25Add some additional sanity checks.Guy Harris2-0/+8
svn path=/trunk/; revision=46745
2012-12-25In dissect_bthci_evt_command_complete():Guy Harris1-42/+45
Make a loop counter a full-width integer, just to be sure. Do *NOT* assume that pinfo->private_data is non-null; I have at least one capture where it is null when dissect_bthci_evt_command_complete() is captured. svn path=/trunk/; revision=46743
2012-12-25set the dtls record length for reassembly _before_ adding a fragmentMartin Kaiser1-2/+2
this is a workaround for https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=8111 it does not fully fix the underlying issue svn path=/trunk/; revision=46739
2012-12-25If there's no packet data, there's nothing to check to see whether thisGuy Harris1-3/+12
is an MPEG-2 transport packet, so don't treat it as one. svn path=/trunk/; revision=46733
2012-12-25Show the Vines Fragmentation Protocol control flags field as bitflags,Guy Harris1-37/+66
rather than as a single field. If bits other than the two defined bits are set in the first byte of the packet, don't dissect UDP packets as Vines FRP, so that other dissectors get a chance to look at the packet. svn path=/trunk/; revision=46732
2012-12-23From report of Elavarasan via ↵Alexis La Goutte1-23/+155
https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=8099 Named field for each item in Selected Registrar Config methods is not available The structure of both the Config Methods and Selected Registrar Config Methods are the same. Display filters such as "wps.config_methods.pushbutton", "wps.config_methods.display", etc are available for the different methods in the Config methods whereas the display filters for the elements in the Selected Registrar Config methods are found to be the same as the Config method Display filters. From me : add new filter for selected_registrar config method bitmask (and also permitted config method) svn path=/trunk/; revision=46725
2012-12-23From Francesco Fondelli via ↵Alexis La Goutte1-7/+68
https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=8128 Add TCP Fast Open This patch provides i) support for Shared Use of Experimental TCP Options (draft-ietf-tcpm-experimental-options-03) ii) support for TCP Fast Open (draft-ietf-tcpm-fastopen-02). A new 'TFO=R' string is appended at the column info in case a client sends a SYN packet with a Fast Open Cookie Request. Moreover, if the server responds with a SYN-ACK containing a Fast Open Cookie option a 'TFO=C' is shown (as well as in any subsequent client attempt to send SYN + DATA). tcp.options.tfo display filter can be used in order to easily select the complete TFO three-way handshake. Chrome (and I think also Firefox) has support for client-side TFO. Linux 3.7 got both client and server-side support. svn path=/trunk/; revision=46723
2012-12-23In nlsp_dissect_clvs(), count len down at the same time we increment theGuy Harris1-5/+5
offset, and do the bounds checking on the length before we count len down. svn path=/trunk/; revision=46718
2012-12-22revert r46678Martin Kaiser1-2/+1
now that tvb_get_ephemeral_unicode_string() throws an exception for invalid length parameters, there's no point in doing an explicit check beforehand (when I added the check, there were many places that I missed) svn path=/trunk/; revision=46707
2012-12-22Fox copy-and-paste error.Michael Tüxen1-2/+2
svn path=/trunk/; revision=46701
2012-12-22Add support for displaying the Packet Block Flags Word of pcapng.Michael Tüxen1-1/+144
svn path=/trunk/; revision=46698
2012-12-22From G.Gerrits:Jaap Keuter1-2/+3
Minor patch just adding the newer AR7400/INT7400 with dev_id==4 for decoding in the Homeplug AV "Get Device/SW Version Confirm (A001)" response. svn path=/trunk/; revision=46695
2012-12-21Get rid of unnecessary initialization that causes "discards qualifiers"Guy Harris1-1/+1
warnings. svn path=/trunk/; revision=46688
2012-12-21Fix GSM 7-bit default alphabet decoding in ANSI IS-637-APascal Quantin1-111/+27
svn path=/trunk/; revision=46687
2012-12-21Include packet-gsm_sms.h and remove extern declarationsPascal Quantin1-11/+3
svn path=/trunk/; revision=46686
2012-12-21Use TVB_SET_ADDRESS_HF() and COPY_ADDRESS_SHALLOW() instead of tvb_get_ptr()Jeff Morriss1-85/+74
and a couple of SET_ADDRESS()s. Use proto_tree_add_item() instead of proto_tree_add_ether() called with a pointer into the TVB. Leave a comment for a place where a bunch of code in several case statements could probably be collapsed into much less code. svn path=/trunk/; revision=46682
2012-12-21Use TVB_SET_ADDRESS() and COPY_ADDRESS_SHALLOW() instead of tvb_get_ptr()Jeff Morriss1-29/+12
and a couple of SET_ADDRESS()s. svn path=/trunk/; revision=46681
2012-12-21fix https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=8112Martin Kaiser1-1/+2
by adding a range to the length that is passed to tvb_get_ephemeral_unicode_string() svn path=/trunk/; revision=46678
2012-12-21The KRB_RM_ #defines fit in 32 bits, so just make them unsigned, notGuy Harris1-4/+2
long. dissect_krb5_Checksum() is declared in epan/dissectors/packet-kerberos.h; don't declare it again here. svn path=/trunk/; revision=46666
2012-12-21Check whether something's too big before subtracting it from anotherGuy Harris1-5/+5
variable. Adjust offset and len in parallel. svn path=/trunk/; revision=46665
2012-12-21Squelch a qualifier-discard warning.Guy Harris1-1/+1
svn path=/trunk/; revision=46664
2012-12-21Well, at least on my machine, packet-pres.c now compiles cleanly, withGuy Harris1-1/+1
the recent changes to pres.cnf to keep from generating some code. svn path=/trunk/; revision=46663
2012-12-21Get rid of unused routines for UDC-type.Guy Harris1-18/+0
svn path=/trunk/; revision=46662
2012-12-21Don't assume a pointer fits inside an unsigned long - it doesn't, inGuy Harris1-11/+11
LLP64 environments such as Windows. Cast the result of a modulus op that causes the result to fit into an int to int, to suppress implicit 64-bit-to-32-bit conversion warnings. svn path=/trunk/; revision=46661
2012-12-21Get rid of duplicate declarations (so that -Wredundant-decls doesn'tGuy Harris1-2/+0
complain). svn path=/trunk/; revision=46660
2012-12-21Everything else in the floating-point calculations is single-precision,Guy Harris1-3/+3
so make the constants single-precision, so we don't end up with warnings about double-precision values being assigned to single-precision variables. svn path=/trunk/; revision=46658
2012-12-21Make some loop counters unsigned, so that we handle very large loopGuy Harris1-23/+19
counts by trying to iterate all over the items (and, presumably, failing when we go past the end of the packet). When assigning to the loop count, cast the value down, to avoid implicit 64-bit-to-32-bit conversion warnings. Write those loops as for loops - it makes it a bit clearer what's going on. svn path=/trunk/; revision=46657
2012-12-21Constify some character pointer variables to avoid warnings aboutGuy Harris3-7/+7
strings being assigned to them. svn path=/trunk/; revision=46653
2012-12-20Fix https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=8095 :Pascal Quantin1-4/+1
Fix dissection of GPRS-NS over Frame Relay over MPLS svn path=/trunk/; revision=46644
2012-12-20Revert r46595Pascal Quantin2-87/+2
svn path=/trunk/; revision=46643
2012-12-20Try to determine wether it is MEAS REP, EXT MEAS REP or ENH MEAS REP.Anders Broman1-2/+9
svn path=/trunk/; revision=46630
2012-12-18When copying addresses, also copy the (new) hf field.Jeff Morriss4-254/+225
Use SET_ADDRESS in some dissectors that weren't using it (so that the hf field is correctly initialized). Introduce a COPY_ADDRESS_SHALLOW (which copies an address without copying the contents of the data field). svn path=/trunk/; revision=46602
2012-12-18Don't do proto_tree_add_ether(..., tvb_get_ptr(...)), just use ↵Jeff Morriss1-10/+5
proto_tree_add_item(). svn path=/trunk/; revision=46598
2012-12-18From J. Bruce Fields via ↵Pascal Quantin1-6/+75
https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=8103 : Add parsing of free_stateid, why_no_delegation, backchannel_ctl, secinfo_no_name and destroy_session fields to NFSv4.1 dissector svn path=/trunk/; revision=46596
2012-12-18Fix https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=8095 :Pascal Quantin2-2/+87
Add dissection of GPRS-NS protocol inside MPLS svn path=/trunk/; revision=46595
2012-12-18SCSI: PERSISTENT_RESERVE_IN add names for service action 2/3 report ↵Ronnie Sahlberg1-1/+5
capabilities/read full status svn path=/trunk/; revision=46584
2012-12-18Use pinfo-scoped memory for 6LoWPAN addresses.Evan Huus1-2/+3
Fixes at least part of https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=7885 svn path=/trunk/; revision=46582
2012-12-18Get rid of another tvb_get_ptr() abuse (just like r46577 but in a differentJeff Morriss1-5/+7
function). svn path=/trunk/; revision=46579
2012-12-18Fix the fuzz failure reported in ↵Jeff Morriss1-6/+7
https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=7945 (or at least the complaints from Valgrind; I couldn't reproduce the crash). What part of: ~~~ * If you're thinking of using tvb_get_ptr, STOP WHAT YOU ARE DOING * IMMEDIATELY. Go take a break. Consider that tvb_get_ptr hands you * a raw, unprotected pointer that you can easily use to create a * security vulnerability or otherwise crash Wireshark. Then consider * that you can probably find a function elsewhere in this file that * does exactly what you want in a much more safe and robust manner. ~~~ did someone not read? Use tvb_get_ephemeral_stringz() instead of adding (apparently not sufficiently checked!) offsets to the result of tvb_get_ptr() and assuming that the result is a) in bounds and b) a NULL-terminated string. svn path=/trunk/; revision=46577
2012-12-17Fix a copy and paste error.Martin Mathieson1-1/+1
svn path=/trunk/; revision=46573
2012-12-16From Robert Bullen via ↵Pascal Quantin2-19/+55
https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=8092 : Add SSL segment data and SSL reassmebled data fields and improve readability of the hex/ASCII data blocks written to the SSL debug log svn path=/trunk/; revision=46572
2012-12-16Followup to r46565 and r46568: don't even create the composite TVB if we'reJeff Morriss1-4/+6
not going to put anything into it. And don't try to finalize the composite if we didn't create it or put anything in it. svn path=/trunk/; revision=46569
2012-12-16Apply r46565 to another spot.Jeff Morriss1-1/+2
svn path=/trunk/; revision=46568
2012-12-16Another part of the fix for ↵Jeff Morriss1-1/+2
https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=8097 : Don't try to add a zero-length TVB to a composite TVB. svn path=/trunk/; revision=46565
2012-12-16From Richard Sharpe via ↵Alexis La Goutte1-36/+30
https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=8074 SMB2 file_info_0f is actually FileFullEaInformation [MS-FSCC].pdf section 2.4.15 gives us the correct format of the structure currently know and file_info_0f. The unknown byte is actually the second byte of the EA Value Len. svn path=/trunk/; revision=46562
2012-12-16From Simon Barber via ↵Alexis La Goutte1-0/+8
https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=8094 Add support for RA and TA to all 802.11 frame formats svn path=/trunk/; revision=46561
2012-12-16Remove unused ett_nfs_security_label variableAlexis La Goutte1-3/+1
svn path=/trunk/; revision=46560
generated by cgit v1.2.3 (git 2.25.1) at 2024-07-05 05:21:30 +0000