aboutsummaryrefslogtreecommitdiffstats
path: root/epan/dissectors
AgeCommit message (Collapse)AuthorFilesLines
2013-04-23Add a quick check for a first printable character to avoid a more expensiveMartin Mathieson1-0/+11
check of the whole first line. This gets called a lot as a heuristic dissector. svn path=/trunk/; revision=49006
2013-04-23Turn some preferences on by default. Won't affect info column.Martin Mathieson1-3/+3
svn path=/trunk/; revision=49005
2013-04-23oops, missed a linebreakMartin Kaiser1-1/+2
svn path=/trunk/; revision=49003
2013-04-23From Mathias GuettlerMartin Kaiser3-0/+1593
dissector for ISO 10747 Inter Domain Routing Protocol https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=8562 from me: check for negative return value of tvb_reported_length_remaining() remove unused hf entries add modelines don't initialise variables unless it's necessary make idrp a new-style dissector svn path=/trunk/; revision=49002
2013-04-23reformat, add editor modelinesMartin Kaiser1-566/+579
svn path=/trunk/; revision=48998
2013-04-23Add curr_layer_num which can be used to keep track of multiple occurances of ↵Anders Broman1-0/+1
the same protocol in a frame. svn path=/trunk/; revision=48997
2013-04-23Restore a lost hf def.Anders Broman1-0/+5
svn path=/trunk/; revision=48995
2013-04-23When calling IP and Ipv6 dissectors, they may reduce the new tvb we pass in.Martin Mathieson1-0/+6
MPLS needs to similarly shrink its own tvb so its caller can tell that there were bytes left over (e.g. ethernet trailer). svn path=/trunk/; revision=48994
2013-04-22Fix some Dead Store (Dead assignement/Dead increment) Warning found by ClangAlexis La Goutte1-1/+1
svn path=/trunk/; revision=48988
2013-04-22Fix some Dead Store (Dead assignement/Dead increment) Warning found by ClangAlexis La Goutte1-1/+1
svn path=/trunk/; revision=48987
2013-04-22Fix some Dead Store (Dead assignement/Dead increment) Warning found by ClangAlexis La Goutte1-1/+1
svn path=/trunk/; revision=48986
2013-04-22Fix some Dead Store (Dead assignement/Dead increment) Warning found by ClangAlexis La Goutte1-1/+0
svn path=/trunk/; revision=48985
2013-04-22Fix some Dead Store (Dead assignement/Dead increment) Warning found by ClangAlexis La Goutte1-1/+0
svn path=/trunk/; revision=48984
2013-04-22Fix some Dead Store (Dead assignement/Dead increment) Warning found by ClangAlexis La Goutte1-1/+0
svn path=/trunk/; revision=48982
2013-04-22Dissect new element in GTPv2 MM Context.Anders Broman1-7/+29
svn path=/trunk/; revision=48977
2013-04-22Fix warning: 'attr_mask_offset' may be used uninitialized in this function ↵Alexis La Goutte1-1/+1
in Mac OS X svn path=/trunk/; revision=48975
2013-04-22From Cal Turney via https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=8601 ↵Alexis La Goutte1-736/+345
NFSv4 attribute and READDIR modifications * "dissect_nfs4_attribute()" was eliminated because the values dissection portion of that routine was identical to the "dissect_nfs_attributes()" routine. The code in "dissect_nfs4_bitmap4()" and "dissect_nfs4_attrlist4()" was also similar so those routines were also eliminated and their code incorporated in dissect_nfs_fattr4s(). These measures have reduced the size of 'packet-nfs.c' by almost 400 lines. * Attributes were relabeled according to RFC 5661 (NFS4v1). o “mand_attr” (REQUIRED attribute) header was changed to "reqd_attr”. o “recc_attr” (RECOMMENDED attributes) header was changed to “reco_attr” because "recommended" only has one ‘c’. =) * In order to be able to list the attribute names horizontally in the "Attr mask[x]" header (e.g., "Attr mask[0]: 0x0010111a (TYPE, CHANGE, SIZE, FSID, ACL, FILEID)", “FATTR4_” was removed from the attribute names (e.g., “FATTR4_TYPE (1)” is now “TYPE (1)”. Note that RFC 5661 does not define them with a “FATTR4” prefix. * In GETATTR responses, the “resok4” and “obj_attributes” subtrees were eliminated because they are neither actual fields nor serve any practical purpose. * The READDIR "Directory Listing" subtree was reformatted. "Filename" was changed to "Entry" because entries can also be directories. "Value Follows", "cookie", and "Attr mask[n]" were moved within each entry. If an Entry header is left-clicked all the fields of that entry are highlighted in the Hex pane. If it is right-clicked the 'nfs.name' field (filter) can be obtained. Finally, the "attr_vals:<DATA>" (text) subtree was eliminated because it appears to serve no useful purpose and clutters the tree. svn path=/trunk/; revision=48966
2013-04-22Fix encoding args (via fix-encodings-args tools) Add Modelines infoAlexis La Goutte1-19/+31
svn path=/trunk/; revision=48965
2013-04-22Add dissection of Aruba Networks Vendor Specific stuff. With ArubaOS 6.2, ↵Alexis La Goutte1-0/+61
there is a option to add AP Name in Beacon frame. svn path=/trunk/; revision=48963
2013-04-22Don't report duplicate use of IP address twice when dissecting aMartin Mathieson1-1/+2
gratuitous ARP request. svn path=/trunk/; revision=48962
2013-04-22Improve AUTH handling (NTLM and elementary PLAIN mechanism)Michael Mann1-3/+162
from Uli Heilmeier, bug 8600 (https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=8600) svn path=/trunk/; revision=48961
2013-04-21General cleanup.Michael Mann1-723/+597
Converted to proto_tree_add_text to proto_tree_add_item/expert_info Allow columns/tree/(sub)dissectors/expert_info to be called at all of the proper times. COL_INFO data still seems a bit verbose when errors occur, but I left it alone, just cleaning up the sequence of events. Removed some structure definitions where the variables that used them were effectively "useless" once proto_tree_add_item was added (although they weren't that useful before that) svn path=/trunk/; revision=48958
2013-04-21Dissect more TLV objectsPascal Quantin1-5/+82
svn path=/trunk/; revision=48956
2013-04-21In tcp_dissect_pdus(), don't put the PDU length into the protocol treeGuy Harris1-29/+28
unless we're going to hand a packet to the PDU subdissector. svn path=/trunk/; revision=48955
2013-04-21Update a comment.Guy Harris1-1/+1
svn path=/trunk/; revision=48954
2013-04-21Fix new gcc 4.8 warning:Jörg Mayer1-3/+3
[ 6%] Building C object epan/CMakeFiles/epan.dir/dissectors/packet-pw-fr.c.o /home/jmayer/work/wireshark/svn/trunk/epan/dissectors/packet-pw-fr.c: In function ‘dissect_pw_fr’: /home/jmayer/work/wireshark/svn/trunk/epan/dissectors/packet-pw-fr.c:81:4: error: typedef ‘packet_quality_e’ locally defined but not used [-Werror=unused-local-typedefs] } packet_quality_e; ^ svn path=/trunk/; revision=48948
2013-04-21Fix new warning in gcc 4.8:Jörg Mayer1-4/+4
[ 5%] Building C object epan/CMakeFiles/epan.dir/dissectors/packet-dcerpc-rs_pgo.c.o /home/jmayer/work/wireshark/svn/trunk/epan/dissectors/packet-dcerpc-rs_pgo.c: In function ‘dissect_rs_pgo_query_t’: /home/jmayer/work/wireshark/svn/trunk/epan/dissectors/packet-dcerpc-rs_pgo.c:631:5: error: typedef ‘rs_pgo_query_t’ locally defined but not used [-Werror=unused-local-typedefs] } rs_pgo_query_t; ^ /home/jmayer/work/wireshark/svn/trunk/epan/dissectors/packet-dcerpc-rs_pgo.c: In function ‘dissect_rs_pgo_query_key_t’: /home/jmayer/work/wireshark/svn/trunk/epan/dissectors/packet-dcerpc-rs_pgo.c:845:5: error: typedef ‘rs_pgo_query_t’ locally defined but not used [-Werror=unused-local-typedefs] } rs_pgo_query_t; ^ cc1: all warnings being treated as errors make[2]: *** [epan/CMakeFiles/epan.dir/dissectors/packet-dcerpc-rs_pgo.c.o] Error 1 [ 5%] Building C object epan/CMakeFiles/epan.dir/dissectors/packet-pw-fr.c.o /home/jmayer/work/wireshark/svn/trunk/epan/dissectors/packet-pw-fr.c: In function ‘dissect_pw_fr’: /home/jmayer/work/wireshark/svn/trunk/epan/dissectors/packet-pw-fr.c:81:4: error: typedef ‘packet_quality_e’ locally defined but not used [-Werror=unused-local-typedefs] } packet_quality_e; ^ svn path=/trunk/; revision=48947
2013-04-20Initialize branch_taken right at the top of dissect_ber_choice so that theEvan Huus1-3/+4
caller can depend on it being initialized even in peculiar error conditions. Fixes the other half of https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=8599 svn path=/trunk/; revision=48944
2013-04-20Remove expert info for bit AD in DNS queryAlexis La Goutte1-3/+1
See Section 5.7 (Setting the AD Bit on Queries) of RFC 6840 (Clarifications and Implementation Notes for DNS Security (DNSSEC)) The semantics of the Authentic Data (AD) bit in the query were previously undefined. Section 4.6 of [RFC4035] instructed resolvers to always clear the AD bit when composing queries. This document defines setting the AD bit in a query as a signal indicating that the requester understands and is interested in the value of the AD bit in the response. This allows a requester to indicate that it understands the AD bit without also requesting DNSSEC data via the DO bit. svn path=/trunk/; revision=48942
2013-04-20Enhance BT-DHT Dissector * Use proto_tree_add_item * Enhance display list ↵Alexis La Goutte1-45/+39
(nodes, peers...) * Remove ununeed space * ... svn path=/trunk/; revision=48941
2013-04-20When we're dissecting the beginning of a fragmented packet that weGuy Harris1-4/+8
haven't reassembled, we're probably moving sequentially through the packet, which means that we'll run past the end of the fragment rather than past the end of what would have been the reassembled packet had we reassembled it. I.e., there's little reason to care whether we're past the end of the fragment but not past the end of the packet, or whether we're past the end of the packet; in either case, we're past the end of the fragment, and if somebody wants to know whether the packet is malformed by stopping short of certain fields, they should enable reassembly. So we get rid of the explicit fragment length in tvbuffs and, instead, have a "this is a fragment" flag; if that flag is set, we throw FragmentBoundsError rather than ReportedBoundsError if we run past the end of the reported data. (This also means we could flag the tvbuff even if we don't know how large the reassembled packet will be, e.g. when doing IP reassembly.) Replace tvb_new_subset_length_fragment() with tvb_new_subset_length() and a new "set the "this is a fragment flag"" routine. svn path=/trunk/; revision=48940
2013-04-19Remove duplicate hf array entry.Evan Huus1-5/+0
svn path=/trunk/; revision=48936
2013-04-19s/mfs/nfs/Evan Huus1-4/+4
svn path=/trunk/; revision=48935
2013-04-19From Cal Turney via https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=8581Evan Huus7-3369/+3501
Major NFS dissector cleanup. Consistent naming, spacing, line wrapping, variable initialization, ... For full details see comment #18 of the bug. svn path=/trunk/; revision=48934
2013-04-19Slightly improve heuristics to not interpret a zero-filled trailerJörg Mayer1-0/+6
as vss data. svn path=/trunk/; revision=48933
2013-04-19Fix apparent copy-paste error leading to a 'used-uninitialized' warning.Evan Huus1-1/+1
svn path=/trunk/; revision=48929
2013-04-19Fix GTPv2 MM Context (UMTS Key, Quad, and Quint Decoded) incorrectlyAnders Broman1-16/+7
https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=8596 svn path=/trunk/; revision=48928
2013-04-19Add dissection of QoS blob.Anders Broman1-6/+169
svn path=/trunk/; revision=48927
2013-04-19Don't use ENC_NA for integer fields longer than 1 byte; useGuy Harris1-11/+11
ENC_BIG_ENDIAN or ENC_LITTLE_ENDIAN. Treat the AP PS Buffer State subfield of the QoS field the same way we treat other subfields in the second byte of the QoS field - show it as the upper 8 bits of the (shown as big-endian) QoS field. Fix a bitmap while we're at it. Show the channel map as an FT_NONE - it's a structure with two bytes. svn path=/trunk/; revision=48924
2013-04-19Small cosmetic fixes to CCX decodingJörg Mayer1-10/+18
svn path=/trunk/; revision=48923
2013-04-19Note that Query Server was reserved.Guy Harris1-1/+1
svn path=/trunk/; revision=48922
2013-04-19Add some names for reserved-but-never-implemented operations, withGuy Harris1-2/+31
references for them. svn path=/trunk/; revision=48921
2013-04-19convert proto_tree_add_text "items" to proto_tree_add_item.Michael Mann1-256/+298
svn path=/trunk/; revision=48920
2013-04-18Add overflow check to fixEvan Huus1-0/+19
https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=8464 Also add modelines. svn path=/trunk/; revision=48919
2013-04-18Fix apparent copy-paste-o that was leading to an 'unused variable' warning onEvan Huus1-1/+1
bleeding-edge GCC. svn path=/trunk/; revision=48918
2013-04-18Add to tvbuffs a "fragment length" field; if the tvbuff represents theGuy Harris1-48/+133
first fragment of a non-reassembled packet, and we know the length the packet would have if it were reassembled, this field holds the length of the fragment, and the "reported length" field shows the length the packet would have if it were reassembled, so going past the end of the fragment but staying within the length of the reassembled packet can be reported as "dissection would have worked if the packet had been reassembled" rather than "the packet is too short, so it was probably malformed". Add a FragmentBoundsError exception, thrown in the "dissection would have worked if the packet had been reassembled" case. Add a new tvb_new_subset_length_fragment() routine to create a new subset tvb with specified fragment and reported lengths. Use it in the CLNP dissector. Add some more sanity checks in the CLNP dissector. svn path=/trunk/; revision=48917
2013-04-18Report bogus handshake length values with expert info. This includesGuy Harris1-45/+88
trying to handle reassembly of packets with *differing* handshake length values a bit better. Make coding style a little more consistent. svn path=/trunk/; revision=48916
2013-04-18Catch retransmission of FINs, so if we're doing "reassemble until end ofGuy Harris1-15/+18
data stream", only the first FIN segment is reported with the reassembled packet. Show the TCP fragment tree *before* processing the payload, so it's shown even if processing the payload throws an exception. svn path=/trunk/; revision=48915
2013-04-18Catch retransmission of FINs, so if we're doing "reassemble until end ofGuy Harris1-28/+48
data stream", only the first FIN segment is reported with the reassembled packet. Show the TCP fragment tree *before* processing the payload, so it's shown even if processing the payload throws an exception. svn path=/trunk/; revision=48914
2013-04-18Let proto_tree_add_item() do the length checking for string lengths, soGuy Harris1-64/+51
we thrown an exception if the lengths are too long. For UCS-2/UTF-16 strings, do an extra length check to avoid overflows, but throw ReportedBoundsError if the check fails, so we report them the same way we report other too-large length errors. Just use proto_tree_add_item() to put UCS-2/UTF-16 strings (assumed to be UTF-16, not UCS-2; is that correct?) into the protocol tree. svn path=/trunk/; revision=48913
generated by cgit v1.2.3 (git 2.25.1) at 2024-07-06 13:56:23 +0000