aboutsummaryrefslogtreecommitdiffstats
path: root/epan/dissectors
AgeCommit message (Collapse)AuthorFilesLines
2015-01-02Add '*.nativecodeanalysis.xml' to 'clean' targetsBill Meier1-1/+1
Change-Id: I90dbf0b31fc737150a01533763a7869b34c68cb6 Reviewed-on: https://code.wireshark.org/review/6220 Reviewed-by: Bill Meier <wmeier@newsguy.com>
2015-01-02tshark: Add endpoints statisticsMichael Mann16-28/+16
"stat name" has been official changed to "endpoints" for all dissectors, rather than a mixture of "host"/"endpoints" based on dissector. Change-Id: If34bcb5165b493948e784ba038ab202803a59843 Reviewed-on: https://code.wireshark.org/review/6154 Reviewed-by: Pascal Quantin <pascal.quantin@gmail.com> Reviewed-by: Michael Mann <mmann78@netscape.net> Petri-Dish: Michael Mann <mmann78@netscape.net> Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org> Reviewed-by: Anders Broman <a.broman58@gmail.com>
2015-01-02Remove pkt_comment member from packet_info structure.Michael Mann2-18/+26
Change-Id: Ifd3d201a09944e3fc36188f891ea8a584886101d Reviewed-on: https://code.wireshark.org/review/5884 Reviewed-by: Pascal Quantin <pascal.quantin@gmail.com> Petri-Dish: Pascal Quantin <pascal.quantin@gmail.com> Reviewed-by: Anders Broman <a.broman58@gmail.com>
2015-01-01Fix tpyo.Guy Harris1-10/+10
Change-Id: I5b190ee35086664ed053d376def4e21ab9ad9236 Reviewed-on: https://code.wireshark.org/review/6213 Reviewed-by: Guy Harris <guy@alum.mit.edu>
2015-01-01More indentation cleanups.Guy Harris1-34/+34
Change-Id: I6d21bda89f8032d302620e21ac393dc345165ac7 Reviewed-on: https://code.wireshark.org/review/6212 Reviewed-by: Guy Harris <guy@alum.mit.edu>
2015-01-01Clean up indentation.Guy Harris1-7/+7
Change-Id: I5aa6cafc6249b3a820b1bbf2eddc2ec1fdc88685 Reviewed-on: https://code.wireshark.org/review/6211 Reviewed-by: Guy Harris <guy@alum.mit.edu>
2015-01-01Declare read_keytab_file() in epan/dissectors/packet-kerberos.h.Guy Harris2-7/+7
Don't throw its declaration in file.h, as it's not defined in file.c. Instead, include it in epan/dissectors/packet-kerberos.h and include that wherever read_keytab_file() is called. Yes, that means you also have to include <epan/asn1.h> and, therefore, you have to include <epan/packet.h>. Yes, that should be cleaned up, perhaps by splitting the Kerberos support code into "stuff that handles encryption keys without any reference to dissection" and "stuff that does dissection-related work". Change-Id: Ide5c31e6d85e6011d57202f728dbc656e36138ef Reviewed-on: https://code.wireshark.org/review/6210 Reviewed-by: Guy Harris <guy@alum.mit.edu>
2015-01-01Let routines from the Kerberos dissector be called from C++.Guy Harris1-3/+9
Wrap its declarations in the usual "extern "C"" stuff. Change-Id: I353ab334bc08a69fdacaaab5672edf758b14766a Reviewed-on: https://code.wireshark.org/review/6201 Reviewed-by: Guy Harris <guy@alum.mit.edu>
2015-01-01Added DNP3 support for g13 and g43, output command eventsGraham Bloice1-9/+117
Bug: 10347 Change-Id: Ic173f31d8cf3fd002454f4c22b85c19bae42d544 Reviewed-on: https://code.wireshark.org/review/6175 Reviewed-by: Graham Bloice <graham.bloice@trihedral.com> Petri-Dish: Graham Bloice <graham.bloice@trihedral.com> Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org> Reviewed-by: Anders Broman <a.broman58@gmail.com>
2014-12-31rtse.cnf: fix Nesting level does not match indendation (CID 1159214)Alexis La Goutte1-9/+10
Change-Id: I86e6c9103990bedf93c323e1360394a7c0a39db4 Reviewed-on: https://code.wireshark.org/review/6173 Reviewed-by: Michael Mann <mmann78@netscape.net> Reviewed-by: Anders Broman <a.broman58@gmail.com>
2014-12-31Zbee ZDP: fix Copy-paste error (CID 1158598)Alexis La Goutte1-1/+1
Change-Id: If98d391f51c9d2aa31b1a3a93b774d91d364cccc Reviewed-on: https://code.wireshark.org/review/6163 Reviewed-by: Anders Broman <a.broman58@gmail.com>
2014-12-31GTPv2: fix Copy-paste error (CID 1158587)Alexis La Goutte1-3/+2
Change-Id: I56eaa2071b4b8042c214cf882d35ebec646d2cb5 Reviewed-on: https://code.wireshark.org/review/6169 Reviewed-by: Alexis La Goutte <alexis.lagoutte@gmail.com> Reviewed-by: Anders Broman <a.broman58@gmail.com>
2014-12-31umts_fp: Replace se_new0(...) by wmem_new0(wmem_file_scope(), ...)Bill Meier1-1/+1
Change-Id: I9d40ffd199147fb8b975c493253d5cf796be5983 Reviewed-on: https://code.wireshark.org/review/6179 Reviewed-by: Bill Meier <wmeier@newsguy.com>
2014-12-31GTP: fix Copy-paste error (CID 1158594 & 1158595)Alexis La Goutte1-2/+2
Change-Id: I501c0d666c7b280656e2d7cf7a196d489d452eff Reviewed-on: https://code.wireshark.org/review/6166 Reviewed-by: Pascal Quantin <pascal.quantin@gmail.com>
2014-12-31SCTP: fix Nesting level does not match indendation (CID 1159213 & 1159215 )Alexis La Goutte1-2/+0
Change-Id: Icd04c5f1f09b9cf704828e4b6a598cd2c1f6dd15 Reviewed-on: https://code.wireshark.org/review/6172 Reviewed-by: Michael Mann <mmann78@netscape.net>
2014-12-31DHCPv6: fix Nesting level does not match indendation (CID 1159219)Alexis La Goutte1-1/+2
Change-Id: Id57a9f2df6a4011078b0bef359b2cd5503f6f7ce Reviewed-on: https://code.wireshark.org/review/6171 Reviewed-by: Michael Mann <mmann78@netscape.net>
2014-12-31GTPv2: fix typo in Anders e-mail AddressAlexis La Goutte1-1/+1
Change-Id: I2410aa7bce574c9153b971b2d8b0cbfbe24e54dc Reviewed-on: https://code.wireshark.org/review/6170 Reviewed-by: Anders Broman <a.broman58@gmail.com>
2014-12-31jxta: fix Copy-paste error (CID 1158599 & 1158600)Alexis La Goutte1-2/+2
Change-Id: Ica4ade2e7de70cefc4e77d421e35ddd72e688c16 Reviewed-on: https://code.wireshark.org/review/6165 Reviewed-by: Michael Mann <mmann78@netscape.net>
2014-12-31mount: fix Copy-paste error (CID 1224605)Alexis La Goutte1-5/+3
Don't longer need to check if(tree) Change-Id: I4ec572df28bad3c487c3c744840d97b79781feb3 Reviewed-on: https://code.wireshark.org/review/6164 Reviewed-by: Michael Mann <mmann78@netscape.net>
2014-12-31DNS: ensure that suffix_addr structure is always initializedPascal Quantin1-1/+1
Bug: 10816 Change-Id: Ifd036148f9f2e76516913bda11cf07fdb63def94 Reviewed-on: https://code.wireshark.org/review/6174 Reviewed-by: Pascal Quantin <pascal.quantin@gmail.com>
2014-12-31E.164: display country_code as decimal not hexLuke Mewburn1-366/+428
Display and filter e164.country_code and e164.identification_code as decimal instead of hexadecimal, as that is more natural. E.g. Use 'e164.country_code == 61' instead of 'e164.country_code == 0x61' to match Australia (+61...) If the country_code or identification_code contain BCD digits > 9 add an expert info warning. Required modifying the various prefix to description value_string arrays from hex to decimal constants, and converting the decoded BCD from hex to decimal before adding to the proto tree. Change-Id: Ibedfc75246fe409b7d63776083379bb028fb784b Reviewed-on: https://code.wireshark.org/review/6054 Petri-Dish: Pascal Quantin <pascal.quantin@gmail.com> Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org> Reviewed-by: Pascal Quantin <pascal.quantin@gmail.com>
2014-12-31BGP : Simple typo fix for BGP AttributeEbben Aries1-1/+1
Change-Id: I793eed5c7d63c82e13847c8a6c8fd6def3025b8c Reviewed-on: https://code.wireshark.org/review/6158 Reviewed-by: Hadriel Kaplan <hadrielk@yahoo.com> Tested-by: Hadriel Kaplan <hadrielk@yahoo.com>
2014-12-30Test suite: Start testing our output for valid UTF-8.Gerald Combs3-99/+109
Feed the output of `tshark -G <glossary>` to `iconv -f UTF-8`. Adjust a couple of the Bluetooth dissectors and X11 keysyms accordingly. Change-Id: I5b04dc3fa4734c8f0a795daf44bd398fe5ebc1bd Reviewed-on: https://code.wireshark.org/review/6146 Petri-Dish: Gerald Combs <gerald@wireshark.org> Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org> Reviewed-by: Gerald Combs <gerald@wireshark.org>
2014-12-30free the temporary buffers allocated by gnutls_x509_privkey_export_rsa_raw()Martin Kaiser1-1/+5
Bug: 10740 Change-Id: Idd4afab1bca6204d17c4bd4345661ec821f209e0 Reviewed-on: https://code.wireshark.org/review/6145 Reviewed-by: Martin Kaiser <wireshark@kaiser.cx> Tested-by: Martin Kaiser <wireshark@kaiser.cx>
2014-12-30Websocket: use pinfo pool and not packet one for the unmasked data tvbPascal Quantin1-3/+3
As indicated in README.wmem, pinfo pool must be used for anything that might end up being passed to add_new_data_source Change-Id: I4a6396fc52e6c70c771390f502d58199c38c172a Reviewed-on: https://code.wireshark.org/review/6144 Reviewed-by: Pascal Quantin <pascal.quantin@gmail.com>
2014-12-30clean up the part where dissect_websocket() is called recursivelyMartin Kaiser1-2/+5
Change-Id: Ia94ddb2c4cb03fe5d1af9f8d316e1cdb18fe8283 Reviewed-on: https://code.wireshark.org/review/6143 Reviewed-by: Martin Kaiser <wireshark@kaiser.cx> Tested-by: Martin Kaiser <wireshark@kaiser.cx>
2014-12-30use packet-scoped memory for the unmasked data tvbMartin Kaiser1-5/+2
Change-Id: I5f9b769e26c16072a1656dfe9094487d6dfe76f4 Reviewed-on: https://code.wireshark.org/review/6142 Reviewed-by: Martin Kaiser <wireshark@kaiser.cx> Tested-by: Martin Kaiser <wireshark@kaiser.cx>
2014-12-30skip the payload if it's emptyMartin Kaiser1-2/+4
Change-Id: Ib38e747bc762422c690abc1cb127bb0944c80ce2 Reviewed-on: https://code.wireshark.org/review/6141 Reviewed-by: Martin Kaiser <wireshark@kaiser.cx> Tested-by: Martin Kaiser <wireshark@kaiser.cx>
2014-12-30no need for if(tree)Martin Kaiser1-5/+3
Change-Id: I0b20b66e1b44da0362c13009946a69738a2aa267 Reviewed-on: https://code.wireshark.org/review/6138 Reviewed-by: Martin Kaiser <wireshark@kaiser.cx> Tested-by: Martin Kaiser <wireshark@kaiser.cx>
2014-12-29Add ability to follow UDP stream by indexPascal Quantin3-4/+16
-z "follow,udp" tshark cli command now supports a stream index It is now possible to select the UDP stream displayed in Qt GUI (like for TCP) Change-Id: Ia367f36ea4f60db0fddb997a7e0903c09e172f2d Reviewed-on: https://code.wireshark.org/review/6083 Reviewed-by: Pascal Quantin <pascal.quantin@gmail.com>
2014-12-29TN5250: Missing break in switch (CID 280477)Alexis La Goutte1-1/+3
fix also indent typo Change-Id: I47ff84a6062a203e14b9dde420a1a2efd5b05fab Reviewed-on: https://code.wireshark.org/review/6118 Reviewed-by: Michael Mann <mmann78@netscape.net>
2014-12-29rtsp: Fix (what I think may be) a minor bug.Bill Meier1-14/+15
(Also fixes a compiler 'Shadow' warning in a different way than the now reverted previous fix). Change-Id: Iedcac3d402b89d1b0261a49647bf39cc854d1a0c Reviewed-on: https://code.wireshark.org/review/6123 Reviewed-by: Bill Meier <wmeier@newsguy.com>
2014-12-29rtsp: Fix compiler 'Shadow' warning ...Bill Meier1-8/+8
Change-Id: I404546fc5eab82d7cb12971723040b4aa77f6a90 Reviewed-on: https://code.wireshark.org/review/6122 Reviewed-by: Bill Meier <wmeier@newsguy.com>
2014-12-29rtsp: Replace g_warning() by expert...() (dissectors shouldn't do termio).Bill Meier1-12/+36
Also: Add an expert...() in rtsp_create_conversation() for "Unknown transport type". Change-Id: I1d8ca20b9c0bc1e3d11b947b6653a2e2669a0f96 Reviewed-on: https://code.wireshark.org/review/6121 Reviewed-by: Bill Meier <wmeier@newsguy.com>
2014-12-29Zebra: Fix some indent typoAlexis La Goutte1-2/+2
Change-Id: I41869fe46e6867333d14f6f86953ff01e2d112a8 Reviewed-on: https://code.wireshark.org/review/6114 Reviewed-by: Michael Mann <mmann78@netscape.net>
2014-12-29OpenFlow: Capatilize O and F of OpenFlow (when use Decode as)Alexis La Goutte1-2/+2
Remove also a trailing whitespace in OpenFlow TCP port preference Change-Id: I5c3f42e634e0fee4fecf1a7f2dd1c75a68165b45 Reviewed-on: https://code.wireshark.org/review/6113 Reviewed-by: Michael Mann <mmann78@netscape.net>
2014-12-29dcerpc: Replace g_warning() by expert...() (dissectors shouldn't do termio).Bill Meier1-12/+20
Change-Id: If51a9acbb3b5a5b1623c72651c8a3ef2dd8ad068 Also: Replace (one of many) proto_tree_add_text() instances. Reviewed-on: https://code.wireshark.org/review/6117 Reviewed-by: Bill Meier <wmeier@newsguy.com>
2014-12-29Eliminate proto_tree_add_text from packet-spice.cMichael Mann1-237/+291
Also do some cleanup in dissect_spice() and replace g_warning calls. Change-Id: I4dc6f6496bb5ae54157aa6f7f27f21c396da623c Reviewed-on: https://code.wireshark.org/review/6106 Petri-Dish: Michael Mann <mmann78@netscape.net> Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org> Reviewed-by: Michael Mann <mmann78@netscape.net>
2014-12-28p_mul: Added checksum from ACP 142(A)Stig Bjørlykke1-10/+17
Bug: 10807 Change-Id: Ifd1ea5d67b65a7e7997458785fff95cc471e0dbc Reviewed-on: https://code.wireshark.org/review/6076 Petri-Dish: Stig Bjørlykke <stig@bjorlykke.org> Reviewed-by: Stig Bjørlykke <stig@bjorlykke.org> Tested-by: Stig Bjørlykke <stig@bjorlykke.org>
2014-12-28Create FT_FCWWN field type.Michael Mann10-273/+197
Also, convert the "string" hf_ entries that used tvb_fcwwn_to_str as a string to use proto_tree_add_item with FT_FCWWN type. Change-Id: I4ca77870499fd8239584a70874998b5d194a7167 Reviewed-on: https://code.wireshark.org/review/6036 Petri-Dish: Michael Mann <mmann78@netscape.net> Reviewed-by: Michael Mann <mmann78@netscape.net>
2014-12-28The symbol rate in the Cable Delivery System Descriptor is in Mega-Symbols/sMartin Kaiser1-1/+1
Change-Id: I1446500f1c5c89b8ed94c04b04bb6985ae827731 Reviewed-on: https://code.wireshark.org/review/6095 Reviewed-by: Martin Kaiser <wireshark@kaiser.cx> Tested-by: Martin Kaiser <wireshark@kaiser.cx>
2014-12-28Replace ip6_to_str and ip6_guint8_to_str with address_to_str and tvb_ip_to_str.Michael Mann24-175/+155
Change-Id: I1d258923a7a63539ec8456d3e306bca5016a1e4b Reviewed-on: https://code.wireshark.org/review/6060 Petri-Dish: Michael Mann <mmann78@netscape.net> Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org> Reviewed-by: Pascal Quantin <pascal.quantin@gmail.com> Reviewed-by: Michael Mann <mmann78@netscape.net>
2014-12-28Removed duplicated #include linesDario Lombardo4-4/+0
Change-Id: I9cafa3cd5c74121168777d8c656e7e94e89efd3c Reviewed-on: https://code.wireshark.org/review/6065 Petri-Dish: Pascal Quantin <pascal.quantin@gmail.com> Reviewed-by: Martin Mathieson <martin.r.mathieson@googlemail.com> Reviewed-by: Pascal Quantin <pascal.quantin@gmail.com>
2014-12-27Zebra dissector highlights wrong byte for version and is missing some fieldsHadriel Kaplan1-18/+145
Bug: 10809 Change-Id: I916d3ee0644570b689b35575e7277fc7d5ee3396 Reviewed-on: https://code.wireshark.org/review/6081 Petri-Dish: Hadriel Kaplan <hadrielk@yahoo.com> Reviewed-by: Michael Mann <mmann78@netscape.net> Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org> Reviewed-by: Hadriel Kaplan <hadrielk@yahoo.com> Tested-by: Hadriel Kaplan <hadrielk@yahoo.com>
2014-12-27OpenFlow: fix dissection of async_config_prop structurePascal Quantin1-10/+12
Bug: 10808 Change-Id: I5ef46cd6b85c415e23dfdbe7a56c8b332eaae5a3 Reviewed-on: https://code.wireshark.org/review/6078 Reviewed-by: Pascal Quantin <pascal.quantin@gmail.com> Petri-Dish: Pascal Quantin <pascal.quantin@gmail.com> Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org> Reviewed-by: Anders Broman <a.broman58@gmail.com>
2014-12-27SRVLOC: fix some fields registration (regression introduced in ga1c6341)Pascal Quantin1-2/+2
Change-Id: I318f4889b94021ece1e61ae080b77b1fb21eae7b Reviewed-on: https://code.wireshark.org/review/6077 Reviewed-by: Pascal Quantin <pascal.quantin@gmail.com>
2014-12-27Eliminate proto_tree_add_text from packet-srvloc.cMichael Mann1-91/+100
Change-Id: I73a2270e259414f21a695d2b279df5b3cac27bb8 Reviewed-on: https://code.wireshark.org/review/6067 Petri-Dish: Michael Mann <mmann78@netscape.net> Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org> Reviewed-by: Michael Mann <mmann78@netscape.net>
2014-12-27Declare cur_rt in the narrowest possible scope.Guy Harris1-1/+2
Change-Id: I0604d6f9f4bb2c58bb74a9b375f644474b68c28f Reviewed-on: https://code.wireshark.org/review/6074 Reviewed-by: Guy Harris <guy@alum.mit.edu>
2014-12-27IP: try to fix OSX 10.5 x86 compilationPascal Quantin1-5/+5
packet-ip.c: In function 'dissect_ip': packet-ip.c:2297: warning: 'cur_rt' may be used uninitialized in this function packet-ip.c:2297: note: 'cur_rt' was declared here Change-Id: I97fe33d2a01e982f057cce6d68f64378727be2da Reviewed-on: https://code.wireshark.org/review/6073 Petri-Dish: Pascal Quantin <pascal.quantin@gmail.com> Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org> Reviewed-by: Pascal Quantin <pascal.quantin@gmail.com>
2014-12-26UDP: fix 'Follow Stream' button from conversations tabPascal Quantin1-1/+1
Add stream index to conversation table Change-Id: Id63b2cc0000d89297c8638b9a89315096fc5458b Reviewed-on: https://code.wireshark.org/review/6062 Reviewed-by: Pascal Quantin <pascal.quantin@gmail.com>