aboutsummaryrefslogtreecommitdiffstats
path: root/epan/dissectors
AgeCommit message (Collapse)AuthorFilesLines
2014-03-04When dissecting GSM MAPv1/v2 messages, display opcode 44 or 46 as forwardSMPascal Quantin1-52/+56
Fixes bug 9829 Change-Id: Ib56bc7dc79ca27667fb89691817f6e568006d3a8 Reviewed-on: https://code.wireshark.org/review/494 Reviewed-by: Anders Broman <a.broman58@gmail.com>
2014-03-03Show ymsg.content as bytes; it's not a simple string.Guy Harris1-3/+3
The content of a YMSG message is a sequence of lines, each one of which contains a text string (in some ASCII-based encoding) for a key, a 0xc080 separator, and a text string (in some ASCII-based encoding) for a value. That's not a string in any ASCII-based encoding I know of - 0xc0 0x80 is not, for example, a valid UTF-8 sequence (it's a too-long sequence for NUL). This should fix bug 9832: https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=9832 by avoiding the general "GTK+ on Windows crashes when asked to copy something that's not valid UTF-8" problem. Fix some field descriptions while we're at it. Change-Id: I4084dabc89b0186ecd1a7329452ca2f1cb48f1c0 Reviewed-on: https://code.wireshark.org/review/488 Reviewed-by: Guy Harris <guy@alum.mit.edu>
2014-03-03Create/use extended value_strings; add editor modelines as needed.Bill Meier5-255/+336
Change-Id: I36ebee937ddd1c5ccbfa36f284a4794bc63631dc Reviewed-on: https://code.wireshark.org/review/482 Reviewed-by: Bill Meier <wmeier@newsguy.com> Tested-by: Bill Meier <wmeier@newsguy.com>
2014-03-03Move value_string defs from .h file; create/use extended value_string; Other ↵Bill Meier3-303/+324
minor changes. - Multiple value string arrays were defined in packet-fcels.h (which was included in two differnt .c files). Only one of the arrays was actually used in two different .c files. All the value_string arrays (and most of the #defines) moved to packet-fcels.c. - Other: Use -1 instead of tvb_length() for the length param of several proto_tree_add...() calls. Add editor modelines. Change-Id: Idc642caf1c8d62b658147a234d5560b8f2fd0630 Reviewed-on: https://code.wireshark.org/review/479 Reviewed-by: Bill Meier <wmeier@newsguy.com> Tested-by: Bill Meier <wmeier@newsguy.com>
2014-03-03Create/use an extended value-string; Move value-string array from .h file; ↵Bill Meier2-268/+283
Do other misc. - Value string arrrays should never be defined in a .h file (especially one included in multiple .c files). So: a. The value_string array (and associated #defines) was moved from the .h file to packet-rtp_events.c b. A public extended value_string was created in packet-rtp_events.c and declared as external in packet-rtp_events.h - Other: Remove a few unneeded initializers; Add editor modelines. Change-Id: Ib580c3e50ab5ce79484c9c6af57f62ca604b57d1 Reviewed-on: https://code.wireshark.org/review/468 Reviewed-by: Bill Meier <wmeier@newsguy.com> Tested-by: Bill Meier <wmeier@newsguy.com>
2014-03-03Create/use several extended value-strings; Do several other small changes.Bill Meier1-26/+40
- Move setting COL_PROTO & clearing COL_INFO to before a tvb fetch which could cause an exception; - Remove some unneeded initializers; - Fix up some long-lines and whitespace; - Use a consistent indentation; - Add editor modelines. Change-Id: I8a8015a65d5dc581ed02cbd134231481b9f96263 Reviewed-on: https://code.wireshark.org/review/467 Reviewed-by: Bill Meier <wmeier@newsguy.com> Tested-by: Bill Meier <wmeier@newsguy.com>
2014-03-03Create/use an extended value_string; Do other misc minor changes.Bill Meier1-235/+249
- Localize some vars; - Use a consisten 4-space indentation & whitespace style; - Add editor modelines; Change-Id: I0d6270eea3fae804788a56557d3c7e171afa8aaa Reviewed-on: https://code.wireshark.org/review/466 Reviewed-by: Bill Meier <wmeier@newsguy.com> Tested-by: Bill Meier <wmeier@newsguy.com>
2014-03-03SSL: dynamically allocate session ticket storage area to avoid buffer overflowPascal Quantin3-2/+5
Fixes bug 9825 Change-Id: I20ae65331ec11b2f6774054df4c026fd5fa76d3a Reviewed-on: https://code.wireshark.org/review/447 Reviewed-by: Pascal Quantin <pascal.quantin@gmail.com> Tested-by: Pascal Quantin <pascal.quantin@gmail.com>
2014-03-03show if the current service is scrambled or freeMartin Kaiser1-2/+13
Change-Id: I9e50920fbc09fdf0650be3a63fee8153ce0fd3df Reviewed-on: https://code.wireshark.org/review/462 Reviewed-by: Martin Kaiser <wireshark@kaiser.cx>
2014-03-03add cleartext values for retention limitMartin Kaiser1-4/+19
Change-Id: I8ecfdb1c366310d224660e89c99136a0a9f4a067 Reviewed-on: https://code.wireshark.org/review/461 Reviewed-by: Martin Kaiser <wireshark@kaiser.cx>
2014-03-03move URI dissection to a separate functionMartin Kaiser1-29/+49
Change-Id: Ia1db91ef9344e46a3f32204bbf9cdbcc514980ce Reviewed-on: https://code.wireshark.org/review/460 Reviewed-by: Martin Kaiser <wireshark@kaiser.cx>
2014-03-03use tvb_memdup() instead of tvb_get_ptr()Martin Kaiser1-1/+1
Change-Id: I1e9ff715c3e315c9e36abb69fb5f441b71477501 Reviewed-on: https://code.wireshark.org/review/459 Reviewed-by: Martin Kaiser <wireshark@kaiser.cx>
2014-03-03remove unnecessary if (tree) checkMartin Kaiser1-12/+10
Change-Id: I1542d715594b1b90e2442edb6f220ddc4dd99675 Reviewed-on: https://code.wireshark.org/review/458 Reviewed-by: Martin Kaiser <wireshark@kaiser.cx>
2014-03-03skip empty service provider name and empty service nameMartin Kaiser1-11/+15
Change-Id: I355600320865a9c7c17093d37fc693b02f0a7f0c Reviewed-on: https://code.wireshark.org/review/457 Reviewed-by: Martin Kaiser <wireshark@kaiser.cx>
2014-03-03service provider name is a DVB-SI stringMartin Kaiser1-2/+12
Change-Id: Idea44f0e4678f738336215f4a250b9e9d9a60fbc Reviewed-on: https://code.wireshark.org/review/456 Reviewed-by: Martin Kaiser <wireshark@kaiser.cx>
2014-03-03service name is a DVB-SI stringMartin Kaiser1-3/+15
Change-Id: I81ef4cd363acf6cff99fd0f75b135962c4c22f53 Reviewed-on: https://code.wireshark.org/review/455 Reviewed-by: Martin Kaiser <wireshark@kaiser.cx>
2014-03-02Don't pass an invalid length to proto_item_set_lenEvan Huus1-1/+2
Fixes bug #9818. Change-Id: I4fb4cf2b5b31ed6efc55a48df67f2ec4949d47c3 Reviewed-on: https://code.wireshark.org/review/442 Reviewed-by: Evan Huus <eapache@gmail.com>
2014-03-02Improve SCTP association lookup.Evan Huus1-5/+5
It's still O(n) in the worst case since the comparison function doesn't appear to be suitable for use in a tree or hash-table, but at least we no longer spend O(n) by default just finding the end of the list so we can iterate backwards. Discovered while investigating bug #9823, but probably not the cause of that bug. Change-Id: Ib6c3691cff8e7fa49703df7c75635ef797c8fbe8 Reviewed-on: https://code.wireshark.org/review/443 Reviewed-by: Anders Broman <a.broman58@gmail.com>
2014-03-02Remove unneeded line of code.Bill Meier1-2/+0
Change-Id: Ic2769d5c125d8db7d32b6ad3ab0e4363f513f599 Reviewed-on: https://code.wireshark.org/review/451 Reviewed-by: Bill Meier <wmeier@newsguy.com> Tested-by: Bill Meier <wmeier@newsguy.com>
2014-03-02Clear INFO column at the beginning of the dissector.Bill Meier1-6/+6
Change-Id: Iea901674e1d9c4745b891ac4330bd781d5eb76ec Reviewed-on: https://code.wireshark.org/review/450 Reviewed-by: Bill Meier <wmeier@newsguy.com> Tested-by: Bill Meier <wmeier@newsguy.com>
2014-03-02tvb_length() --> tvb_reported_length() in several cases + other misc changes.Bill Meier1-256/+265
Misc changes: - sort entries in an enum by value; - add some XXX notes as to possible missing entries in a value-string array; - remove an unneeded initializer; - 0 --> FALSE for several boolean values; - whitespace. Change-Id: I6c8f1c1f37edad120d979fcd2d7278e7981ca5a7 Reviewed-on: https://code.wireshark.org/review/449 Reviewed-by: Bill Meier <wmeier@newsguy.com> Tested-by: Bill Meier <wmeier@newsguy.com>
2014-03-02Clear INFO col; Create/use extended value-string; Do other minor changesBill Meier1-1214/+1222
- val_to_str() -> val_to_str_const() in a few cases; - localize some vars; - remove some unneeded initializers; - convert "4 space tabs" indentation to "4 spaces"; revise editor modelines to match; - do some whitespace changes. Change-Id: Ic91df02022971c973b27c71e6127395ed3ef06d3 Reviewed-on: https://code.wireshark.org/review/448 Reviewed-by: Bill Meier <wmeier@newsguy.com> Tested-by: Bill Meier <wmeier@newsguy.com>
2014-03-02Fix packet-h223.c:842:18: error: will never be executed ↵Alexis La Goutte1-4/+4
[-Werror,-Wunreachable-code] Change-Id: I8255a3841add78eaa167ef631effe58d9fb12736 Reviewed-on: https://code.wireshark.org/review/323 Reviewed-by: Evan Huus <eapache@gmail.com>
2014-03-01Create/use two extended value-strings & do other minor changes.Bill Meier1-187/+138
- Use VALUE_STRING_ENUM/VALUE_STRING_ARRAY macros to create one of the value string arrays instead of using the usual separate #defines & array definition; - Remove a few unneeded initializers; - prefs_register_protocol() need not be called under 'if (gp_zbee_prefs == NULL)' - Do some minor whitespace changes; - Add editor modelines. Change-Id: I33669b25fa18ecc452b83a0d88a6c0b33aae904a Reviewed-on: https://code.wireshark.org/review/441 Reviewed-by: Bill Meier <wmeier@newsguy.com> Tested-by: Bill Meier <wmeier@newsguy.com>
2014-03-01Add the PPID for 3GPP Pua. Move the (unregistered) M2TP PPID into that ↵Jeff Morriss1-3/+2
dissector. Also put a note in sctpppids.h saying that only IANA-registered PPIDs should go in that file. Inspired by the rejection of https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=4332 Change-Id: I763aad7d1b69e9d36c798061473438ce3cb66ca1 Reviewed-on: https://code.wireshark.org/review/434 Reviewed-by: Evan Huus <eapache@gmail.com> Reviewed-by: Anders Broman <a.broman58@gmail.com> Tested-by: Anders Broman <a.broman58@gmail.com>
2014-03-01GlusterFS: add support for ZEROFILL fopNiels de Vos2-6/+30
Implementation details in http://review.gluster.org/5327 BUG: 9812 Change-Id: Ib1650fb7ca8221def4e9c6a323008847dc7b5f62 Signed-off-by: Niels de Vos <ndevos@redhat.com> Reviewed-on: https://code.wireshark.org/review/429 Reviewed-by: Evan Huus <eapache@gmail.com> Reviewed-by: Pascal Quantin <pascal.quantin@gmail.com>
2014-03-01Disable IPv4 checksum verfification to match TCP and UDP.Gerald Combs1-1/+1
Offloading seems to be very common nowadays and having this option enabled by default generates a lot of false positives. Suggested by Laura Chappell. Change-Id: I285f218efb3c9f164d8ad7a6d6de8270e442ffff Reviewed-on: https://code.wireshark.org/review/426 Reviewed-by: Evan Huus <eapache@gmail.com> Reviewed-by: Alexis La Goutte <alexis.lagoutte@gmail.com>
2014-02-28packet-homeplug-av: use HOMEPLUG_AV_MMVER_1_1 consistentlyFlorian Fainelli1-7/+7
The HomePlug AV dissector was not consistently using the HOMEPLUG_AV_MMVER_1_1 constant and was sometimes using it and sometimes using mmver == 1 directly. Make sure we use that constant throughout the code to help clarifiying which version tests are applying to. Change-Id: I602413163e4e44dedfbf3e2364448a951fa70f54 Signed-off-by: Florian Fainelli <florian@openwrt.org> Reviewed-on: https://code.wireshark.org/review/428 Reviewed-by: Evan Huus <eapache@gmail.com>
2014-02-28packet-homeplug-av: fix missing reserved byte for station dumpFlorian Fainelli1-1/+1
dissect_homeplug_av_nw_info_sta() was processing stations information correctly, except that after the first station dump, all dumps would be off-by-one byte because we were not reserving a missing byte at the end of the station dump. Fixes #9798. Change-Id: Iff3afd5ff536ae718fa446de3c59cd5e9851ff20 Signed-off-by: Florian Fainelli <florian@openwrt.org> Reviewed-on: https://code.wireshark.org/review/427 Reviewed-by: Evan Huus <eapache@gmail.com>
2014-02-27Ensure ieee802154_packet struct is initialized.Evan Huus1-1/+1
A malformed capture could cause the zbee-nwk-gp and 6lowpan heuristics to be called with an incompletely-initialized structure, leading to valgrind errors. Change-Id: Iaea6daecdca6856466b58071f095930e68c6e159 Closes-Bug: #9735 Reviewed-on: https://code.wireshark.org/review/418 Reviewed-by: Jeff Morriss <jeff.morriss.ws@gmail.com> Reviewed-by: Evan Huus <eapache@gmail.com>
2014-02-27Sherman, set the Wayback Machine for 1997.Guy Harris1-1/+1
The URLs for the CRC-10 code are dead; use Wayback Machine URLs. Change-Id: I3924e9cabb3b49b0e1abb31fbffa9b89f95cd0ce Reviewed-on: https://code.wireshark.org/review/419 Reviewed-by: Guy Harris <guy@alum.mit.edu>
2014-02-26Remove trailing whitespace from asn1 .cnf & template.[hc] files. Regenerate ↵Bill Meier64-309/+309
dissectors. Change-Id: I0e779b2ac2f608356649c5bbfca438141070dea4 Reviewed-on: https://code.wireshark.org/review/412 Reviewed-by: Bill Meier <wmeier@newsguy.com> Tested-by: Bill Meier <wmeier@newsguy.com>
2014-02-26Create/use an extended value_string.Bill Meier1-4/+5
Change-Id: I1cd20d68ebb50d11ecfa00bf76e9be7c47a45860 Reviewed-on: https://code.wireshark.org/review/410 Reviewed-by: Bill Meier <wmeier@newsguy.com> Tested-by: Bill Meier <wmeier@newsguy.com>
2014-02-26(Minor) Use col_add_str() iso col_set_str().Bill Meier2-5/+6
Change-Id: I3d430e7e6a6bbdcb518f0110bd81ab32f88c17f0 Reviewed-on: https://code.wireshark.org/review/409 Reviewed-by: Bill Meier <wmeier@newsguy.com> Tested-by: Bill Meier <wmeier@newsguy.com>
2014-02-26Create/use some extended value-strings. Do some whitespace changes.Bill Meier1-179/+182
Change-Id: Iee5cb12d3b6669c7e45e18352ebcd151db721ad3 Reviewed-on: https://code.wireshark.org/review/408 Reviewed-by: Bill Meier <wmeier@newsguy.com> Tested-by: Bill Meier <wmeier@newsguy.com>
2014-02-26Use proto_tree_add_item() for most string encodings.Guy Harris1-15/+15
We support ISO 8859-1 and 8859-8, so use proto_tree_add_item() for them. That leaves only EUC-KR. Change-Id: Ie61f69af43be03e5abeb84b95601a407900fb79b Reviewed-on: https://code.wireshark.org/review/403 Reviewed-by: Guy Harris <guy@alum.mit.edu>
2014-02-26Use tvb_get_string_enc(..., ENC_ASCII|ENC_NA) for 8-bit encoding.Guy Harris1-2/+6
If there are 8-bit "extended ASCII" encodings, either one should be wired in or there should be a preference for them. Change-Id: Id62381b2579e8edf3719bd92959821c21f7ba223 Reviewed-on: https://code.wireshark.org/review/402 Reviewed-by: Guy Harris <guy@alum.mit.edu>
2014-02-26Replace tabs by spacesPascal Quantin1-2/+2
Change-Id: Ib7b97c415fdf924783637bfe566f1e7d21e28369 Reviewed-on: https://code.wireshark.org/review/401 Reviewed-by: Pascal Quantin <pascal.quantin@gmail.com>
2014-02-26packet-smb-direct: register as a infiniband subdissectorStefan Metzmacher1-0/+39
This is implemented based on the documentation, I sadly don't have a capture to verify this. Change-Id: Ia7dc371cb5b17ea42be0e686c97797f8c06ccabd Signed-off-by: Stefan Metzmacher <metze@samba.org> Reviewed-on: https://code.wireshark.org/review/358 Reviewed-by: Pascal Quantin <pascal.quantin@gmail.com>
2014-02-26packet-infiniband: pass a struct infinibandinfo to subdissectorsStefan Metzmacher2-96/+106
Change-Id: I187a1a91f34b1b758cad03bd9902ba132272cd3a Signed-off-by: Stefan Metzmacher <metze@samba.org> Reviewed-on: https://code.wireshark.org/review/357 Reviewed-by: Pascal Quantin <pascal.quantin@gmail.com>
2014-02-26packet-smb-direct: only handle RDMA_SEND_* messagesStefan Metzmacher1-1/+17
Change-Id: I08fa1092e2722c108bf6f847f8fc230f131e584b Signed-off-by: Stefan Metzmacher <metze@samba.org> Reviewed-on: https://code.wireshark.org/review/356 Reviewed-by: Pascal Quantin <pascal.quantin@gmail.com>
2014-02-26packet-iwarp-ddp-rdmap: pass struct rdmapinfo with opcode to the subdissectorsStefan Metzmacher3-24/+75
Change-Id: I51bb8a3047bbc16d55d0c089fe869c7534d4c0b5 Signed-off-by: Stefan Metzmacher <metze@samba.org> Reviewed-on: https://code.wireshark.org/review/355 Reviewed-by: Pascal Quantin <pascal.quantin@gmail.com>
2014-02-26We don't use EBCDIC_to_ASCII(), so we don't need to include <epan/charsets.h>.Guy Harris1-1/+0
Change-Id: Ief609f48493f406ba0818ed3e6febe9a8ef0aaf2 Reviewed-on: https://code.wireshark.org/review/400 Reviewed-by: Guy Harris <guy@alum.mit.edu>
2014-02-26Use tvb_get_string_enc() to get UCS-2 strings.Guy Harris1-21/+8
Also, note that the "8-bit" encoding is "user-defined". Change-Id: Ic4786873150d837d8793d2d3d20af50cd0003cc7 Reviewed-on: https://code.wireshark.org/review/399 Reviewed-by: Guy Harris <guy@alum.mit.edu>
2014-02-25packet-smb: register a dissector on top of smb_directStefan Metzmacher1-0/+1
Change-Id: I316b958c6a91dc333bcdb468368f2c19fe8845d6 Old-Change-Id: I26a3088df12de9d74cf6c224b938003417b758f5 Signed-off-by: Stefan Metzmacher <metze@samba.org> Reviewed-on: https://code.wireshark.org/review/58 Reviewed-by: Evan Huus <eapache@gmail.com> (cherry picked from commit d0d83e5b85173cd9fdc9001a2efb2f596124e2a2) Reviewed-on: https://code.wireshark.org/review/389
2014-02-25packet-smb2: register a dissector on top of smb_directStefan Metzmacher1-0/+1
Change-Id: I6a87c57d513af9c8ce9dff783988f7242f5257d0 Old-Change-Id: If52130f7f9e9783a8ecc8b8b3c01d86a02e4f946 Signed-off-by: Stefan Metzmacher <metze@samba.org> Reviewed-on: https://code.wireshark.org/review/57 Reviewed-by: Evan Huus <eapache@gmail.com> (cherry picked from commit cd9f6e077fdbdde2462acea6b7906e153c8c4864) Reviewed-on: https://code.wireshark.org/review/390
2014-02-25packet-smb-direct.c: add initial implementationStefan Metzmacher2-0/+489
See [MS-SMBD] http://msdn.microsoft.com/en-us/library/hh536346.aspx Change-Id: If2cf719bdf5da82bc5f5e086dd69d02caff2166a Signed-off-by: Stefan Metzmacher <metze@samba.org> Reviewed-on: https://code.wireshark.org/review/55 Reviewed-by: Evan Huus <eapache@gmail.com>
2014-02-25packet-kerberos: remember in what frame a key was learnedStefan Metzmacher2-0/+4
Change-Id: Icd05d4941fdacac44094fafbad07f08ec4cbe976 Signed-off-by: Stefan Metzmacher <metze@samba.org> Reviewed-on: https://code.wireshark.org/review/364 Reviewed-by: Alexis La Goutte <alexis.lagoutte@gmail.com>
2014-02-25802.11 : Add channel number custom (to display info when report channel ↵Alexis La Goutte1-13/+26
number is 0 or 255) Fix also indent for other custom... Change-Id: Ic95b65d5217a0d1e967892ac2694f3ba749242fb Reviewed-on: https://code.wireshark.org/review/379 Reviewed-by: Alexis La Goutte <alexis.lagoutte@gmail.com> Tested-by: Alexis La Goutte <alexis.lagoutte@gmail.com>
2014-02-25802.11: Regulatory Class => Operating Class (changed in 802.11-2012)Alexis La Goutte1-59/+59
Fix also typo for hf_ieee80211_tag_measure_request_regulatory_class wrong hf name... Change-Id: I49e582c7683e58abb8785958dcc043789fd79a26 Reviewed-on: https://code.wireshark.org/review/378 Reviewed-by: Alexis La Goutte <alexis.lagoutte@gmail.com> Tested-by: Alexis La Goutte <alexis.lagoutte@gmail.com>
generated by cgit v1.2.3 (git 2.25.1) at 2024-06-20 02:22:12 +0000