aboutsummaryrefslogtreecommitdiffstats
path: root/epan/dissectors/packet-zbee-zcl.c
AgeCommit message (Collapse)AuthorFilesLines
2014-06-18Fixup: tvb_* -> tvb_capturedDario Lombardo1-14/+14
Change-Id: I9209c1271967405c34c1b6fa43e1726a4d3a5a3f Reviewed-on: https://code.wireshark.org/review/2377 Reviewed-by: Anders Broman <a.broman58@gmail.com>
2014-06-18Fixup: tvb_get_string(z) -> tvb_get_string(z)_encDario Lombardo1-2/+2
Change-Id: I63a3704effe3fcab01a193dc39b6a22e9f1cf3fe Reviewed-on: https://code.wireshark.org/review/2376 Reviewed-by: Anders Broman <a.broman58@gmail.com>
2014-06-07tvb_new_subset -> tvb_new_subset_length when length parameters are equal.Michael Mann1-1/+1
tvb_new_subset -> tvb_new_subset_remaining it appears that's what the intention is. Change-Id: I2334bbf3f10475b3c22391392fc8b6864454de2d Reviewed-on: https://code.wireshark.org/review/1999 Reviewed-by: Pascal Quantin <pascal.quantin@gmail.com>
2014-04-15Bug 8214. Don't let array ett_ variables limit the number of array elements ↵Michael Mann1-9/+98
dissected. Also add support for set and bag dissection. Change-Id: I11059ec313aba7d289ce06e38b4992429f2fd999 Reviewed-on: https://code.wireshark.org/review/1123 Reviewed-by: Michael Mann <mmann78@netscape.net>
2014-03-04Remove all $Id$ from top of fileAlexis La Goutte1-2/+0
(Using sed : sed -i '/^ \* \$Id\$/,+1 d') Fix manually some typo (in export_object_dicom.c and crc16-plain.c) Change-Id: I4c1ae68d1c4afeace8cb195b53c715cf9e1227a8 Reviewed-on: https://code.wireshark.org/review/497 Reviewed-by: Anders Broman <a.broman58@gmail.com>
2014-01-12Zcl OTA Upgrade cluster dissector. Bug 9545 ↵Michael Mann1-482/+14
(https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=9545) From Fabio Tarabelloni From me: Reorder function definitions so declarations aren't necessary svn path=/trunk/; revision=54701
2013-12-26Bugfix attribute id parsing in zbee dissectors. Bug 9566 ↵Michael Mann1-5/+2
(https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=9566) From Fabio Tarabelloni svn path=/trunk/; revision=54465
2013-12-19Rename a couple of to_str functions to have ep_ in the name. This makes itEvan Huus1-2/+2
obvious that the returned string is ephemeral, and opens up the original names in the API for versions that take a wmem pool (and thus can work in any scope). svn path=/trunk/; revision=54249
2013-12-17General cleanup of ZBEE ZCL dissector. Removed unnecessary casts and ↵Michael Mann1-315/+166
wrapping functions. Tried to remove zcl_cluster_id global, but it's used in a function that is called by other dissectors that I'm not sure if they are expecting the zcl_cluster_id to be "saved" (or if -1 could be passed in for cluster id from those dissectors). Removed as many uses of it as possible if someone knows the dissectors better to make that call. svn path=/trunk/; revision=54186
2013-12-17From Fabio Tarabelloni via ↵Alexis La Goutte1-9/+17
https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=9547 Zbee ZCL wrong cmdID in DefaultRespons Default Response command generated by Specific command cluster contains wrong cmdId decoding. The value shows the cross-cluster command id but not the specific cluster command id name. Draft of solution is already created (now is under test). The idea is to add a cmdId function callback in zbee_zcl_init_cluster in order to call it when wireshark has to decode specific cluster cmd in default response. svn path=/trunk/; revision=54171
2013-12-15From Fabio Tarabelloni via ↵Alexis La Goutte1-72/+0
https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=9544 Zbee ZCL Identify dissector duplicated The packet-zbee-zcl.c contains duplication of ZCL Identify cluster dissector, already developed in packet-zbee-zcl-general.c file svn path=/trunk/; revision=54125
2013-12-09Reject the packet if data is NULL.Chris Maynard1-1/+6
svn path=/trunk/; revision=53893
2013-12-07- Make local functions static.Anders Broman1-0/+2
- Forward declaration of register function. svn path=/trunk/; revision=53817
2013-11-29Bugfixes of r53636, part of bug 9423 ↵Michael Mann1-28/+36
(https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=9423) From DSR Corporation svn path=/trunk/; revision=53645
2013-11-29Improved ZCL dissectors. Bug 9423 ↵Michael Mann1-28/+1201
(https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=9423) From DSR Corporation svn path=/trunk/; revision=53636
2013-10-24Have ZigBee dissectors pass data through subdissector parameter instead of ↵Michael Mann1-9/+8
using struct _packet_info. svn path=/trunk/; revision=52827
2013-10-13whitespace fixes; mostly: remove trailing blanksBill Meier1-13/+13
svn path=/trunk/; revision=52591
2013-09-22emem -> wmem conversion:Pascal Quantin1-2/+2
- ep_tvb_get_bits() -> wmem_packet_tvb_get_bits() - tvb_g_memdup()/ep_tvb_memdup() -> tvb_memdup() - tvb_fake_unicode()/tvb_get_ephemeral_faked_unicode() -> tvb_get_faked_unicode() - tvb_get_g_string()/tvb_get_ephemeral_string()/tvb_get_seasonal_string() -> tvb_get_string() - tvb_get_g_unicode_string()/tvb_get_ephemeral_unicode_string() -> tvb_get_unicode_string() - tvb_get_ephemeral_string_enc() -> tvb_get_string_enc() - update docs accordingly svn path=/trunk/; revision=52172
2013-09-10Fix https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=9128 :Pascal Quantin1-4/+3
ZigBee ZCL epoch is January 1, 2000 svn path=/trunk/; revision=51939
2013-06-29From Fabio Tarabelloni viaEvan Huus1-10/+26
https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=8718 Zigbee dissectors for the power profile cluster and the appliance control cluster svn path=/trunk/; revision=50229
2013-06-20From Fabio Tarabelloni viaEvan Huus1-6/+3
https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=8718 Zigbee partition cluster dissector. svn path=/trunk/; revision=50089
2013-06-20From Fabio Tarabelloni viaEvan Huus1-40/+57
https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=8718 New zigbee cluster dissectors added for Basic and Identify clusters. svn path=/trunk/; revision=50086
2013-06-14Remove check_col() and the occasional tree.Michael Mann1-12/+6
This leaves just the Pidl dissectors remaining for removal of check_col() in the dissectors directory. A small handful of check_col() calls remain outside of the dissectors. svn path=/trunk/; revision=49941
2013-05-25From Fabio Tarabelloni via ↵Evan Huus1-81/+198
https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=8387 ZigBee ZCL OnOff cluster dissection. Also, fix decryption of APS commands. svn path=/trunk/; revision=49571
2013-03-21Use consistent indentation;Bill Meier1-31/+31
Also: replace a few "4 space tabs" by spaces. svn path=/trunk/; revision=48462
2013-03-21From Fabio Tarabelloni: Fix for: "ZigBee Cluster Library dissector does not ↵Bill Meier1-1/+84
handle arrays correctly" See: https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=8214 From me: - Use spaces for indentation (instead of :4 space tabs"); - Remove trailing whitespace; - Add placeholder for un-implemented dissection of data types set, struct, bag. (Probably should use 'expert' but that requires more work since dissection is under 'if (tree)'). svn path=/trunk/; revision=48455
2013-01-31Use '#if 0 ... #endif' rather than /** ... **/ to comment outBill Meier1-0/+7
unused hf[] entries (which I should have done in the first place). svn path=/trunk/; revision=47390
2013-01-26Comment out cases of unused hf array entries found by checkhf.Bill Meier1-5/+0
svn path=/trunk/; revision=47302
2012-12-26Fix a bunch of warnings.Guy Harris1-43/+43
Cast away some implicit 64-bit-to-32-bit conversion errors due to use of sizeof. Cast away some implicit 64-bit-to-32-bit conversion errors due to use of strtol() and strtoul(). Change some data types to avoid those implicit conversion warnings. When assigning a constant to a float, make sure the constant isn't a double, by appending "f" to the constant. Constify a bunch of variables, parameters, and return values to eliminate warnings due to strings being given const qualifiers. Cast away those warnings in some cases where an API we don't control forces us to do so. Enable a bunch of additional warnings by default. Note why at least some of the other warnings aren't enabled. randpkt.c and text2pcap.c are used to build programs, so they don't need to be in EXTRA_DIST. If the user specifies --enable-warnings-as-errors, add -Werror *even if the user specified --enable-extra-gcc-flags; assume they know what they're doing and are willing to have the compile fail due to the extra GCC warnings being treated as errors. svn path=/trunk/; revision=46748
2012-10-22Minor cleanup:Bill Meier1-49/+48
- Ethereal -> Wireshark; - remove unneeded #include. svn path=/trunk/; revision=45726
2012-09-20We always HAVE_CONFIG_H so don't bother checking whether we have it or not.Jeff Morriss1-2/+0
svn path=/trunk/; revision=45017
2012-07-25Converted ZigBee dissectors display filter format from zbee.<protocol> to ↵Michael Mann1-49/+49
zbee_<protocol> Also corrected zbee_afp filters as they were incorrectly using zbee.app svn path=/trunk/; revision=43990
2012-06-28Update Free Software Foundation address.Jakub Zawadzki1-1/+1
(COPYING will be updated in next commit) svn path=/trunk/; revision=43536
2011-12-30From Fred Fierling via https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=6698Alexis La Goutte1-1/+2
Updates for newest profile identifier database, ZigBee 053298r19 Corrects error in Samsung manufacturer code in r18. svn path=/trunk/; revision=40344
2011-12-22From Fred Fierling:Anders Broman1-8/+82
Update the ZigBee dissectors to the latest profile identifier database, 05-3298-18. https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=6693 svn path=/trunk/; revision=40272
2011-12-17Fix some Dead Store (Dead assignement/Dead increment) Warning found by ClangAlexis La Goutte1-3/+0
svn path=/trunk/; revision=40234
2011-12-09From report of Arasch Honarbacht via ↵Alexis La Goutte1-3/+2
https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=6649 ZigBee ZCL Dissector reports invalid status The status code 0x8d contained in an attriute status record in a configure reporting response frame is incorrectly displayed as "Write only" (where WRITE_ONLY = 0x8f). According to the ZigBee Cluster Library Specification, Document 075123r03ZB, April 26, 2010 a status of 0x8d should display as "INVALID_DATA_TYPE" From me : Fix this issue (Wrong value define) based on Specs available in ZigBee.org svn path=/trunk/; revision=40133
2011-10-10 Convert 'encoding' parameter of certain proto_tree_add_item() calls in ↵Bill Meier1-1/+1
non-autogenerated epan/dissectors: Specifically: Replace FALSE|0 and TRUE|1 by ENC_BIG_ENDIAN|ENC_LITTLE_ENDIAN as the encoding parameter for proto_tree_add_item() calls which directly reference an item in hf[] which has a type of: FT_BOOLEAN FT_IPv4 FT_EUI64 FT_GUID FT_UINT_STRING Also: For type FT_ITv6 use ENC_NA. (This was missed in SVN #39260) svn path=/trunk/; revision=39328
2011-10-06Convert 'encoding' parameter of certain proto_tree_add_item() calls in ↵Bill Meier1-2/+2
non-autogenerated epan/dissectors: Specifically: Replace FALSE|0 and TRUE|1 by ENC_BIG_ENDIAN|ENC_LITTLE_ENDIAN as the encoding parameter for proto_tree_add_item() calls which directly reference an item in hf[] which has a type of: FT_UINT8 FT_UINT16 FT_UINT24 FT_UINT32 FT_UINT64 FT_INT8 FT_INT16 FT_INT24 FT_INT32 FT_INT64 FT_FLOAT FT_DOUBLE svn path=/trunk/; revision=39288
2011-07-18Fix gcc 4.6 "set but not used [-Wunused-but-set-variable]" warnings.Bill Meier1-4/+0
svn path=/trunk/; revision=38082
2011-01-16There's no need to pass the result of tvb_get_ptr() as the 'value' inJeff Morriss1-2/+1
proto_tree_add_*(): just use proto_tree_add_item(). Replace some tvb_get_ptr()s with tvb_get_ephemeral_string() or tvb_get_const_stringz(). Use tvb_memeql() & tvb_memcmp(). svn path=/trunk/; revision=35558
2010-12-20Rename the routines that handle dissector tables with unsigned integerGuy Harris1-10/+10
keys to have _uint in their names, to match the routines that handle dissector tables with string keys. (Using _port can confuse people into thinking they're intended solely for use with TCP/UDP/etc. ports when, in fact, they work better for things such as Ethernet types, where the binding of particular values to particular protocols are a lot stronger.) svn path=/trunk/; revision=35224
2010-11-12zbee_mfr_code_names: sort so in ascending order by value; add dummy ↵Bill Meier1-3/+61
"Unknown" entries for missing values. svn path=/trunk/; revision=34855
2010-11-03From Fred Fierling:Jaap Keuter1-8/+3
Patch to correct various typos svn path=/trunk/; revision=34757
2010-11-02From Fred Fierling:Jaap Keuter1-0/+23
Update Profile ID Information to ZigBee-053298r17 (2010/7/21) svn path=/trunk/; revision=34749
2010-11-01Use value_string_ext fcns to access various value_string arrays;Bill Meier1-22/+28
Also: Fix a typo in packet-zbee.h in the value for #define ZBEE_MFG_CODE_STG svn path=/trunk/; revision=34746
2010-10-20From Fred Fierling:Anders Broman1-242/+175
Cleanup of unnecessary tree == NULL checks in ZCL dissector https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=5321 svn path=/trunk/; revision=34595
2010-10-19From Fred Fierling:Anders Broman1-13/+15
Infinite loop in ZCL Discover Attributes dissection https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=5303 svn path=/trunk/; revision=34575
2010-08-23Fix for attribute boolean, from bug 5127.Stig Bjørlykke1-2/+1
svn path=/trunk/; revision=33887
2009-12-19For fields of type FT_ABSOLUTE_TIME, have the "display" value be one ofGuy Harris1-1/+1
ABSOLUTE_TIME_LOCAL or ABSOLUTE_TIME_UTC, indicating whether to display the date/time in local time or UTC. (int)ABSOLUTE_TIME_LOCAL == (int)BASE_NONE, so there's no source or binary compatiblity issue, although we might want to eliminate BASE_NONE at some point and have the BASE_ values used with integral types start at 0, so that you can't specify BASE_NONE for an integral field. svn path=/trunk/; revision=31319