aboutsummaryrefslogtreecommitdiffstats
path: root/epan/dissectors/packet-zbee-zcl-se.c
AgeCommit message (Collapse)AuthorFilesLines
2024-08-12Dissectors: Include what you use.Anders Broman1-1/+3
2024-08-01Fix some spelling errorsMartin Mathieson1-1/+1
2024-07-20Convert dissectors YZ to C99 typesAnders Broman1-485/+485
2024-05-09Add a ENC_TIME_ZBEE_ZCL time encoding and use it.Guy Harris1-216/+51
Add an epoch value for the Zigbee ZCL epoch - 2000-01-01 00:00:00 UTC - to wsutil/epochs.h, and use that. Add a time stamp format consisting of a 4-byte or 8-byte count of seconds since that epoch, ENC_TIME_ZBEE_ZCL, and use that instead of manually extracting the value, constructing an nstime_t, and adding that value.
2024-01-25Fix more FT_BOOLEAN items with no mask - set len to BASE_NONEMartin Mathieson1-3/+3
2024-01-17Add descriptions for heur dissector tablesDavid Perry1-1/+1
Build on !13975 to add human-readable descriptions for all heuristic dissector tables in Wireshark. Chosen names are meant to give some info on when a heuristic dissector lookup will be made. Terms like 'fallback' are used when the heuristic is only consulted if other checks do not result in dissection, for example. People with more intimate knowledge of the protocols and dissectors involved are encouraged to suggest or implement better descriptions.
2023-12-11Zigbee improved Smart Energy time format and displayChris Brandson1-147/+56
Similar to other changes to the dissection and display of UTC Time, changed Smart Energy time fields to display both UTC text time and UTC Time as a number with the number as the field value for t-shark. As UTC Time is used elsewhere, broke that functionality out into the main ZCL file, but Smart Energy applies a special meaning where the value 0 means 'now' independant of the actual time, this is restricted to Smart Energy uses of UTC Time. Thanks to Cole Wu <colewu9712@gmail.com> for the original implementation and support.
2023-12-07Zigbee display Smart Energy Fast Poll End Time as numeric and stringChris Brandson1-1/+10
Thanks to Cole Wu <colewu9712@gmail.com> for the original implementation
2023-11-24Zigbee fix incorrect endianness on Smart Energy (SE) Tunnel Close Timeout ValueChris Brandson1-1/+1
Zigbee values are little endian, however original implementation of Tunnel Close attribute used ENC_NA resulting in incorrect dissection Cole Wu <colewu9712@gmail.com> provided this fix and data used to verify.
2023-11-20Remove init of proto variablesStig Bjørlykke1-824/+824
Remove init of proto, header field, expert info and subtree variables. This will reduces the binary size by approximate 1266320 bytes due to using .bss to zero-initialize the fields. The conversion is done using the tools/convert-proto-init.py script.
2023-11-18dissectors: Remove init of hf and ett variable arraysStig Bjørlykke1-1/+0
Manually remove init of hf and ett variable arrays because this cannot be easily done using the convert script.
2023-11-17dissectors: Remove init of hf and ett variable arraysStig Bjørlykke1-2/+0
Manually remove init of hf and ett variable arrays because this cannot be easily done using the convert script.
2023-11-07Fix some more copy/pasted filtersMartin Mathieson1-1/+1
2023-11-03Detect more copy/pasted filters - looking further backMartin Mathieson1-2/+2
2023-09-22Make tfs_true_false the default for booleansJoão Valverde1-2/+2
Instead of adding a TFS(&tfs_true_false) to every boolean field, make it the default if "strings" is NULL. This seems to match the already existing documentation: If the Boolean field is to be displayed as "False" or "True", the 'strings' field would be set to NULL.
2022-11-08Fix more unused variables and enable unused-but-set-variable errors.Gerald Combs1-1/+1
Add -Werror=unused-but-set-variable to our default compiler flags and fix ``` epan/dissectors/packet-dcerpc-frsrpc.c:709:10: error: variable 'nb_chunk' set but not used [-Werror,-Wunused-but-set-variable] guint32 nb_chunk = 0; ^ ``` ``` epan/dissectors/packet-dcom-oxid.c:175:13: error: variable 'u32ItemIdx' set but not used [-Werror,-Wunused-but-set-variable] guint32 u32ItemIdx; ^ ``` ``` epan/dissectors/packet-l2tp.c:1775:104: error: parameter 'ccid' set but not used [-Werror,-Wunused-but-set-parameter] static int dissect_l2tp_ericsson_avps(tvbuff_t *tvb, packet_info *pinfo _U_, proto_tree *tree, guint32 ccid) ^ ``` ``` epan/dissectors/packet-ldp.c:1922:19: error: variable 'ix' set but not used [-Werror,-Wunused-but-set-variable] guint8 ix; ^ ``` ``` epan/dissectors/packet-nas_5gs.c:4757:14: error: variable 'curr_len' set but not used [-Werror,-Wunused-but-set-variable] guint i, curr_len; ^ ``` ``` epan/dissectors/packet-per.c:1769:6: error: variable 'extension_addition_entries' set but not used [-Werror,-Wunused-but-set-variable] int extension_addition_entries; ^ ``` ``` epan/dissectors/packet-rtitcp.c:618:11: error: variable 'messages_count' set but not used [-Werror,-Wunused-but-set-variable] guint messages_count, offset; ^ ``` ``` epan/dissectors/packet-tcp.c:2130:9: error: variable 'ackcount' set but not used [-Werror,-Wunused-but-set-variable] int ackcount; ^ epan/dissectors/packet-tcp.c:3317:12: error: variable 'nbOptionsChanged' set but not used [-Werror,-Wunused-but-set-variable] guint8 nbOptionsChanged = 0; ^ ``` ``` epan/dissectors/packet-zbee-zcl-se.c:11802:15: error: variable 'i' set but not used [-Werror,-Wunused-but-set-variable] for (gint i = 0; tvb_reported_length_remaining(tvb, *offset) >= 5; i++) { ^ ``` ``` ui/iface_lists.c:142:23: error: variable 'linktype_count' set but not used [-Werror,-Wunused-but-set-variable] gint linktype_count; ^ ``` ``` ui/voip_calls.c:456:15: error: variable 'item_num' set but not used [-Werror,-Wunused-but-set-variable] guint item_num; ^ ``` ``` file.c:572:17: error: variable 'count' set but not used [-Werror,-Wunused-but-set-variable] guint32 count = 0; ^ ``` ``` file.c:3667:24: warning: cast from 'const unsigned char *' to 'unsigned char *' drops const qualifier [-Wcast-qual] pd = (guint8 *)ws_mempbrk_exec(pd, buf_end - pd, pattern, &c_char); ^ ``` ``` ui/qt/io_graph_dialog.cpp:1932:60: error: variable 'mavg_right' set but not used [-Werror,-Wunused-but-set-variable] unsigned int mavg_in_average_count = 0, mavg_left = 0, mavg_right = 0; ^ ``` ``` ui/qt/stats_tree_dialog.cpp:166:9: error: variable 'node_count' set but not used [-Werror,-Wunused-but-set-variable] int node_count = 0; ^ ``` ``` ui/qt/models/profile_model.cpp:1142:13: error: variable 'entryCount' set but not used [-Werror,-Wunused-but-set-variable] int entryCount = 0; ^ ```
2022-03-28zigbee/isis-clv/wsdg: depreciate -> deprecateChuck Craft1-3/+3
zigbee per Document 07-5356-19 Unchanged: packet-cfm.c per ITU standard packet-opa-mad.c - unable to confirm status
2021-12-19Replace g_snprintf() with snprintf() (dissectors)João Valverde1-10/+10
Use macros from inttypes.h with format strings.
2021-12-03epan: Remove STR_ASCII and STR_UNICODEJoão Valverde1-6/+6
These display bases work to replace unprintable characters so the name is a misnomer. In addition they are the same option and this display behaviour is not something that is configurable. This does not affect encodings because all our internal text strings need to be valid UTF-8 and the source encoding is specified using ENC_*. Remove the assertion for valid UTF-8 in proto.c because tvb_get_*_string() must return a valid UTF-8 string, always, and we don't need to assert that, it is expensive.
2020-09-28Fix some more wrong filter names.Martin Mathieson1-2/+2
These are duplicates detected seen by running check_typed_item_calls.py --consecutive. There are still quite a few more to go.
2020-08-30More spelling fixes, start of second pass of dissectors.Martin Mathieson1-1/+1
Now easier to find errors due to script improvements and more complete dictionary file.
2020-06-19Fix the type of arrays of pointers to hf_ values for bitfield routines.Guy Harris1-36/+36
The static arrays are supposed to be arrays of const pointers to int, not arrays of non-const pointers to const int. Fixing that means some bugs (scribbling on what's *supposed* to be a const array) will be caught (see packet-ieee80211-radiotap.c for examples, the first of which inspired this change and the second of which was discovered while testing compiles with this change), and removes the need for some annoying casts. Also make some of those arrays static while we're at it. Update documentation and dissector-generator tools. Change-Id: I789da5fc60aadc15797cefecfd9a9fbe9a130ccc Reviewed-on: https://code.wireshark.org/review/37517 Petri-Dish: Guy Harris <gharris@sonic.net> Tested-by: Petri Dish Buildbot Reviewed-by: Anders Broman <a.broman58@gmail.com>
2020-06-17ZigBee: Fix multiple wrong field type string in ZCL SE.Enrique Giraldo1-60/+17
Replacing FT_STRING with FT_UINT_STRING and removing length field where it existed. Change-Id: I5dc8b8ba472f161d604e4c157a9b0230694ea87a Reviewed-on: https://code.wireshark.org/review/37463 Reviewed-by: Kenneth Soerensen <knnthsrnsn@gmail.com> Petri-Dish: Anders Broman <a.broman58@gmail.com> Tested-by: Petri Dish Buildbot Reviewed-by: Anders Broman <a.broman58@gmail.com>
2020-04-04zbee_se: fix typ found by range_string checkingAlexis La Goutte1-1/+1
Notification Scheme (zbee_zcl_se.met.mirror_report_attribute_response.notification_scheme) hidden by earlier entry (prev="For MSP Requirements": 129 -> 255) (this="Reserved": 255 -> 255) Notification Scheme (zbee_zcl_se.met.configure_mirror.notification_scheme) hidden by earlier entry (prev="For MSP Requirements": 129 -> 255) (this="Reserved": 255 -> 255) Notification Scheme (zbee_zcl_se.met.configure_notification_scheme.notification_scheme) hidden by earlier entry (prev="For MSP Requirements": 129 -> 255) (this="Reserved": 255 -> 255) Notification Scheme (zbee_zcl_se.met.configure_notification_flags.notification_scheme) hidden by earlier entry (prev="For MSP Requirements": 129 -> 255) (this="Reserved": 255 -> 255) Notification Scheme (zbee_zcl_se.met.get_notified_msg.notification_scheme) hidden by earlier entry (prev="For MSP Requirements": 129 -> 255) (this="Reserved": 255 -> 255) Change-Id: If288052e7d02f6c4360f458e0496d9c05a245916 Reviewed-on: https://code.wireshark.org/review/36690 Petri-Dish: Anders Broman <a.broman58@gmail.com> Reviewed-by: Martin Mathieson <martin.r.mathieson@googlemail.com> Reviewed-by: Kenneth Soerensen <knnthsrnsn@gmail.com> Tested-by: Petri Dish Buildbot Reviewed-by: Anders Broman <a.broman58@gmail.com>
2019-08-20ZigBee OTA: Fix GetProfileResponse end time decodingMartin Boye Petersen1-1/+5
Added missing time offset to GetProfileResponse end time. Change-Id: I47f31cea709ccc600c9ea182c4bf6cf96410ff78 Reviewed-on: https://code.wireshark.org/review/34322 Reviewed-by: Kenneth Soerensen <knnthsrnsn@gmail.com> Reviewed-by: Alexis La Goutte <alexis.lagoutte@gmail.com> Petri-Dish: Alexis La Goutte <alexis.lagoutte@gmail.com> Tested-by: Petri Dish Buildbot Reviewed-by: Anders Broman <a.broman58@gmail.com>
2019-07-26HTTPS (almost) everywhere.Guy Harris1-1/+1
Change all wireshark.org URLs to use https. Fix some broken links while we're at it. Change-Id: I161bf8eeca43b8027605acea666032da86f5ea1c Reviewed-on: https://code.wireshark.org/review/34089 Reviewed-by: Guy Harris <guy@alum.mit.edu>
2019-06-11ZigBee: Improve dissection of PublishBillingPeriod, PublishBlockPeriodKenneth Soerensen1-55/+121
Change-Id: I34bda01c5c71819c885a06cd0a41bd5a5d9e67b7 Reviewed-on: https://code.wireshark.org/review/33558 Petri-Dish: Alexis La Goutte <alexis.lagoutte@gmail.com> Tested-by: Petri Dish Buildbot Reviewed-by: Anders Broman <a.broman58@gmail.com>
2019-05-05ZBEE ZCL: fix hf conflict.Alexis La Goutte1-1/+1
'zbee_zcl_se.drlc.report_event.signature_type' exists multiple times with NOT compatible types: FT_BYTES and FT_UINT8 Change-Id: I79bfd0178f46444a08f2350cddbc792ea480a173 Reviewed-on: https://code.wireshark.org/review/33075 Reviewed-by: Kenneth Soerensen <knnthsrnsn@gmail.com> Reviewed-by: Anders Broman <a.broman58@gmail.com>
2019-04-15ZigBee: Remove unused hfKenneth Soerensen1-5/+0
Change-Id: I744d0cfee7ca6a0256e8f651986a64556edac0eb Reviewed-on: https://code.wireshark.org/review/32864 Petri-Dish: Alexis La Goutte <alexis.lagoutte@gmail.com> Tested-by: Petri Dish Buildbot Reviewed-by: Alexis La Goutte <alexis.lagoutte@gmail.com>
2019-04-15ZigBee: Dissect Snapshot Payload Type namesKenneth Soerensen1-1/+1
Change-Id: I5897542d011d6ba9461b94387795206e358fbf88 Reviewed-on: https://code.wireshark.org/review/32863 Petri-Dish: Alexis La Goutte <alexis.lagoutte@gmail.com> Tested-by: Petri Dish Buildbot Reviewed-by: Alexis La Goutte <alexis.lagoutte@gmail.com>
2019-04-15ZigBee: Dissect Notification Scheme namesKenneth Soerensen1-6/+6
Change-Id: I6b8a43ebb66eace9f87fe1865403e03c1fe510ed Reviewed-on: https://code.wireshark.org/review/32859 Petri-Dish: Anders Broman <a.broman58@gmail.com> Tested-by: Petri Dish Buildbot Reviewed-by: Anders Broman <a.broman58@gmail.com>
2019-04-15ZigBee: Fix some -Wdocumentation issuesKenneth Soerensen1-2/+2
Change-Id: Iecf0d68086076cdb239050d9e064411fda59f662 Reviewed-on: https://code.wireshark.org/review/32853 Reviewed-by: Anders Broman <a.broman58@gmail.com>
2019-04-15ZigBee: Decode remaining commands in Metering ClusterKenneth Soerensen1-5/+130
Bug: 13360 Change-Id: I47fcbb97303e111f9ab52be709127198f0825704 Reviewed-on: https://code.wireshark.org/review/32850 Petri-Dish: Alexis La Goutte <alexis.lagoutte@gmail.com> Tested-by: Petri Dish Buildbot Reviewed-by: Martin Boye Petersen <martinboyepetersen@gmail.com> Reviewed-by: Anders Broman <a.broman58@gmail.com>
2019-03-13ZigBee: Decode Tariff Label as unicodeKenneth Soerensen1-1/+1
Change-Id: I2a7d24a15da196d95f7fc477e21719477f0382a8 Reviewed-on: https://code.wireshark.org/review/32388 Reviewed-by: Alexis La Goutte <alexis.lagoutte@gmail.com> Petri-Dish: Alexis La Goutte <alexis.lagoutte@gmail.com> Tested-by: Petri Dish Buildbot Reviewed-by: Anders Broman <a.broman58@gmail.com>
2019-03-13ZigBee: Rename variables to be consistentKenneth Soerensen1-6/+6
Change-Id: I1b0b3bd3c8e7e4111622e0035d3bd9027639b614 Reviewed-on: https://code.wireshark.org/review/32389 Reviewed-by: Alexis La Goutte <alexis.lagoutte@gmail.com> Petri-Dish: Alexis La Goutte <alexis.lagoutte@gmail.com> Tested-by: Petri Dish Buildbot Reviewed-by: Anders Broman <a.broman58@gmail.com>
2019-03-11ZBEE ZCL: updated Device Management Cluster dissection.Nikita Ryaskin1-21/+729
Implemented dissection for commands payload. Change-Id: I856ff2ad824d8b8b9df4b1d2121d64f8e2940e54 Reviewed-on: https://code.wireshark.org/review/32347 Reviewed-by: Kenneth Soerensen <knnthsrnsn@gmail.com> Petri-Dish: Anders Broman <a.broman58@gmail.com> Tested-by: Petri Dish Buildbot Reviewed-by: Anders Broman <a.broman58@gmail.com>
2019-03-04ZBEE ZCL: Fixed errors in dissectors.Nikita Ryaskin1-8/+8
Changed fields to correct. Fixed bug with encoding for tunneling fields. Change-Id: If2e48693b9174184aabaa1d3157982130460e6f6 Reviewed-on: https://code.wireshark.org/review/32310 Reviewed-by: Kenneth Soerensen <knnthsrnsn@gmail.com> Reviewed-by: Anders Broman <a.broman58@gmail.com>
2019-03-04ZBEE ZCL: updated Energy Management Cluster dissection.Nikita Ryaskin1-3/+323
Implemented commands payload dissectors. Change-Id: Ic1141cacf60754c97cb8e455d85e63239ecc7c79 Reviewed-on: https://code.wireshark.org/review/32307 Reviewed-by: Kenneth Soerensen <knnthsrnsn@gmail.com> Petri-Dish: Anders Broman <a.broman58@gmail.com> Tested-by: Petri Dish Buildbot Reviewed-by: Anders Broman <a.broman58@gmail.com>
2019-03-01ZBEE ZCL: updated ZCL DRLC Cluster dissection.Nikita Ryaskin1-11/+642
Implemented commands payload dissectors. Change-Id: Ie62c25c5efd8d41256eb92455d94985d5a3749af Reviewed-on: https://code.wireshark.org/review/32259 Reviewed-by: Kenneth Soerensen <knnthsrnsn@gmail.com> Petri-Dish: Anders Broman <a.broman58@gmail.com> Tested-by: Petri Dish Buildbot Reviewed-by: Alexis La Goutte <alexis.lagoutte@gmail.com>
2019-02-28ZBEE ZCL: updated ZCL Metering dissection.Nikita Ryaskin1-36/+229
Updated payload dissectors. Change-Id: Ia800bba9f0b0d747a0926afb9bd833b2f3dc3666 Reviewed-on: https://code.wireshark.org/review/32144 Reviewed-by: Anders Broman <a.broman58@gmail.com>
2019-02-06ZigBee: Be consistent and use ENC_NA for all 1 byte fieldsKenneth Soerensen1-33/+33
Change-Id: Ibd4ec7bef40e5e9a9ed87f1044dfff0f044a7d1f Reviewed-on: https://code.wireshark.org/review/31904 Petri-Dish: Anders Broman <a.broman58@gmail.com> Tested-by: Petri Dish Buildbot Reviewed-by: Anders Broman <a.broman58@gmail.com>
2019-02-05ZigBee: Dissect Metering cluster Request Fast Poll Mode ResponseKenneth Soerensen1-1/+31
Change-Id: I7a9ec5f992c0856469021e93db22bf3a68ca9c6d Reviewed-on: https://code.wireshark.org/review/31867 Petri-Dish: Anders Broman <a.broman58@gmail.com> Tested-by: Petri Dish Buildbot Reviewed-by: Anders Broman <a.broman58@gmail.com>
2019-02-05ZigBee: Dissect Metering cluster Schedule Snapshot ResponseKenneth Soerensen1-2/+50
Change-Id: Idde270ed14b3b874be08e24d9cad5a1473b7dec9 Reviewed-on: https://code.wireshark.org/review/31866 Petri-Dish: Anders Broman <a.broman58@gmail.com> Tested-by: Petri Dish Buildbot Reviewed-by: Anders Broman <a.broman58@gmail.com>
2019-02-04ZigBee: Dissect Metering cluster Get Profile ResponseKenneth Soerensen1-1/+60
Change-Id: Idb06af3cc350c2cf7000b7cbb1535c4102a23eb6 Reviewed-on: https://code.wireshark.org/review/31868 Petri-Dish: Alexis La Goutte <alexis.lagoutte@gmail.com> Tested-by: Petri Dish Buildbot Reviewed-by: Anders Broman <a.broman58@gmail.com>
2019-02-04ZigBee: Fix spellingKenneth Soerensen1-4/+4
Change-Id: Ia419438262ccc869d1b5771c76a73b5a6b0cf5df Reviewed-on: https://code.wireshark.org/review/31865 Reviewed-by: Alexis La Goutte <alexis.lagoutte@gmail.com> Petri-Dish: Alexis La Goutte <alexis.lagoutte@gmail.com> Tested-by: Petri Dish Buildbot Reviewed-by: Anders Broman <a.broman58@gmail.com>
2019-01-19ZigBee: Correct command names in Key-Establishment clusterKenneth Soerensen1-20/+30
Change-Id: I5c6a25bfc31160c722ddefb811cc3b1beeec772b Reviewed-on: https://code.wireshark.org/review/31594 Reviewed-by: Martin Boye Petersen <martinboyepetersen@gmail.com> Reviewed-by: Jaap Keuter <jaap.keuter@xs4all.nl> Petri-Dish: Jaap Keuter <jaap.keuter@xs4all.nl> Tested-by: Petri Dish Buildbot Reviewed-by: Anders Broman <a.broman58@gmail.com>
2018-12-05Fix some spelling errors found by Lintian.Gerald Combs1-11/+11
Change-Id: If6fc3aab7ad4fc634567121f7b9541bc6f6c5766 Reviewed-on: https://code.wireshark.org/review/30926 Reviewed-by: Gerald Combs <gerald@wireshark.org> Petri-Dish: Gerald Combs <gerald@wireshark.org> Tested-by: Petri Dish Buildbot Reviewed-by: Anders Broman <a.broman58@gmail.com>
2018-11-25[zigbee] add Daily Schedule (0x070d) cluster dissectorsNikolay Kovtun1-0/+519
Change-Id: I99b9b517ed534e4b9b7a148d384c55406174d024 Reviewed-on: https://code.wireshark.org/review/30771 Petri-Dish: Anders Broman <a.broman58@gmail.com> Tested-by: Petri Dish Buildbot Reviewed-by: Anders Broman <a.broman58@gmail.com>
2018-11-20ZigBee: Change time format to be consistent within ZigBee Smart EnergyKenneth Soerensen1-2/+2
Change-Id: I9e906afa46f4aebf115fd1eb15631032b5562389 Reviewed-on: https://code.wireshark.org/review/30741 Petri-Dish: Anders Broman <a.broman58@gmail.com> Reviewed-by: Martin Boye Petersen <martinboyepetersen@gmail.com> Tested-by: Petri Dish Buildbot Reviewed-by: Anders Broman <a.broman58@gmail.com>
2018-11-16ZigBee: Fixed incorrect field typeMartin Boye Petersen1-1/+1
Fixed incorrect field type for tariff label in publish tariff information. It is an zigbee octet string, so the first byte indicates the length of the string. Change-Id: Ia90e47a19a3bd1ca7642f5e7ce99377618198f15 Reviewed-on: https://code.wireshark.org/review/30663 Petri-Dish: Anders Broman <a.broman58@gmail.com> Tested-by: Petri Dish Buildbot Reviewed-by: Anders Broman <a.broman58@gmail.com>
generated by cgit v1.2.3 (git 2.25.1) at 2024-09-22 21:50:15 +0000