aboutsummaryrefslogtreecommitdiffstats
path: root/epan/dissectors/packet-x11.c
AgeCommit message (Collapse)AuthorFilesLines
2012-08-25cleanup some unnecessary g_malloc callsMichael Mann1-44/+9
svn path=/trunk/; revision=44662
2012-08-10Use val_to_str_const() where appropriate;Bill Meier1-1/+1
Also (for a few files): - create/use some extended value strings; - remove unneeded #include files; - remove unneeded variable initialization; - re-order fcns slightly so prefs_reg_handoff...() at end, etc svn path=/trunk/; revision=44438
2012-07-03Improve use of the value_string x11_keysym_vals_source[]:Bill Meier1-15/+32
- Compile the value_string only as part of packet-x11.c - Create a value_string_ext to ref the value_string; - packet_vnc.c: Access the value_string using the value_string_ext; - packet-x11.c: Access the value-string using the value_string_ext rather then building a temp GTree from the value_string. svn path=/trunk/; revision=43558
2012-06-28Update FSF address - part II.Jakub Zawadzki1-1/+1
svn path=/trunk/; revision=43538
2012-05-15Remove unneeded #includes (stdlib, stdio, ctypes, time);Bill Meier1-3/+2
In a few cases: do some whitespace, indentation cleanup & reformatting. svn path=/trunk/; revision=42632
2012-05-12"byte_order" is an encoding value, so it should be guint.Guy Harris1-6/+6
svn path=/trunk/; revision=42608
2012-05-12Fix a compile errorBill Meier1-1/+1
svn path=/trunk/; revision=42606
2012-05-12Get rid of remaining Booleans-as-encoding-arguments inGuy Harris1-171/+167
proto_tree_add_item() calls. Updated tools/process-x11-xcb.pl to support different encoding values for different fields. Replaced the "little_endian" Boolean value with a "byte_order" value containing the setting of the byte-order ENC_ bit. Regenerated X11 fields from current x.org git. svn path=/trunk/; revision=42601
2012-05-12hf_x11_keycodes is an FT_NONE; use ENC_NA with it.Guy Harris1-2/+2
svn path=/trunk/; revision=42595
2012-05-12string16_with_buffer_preallocated() takes a byte-order gboolean as itsGuy Harris1-1/+1
argument. svn path=/trunk/; revision=42594
2012-05-12Get rid of remaining Booleans-as-encoding-arguments inGuy Harris1-39/+46
proto_tree_add_item() calls. svn path=/trunk/; revision=42593
2011-10-21For proto_tree_add_item(..., proto_xxx, ...)use ENC_NA as the encoding arg.Bill Meier1-7/+7
Also: remove trailing whitespace for a number of files. svn path=/trunk/; revision=39503
2011-07-09If the reply length is < 32, that's an overflow, not a bug in theGuy Harris1-1/+3
dissector (unless you consider the calculation not being done in 64 bits as a bug). For now, toss a ReportedBoundsError. svn path=/trunk/; revision=37946
2011-06-19Fix gcc 4.6 "set but not used [-Wunused-but-set-variable]" warnings.Bill Meier1-2/+1
svn path=/trunk/; revision=37716
2011-05-27Use a non-volatile temporary variable as a parameter to DISSECTOR_ASSERT().Chris Maynard1-2/+8
This avoids an "assert with side effects" warning and resolves Coverity CID322. svn path=/trunk/; revision=37441
2011-05-27Fix a gcc 4.6 error: "variable might be clobbered by 'longjmp' or 'vfork' ↵Bill Meier1-1/+1
[-Werror=clobbered]" svn path=/trunk/; revision=37438
2011-03-25From Didier via https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=3055 :Jeff Morriss1-8/+15
Apply rev 25869 to most of the rest of the TCP-desegmenting dissectors. (The SSL dissector was already updated in one of two spots with bug 4535/rev 32456.) A couple of the patches had to be manually applied. From me: Fix the comments to match the change (including in the TCP and SSL dissectors.) svn path=/trunk/; revision=36332
2011-02-18Try to fix more Clang scan-build warnings.Gerald Combs1-2/+2
svn path=/trunk/; revision=36005
2010-12-20Rename the routines that handle dissector tables with unsigned integerGuy Harris1-5/+5
keys to have _uint in their names, to match the routines that handle dissector tables with string keys. (Using _port can confuse people into thinking they're intended solely for use with TCP/UDP/etc. ports when, in fact, they work better for things such as Ethernet types, where the binding of particular values to particular protocols are a lot stronger.) svn path=/trunk/; revision=35224
2010-12-14Minor cleanup:Bill Meier1-3418/+3418
- Initialize a few static global variables; - Remove two unnecessary calls to g_hash_table_foreach_remove; - Do whitespace cleanup and use consistent indentation; - Fix a few typos and fix up several comments. svn path=/trunk/; revision=35183
2010-05-18Use val_to_str() instead of match_strval() to ensure we get a non-NULL result.Jeff Morriss1-4/+3
svn path=/trunk/; revision=32877
2010-05-13As suggested in ↵Jeff Morriss1-19/+2
http://www.wireshark.org/lists/wireshark-dev/200809/msg00075.html (as referenced in https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=2907 ) and https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=3411 : Write a new convenience routine for finding a conversation and, if it is not found, create it. The frame number and addresses are taken from pinfo (as is the common case). Use this function in a bunch of dissectors. svn path=/trunk/; revision=32790
2010-04-21From Peter Harris via https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=4701 :Jeff Morriss1-2/+19
The ChangeProperty request always calls LISTofBYTE, which always tries to dissect at least one byte, even when the request is empty. This causes Wireshark to put a big, red, scary "Malformed Packet" entry in the dissection. Also, ChangeProperty only dissects (data_length) bytes. data_length is "number of units", and units may be 16 or 32-bit entities. In this case, the dissected data will be truncated. First reported in https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=4481#c10 The attached patch fixes these two bugs. svn path=/trunk/; revision=32526
2010-04-20From Peter Harris via https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=4481 :Jeff Morriss1-0/+14
The XKEYBOARD extension is a pain in the... so XCB had to grow new ways to describe the protocol. This patch adds support to the Wireshark dissector, so it can successfully process the XCB description of the XKEYBOARD extension. Without this patch, "make x11-dissector" chokes on the current xcbproto from git. Also update the script to deal with the new mesa directory structure. svn path=/trunk/; revision=32520
2010-04-03 From Yaniv Kaul: constify parametersBill Meier1-2/+2
https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=4422 From me: Fix a number of instances where the function prototype or the function definition wasn't changed so there was a mismatch thus causing Windows (but not gcc) compilation errors. svn path=/trunk/; revision=32365
2010-04-02Revert SVN #32360 until Windows compilation errors corrected.Bill Meier1-2/+2
svn path=/trunk/; revision=32361
2010-04-02From Yaniv Kaul: constify parametersBill Meier1-2/+2
https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=4422 svn path=/trunk/; revision=32360
2010-01-26Fix some gcc -Wshadow warningsBill Meier1-12/+14
svn path=/trunk/; revision=31673
2009-10-25From Jakub Zawadzki:Anders Broman1-4/+1
Cleanup dissector code - use proper memory functions. https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=4164 svn path=/trunk/; revision=30691
2009-09-11From Peter Harris via https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=2981 :Jeff Morriss1-28/+283
This patch adds extension support to the X11 dissector. I've removed the perl script from the make file, since the new one depends on perl 5.10, xcbproto (at least git as of today), and mesa (at least the mesa/src/mesa/glapi directory). It seemed easier to just add the generated header files to svn directly. svn path=/trunk/; revision=29854
2009-08-09Don't guard col_set_str (COL_INFO) with col_checkKovarththanan Rajaratnam1-5/+2
svn path=/trunk/; revision=29342
2009-08-09Don't guard col_set_str (COL_PROTOCOL) with col_checkKovarththanan Rajaratnam1-2/+1
svn path=/trunk/; revision=29340
2009-04-04tvbuff.[ch]: Accept more size_t's.Gerald Combs1-31/+14
packet-wcp.c: Add size_t casts. packet-x11.c: Use string buffers. svn path=/trunk/; revision=27959
2008-12-20Fix various typos and spelling errors (mostly in text strings)Bill Meier1-1/+1
svn path=/trunk/; revision=27065
2008-12-19Back out r27047 and r27053.Gerald Combs1-1/+1
svn path=/trunk/; revision=27062
2008-12-18Update calls to proto_tree_add_bytes_format to reflect r27047.Gerald Combs1-1/+1
svn path=/trunk/; revision=27053
2008-11-22From Peter (bug 2942):Stig Bjørlykke1-1/+1
Allow optimalization with -ftracer. svn path=/trunk/; revision=26822
2008-10-27From Tom Hughes:Jaap Keuter1-13/+51
The attached patch extends the X11 protocol dissector to decode the event contained in a SendEvent request. svn path=/trunk/; revision=26584
2008-10-24From Tom Hughes:Jaap Keuter1-0/+15
The attached patch extends the X11 protocol dissector to decode MappingNotify events. svn path=/trunk/; revision=26540
2008-10-18From Peter Harris:Jaap Keuter1-8/+12
The attached patch adds support for dissecting 'sent' events to the X11 dissector. svn path=/trunk/; revision=26488
2008-10-04Add safety against possible endless loop.Jaap Keuter1-1/+1
svn path=/trunk/; revision=26349
2008-09-26Minor cleanups related to proto_reg_handoffBill Meier1-3/+0
svn path=/trunk/; revision=26277
2008-03-17There are several g_malloc()'d things hanging off x11_conv_data_t's so don't ↵Jeff Morriss1-155/+161
se_ alloc that structure but rather g_malloc() it and free it after we've freed the contents. This fixes the X11 part of the crash from http://bugs.wireshark.org/bugzilla/show_bug.cgi?id=1113 svn path=/trunk/; revision=24666
2007-10-23Apply the small performance enhancment patches for:Anders Broman1-2/+2
- if offset is 0, tvb_length is the same as tvb_length_remaining, just faster. Replace - col_append_fstr() with faster col_append_str() - col_add_str() with col_set_str() when it's safe svn path=/trunk/; revision=23252
2007-04-23Just use -1 to go to the end of a tvbuff.Guy Harris1-3/+1
svn path=/trunk/; revision=21525
2007-03-26From Sebastien Tandel Ronnie Sahlberg1-6/+6
fixes for various compiler warnings svn path=/trunk/; revision=21210
2006-05-21change a whole bunch of ethereal into wiresharkRonnie Sahlberg1-3/+3
svn path=/trunk/; revision=18196
2006-02-27from dieder:Anders Broman1-1/+1
packet-x11 copy and past overlooked? test with 8 but substract to 4. svn path=/trunk/; revision=17420
2006-01-20packet-bgp.c: Fix incorrect use of g_snprintf return valueJörg Mayer1-12/+22
mp_addr_to_str was unnecessary 'complex' - simplified it packet-dns.c: Fix incorrect use of g_snprintf return value packet-dcm.c: Fix incorrect use of g_snprintf return value Someone who understands the protocol should look at the "vr, tr might be used uninitialized..." warning. packet-x11.c: Fix incorrect use of g_snprintf return value packet-kerberos.c: Fix incorrect use of g_snprintf return value Someone should take a look at the "longjump might clobber ..." messages packet-diameter.c: Fix incorrect use of g_snprintf return value Get rid of unsigned < 0 check packet-pgm.c: Fix incorrect use of g_snprintf return value packet-nbns.c: Fix incorrect use of g_snprintf return value packet-winsrepl.c: Collateral damage to packet-nbns.c fix packet-netbios.c: Collateral damage to packet-nbns.c fix packet-netbios.h: Collateral damage to packet-nbns.c fix packet-kerberos.c: Collateral damage to packet-nbns.c fix packet-nbipx.c: Collateral damage to packet-nbns.c fix svn path=/trunk/; revision=17065
2005-09-21fix #372: the bug raised a "division by zero" exception. I've add a check ↵Ulf Lamping1-1/+3
for this and simply replaced the expression with 0 in that case. Don't know if it's correct to do so, but fixes the exception at least :-) svn path=/trunk/; revision=15927
generated by cgit v1.2.3 (git 2.25.1) at 2024-07-01 02:03:36 +0000