aboutsummaryrefslogtreecommitdiffstats
path: root/epan/dissectors/packet-windows-common.c
AgeCommit message (Collapse)AuthorFilesLines
2005-10-04Don't ensure all the bytes of a security descriptor exist before callingGuy Harris1-23/+90
"dissect_nt_sec_desc()". Add a Boolean argument to "dissect_nt_sec_desc()" to indicate whether a length was passed to it (so we don't treat -1 as a special value; we want to stop treating -1 as a special length value, and, in fact, want to stop treating *any* negative length values specially, so that we don't have to worry about passing arbitrary 32-bit values from packets as lengths), and have "dissect_nt_sec_desc()" initially create the protocol tree item for the security descriptor with a length of "go to the end of the tvbuff", and set the length once we're done dissecting it - and, if the length was specified, check at *that* point, *after* we've dissected the security descriptor, whether we have the entire security descriptor in the tvbuff. That means that we don't have to worry about overflows after "dissect_nt_sec_desc()" returns - if the length was so large that we would have gotten an overflow, we'd have thrown an exception in the "tvb_ensure_bytes_exist()" call at the end of "dissect_nt_sec_desc()". Do sanity checks on offsets within the security descriptor, so we know the item referred to by the offset is after the fixed-length portion of the descriptor. svn path=/trunk/; revision=16113
2005-09-17Move some headers for stuff defined by a dissector into epan/dissectorsGuy Harris1-1/+1
- and rename smb.h to packet-smb.h, as it's packet-smb.c's header file. svn path=/trunk/; revision=15845
2005-09-17Move a pile of protocol-related headers from the top-level sourceGuy Harris1-1/+1
directory to the epan directory. Some of them should perhaps ultimately be moved to epan/dissectors, if they pertain only to stuff exported by a particular dissector. Fix Gerald's e-mail address in files we're moving. svn path=/trunk/; revision=15844
2005-08-30change one g_string_sprintf() into g_snprintf() and move one array of ↵Ronnie Sahlberg1-17/+12
characters from the stack into emem allocated memory svn path=/trunk/; revision=15617
2005-08-05More char -> const char warning fixesJörg Mayer1-1/+1
svn path=/trunk/; revision=15222
2005-06-26Yet more constification.Guy Harris1-2/+2
svn path=/trunk/; revision=14788
2005-06-01bugfix: use g_snprintf instead of sprintf to prevent a buffer overflowUlf Lamping1-2/+2
svn path=/trunk/; revision=14515
2005-01-30add dissection of three new flags in the security descriptorRonnie Sahlberg1-0/+33
svn path=/trunk/; revision=13210
2004-12-30Update a URL.Guy Harris1-1/+1
svn path=/trunk/; revision=12864
2004-12-25Again, some warnings removed.Ulf Lamping1-1/+1
svn path=/trunk/; revision=12831
2004-12-22Check for all bogus ACE lengths, i.e. all lengths < 4.Guy Harris1-8/+39
Clean up indentation. Add a comment asking whether the revision in an ACL is *really* 2 bytes and the ACE count is *really* 4 bytes. svn path=/trunk/; revision=12816
2004-12-09From Brian Caswell:Gerald Combs1-16/+16
The ACL parser will attempt to decode as many ACE structures as are specified in the ACL structure. If the number of ACE structures is sufficiently large with one of the ACE structures specifying a size of 0, then the ACL parser will parse that ACE structure repeatedly, eventually causing a denial of service to Ethereal. I've attached a diff against HEAD that corrects the problem. The diff also corrects a few decoding errors in the NT ACL & ACE structures. A pcap is attached that reproduces the problem. svn path=/trunk/; revision=12706
2004-08-19MSVC++ doesn't understand that "64_bit_integer % 10000000" fits in anGuy Harris1-1/+1
"int", so we throw in a cast to squelch a warning. svn path=/trunk/; revision=11774
2004-08-19Use "G_GINT64_CONSTANT()" for 64-bit integral constants, rather thanGuy Harris1-1/+1
hardwiring "LL" as the suffix - it's not "LL" in MSVC++. svn path=/trunk/; revision=11773
2004-08-16Don't do the FILETIME->nstime_t conversion in floating point, as itGuy Harris1-13/+18
produces some floating-point noise in the nanoseconds field; we've required 64-bit integer support for a while, so use that. svn path=/trunk/; revision=11754
2004-08-16cast define of TIME_T_MIN and TIME_T_MAX to (time_t), as MSVC seems to have ↵Ulf Lamping1-3/+3
problems with this definition and throws a warning "convert negative constant to unsigned integer" svn path=/trunk/; revision=11753
2004-08-03Move a bunch of stuff that's more Windows-related than SMB-related toGuy Harris1-0/+2332
"packet-windows-common.[ch]". svn path=/trunk/; revision=11592
generated by cgit v1.2.3 (git 2.25.1) at 2024-07-05 04:52:38 +0000