aboutsummaryrefslogtreecommitdiffstats
path: root/epan/dissectors/packet-wbxml.c
AgeCommit message (Collapse)AuthorFilesLines
2015-08-10Eliminate proto_tree_add_text from packet-wbxml.cMichael Mann1-1236/+756
While I was at it, some (mostly) duplicate functionality allowed rearranging of functions to eliminate most forward declarations. Change-Id: I2d7027d336c391d81dfe81c7a1ebf0d56c0826b2 Reviewed-on: https://code.wireshark.org/review/9951 Reviewed-by: Michael Mann <mmann78@netscape.net> Petri-Dish: Michael Mann <mmann78@netscape.net> Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org> Reviewed-by: Anders Broman <a.broman58@gmail.com>
2014-12-25Deleting unnecessary #includes from dissectors.Martin Mathieson1-1/+0
Fifth batch (packet-rtp.c -> end). Will look at cleaning up and committing script afterwards. Change-Id: I8ed61dc941d98d3f7259a9d1f74e214eb7b4bfa2 Reviewed-on: https://code.wireshark.org/review/6052 Reviewed-by: Martin Mathieson <martin.r.mathieson@googlemail.com>
2014-12-21Cleanup use of #includes in non-generated epan/dissector/*.cBill Meier1-4/+0
Specifically: - Set packet.h to be the first wireshark #include after config.h and "system" #includes. packet.h added as an #include in some cases when missing. - Remove some #includes included (directly/indirectly) in packet.h. E.g., glib.h. (Done only for those files including packet.h). - As needed, move "system" #includes to be after config.h and before wireshark #includes. - Rework various #include file specifications for consistency. - Misc. Change-Id: Ifaa1a14b50b69fbad38ea4838a49dfe595c54c95 Reviewed-on: https://code.wireshark.org/review/5923 Petri-Dish: Alexis La Goutte <alexis.lagoutte@gmail.com> Reviewed-by: Bill Meier <wmeier@newsguy.com>
2014-10-06Adjust indentation to match editor modelines; Do other minor whitespace changes.Bill Meier1-1/+1
Change-Id: Ic020b2c92db5d14a2be9dc4d35aef4514b8b0353 Reviewed-on: https://code.wireshark.org/review/4502 Reviewed-by: Bill Meier <wmeier@newsguy.com>
2014-07-06convert to proto_tree_add_subtree[_format]Michael Mann1-3/+2
Change-Id: I3efa2a81ab2685cde6eae0a00b24520478a545ce Reviewed-on: https://code.wireshark.org/review/2900 Reviewed-by: Michael Mann <mmann78@netscape.net>
2014-03-04Remove all $Id$ from top of fileAlexis La Goutte1-2/+0
(Using sed : sed -i '/^ \* \$Id\$/,+1 d') Fix manually some typo (in export_object_dicom.c and crc16-plain.c) Change-Id: I4c1ae68d1c4afeace8cb195b53c715cf9e1227a8 Reviewed-on: https://code.wireshark.org/review/497 Reviewed-by: Anders Broman <a.broman58@gmail.com>
2013-12-15Fix [-Wmissing-prototypes]Jakub Zawadzki1-3/+2
svn path=/trunk/; revision=54135
2013-12-14Fix const warnings.Jakub Zawadzki1-2/+2
svn path=/trunk/; revision=54092
2013-11-10Add missing includes in order to remove exceptions.h from proto.h (next commit).Jakub Zawadzki1-0/+1
svn path=/trunk/; revision=53230
2013-09-12emem -> wmemJörg Mayer1-41/+41
"tshark -v" tested svn path=/trunk/; revision=51988
2013-06-14Remove check_col() and the occasional tree.Michael Mann1-4/+2
svn path=/trunk/; revision=49923
2013-03-29Rename value string (and similar) functions to use a consistent pattern. ThisEvan Huus1-1/+1
was done using textual search+replace, not anything syntax-aware, so presumably it got most comments as well (except where there were typos). Use a consistent coding style, and make proper use of the WS_DLL_* defines. Group the functions appropriately in the header. I ended up getting rid of most of the explanatory comments since many of them duplicated what was in the value_string.c file (and were out of sync with the recent updates I made to those in r48633). Presumably most of the comments should be in the .h file not the .c file, but there's enough churn ahead that it's not worth fixing yet. Part of https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=8467 svn path=/trunk/; revision=48634
2013-02-01Fix some Dead Store (Dead assignement/Dead increment) Warning found by ClangAlexis La Goutte1-1/+1
svn path=/trunk/; revision=47426
2012-12-10Re-generate value_string array for MIBenum mapping char set names from ↵Bill Meier1-74/+74
latest IANA document; Adds new values and fixes an incorrect value in the previous value_string array. Note: names used as specified (with capitalization) in the document. (Previously all the names in the value_string array were lower case). Also: rename the value_string array to have a less generic name. svn path=/trunk/; revision=46490
2012-09-20We always HAVE_CONFIG_H so don't bother checking whether we have it or not.Jeff Morriss1-3/+1
svn path=/trunk/; revision=45017
2012-08-14convert g_strdup_printf() to ep_strdup_printf()Michael Mann1-43/+39
svn path=/trunk/; revision=44490
2012-06-28Update FSF address - part II.Jakub Zawadzki1-1/+1
svn path=/trunk/; revision=43538
2012-06-08From Stefan Hoffmeister:Anders Broman1-234/+523
ActiveSync WBXML CodeSpace updated to match official documentation. https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=7345 svn path=/trunk/; revision=43151
2012-05-15Remove unneeded #includes (stdlib, stdio, ctypes, time);Bill Meier1-3/+0
In a few cases: do some whitespace, indentation cleanup & reformatting. svn path=/trunk/; revision=42632
2011-10-21For proto_tree_add_item(..., proto_xxx, ...)use ENC_NA as the encoding arg.Bill Meier1-2/+2
Also: remove trailing whitespace for a number of files. svn path=/trunk/; revision=39503
2011-10-15Convert proto_tree_add_item() 'encoding' arg for field types FT_STRING, ↵Bill Meier1-1/+1
FT_STRINGZ, FT_UINT_STRING as follows: 1. If there's no character encoding (ENC_ASCII, ...) specified then use ENC_ASCII. 2. For all but FT_UINT_STRING, always use ENC_NA (replacing any existing True/1/FALSE/0 /ENC_BIG_ENDIAN/ENC_LITTLE_ENDIAN). svn path=/trunk/; revision=39426
2011-09-21Fix ex "modeline" so it works;Bill Meier1-1/+1
See https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=5748 svn path=/trunk/; revision=39081
2011-01-16There's no need to pass the result of tvb_get_ptr() as the 'value' inJeff Morriss1-7/+4
proto_tree_add_*(): just use proto_tree_add_item(). Replace some tvb_get_ptr()s with tvb_get_ephemeral_string() or tvb_get_const_stringz(). Use tvb_memeql() & tvb_memcmp(). svn path=/trunk/; revision=35558
2010-11-04Use value_string_ext fcns to access certain value_string arrays;Bill Meier1-1/+2
Sort certain value_string arrays to be in ascending numeric order; Do minor whitespace cleanup and reformatting of long lines. svn path=/trunk/; revision=34780
2010-11-03Use value_string_ext fcns to access certain value_string arrays;Bill Meier1-11/+14
Some whitespace cleanup. svn path=/trunk/; revision=34763
2010-01-26Fix some gcc -Wshadow warningsBill Meier1-48/+48
svn path=/trunk/; revision=31673
2009-11-09Removed an unused assignment.Stig Bjørlykke1-1/+1
svn path=/trunk/; revision=30889
2009-10-25From Jakub Zawadzki:Anders Broman1-4/+2
Cleanup dissector code - use proper memory functions. https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=4164 svn path=/trunk/; revision=30691
2009-08-05Fix for bug 3811:Jaap Keuter1-0/+6
Add missing shorthand application/vnd.ms-sync besides application/vnd.ms-sync.wbxml. svn path=/trunk/; revision=29306
2008-09-30Minor proto_reg_handoff cleanup: use find_dissector when appropriate.Bill Meier1-1/+1
svn path=/trunk/; revision=26308
2008-09-02Fix a few Emacs "file variables" to have "safe" values.Bill Meier1-1/+1
That is: indent-tabs-mode: tabs --> indent-tabs-mode: t Also: fix a typo: set-tabs-mode --> indent-tabs-mode svn path=/trunk/; revision=26113
2008-08-11From Darryl Champagne:Anders Broman1-0/+578
Add SyncML 1.2, and ActiveSync support to packet-wbxml. svn path=/trunk/; revision=25984
2008-06-27If we find an invalid version number, at least put something into theGuy Harris1-2/+7
Info column and protocol tree to indicate that. If we find an invalid version number in the *second* switch statement, don't bother spewing out a warning - that's a "cannot happen", so just throw a dissector assertion. svn path=/trunk/; revision=25621
2008-06-27Fix some checkAPIs warnings.Gerald Combs1-1/+1
svn path=/trunk/; revision=25617
2008-04-09Remove:Anders Broman1-3/+0
#ifdef NEED_G_ASCII_STRCASECMP_H #include "g_ascii_strcasecmp.h" #endif svn path=/trunk/; revision=24859
2008-02-07Removed some "statement not reached" warnings.Stig Bjørlykke1-2/+0
svn path=/trunk/; revision=24282
2007-12-15Get rid of another non-ASCII character.Guy Harris1-1/+1
svn path=/trunk/; revision=23877
2007-11-27strcasecmp(), strncasecmp(), g_strcasecmp(), and g_strncasecmp() delendaGuy Harris1-1/+5
est. Use g_ascii_strcasecmp() and g_ascii_strncasecmp(), and supply our own versions if they're missing from GLib (as is the case with GLib 1.x). In the code to build the list of named fields for Diameter, don't use g_strdown(); do our own g_ascii_-style upper-case to lower-case mapping in the hash function and use g_ascii_strcasecmp() in the compare function. We do this because there is no guarantee that toupper(), tolower(), and functions that use them will, for example, map between "I" and "i" in all locales; in Turkish locales, for example, there are, in both upper case and lower case, versions of "i" with and without a dot, and the upper-case version of "i" is "I"-with-a-dot and the lower-case version of "I" is "i"-without-a-dot. This causes strings that should match not to match. This finishes fixing bug 2010 - an earlier checkin prevented the crash (as there are other ways to produce the same crash, e.g. a bogus dictionary.xml file), but didn't fix the case-insensitive string matching. svn path=/trunk/; revision=23623
2007-11-26Get rid of C++/C99 style comments--not all compilers support themJeff Morriss1-146/+146
svn path=/trunk/; revision=23608
2007-10-05From Andrei Rubaniuk:Stig Bjørlykke1-1483/+2585
This patch adds support for IMPS 1.3 protocol dissection and also updates IMPS 1.2 protocol to approved release version. From me: - Updated vals_wbxml_public_ids table. - Reindented file. svn path=/trunk/; revision=23078
2007-03-26From Sebastien Tandel Ronnie Sahlberg1-82/+87
fixes for various compiler warnings svn path=/trunk/; revision=21210
2006-10-25From Stephen FisherJaap Keuter1-1/+1
Attached is a patch to fix bug #1170: "Wireshark interpretation of WBXML does not comply with Spec." This has been verified with the sample capture the user provided. svn path=/trunk/; revision=19681
2006-10-16Make sure a value is non-null before we feed it to strcmp(). Fixes bugGerald Combs1-56/+56
1134. svn path=/trunk/; revision=19560
2006-05-21change a whole bunch of ethereal into wiresharkRonnie Sahlberg1-3/+3
svn path=/trunk/; revision=18196
2005-11-01Use g_print() instead of fprintf() to write messages to the debug console.Olivier Biot1-3/+2
svn path=/trunk/; revision=16373
2005-09-22bugfix: don't crash, if tag_save_literal == NULLUlf Lamping1-2/+2
svn path=/trunk/; revision=15968
2005-08-20sprintf removalsRonnie Sahlberg1-4/+7
svn path=/trunk/; revision=15459
2005-08-02Fix more "no previous declaration" warningsJörg Mayer1-18/+18
svn path=/trunk/; revision=15169
2005-06-10just to get things straight: a dissector should *never* do any g_assert() calls!Ulf Lamping1-1/+1
in a simple approach, I've replaced all g_assert() and g_assert_not_reached() calls by their exception throwing counterparts DISSECTOR_ASSERT() and DISSECTOR_ASSERT_NOT_REACHED() this will replace application crash by showing a dissector bug, which is the desired behaviour there were some g_assert calls in the protocol registering functions, which might not be acting as expected now, but to be able to simply search for g_assert in the future I've replaced that calls too one g_assert remained, the one when someone throws an unknown exception "into" packet_frame.c, but IMHO this one should remain. svn path=/trunk/; revision=14608
2005-06-02bugfix: don't use match_strval() in combination with format strings (as it ↵Ulf Lamping1-5/+5
may return NULL) but val_to_str() I don't know if the output as hex is appropriate, someone with more WBXML knowledge might have a look (however, it's done for unknown values only) svn path=/trunk/; revision=14522