aboutsummaryrefslogtreecommitdiffstats
path: root/epan/dissectors/packet-vnc.c
AgeCommit message (Collapse)AuthorFilesLines
2013-09-22emem -> wmem conversion:Pascal Quantin1-6/+6
- ep_tvb_get_bits() -> wmem_packet_tvb_get_bits() - tvb_g_memdup()/ep_tvb_memdup() -> tvb_memdup() - tvb_fake_unicode()/tvb_get_ephemeral_faked_unicode() -> tvb_get_faked_unicode() - tvb_get_g_string()/tvb_get_ephemeral_string()/tvb_get_seasonal_string() -> tvb_get_string() - tvb_get_g_unicode_string()/tvb_get_ephemeral_unicode_string() -> tvb_get_unicode_string() - tvb_get_ephemeral_string_enc() -> tvb_get_string_enc() - update docs accordingly svn path=/trunk/; revision=52172
2013-09-12Add missing includesJörg Mayer1-3/+3
Remove not needed include emem -> wmem svn path=/trunk/; revision=51984
2013-09-09expert_add_info_format_text -> expert_add_info_formatMichael Mann1-4/+4
svn path=/trunk/; revision=51852
2013-07-30From Roman DontschenkoMartin Kaiser1-10/+99
VNC: Add Apple Remote Desktop authentication support https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=8992 svn path=/trunk/; revision=51038
2013-07-05Batch of filterable expert infos.Michael Mann1-19/+40
svn path=/trunk/; revision=50384
2013-06-30Add a cast to squelch a warning.Jeff Morriss1-2/+2
svn path=/trunk/; revision=50267
2013-06-30Fix up a mixup of the declaration of hf_vnc_auth_error_length andJeff Morriss1-2/+2
hf_vnc_auth_error. svn path=/trunk/; revision=50264
2013-06-30From Matthias Benesch via ↵Jeff Morriss1-18/+1102
https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=8869 : This patch adds dissection of the following VNC extensions: - MirrorLink messages (http://mirrorlink.com/) - Context Information pseudo encoding (http://mirrorlink.com/) - Scan Line based Run-Length encoding (http://mirrorlink.com/) - LibVNCServer additions (http://libvncserver.sourceforge.net/) - H.264 encoding From me: fix encoding arguments. svn path=/trunk/; revision=50263
2013-06-14Remove check_col() and the occasional tree.Michael Mann1-4/+2
svn path=/trunk/; revision=49923
2013-05-12Add the posibillity to use a key for per-packet-data.Anders Broman1-8/+8
svn path=/trunk/; revision=49259
2013-03-18From beroset:Anders Broman1-10/+10
remove C++ incompatibilities https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=8416 svn path=/trunk/; revision=48400
2012-12-26OK, see if not using an enum gets rid of "implicit conversion shortensGuy Harris1-58/+56
64-bit value to 32 bits" warnings on 32-bit compilers. According to 6.1.3.3 "Enumeration constants" of C90, "An identifier declared as an enumeration constant has type int", so there may be signed vs. unsigned issues. svn path=/trunk/; revision=46772
2012-10-11Change 'for (i=1; i<=n;...' to 'for (i=0; i<n; ...)Bill Meier1-12/+12
The changes fix definite problems or are done "just in case" for cases not esily determined to be a problem by quick inspection. Note: in some cases for loop index variables have been renamed to ensure all required codes changes detected. ##backport svn path=/trunk/; revision=45477
2012-09-20We always HAVE_CONFIG_H so don't bother checking whether we have it or not.Jeff Morriss1-3/+1
svn path=/trunk/; revision=45017
2012-09-10Initial commit to support yet another method of passing data between dissectors.Jakub Zawadzki1-1/+1
Add new parameter 'data' to heur_dissector_t and new_dissector_t, for now it's always NULL svn path=/trunk/; revision=44860
2012-07-19Fixes https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=5469. Added more ↵Michael Mann1-41/+72
comments to make the function of vnc_is_client_or_server_version_message() very clear. Also includes some minor cleanup of proto_tree_add_text -> proto_tree_add_item svn path=/trunk/; revision=43814
2012-07-03Improve use of the value_string x11_keysym_vals_source[]:Bill Meier1-3/+3
- Compile the value_string only as part of packet-x11.c - Create a value_string_ext to ref the value_string; - packet_vnc.c: Access the value_string using the value_string_ext; - packet-x11.c: Access the value-string using the value_string_ext rather then building a temp GTree from the value_string. svn path=/trunk/; revision=43558
2012-06-28Update FSF address - part II.Jakub Zawadzki1-1/+1
svn path=/trunk/; revision=43538
2012-03-16FT_BOOLEAN hf[] entries with a 0 'bitmask' should have 'display' = BASE_NONE;Bill Meier1-27/+27
In some cases: Use val_to_str_const() instead of val_to_str(); Reformat long lines; Do some general whitespace changes. svn path=/trunk/; revision=41587
2011-11-09Fix a number of proto_tree_add_item() encoding args.Bill Meier1-1/+1
svn path=/trunk/; revision=39774
2011-11-01Remove comma at the end of several enumerator lists.Jeff Morriss1-2/+2
svn path=/trunk/; revision=39700
2011-10-24Fix encoding arg for various fcn calls:Bill Meier1-6/+6
- proto_tree_add_bits_item - proto_tree_add_bits_ret_val - proto_tree_add_bitmask - tvb_get_bits - tvb_get_bits16 - tvb_get_bits24 - tvb_get_bits32 - tvb_get_bits64 svn path=/trunk/; revision=39539
2011-10-21For proto_tree_add_item(..., proto_xxx, ...)use ENC_NA as the encoding arg.Bill Meier1-1/+1
Also: remove trailing whitespace for a number of files. svn path=/trunk/; revision=39503
2011-10-16Do some conversions of proto_tree_add_item() 'encoding' arg.Bill Meier1-31/+31
(previously missed). 57 FT_BOOLEAN: FALSE-->ENC_BIG_ENDIAN 31 FT_BOOLEAN: TRUE-->ENC_LITTLE_ENDIAN 10 FT_BYTES: ENC_BIG_ENDIAN-->ENC_NA 1 FT_BYTES: ENC_LITTLE_ENDIAN-->ENC_NA 21 FT_BYTES: FALSE-->ENC_NA 2 FT_BYTES: TRUE-->ENC_NA 2 FT_IPXNET: ENC_BIG_ENDIAN-->ENC_NA 6 FT_IPv6: ENC_BIG_ENDIAN-->ENC_NA 1 FT_IPv6: FALSE-->ENC_NA 6 FT_NONE: ENC_BIG_ENDIAN-->ENC_NA 19 FT_NONE: FALSE-->ENC_NA 3 FT_NONE: TRUE-->ENC_NA 1 FT_STRING: ENC_BIG_ENDIAN-->ENC_ASCII|ENC_NA 1 FT_STRING: ENC_LITTLE_ENDIAN-->ENC_ASCII|ENC_NA 5 FT_STRING: FALSE-->ENC_ASCII|ENC_NA 1 FT_STRING: TRUE-->ENC_ASCII|ENC_NA 4 FT_STRINGZ: ENC_NA-->ENC_ASCII|ENC_NA 8 FT_STRINGZ: FALSE-->ENC_ASCII|ENC_NA 1 FT_INT32: FALSE-->ENC_BIG_ENDIAN 1 FT_INT32: TRUE-->ENC_LITTLE_ENDIAN 11 FT_UINT8: 0-->ENC_BIG_ENDIAN 111 FT_UINT8: FALSE-->ENC_BIG_ENDIAN 17 FT_UINT8: TRUE-->ENC_LITTLE_ENDIAN 1 FT_UINT16: 0-->ENC_BIG_ENDIAN 68 FT_UINT16: FALSE-->ENC_BIG_ENDIAN 18 FT_UINT16: TRUE-->ENC_LITTLE_ENDIAN 4 FT_UINT24: FALSE-->ENC_BIG_ENDIAN 70 FT_UINT32: FALSE-->ENC_BIG_ENDIAN 1 FT_UINT32: TRUE-->ENC_LITTLE_ENDIAN 4 FT_UINT64: FALSE-->ENC_BIG_ENDIAN 1 FT_UINT64: TRUE-->ENC_LITTLE_ENDIAN 1 FT_UINT_STRING: FALSE-->ENC_ASCII|ENC_BIG_ENDIAN svn path=/trunk/; revision=39442
2011-10-15Convert proto_tree_add_item() 'encoding' arg for field types FT_STRING, ↵Bill Meier1-6/+6
FT_STRINGZ, FT_UINT_STRING as follows: 1. If there's no character encoding (ENC_ASCII, ...) specified then use ENC_ASCII. 2. For all but FT_UINT_STRING, always use ENC_NA (replacing any existing True/1/FALSE/0 /ENC_BIG_ENDIAN/ENC_LITTLE_ENDIAN). svn path=/trunk/; revision=39426
2011-10-10 Convert 'encoding' parameter of certain proto_tree_add_item() calls in ↵Bill Meier1-11/+11
non-autogenerated epan/dissectors: Specifically: Replace FALSE|0 and TRUE|1 by ENC_BIG_ENDIAN|ENC_LITTLE_ENDIAN as the encoding parameter for proto_tree_add_item() calls which directly reference an item in hf[] which has a type of: FT_BOOLEAN FT_IPv4 FT_EUI64 FT_GUID FT_UINT_STRING Also: For type FT_ITv6 use ENC_NA. (This was missed in SVN #39260) svn path=/trunk/; revision=39328
2011-10-06Convert 'encoding' parameter of certain proto_tree_add_item() calls in ↵Bill Meier1-62/+62
non-autogenerated epan/dissectors: Specifically: Replace FALSE|0 and TRUE|1 by ENC_BIG_ENDIAN|ENC_LITTLE_ENDIAN as the encoding parameter for proto_tree_add_item() calls which directly reference an item in hf[] which has a type of: FT_UINT8 FT_UINT16 FT_UINT24 FT_UINT32 FT_UINT64 FT_INT8 FT_INT16 FT_INT24 FT_INT32 FT_INT64 FT_FLOAT FT_DOUBLE svn path=/trunk/; revision=39288
2011-10-04Use ENC_NA as encoding for proto_tree_add_item() calls which directly ↵Bill Meier1-25/+25
reference an hf item (in hf[] with types: FT_NONE FT_BYTES FT_IPV6 FT_IPXNET FT_OID Note: Encoding field set to ENC_NA only if the field was previously TRUE|FALSE|ENC_LITTLE_ENDIAN|ENC_BIG_ENDIAN svn path=/trunk/; revision=39260
2011-04-22Don't create a subtree that is not used.Jeff Morriss1-4/+2
svn path=/trunk/; revision=36808
2011-03-28Cast to guint to avoid a Windows compiler warning.Chris Maynard1-1/+1
svn path=/trunk/; revision=36389
2011-03-28Fix for bug #4334 "VNC Hextile encoding is incomplete" from Yaniv Kaul.Stephen Fisher1-82/+103
svn path=/trunk/; revision=36386
2011-03-25Fix coverity 268, 269, 546, 547, 548, 549 by checking for null returnStephen Fisher1-6/+15
from p_get_proto_data() since it should have been set already by the calling function. Any other case would be a bug, so call DISSECTOR_ASSERT in those cases. Hopefully Coverity realizes that this is a null return value check. svn path=/trunk/; revision=36337
2011-02-21From Yaniv Kaul:Jaap Keuter1-3/+82
This one parses the extended desktop size pseudo-encoding, as specified in http://www.tigervnc.com/cgi-bin/rfbproto#extendeddesktopsize-pseudo-encoding svn path=/trunk/; revision=36022
2010-12-20Rename the routines that handle dissector tables with unsigned integerGuy Harris1-6/+6
keys to have _uint in their names, to match the routines that handle dissector tables with string keys. (Using _port can confuse people into thinking they're intended solely for use with TCP/UDP/etc. ports when, in fact, they work better for things such as Ethernet types, where the binding of particular values to particular protocols are a lot stronger.) svn path=/trunk/; revision=35224
2010-11-19Verify the number of rectangles, sub-rectangles, the number of bytes of cutJeff Morriss1-75/+103
text, etc. are "sane" before: 1) requesting enough bytes (from reassembly) to dissect them all 2) (and) attempting to add them all to the tree Request all the bytes we'll need to dissect all those rectangles/sub-rectangles before starting dissection rather than checking before dissecting each rectangle/sub-rectangle. Use tvb_get_ephemeral_string(). Use _U_ to mark unused arguments. Fix up some indentation. Get rid of one more DISSECTOR_ASSERT. svn path=/trunk/; revision=34977
2010-11-19From Yaniv Kaul via https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=5366 :Jeff Morriss1-51/+109
Several fixes that make Tight VNC negotiation properly parsed. It was not parsed correctly previously, for multiple reasons. svn path=/trunk/; revision=34976
2010-09-23Replace blurbs that match the name (case insensitive) with NULL.Jeff Morriss1-1/+1
svn path=/trunk/; revision=34227
2010-05-13As suggested in ↵Jeff Morriss1-109/+100
http://www.wireshark.org/lists/wireshark-dev/200809/msg00075.html (as referenced in https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=2907 ) and https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=3411 : Write a new convenience routine for finding a conversation and, if it is not found, create it. The frame number and addresses are taken from pinfo (as is the common case). Use this function in a bunch of dissectors. svn path=/trunk/; revision=32790
2010-02-13From Yaniv Kaul: minor changes + smallest additionsBill Meier1-200/+282
See: https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=4339#c5 From Me: - Use VNC_... as the initial part of various enum identifiers to ensure that they are unique since they are part of the global namespace; - Fix some indentatiom; svn path=/trunk/; revision=31876
2010-01-08Remove unneeded #includes.Bill Meier1-4/+0
svn path=/trunk/; revision=31465
2010-01-07From Yaniv Kaul: VNC dissector cleanups and minor changes.Bill Meier1-96/+110
From me: Several fixes to the patch and some additional cleanup. svn path=/trunk/; revision=31464
2009-12-15Fix a number of copy & paste errors introduced over various checkins andStephen Fisher1-8/+8
change duplicated filter names used for different purposes by inserting another word to differentiate between them. svn path=/trunk/; revision=31274
2009-12-15From Yaniv Kaul:Jaap Keuter1-8/+16
Attached patch fixes the dissection of the Set Colormap Entries server message. It was at least off-by-one to start with, and the dissection went a bit wrong from there on. svn path=/trunk/; revision=31273
2009-12-12From Yaniv Kaul:Jaap Keuter1-22/+45
VNC dissector fails to dissect properly the authentication used by the older VNC protocol. Specifically, the part about version 3.3 in section 6.2 of the protocol was ignored / not properly implemented. svn path=/trunk/; revision=31250
2009-11-17Remove the address operator from value_string arrays fed to VALS()Gerasimos Dimitriadis1-8/+8
svn path=/trunk/; revision=30995
2009-09-24* Prefer col_append_str instead of col_append_fstr for constant stringsKovarththanan Rajaratnam1-2/+1
* Remove check_col guards svn path=/trunk/; revision=30127
2009-08-09Don't guard col_set_str (COL_INFO/COL_PROTOCOL) with col_checkKovarththanan Rajaratnam1-4/+1
svn path=/trunk/; revision=29345
2009-08-09Don't guard col_clear with col_checkKovarththanan Rajaratnam1-2/+1
svn path=/trunk/; revision=29344
2009-08-09Don't guard col_set_str (COL_INFO) with col_checkKovarththanan Rajaratnam1-60/+22
svn path=/trunk/; revision=29342
2009-08-09Don't guard col_set_str (COL_PROTOCOL) with col_checkKovarththanan Rajaratnam1-2/+1
svn path=/trunk/; revision=29340
generated by cgit v1.2.3 (git 2.25.1) at 2024-10-05 09:51:04 +0000