aboutsummaryrefslogtreecommitdiffstats
path: root/epan/dissectors/packet-vnc.c
AgeCommit message (Collapse)AuthorFilesLines
2011-04-22Don't create a subtree that is not used.Jeff Morriss1-4/+2
svn path=/trunk/; revision=36808
2011-03-28Cast to guint to avoid a Windows compiler warning.Chris Maynard1-1/+1
svn path=/trunk/; revision=36389
2011-03-28Fix for bug #4334 "VNC Hextile encoding is incomplete" from Yaniv Kaul.Stephen Fisher1-82/+103
svn path=/trunk/; revision=36386
2011-03-25Fix coverity 268, 269, 546, 547, 548, 549 by checking for null returnStephen Fisher1-6/+15
from p_get_proto_data() since it should have been set already by the calling function. Any other case would be a bug, so call DISSECTOR_ASSERT in those cases. Hopefully Coverity realizes that this is a null return value check. svn path=/trunk/; revision=36337
2011-02-21From Yaniv Kaul:Jaap Keuter1-3/+82
This one parses the extended desktop size pseudo-encoding, as specified in http://www.tigervnc.com/cgi-bin/rfbproto#extendeddesktopsize-pseudo-encoding svn path=/trunk/; revision=36022
2010-12-20Rename the routines that handle dissector tables with unsigned integerGuy Harris1-6/+6
keys to have _uint in their names, to match the routines that handle dissector tables with string keys. (Using _port can confuse people into thinking they're intended solely for use with TCP/UDP/etc. ports when, in fact, they work better for things such as Ethernet types, where the binding of particular values to particular protocols are a lot stronger.) svn path=/trunk/; revision=35224
2010-11-19Verify the number of rectangles, sub-rectangles, the number of bytes of cutJeff Morriss1-75/+103
text, etc. are "sane" before: 1) requesting enough bytes (from reassembly) to dissect them all 2) (and) attempting to add them all to the tree Request all the bytes we'll need to dissect all those rectangles/sub-rectangles before starting dissection rather than checking before dissecting each rectangle/sub-rectangle. Use tvb_get_ephemeral_string(). Use _U_ to mark unused arguments. Fix up some indentation. Get rid of one more DISSECTOR_ASSERT. svn path=/trunk/; revision=34977
2010-11-19From Yaniv Kaul via https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=5366 :Jeff Morriss1-51/+109
Several fixes that make Tight VNC negotiation properly parsed. It was not parsed correctly previously, for multiple reasons. svn path=/trunk/; revision=34976
2010-09-23Replace blurbs that match the name (case insensitive) with NULL.Jeff Morriss1-1/+1
svn path=/trunk/; revision=34227
2010-05-13As suggested in ↵Jeff Morriss1-109/+100
http://www.wireshark.org/lists/wireshark-dev/200809/msg00075.html (as referenced in https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=2907 ) and https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=3411 : Write a new convenience routine for finding a conversation and, if it is not found, create it. The frame number and addresses are taken from pinfo (as is the common case). Use this function in a bunch of dissectors. svn path=/trunk/; revision=32790
2010-02-13From Yaniv Kaul: minor changes + smallest additionsBill Meier1-200/+282
See: https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=4339#c5 From Me: - Use VNC_... as the initial part of various enum identifiers to ensure that they are unique since they are part of the global namespace; - Fix some indentatiom; svn path=/trunk/; revision=31876
2010-01-08Remove unneeded #includes.Bill Meier1-4/+0
svn path=/trunk/; revision=31465
2010-01-07From Yaniv Kaul: VNC dissector cleanups and minor changes.Bill Meier1-96/+110
From me: Several fixes to the patch and some additional cleanup. svn path=/trunk/; revision=31464
2009-12-15Fix a number of copy & paste errors introduced over various checkins andStephen Fisher1-8/+8
change duplicated filter names used for different purposes by inserting another word to differentiate between them. svn path=/trunk/; revision=31274
2009-12-15From Yaniv Kaul:Jaap Keuter1-8/+16
Attached patch fixes the dissection of the Set Colormap Entries server message. It was at least off-by-one to start with, and the dissection went a bit wrong from there on. svn path=/trunk/; revision=31273
2009-12-12From Yaniv Kaul:Jaap Keuter1-22/+45
VNC dissector fails to dissect properly the authentication used by the older VNC protocol. Specifically, the part about version 3.3 in section 6.2 of the protocol was ignored / not properly implemented. svn path=/trunk/; revision=31250
2009-11-17Remove the address operator from value_string arrays fed to VALS()Gerasimos Dimitriadis1-8/+8
svn path=/trunk/; revision=30995
2009-09-24* Prefer col_append_str instead of col_append_fstr for constant stringsKovarththanan Rajaratnam1-2/+1
* Remove check_col guards svn path=/trunk/; revision=30127
2009-08-09Don't guard col_set_str (COL_INFO/COL_PROTOCOL) with col_checkKovarththanan Rajaratnam1-4/+1
svn path=/trunk/; revision=29345
2009-08-09Don't guard col_clear with col_checkKovarththanan Rajaratnam1-2/+1
svn path=/trunk/; revision=29344
2009-08-09Don't guard col_set_str (COL_INFO) with col_checkKovarththanan Rajaratnam1-60/+22
svn path=/trunk/; revision=29342
2009-08-09Don't guard col_set_str (COL_PROTOCOL) with col_checkKovarththanan Rajaratnam1-2/+1
svn path=/trunk/; revision=29340
2009-06-18From Kovarththanan Rajaratnam via bug 3548:Stig Bjørlykke1-3/+3
(1) Trailing/leading spaces are removed from 'name's/'blurb's (2) Duplicate 'blurb's are replaced with NULL (3) Empty ("") 'blurb's are replaced with NULL (4) BASE_NONE, NULL, 0x0 are used for 'display', 'strings' and 'bitmask' fields for FT_NONE, FT_BYTES, FT_IPv4, FT_IPv6, FT_ABSOLUTE_TIME, FT_RELATIVE_TIME, FT_PROTOCOL, FT_STRING and FT_STRINGZ field types (5) Only allow non-zero value for 'display' if 'bitmask' is non-zero svn path=/trunk/; revision=28770
2009-05-31Change my e-mail addressStephen Fisher1-1/+1
svn path=/trunk/; revision=28537
2009-05-18Remove unnecessary tree checks pointed out by Stig.Gerald Combs1-16/+9
svn path=/trunk/; revision=28396
2009-05-18Clean up indentation.Guy Harris1-133/+133
svn path=/trunk/; revision=28395
2009-05-18From Yaniv Kaul via bug 3215:Gerald Combs1-29/+84
Attached please find a patch that enables to heuristically find VNC traffic on non-standard ports. (it also adds some if(tree) ... around some proto_tree_add_item() functions) svn path=/trunk/; revision=28394
2009-05-13Apply some of the patches from:Anders Broman1-2/+1
http://wiki.wireshark.org/Development/Optimization svn path=/trunk/; revision=28356
2009-05-08FT_BOOLEAN fields w/o bitmasks really should use BASE_NONE (not BASE_DEC,...).Bill Meier1-1/+1
svn path=/trunk/; revision=28317
2008-12-20Fix various typos and spelling errors (mostly in text strings)Bill Meier1-1/+1
svn path=/trunk/; revision=27065
2008-12-02Trivial warning fixesJörg Mayer1-1/+1
svn path=/trunk/; revision=26899
2008-11-30Fix copy & paste typoStephen Fisher1-1/+1
svn path=/trunk/; revision=26882
2008-11-23From Federico Mena Quintero (bug 3070):Stig Bjørlykke1-106/+762
Add support for TightVNC extensions to the VNC dissector. It has the following changes: - Dissect TightVNC negotiation (tunneling, basic authentication, capabilities). - Dissect X cursor encoding. - Dissect POINTER_POS encoding. - Dissect the general form of Tight rectangles. - Dissect Tight image data (basic compression, JPEG, gradient). - Handle LastRect encoding. - Fix some always-true conditions. - Some code cleanups. svn path=/trunk/; revision=26825
2008-09-15Fix for bug 2875:Jaap Keuter1-1/+6
Fix a final eth_fopen -> ws_fopen When configuring with --without-zlib these functions need to have some parameters tagged _U_ svn path=/trunk/; revision=26212
2008-09-03Cleanup related to prefs & proto_reg_handoffBill Meier1-33/+31
svn path=/trunk/; revision=26128
2008-04-09Remove:Anders Broman1-3/+0
#ifdef NEED_G_ASCII_STRCASECMP_H #include "g_ascii_strcasecmp.h" #endif svn path=/trunk/; revision=24859
2007-11-27strcasecmp(), strncasecmp(), g_strcasecmp(), and g_strncasecmp() delendaGuy Harris1-3/+7
est. Use g_ascii_strcasecmp() and g_ascii_strncasecmp(), and supply our own versions if they're missing from GLib (as is the case with GLib 1.x). In the code to build the list of named fields for Diameter, don't use g_strdown(); do our own g_ascii_-style upper-case to lower-case mapping in the hash function and use g_ascii_strcasecmp() in the compare function. We do this because there is no guarantee that toupper(), tolower(), and functions that use them will, for example, map between "I" and "i" in all locales; in Turkish locales, for example, there are, in both upper case and lower case, versions of "i" with and without a dot, and the upper-case version of "i" is "I"-with-a-dot and the lower-case version of "I" is "i"-without-a-dot. This causes strings that should match not to match. This finishes fixing bug 2010 - an earlier checkin prevented the crash (as there are other ways to produce the same crash, e.g. a bogus dictionary.xml file), but didn't fix the case-insensitive string matching. svn path=/trunk/; revision=23623
2007-11-06use strcasecmp instead of g_ascii_strcasecmpRonnie Sahlberg1-3/+3
svn path=/trunk/; revision=23372
2007-11-03Add partial support for TightVNC packet dissection (work in progress). Stephen Fisher1-7/+195
svn path=/trunk/; revision=23345
2007-10-30Minor correction to protocol behavior handling when security type "none" isStephen Fisher1-4/+6
selected by the client. svn path=/trunk/; revision=23312
2007-10-30Fix for issue #1 in bug #1947 by doing a major overhaul of how the firstStephen Fisher1-311/+294
nine or so packets are handled to accommodate authentication type none and to allow cleaner future improvements. Includes a few touch ups to the rest of the dissector as well. svn path=/trunk/; revision=23310
2007-03-23fix some more warnings (type casts)Ulf Lamping1-1/+1
svn path=/trunk/; revision=21141
2007-03-09GCC warning fixesJörg Mayer1-3/+6
epan/dissectors/ packet-bctp.c: no newline at end of file packet-epl.c: C++ style comments are not allowed in ISO C90 packet-sccp.c: missing initializer packet-sccp.h: comma at end of enumerator list packet-sctp.c: suggest parentheses around assignment used as truth value packet-vnc.c: control reaches end of non-void function pointer targets in passing argument 1 of 'g_strtod' differ in signedness pointer targets in passing argument 3 of 'vnc_client_to_server' differ in signedness gtk/ main.c: C++ style comments are not allowed in ISO C90 u3.h: function declaration isn't a prototype Other (trivial) stuff packet-sccp.h: Add svn properties svn path=/trunk/; revision=21011
2007-02-21Major overhaul of VNC dissector: split everything into its own function andStephen Fisher1-375/+1399
bring the server message type dissection nearly to completion. As for RealVNC protocol dissection, the only things not working at 100% is the TCP reassembly and some ZRLE subencoding types. However, it is is much more useful shape now than before. svn path=/trunk/; revision=20886
2006-10-31Escape non-ASCII characters in the client and server protocol version strings.Gerald Combs1-61/+61
svn path=/trunk/; revision=19748
2006-10-03From Stephen Fisher:Anders Broman1-0/+6
Modifie the VNC dissector to desegment the "server cut text" message type for cases where the cut text is in the next tcp segment from the first part of the message. svn path=/trunk/; revision=19402
2006-09-05From Stephen Fisher:Anders Broman1-159/+1129
A patch to bring the VNC dissector almost to completion. I have not had a chance to finish the server message type "frame buffer update," which are the pixel values for screen rectangle updates. Everything else is there - tracking the keys the user is pushing, ringing a bell on the client, mouse button pushes/pointer movements, etc. svn path=/trunk/; revision=19145
2006-05-21change a whole bunch of ethereal into wiresharkRonnie Sahlberg1-7/+7
svn path=/trunk/; revision=18196
2006-01-05Bill Meier:Jörg Mayer1-1/+1
Spelling fixes. svn path=/trunk/; revision=16956
2005-08-10rename ep_tvb_get_string() to tvb_get_ephemeral_string() asnd update the ↵Ronnie Sahlberg1-1/+1
documentation in README.developer svn path=/trunk/; revision=15270
generated by cgit v1.2.3 (git 2.25.1) at 2024-10-05 22:43:29 +0000