aboutsummaryrefslogtreecommitdiffstats
path: root/epan/dissectors/packet-usb.c
AgeCommit message (Collapse)AuthorFilesLines
2022-01-06usb: dissect other speed config descriptorsJohn Keeping1-0/+1
Other speed config descriptors are identical to config descriptors, it's just the request that is different. Handle this request so that other speed config responses are decoded.
2021-12-19Replace g_snprintf() with snprintf() (dissectors)João Valverde1-4/+4
Use macros from inttypes.h with format strings.
2021-12-03epan: Remove STR_ASCII and STR_UNICODEJoão Valverde1-3/+3
These display bases work to replace unprintable characters so the name is a misnomer. In addition they are the same option and this display behaviour is not something that is configurable. This does not affect encodings because all our internal text strings need to be valid UTF-8 and the source encoding is specified using ENC_*. Remove the assertion for valid UTF-8 in proto.c because tvb_get_*_string() must return a valid UTF-8 string, always, and we don't need to assert that, it is expensive.
2021-08-26USBLL: Reassemble transactions into transfersTomasz Moń1-9/+74
Create pseudo URB and pass the reassembled data to USB URB dissector. Reassembly for control transfers is not problematic as the transfer length is known. For bulk transfers assume the transfer can span across multiple transactions, however for periodic (interrupt and isochronous) assume the transfer never spans across multiple transactions. Rely on USB dissector to provide endpoint maximum packet size. Actual interface/configuration handling in USB dissector needs to be reworked as the code assumes that there is only one configuration and alternate interface configurations have matching endpoints. While the reassembly bulk transfers and never reassemble periodic transfers result in pretty good dissection, the USB class dissectors need a mechanism to provide transfer size hints to USBLL dissector. Such hint is not needed for software USB capture as software sniffers essentially capture URBs and every transfer is associated with one URB. The problem can be seen for example in Mass Storage Class where it is common for data transfers length to be multiple of endpoint maximum packet size. Because USBLL dissector doesn't know expected transfer size, it combines together data and status transport. Related to #15908
2021-07-21First pass pinfo->pool conversionEvan Huus1-7/+7
Automated find/replace of wmem_packet_scope() with pinfo->pool in all files where it didn't cause a build failure. I also tweaked a few of the docs which got caught up.
2021-06-16wsutil: add a header that defines some "round to power of 2" macros.Guy Harris1-2/+3
Add macros to round to multiples of 2, 4, 8, 16, and 32. Use them instead of independently defined macros. (We don't define a general "round to a power of 2" macro to avoid the risk of somebody passing something other than a power of 2 to it.)
2021-04-30Cast away the return value of g_strlcpy() and g_strlcat().Guy Harris1-1/+1
Most of the time, the return value tells us nothing useful, as we've already decided that we're perfectly willing to live with string truncation. Hopefully this keeps Coverity from whining that those routines could return an error code (NARRATOR: They don't) and thus that we're ignoring the possibility of failure (as indicated, we've already decided that we can live with string truncation, so truncation is *NOT* a failure).
2021-03-24USB HID: Removed codes of repeated dissectionCaleb Chiu1-5/+1
For class-specified HID request with data fragment, the original codes perform repeated dissection. For example, the SET REPORT REQUEST 21 09 02 02 03 00 02 00 02 00 would be dissected as: Setup Data bmRequestType: 0x21 0... .... = Direction: Host-to-device .01. .... = Type: Class (0x1) ...0 0001 = Recipient: Interface (0x01) bRequest: SET_REPORT (0x09) wValue: 0x0202 ReportID: 2 ReportType: Output (2) wIndex: 3 wLength: 2 bRequest: 9 wValue: 0x0202 wIndex: 3 (0x0003) wLength: 2 Data Fragment: 0200 And dissected as below after the codes removed: Setup Data bmRequestType: 0x21 0... .... = Direction: Host-to-device .01. .... = Type: Class (0x1) ...0 0001 = Recipient: Interface (0x01) bRequest: SET_REPORT (0x09) wValue: 0x0202 ReportID: 2 ReportType: Output (2) wIndex: 3 wLength: 2 Data Fragment: 0200
2021-02-02Address more non-static, non-shared symbols.Martin Mathieson1-2/+2
2020-08-02usb: fix comments.Guy Harris1-4/+4
Some of the fiels that are claimed to be in "host endian byte order" are also used for the Linux USB/IP protocol, where they're big-endian. Change-Id: I8e17d6d6e848ba9cd3465bb3b1debe385c522392 Reviewed-on: https://code.wireshark.org/review/38022 Reviewed-by: Guy Harris <gharris@sonic.net>
2020-08-02usb: use proto_tree_add_item() and proto_tree_add_item_ret_{u}int().Guy Harris1-32/+20
We now have ENC_HOST_ENDIAN, so we can use it to add host-endian fields with proto_tree_add_item(). Instead of fetching field values directly, use proto_tree_add_item_ret_{}int() to get the value. Change-Id: I96b9a55174594bf04f805af559c2521cd813e8f3 Reviewed-on: https://code.wireshark.org/review/38021 Petri-Dish: Guy Harris <gharris@sonic.net> Tested-by: Petri Dish Buildbot Reviewed-by: Guy Harris <gharris@sonic.net>
2020-08-02USB: Make iso_status variable a gint.Martin Mathieson1-1/+1
The type for this field really can be -ve - it corresponds to errno. Change-Id: I842664b692ffd944a0c02ad5de750b321b247dbf Reviewed-on: https://code.wireshark.org/review/38019 Petri-Dish: Martin Mathieson <martin.r.mathieson@googlemail.com> Tested-by: Petri Dish Buildbot Reviewed-by: Guy Harris <gharris@sonic.net>
2020-08-01USB: Use the correct API to add iso status fieldMartin Mathieson1-1/+1
The field does seem to be an int (kernel/srouce/drivers/usb/mon/mon_bin.c), so item type (FT_INT32) is correct, but was using uint API. Change-Id: I3c45785d18f890c362c96deb06120904ffea2081 Reviewed-on: https://code.wireshark.org/review/38014 Petri-Dish: Martin Mathieson <martin.r.mathieson@googlemail.com> Tested-by: Petri Dish Buildbot Reviewed-by: Martin Mathieson <martin.r.mathieson@googlemail.com>
2020-07-27USB Audio: Fix parsing of v2 Endpoint DescriptorPetr Janecek1-1/+4
dissect_usb_endpoint_descriptor() silently assumed that Audio Endpoint Descriptor size is 9B. In v2.0, the last two fields are absent. Change-Id: I5758857fd2b26e2b3430874c313769862a2a87de Reviewed-on: https://code.wireshark.org/review/37973 Petri-Dish: Anders Broman <a.broman58@gmail.com> Tested-by: Petri Dish Buildbot Reviewed-by: Anders Broman <a.broman58@gmail.com>
2020-07-09USB: Add a size check.Gerald Combs1-4/+12
In dissect_usbpcap_iso_packets check for a sane isochronous packet count, otherwise we might overflow our data start offset. Bug: 16677 Change-Id: I79534b4a519eefcf85cf4dd03424ac654bacd8c9 Reviewed-on: https://code.wireshark.org/review/37789 Reviewed-by: Gerald Combs <gerald@wireshark.org> Petri-Dish: Gerald Combs <gerald@wireshark.org> Tested-by: Petri Dish Buildbot Reviewed-by: Anders Broman <a.broman58@gmail.com>
2020-06-19Fix the type of arrays of pointers to hf_ values for bitfield routines.Guy Harris1-8/+8
The static arrays are supposed to be arrays of const pointers to int, not arrays of non-const pointers to const int. Fixing that means some bugs (scribbling on what's *supposed* to be a const array) will be caught (see packet-ieee80211-radiotap.c for examples, the first of which inspired this change and the second of which was discovered while testing compiles with this change), and removes the need for some annoying casts. Also make some of those arrays static while we're at it. Update documentation and dissector-generator tools. Change-Id: I789da5fc60aadc15797cefecfd9a9fbe9a130ccc Reviewed-on: https://code.wireshark.org/review/37517 Petri-Dish: Guy Harris <gharris@sonic.net> Tested-by: Petri Dish Buildbot Reviewed-by: Anders Broman <a.broman58@gmail.com>
2020-05-27USB: Set address after creating interface conversationTomasz Moń1-0/+2
Both bus id and device address are already known when creating interface info on the first pass. Set the values early to prevent passing zero initialized data to dissectors. Change-Id: I50c748eb16e0ab39fdc84f2d7503c87ae48eeae9 Reviewed-on: https://code.wireshark.org/review/37328 Petri-Dish: Tomasz Moń <desowin@gmail.com> Tested-by: Petri Dish Buildbot Reviewed-by: Filipe Laíns <lains@archlinux.org> Reviewed-by: Anders Broman <a.broman58@gmail.com>
2020-03-30USB: GitHub link updateAmeya Deshpande1-1/+1
Change-Id: Ief4bf1d9e3bc8419f3a99187267dbb0064273c20 Reviewed-on: https://code.wireshark.org/review/36631 Reviewed-by: Pascal Quantin <pascal@wireshark.org>
2020-03-02USB: Fix NULL pointer dereferenceTomasz Moń1-1/+1
Coverity CID 1460459 Change-Id: I64c40a8c8aa85a01909c36bc35e61917c80e9327 Reviewed-on: https://code.wireshark.org/review/36258 Petri-Dish: Tomasz Moń <desowin@gmail.com> Tested-by: Petri Dish Buildbot Reviewed-by: Anders Broman <a.broman58@gmail.com>
2020-03-02USB Audio: Dissecting Selector Unit and Endpoint DescriptorAmeya Deshpande1-0/+20
Dissection of "Class-specific Audio Control Interface Descriptor: Selector Unit Descriptor" and "ENDPOINT DESCRIPTOR" for USB Audio Device added. The USB Audio class extended Standard USB Endpoint Descriptor 2 bytes further. A condition to check whether the interface class is CLASS_AUDIO is added and the 2 bytes are dissected. Change-Id: I63f1334df71b9e8cd92a299d533b732b0a13ace7 Reviewed-on: https://code.wireshark.org/review/36250 Petri-Dish: Alexis La Goutte <alexis.lagoutte@gmail.com> Tested-by: Petri Dish Buildbot Reviewed-by: Anders Broman <a.broman58@gmail.com>
2020-03-01USB: Record bcdVersion in device product dataTomasz Moń1-5/+10
Set usb conversation info vendor, product and version based on values recorded in device product data. This results in USB dissectors that register on VID/PID to get correct vendor, product and version information if configuration descriptor is not present in the capture. One such dissector is FTDI FT where the version is used to determine chip type. Ping-Bug: 11743 Change-Id: Idcc361861b616222e32fc0d8cef9f9dd687cf1e4 Reviewed-on: https://code.wireshark.org/review/36243 Petri-Dish: Tomasz Moń <desowin@gmail.com> Tested-by: Petri Dish Buildbot Reviewed-by: Filipe Laíns <lains@archlinux.org> Reviewed-by: Anders Broman <a.broman58@gmail.com>
2020-02-24FTDI MPSSE: Display pin name alongside signal nameTomasz Moń1-0/+1
Pass chip and interface information from FTDI FT to MPSSE dissector. Set usb_conv_info_t field deviceVersion to bcdDevice field from DEVICE DESCRIPTOR so USB dissectors can use it. In case of FTDI FT chips, the bcdDevice value is used to determine chip. Ping-Bug: 11743 Change-Id: I4f2cf5d50355d914fef51cf7e268064b02bc02ed Reviewed-on: https://code.wireshark.org/review/36147 Petri-Dish: Tomasz Moń <desowin@gmail.com> Tested-by: Petri Dish Buildbot Reviewed-by: Filipe Laíns <lains@archlinux.org> Reviewed-by: Anders Broman <a.broman58@gmail.com>
2020-01-06USB MSC: Dissect subclass and protocol codesTomasz Moń1-0/+21
Change-Id: I7a818a11352e437a9492f896557c3348abe33c95 Reviewed-on: https://code.wireshark.org/review/35668 Petri-Dish: Tomasz Moń <desowin@gmail.com> Tested-by: Petri Dish Buildbot Reviewed-by: Alexis La Goutte <alexis.lagoutte@gmail.com>
2019-12-24USB CDC: Match subordinate interfaces with masterTomasz Moń1-0/+4
CDC Data interfaces are linked with Communications and CDC Control interfaces via Union Functional Descriptors. Store subordinate to master interface connection during descriptor dissection and use that information to determine if CDC Data is Ethernet or not. Bug: 14587 Change-Id: I442262186319969303af9ac3a7c17aad19cecab8 Reviewed-on: https://code.wireshark.org/review/35496 Petri-Dish: Tomasz Moń <desowin@gmail.com> Tested-by: Petri Dish Buildbot Reviewed-by: Pascal Quantin <pascal@wireshark.org> Reviewed-by: Michael Mann <mmann78@netscape.net>
2019-08-04USBLL: Minimal destination address handlingTomasz Moń1-1/+1
Currently only following packets have the address fields populated: * SETUP * OUT * IN * PING * SPLIT Although only some packets have the fields populated, this already makes trace analysis significantly easier. Ping-Bug: 15908 Change-Id: I5a5c0e210cb1ceb8e8a747349c4da33ac84ec4c9 Reviewed-on: https://code.wireshark.org/review/34039 Reviewed-by: Anders Broman <a.broman58@gmail.com>
2019-07-26HTTPS (almost) everywhere.Guy Harris1-1/+1
Change all wireshark.org URLs to use https. Fix some broken links while we're at it. Change-Id: I161bf8eeca43b8027605acea666032da86f5ea1c Reviewed-on: https://code.wireshark.org/review/34089 Reviewed-by: Guy Harris <guy@alum.mit.edu>
2019-06-18USB: workaround for compatibility with USBPcap captures < 1.5.0.0Pascal Quantin1-15/+81
Bug: 15842 Change-Id: I63188c30e1747a65c2a2a7cce498b5777122fec3 Reviewed-on: https://code.wireshark.org/review/33628 Petri-Dish: Pascal Quantin <pascal@wireshark.org> Reviewed-by: Tomasz Moń <desowin@gmail.com> Tested-by: Petri Dish Buildbot Reviewed-by: Pascal Quantin <pascal@wireshark.org>
2019-06-16USB: Handle USBPcap 1.5.0.0 updated pseudoheaderTomasz Moń1-15/+55
USBPcap 1.5.0.0 features two main changes: * Introduction of USB IRP Info transfer type (0xFE) This type is used when the IRP is of general interest to the user, but does not really directly match to any USB payload. When such type is encountered, display the URB Function code in Info column. Currently following URB functions are recorded as USB IRP Info: * URB_FUNCTION_SYNC_RESET_PIPE_AND_CLEAR_STALL * URB_FUNCTION_SYNC_RESET_PIPE * URB_FUNCTION_SYNC_CLEAR_STALL * URB_FUNCTION_ABORT_PIPE * URB_FUNCTION_CLOSE_STATIC_STREAMS * Introduction of control stage COMPLETE (0x03) The control transactions are now recorded as 2 packets: SETUP and COMPLETE. All Wireshark versions since the USBPcap pseudoheader support was implemented correctly pass the data to subdissectors. This makes the USBPcap control packets behave just like usbmon. Ping-Bug: 15842 Change-Id: Idc0edf2a0fcf58997531c492293e0719f037493f Reviewed-on: https://code.wireshark.org/review/33623 Petri-Dish: Pascal Quantin <pascal@wireshark.org> Tested-by: Petri Dish Buildbot Reviewed-by: Pascal Quantin <pascal@wireshark.org>
2019-06-14USB: Do not assume that request is standardTomasz Moń1-3/+8
USBPcap control status packets for non standard request types (eg. Vendor) were incorrectly treated as the standard request type. This resulted in confusing Info column description. Describe status packet of non standard request types as "URB_CONTROL status". Do not try any extra labelling as the overall idea of Setup/Data/Status is not too good and will be revised in future USBPcap versions. Ping-Bug: 11743 Ping-Bug: 15842 Change-Id: Iade5cb85aa01e65874006eb4c7a242568f07b7c8 Reviewed-on: https://code.wireshark.org/review/33596 Petri-Dish: Alexis La Goutte <alexis.lagoutte@gmail.com> Tested-by: Petri Dish Buildbot Reviewed-by: Pascal Quantin <pascal@wireshark.org>
2019-06-11decode_as: remove the "title" member from decode_as_tMartin Kaiser1-3/+3
The title of a decode_as_t was used by the GTK UI. It's no longer required for Qt. Change-Id: Ibd9d4acbe9cad2c1af520340d04e550326a97ebe Reviewed-on: https://code.wireshark.org/review/33557 Petri-Dish: Martin Kaiser <wireshark@kaiser.cx> Tested-by: Petri Dish Buildbot Reviewed-by: Anders Broman <a.broman58@gmail.com>
2019-06-10FTDI FT: Initial USB Bridging Devices dissectorTomasz Moń1-0/+3
Note that this dissector covers the USB to serial only. FTDI Multi-Protocol Synchronous Serial Engine (MPSSE) should be implemented as separate dissector receiving data from FTDI FT dissector if the chip has MPSSE. Ping-Bug: 11743 Change-Id: I1f2e2b56b9351442f7ddbe97106b5f166de2cdca Reviewed-on: https://code.wireshark.org/review/33520 Petri-Dish: Alexis La Goutte <alexis.lagoutte@gmail.com> Tested-by: Petri Dish Buildbot Reviewed-by: Anders Broman <a.broman58@gmail.com>
2019-06-05USB: Use standard descriptor strings in GET DESCRIPTORTomasz Moń1-7/+6
Display the default strings in all contexts where usb.bDescriptor is used. Change-Id: I9f4479ccc0664585fc259927c0b2ee1149b02454 Reviewed-on: https://code.wireshark.org/review/33368 Petri-Dish: Martin Kaiser <wireshark@kaiser.cx> Tested-by: Petri Dish Buildbot Reviewed-by: Gerald Combs <gerald@wireshark.org>
2019-05-29USB: Add interface-specific setup data to setup treeTomasz Moń1-7/+14
This results in GET DESCRIPTOR Request HID Report entries to be properly grouped under the URB setup instead of being directly added to top level tree. Rename tree from "URB setup" to "Setup Data" to better match the terminology used in USB specification. Change-Id: If9ef7cea86b51c0c63680c424d7f45d7dd38249b Reviewed-on: https://code.wireshark.org/review/33408 Reviewed-by: Alexis La Goutte <alexis.lagoutte@gmail.com> Petri-Dish: Alexis La Goutte <alexis.lagoutte@gmail.com> Tested-by: Petri Dish Buildbot Reviewed-by: Anders Broman <a.broman58@gmail.com>
2019-05-29USB: Dissect SuperSpeed Endpoint Companion descriptorsTomasz Moń1-7/+109
Mark undecoded data in endpoint descriptors with expert info. Bug: 15798 Change-Id: I392da00205274fb3f5eb947a54ba424d1edb041b Reviewed-on: https://code.wireshark.org/review/33386 Petri-Dish: Anders Broman <a.broman58@gmail.com> Tested-by: Petri Dish Buildbot Reviewed-by: Anders Broman <a.broman58@gmail.com>
2019-05-22USB: Add expert info for unknown URBs captured by USBPcapTomasz Moń1-2/+8
Current development builds and next official release of USBPcap will feature generic unknown URB Function capture. When USBPcap notices URB Function code that it does not understand, it'll write the USBPcap pseudoheader with transfer type 0xFF (URB_UNKNOWN). The pseudoheader will contain the IRP ID, status code, URB Function code, bus id, device address and PDO->FDO or FDO->PDO flag. Other fields in the pseudoheader will be 0. Capturing such packets serves multiple purposes: * Makes it clear that the USBPcap capture is incomplete * Combined with expert info, makes casual users able to report device whose driver does issue IRPs with unhandled URB Function codes * Shows that USBPcap can be improved to capture such data Bug: 15792 Change-Id: Ib44c6bf05dd9f025617368e44b7dc80b5910aacd Reviewed-on: https://code.wireshark.org/review/33307 Petri-Dish: Pascal Quantin <pascal@wireshark.org> Tested-by: Petri Dish Buildbot Reviewed-by: Pascal Quantin <pascal@wireshark.org>
2019-05-13USB Audio: Dissect USB Audio Interface SubclassTomasz Moń1-0/+10
Change-Id: I2e2a84b07a6d9cb17b6a12c8129e909d21a6a1d6 Reviewed-on: https://code.wireshark.org/review/33173 Petri-Dish: Alexis La Goutte <alexis.lagoutte@gmail.com> Tested-by: Petri Dish Buildbot Reviewed-by: Alexis La Goutte <alexis.lagoutte@gmail.com>
2019-04-06Dissect USB "device" Setup CONTROL messagesArtem Mygaiev1-8/+2
Before this change Wireshark would assume there is no USB devices that use "device" recepient (RQT_SETUP_RECIPIENT_DEVICE) in Setup stage of USB CONTROL messages. But there are plenty of such, examples are: FrescoLogic's FL2000 USB Display controller, Razer USB peripherals; there are open projects that investigate protocols for them in order to implement OSS drivers and SW stacks. Allow dissection of USB "device" Setup CONTROL messages by treating them in the same way as "other" or "reserved" with assumption that at least IntefaceClass is set to UNKNWON (0xffff) which is true for at least beforementioned FL2000 and Razer HW implementations. Change-Id: I44f4f8cdccd973194aeda2c39c59529d531c31b2 Reviewed-on: https://code.wireshark.org/review/32626 Petri-Dish: Alexis La Goutte <alexis.lagoutte@gmail.com> Tested-by: Petri Dish Buildbot Reviewed-by: Alexis La Goutte <alexis.lagoutte@gmail.com>
2019-04-04epan: Convert our PROTO_ITEM_ macros to inline functions.Gerald Combs1-14/+14
Convert our various PROTO_ITEM_ macros to inline functions and document them. Change-Id: I070b15d4f70d2189217a177ee8ba2740be36327c Reviewed-on: https://code.wireshark.org/review/32706 Reviewed-by: Gerald Combs <gerald@wireshark.org> Petri-Dish: Gerald Combs <gerald@wireshark.org> Reviewed-by: Anders Broman <a.broman58@gmail.com>
2019-01-01Add a "failed" return for tap packet routines.Guy Harris1-4/+4
This allows taps that can fail to report an error and fail; a failed tap's packet routine won't be called again, so they don't have to keep track of whether they've failed themselves. We make the return value from the packet routine an enum. Don't have a separate type for the per-packet routine for "follow" taps; they're expected to act like tap packet routines, so just use the type for tap packet routines. One tap packet routine returned -1; that's not a valid return value, and wasn't one before this change (the return value was a boolean), so presume the intent was "don't redraw". Another tap routine's early return, without doing any work, returned TRUE; this is presumably an error (no work done, no need to redraw), so presumably it should be "don't redraw". Clean up some white space while we're at it. Change-Id: Ia7d2b717b2cace4b13c2b886e699aa4d79cc82c8 Reviewed-on: https://code.wireshark.org/review/31283 Reviewed-by: Guy Harris <guy@alum.mit.edu>
2018-12-27Try to squeeze some bytes out of the frame_data structure.Guy Harris1-5/+5
Make the time stamp precision a 4-bit bitfield, so, when combined with the other bitfields, we have 32 bits. That means we put the flags at the same structure level as the time stamp precision, so they can be combined; that gets rid of an extra "flags." for references to the flags. Put the two pointers next to each other, and after a multiple of 8 bytes worth of other fields, so that there's no padding before or between them. It's still not down to 64 bytes, which is the next lower power of 2, so there's more work to do. Change-Id: I6f3e9d9f6f48137bbee8f100c152d2c42adb8fbe Reviewed-on: https://code.wireshark.org/review/31213 Petri-Dish: Guy Harris <guy@alum.mit.edu> Tested-by: Petri Dish Buildbot Reviewed-by: Guy Harris <guy@alum.mit.edu>
2018-12-05Fix some spelling errors found by Lintian.Gerald Combs1-1/+1
Change-Id: If6fc3aab7ad4fc634567121f7b9541bc6f6c5766 Reviewed-on: https://code.wireshark.org/review/30926 Reviewed-by: Gerald Combs <gerald@wireshark.org> Petri-Dish: Gerald Combs <gerald@wireshark.org> Tested-by: Petri Dish Buildbot Reviewed-by: Anders Broman <a.broman58@gmail.com>
2018-06-25USB: Fall back to transfer type from descriptorLars Christensen1-3/+32
When dissecting USBIP packets, the transfer type is not known for every packet like when dissecting usbmon captures. This patch lifs the transfer type for the endpoint in the device descriptor and stores it in the conversation. If the per-packet transfer type is unknown for a transfer, it tries the one from the descriptor instead. This enables bulk/iso payload dissectors to work on USBIP packets too. Change-Id: If0a3e4f3b9598f586fa460d0d07032d22e203122 Reviewed-on: https://code.wireshark.org/review/28412 Reviewed-by: Jaap Keuter <jaap.keuter@xs4all.nl> Petri-Dish: Jaap Keuter <jaap.keuter@xs4all.nl> Tested-by: Petri Dish Buildbot Reviewed-by: Anders Broman <a.broman58@gmail.com>
2018-06-24USB: Dissect URB transfer flagsLars Christensen1-1/+115
Change-Id: I52cbafe519bbdb46961748a84db4f2db0bbe3c2d Reviewed-on: https://code.wireshark.org/review/28411 Petri-Dish: Anders Broman <a.broman58@gmail.com> Tested-by: Petri Dish Buildbot Reviewed-by: Anders Broman <a.broman58@gmail.com>
2018-02-27Qt/USB: Allow USB src/dst addresses to be selected for columnsPeter Wu1-1/+7
Make "Prepare a Filter" from the Source and Destination columns work for USB source and destination address, this value must be quoted as well. Change-Id: Ib7a772050c204e716781cc27f9eddbdb7971e547 Reviewed-on: https://code.wireshark.org/review/26096 Petri-Dish: Peter Wu <peter@lekensteyn.nl> Tested-by: Petri Dish Buildbot Reviewed-by: Anders Broman <a.broman58@gmail.com>
2018-02-18USB: Sanity check Darwin USB header to prevent infinite loop.Michael Mann1-1/+1
Bug: 14421 Change-Id: Ifb492b776182507c10664d067f99312af250e6ff Reviewed-on: https://code.wireshark.org/review/25872 Petri-Dish: Michael Mann <mmann78@netscape.net> Tested-by: Petri Dish Buildbot Reviewed-by: Michael Mann <mmann78@netscape.net>
2018-02-12dissectors: use SPDX identifiers.Dario Lombardo1-13/+1
Change-Id: I92c94448e6641716d03158a5f332c8b53709423a Reviewed-on: https://code.wireshark.org/review/25756 Petri-Dish: Dario Lombardo <lomato@gmail.com> Reviewed-by: Anders Broman <a.broman58@gmail.com>
2017-10-29Use endpoint_type in conversation tables and hostlistsMichael Mann1-3/+3
Follow up to having conversions use endpoint_type instead of port_type. Change-Id: Ifd59a33bd8b9a013c242bce5fcceb09533f02c17 Reviewed-on: https://code.wireshark.org/review/24172 Petri-Dish: Michael Mann <mmann78@netscape.net> Tested-by: Petri Dish Buildbot Reviewed-by: Michael Mann <mmann78@netscape.net>
2017-10-29Add conversation endpoint typeMichael Mann1-2/+2
For the moment this mirrors the port_type enumeration (PT_XXX), but the intent is to move away from using "port types", eliminating most (if not all) Added conversation_pt_to_endpoint_type() so that conversations deal with the correct enumeration. This is for dissector that use pinfo->ptype as input to conversation APIs. Explicit use of port types are converted to using ENDPOINT_XXX type. Change-Id: Ia0bf553a3943b702c921f185407e03ce93ebf0ef Reviewed-on: https://code.wireshark.org/review/24166 Petri-Dish: Michael Mann <mmann78@netscape.net> Tested-by: Petri Dish Buildbot Reviewed-by: Michael Mann <mmann78@netscape.net>
2017-09-06USB: use G_GUINT64_CONSTANT() macroPascal Quantin1-4/+4
Change-Id: I2c3d2956be898c767afc19b2c63f2e84b5e79ed0 Reviewed-on: https://code.wireshark.org/review/23422 Reviewed-by: Pascal Quantin <pascal.quantin@gmail.com> Petri-Dish: Pascal Quantin <pascal.quantin@gmail.com> Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org> Reviewed-by: Michael Mann <mmann78@netscape.net>
2017-09-06packet-usb.c: Add support for USBPort KeywordMichael Mann1-0/+46
Change-Id: I29e0a7bf81b1f6cf2f84cccb212e223089dd918a Reviewed-on: https://code.wireshark.org/review/23419 Petri-Dish: Michael Mann <mmann78@netscape.net> Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org> Reviewed-by: Michael Mann <mmann78@netscape.net>
generated by cgit v1.2.3 (git 2.25.1) at 2024-07-08 19:44:14 +0000