aboutsummaryrefslogtreecommitdiffstats
path: root/epan/dissectors/packet-umts_rlc.c
AgeCommit message (Collapse)AuthorFilesLines
2018-06-04RLC: Use PINFO_FD_VISITED macroDarien Spencer1-3/+3
Change-Id: I0db66647876cc57a4c88957ebc00dffde0a18177 Reviewed-on: https://code.wireshark.org/review/27984 Petri-Dish: Anders Broman <a.broman58@gmail.com> Tested-by: Petri Dish Buildbot Reviewed-by: Peter Wu <peter@lekensteyn.nl>
2018-05-22rlc: Catch exceptions from sub-dissectorsDarien Spencer1-11/+30
Incorrect reassembly and/or parsing ciphered data can lead to exceptions. We want to be able to parse other SDUs/transport blocks in FP even if this happens. Change-Id: Ie54ee337cf85d8c1cd0e3ac8e46bda96ff2304b9 Reviewed-on: https://code.wireshark.org/review/27656 Petri-Dish: Anders Broman <a.broman58@gmail.com> Tested-by: Petri Dish Buildbot Reviewed-by: Anders Broman <a.broman58@gmail.com>
2018-05-15umts_rlc, umts_mac: fix memory leaks (found via ASAN)Ivan Nardi1-3/+2
Such leaks are triggered by malformed packets Change-Id: Ie392834b235cf9c5a249ede7fffb5a0dbdb360e5 Reviewed-on: https://code.wireshark.org/review/27556 Petri-Dish: Pascal Quantin <pascal.quantin@gmail.com> Tested-by: Petri Dish Buildbot Reviewed-by: Pascal Quantin <pascal.quantin@gmail.com>
2018-04-13UMTS RLC: add expert info for unknown / missing UDP framing tagsPascal Quantin1-2/+21
Change-Id: I29dbeaf0d90bab4c10b4674bfa983f7f5f26027b Reviewed-on: https://code.wireshark.org/review/26909 Reviewed-by: Pascal Quantin <pascal.quantin@gmail.com>
2018-03-02RLC: Fix duplication check after sqn resetLutz Kresge1-12/+27
When rlc sequence number wrapped around, duplicate frames wouldn't be marked because they were compared to the sqn from the first round. Change-Id: Ia57aac9b86b4cc84dd8ec411fe0a94972acb9526 Reviewed-on: https://code.wireshark.org/review/26208 Petri-Dish: Anders Broman <a.broman58@gmail.com> Tested-by: Petri Dish Buildbot Reviewed-by: Anders Broman <a.broman58@gmail.com>
2018-02-12dissectors: use SPDX identifiers.Dario Lombardo1-13/+1
Change-Id: I92c94448e6641716d03158a5f332c8b53709423a Reviewed-on: https://code.wireshark.org/review/25756 Petri-Dish: Dario Lombardo <lomato@gmail.com> Reviewed-by: Anders Broman <a.broman58@gmail.com>
2018-01-06RRC: Fix direction valuesNick James1-2/+2
Values were swapped: uplink is 0, downlink is 1. Change-Id: I30dbb6d89ea832741c3ce4a319be1cb261b1565b Reviewed-on: https://code.wireshark.org/review/25143 Petri-Dish: Pascal Quantin <pascal.quantin@gmail.com> Tested-by: Petri Dish Buildbot Reviewed-by: Pascal Quantin <pascal.quantin@gmail.com>
2017-11-05RLC: Replaced g_malloc with tvb_memdupDarien Spencer1-16/+5
Also updated some comments and a string Change-Id: Ib8c079a34f21614047262900b0a4c1547d5df0b3 Reviewed-on: https://code.wireshark.org/review/24237 Petri-Dish: Anders Broman <a.broman58@gmail.com> Tested-by: Petri Dish Buildbot Reviewed-by: Michael Mann <mmann78@netscape.net>
2017-10-15rlc: Fix bug in 'RLC over UDP' dissectorDarien Spencer1-0/+4
Reassembly of AM/UM packets doesn't work when the URNTI tag is missing and the default value of 0 is kept. This patch makes the default value 1 for those cases. Bug: 14129 Change-Id: Id13121b5de63da4318214871b8963ceef5d28cf0 Reviewed-on: https://code.wireshark.org/review/23930 Petri-Dish: Pascal Quantin <pascal.quantin@gmail.com> Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org> Reviewed-by: Pascal Quantin <pascal.quantin@gmail.com>
2017-09-20UMTS RLC: Removing unused 'is ciphered' functionDarien Spencer1-16/+0
All calls to this function were commented out in a previous commit. Also dealing with the state of the payload (ciphred or not) should be done within the RLC dissector Change-Id: Ice3a3ca8392d73c7b67308537d7568ab71a98b5e Reviewed-on: https://code.wireshark.org/review/23644 Reviewed-by: Anders Broman <a.broman58@gmail.com> Petri-Dish: Anders Broman <a.broman58@gmail.com> Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org> Reviewed-by: Michael Mann <mmann78@netscape.net>
2017-09-20UMTS RLC: Hide deciphering preference by defaultDarien Spencer1-5/+15
Unless wireshark is compiled with a KASUMI implementation, trying to decipher RLC will always fail. Change-Id: I0d44514579fbfcd21fe8c2b74c566c54f94e4698 Reviewed-on: https://code.wireshark.org/review/23557 Petri-Dish: Anders Broman <a.broman58@gmail.com> Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org> Reviewed-by: Anders Broman <a.broman58@gmail.com>
2017-09-13UMTS RLC: Mark ciphered framesDarien Spencer1-26/+118
- Updated RRC dissector to always collect ciphering sequence numbers from Security Mode Command/ Security Mode Complete - Updated RLC dissector to seek the collected info when deciding if the frame is ciphered Change-Id: I44bc61736968ef9f420782048e15ba27d6c6267f Reviewed-on: https://code.wireshark.org/review/23132 Petri-Dish: Pascal Quantin <pascal.quantin@gmail.com> Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org> Reviewed-by: Pascal Quantin <pascal.quantin@gmail.com>
2017-07-05UMTS RLC: check rlc_channel_assign return value when searching duplicatesPascal Quantin1-1/+2
Bug: 13871 Change-Id: Id28d73115b557af96c23154a18dcee502b4305ed Reviewed-on: https://code.wireshark.org/review/22520 Reviewed-by: Pascal Quantin <pascal.quantin@gmail.com>
2017-07-03[UMTS RLC] Allow multiple payloads in INFO columnDarien Spencer1-4/+9
Currently the code sets 'writable' to false for the '-1' column (all columns?) after the first successfuly decoded RRC payload. So only the first of all RRC payloads in a single RLC will be shown. This change allows all of them to show using fences. Change-Id: I203f0c520d331dbb142eb5bdd8339f89c5124394 Reviewed-on: https://code.wireshark.org/review/22493 Petri-Dish: Michael Mann <mmann78@netscape.net> Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org> Reviewed-by: Michael Mann <mmann78@netscape.net>
2017-06-19RLC: Renamed U-RNTI to UE IDDarien Spencer1-15/+15
The 'U-RNTI' field in RLC Info struct is both used in the code and shown in the UI as a generic unique 'UE ID' (not specificly U-RNTI, although sometimes it is) This commit renames the field to fit it's usage. Change-Id: Ib42b8ed5192fe60c9a164d6d225634be53708c66 Reviewed-on: https://code.wireshark.org/review/22225 Petri-Dish: Pascal Quantin <pascal.quantin@gmail.com> Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org> Reviewed-by: Anders Broman <a.broman58@gmail.com>
2017-06-19[UMTS RLC] Rename proto variableDarien Spencer1-34/+34
To match the recently renamed file name. Change-Id: Id784b955ec96a52a5f380d415094dce81e1774d5 Reviewed-on: https://code.wireshark.org/review/22222 Petri-Dish: Alexis La Goutte <alexis.lagoutte@gmail.com> Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org> Reviewed-by: Pascal Quantin <pascal.quantin@gmail.com>
2017-06-17[UMTS RLC] Renaming dissector files to fit FP/MACDarien Spencer1-0/+3029
Currently the UMTS FP & MAC dissector's are named packet-umts_X. This commit renames the UMTS RLC's files to show their relation. Change-Id: I9e37be95f7c7d08278075a49b8abc2b480a13d64 Reviewed-on: https://code.wireshark.org/review/22188 Reviewed-by: Michael Mann <mmann78@netscape.net> Petri-Dish: Michael Mann <mmann78@netscape.net> Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org> Reviewed-by: Anders Broman <a.broman58@gmail.com>
generated by cgit v1.2.3 (git 2.25.1) at 2024-09-27 05:17:19 +0000