aboutsummaryrefslogtreecommitdiffstats
path: root/epan/dissectors/packet-umts_fp.c
AgeCommit message (Collapse)AuthorFilesLines
2010-11-23Check the DDI while dissecting the header.Martin Mathieson1-2/+26
svn path=/trunk/; revision=35013
2010-11-22Add another (unsupported) channel type identifier.Martin Mathieson1-0/+4
svn path=/trunk/; revision=35001
2010-11-19Reserve not-yet-supported channel type IDs.Martin Mathieson1-0/+8
svn path=/trunk/; revision=34967
2010-10-08From Tobias Witek (https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=5283)Martin Mathieson1-2/+10
epan/dissectors/packet-umts_fp.c * Added mac subdissector (MAC) call to HSDSCH TYPE2 frames epan/dissectors/packet-umts_mac.c * Added support for HSDSCH TYPE2 frames by means of not nibble-shifting (4 bits) the SDU if MAC-ehs is used epan/dissectors/packet-rlc.c * Added support for "Use special value of the HE field" (3gpp 25.332-7a0 9.2.2.7) commonly used for Release 7 HSDPA. REMARK: although the specification mandates that the special value is only allowed when activated by higher layers (RRC), it is interpreted unconditionally. We assume this is OK, because a different use in future specifications is very unlikely. epan/dissectors/packet-fp_hint.c * Added decoding of MAC-ehs indicator for HSDSCH frames * Bumped fpi->release from 6 to 7 to enable proper HSDSCH TYPE2 frame decoding in the UTMS MAC parser. In general, this appears not to affect decoding of (conformant) FP frames of pevious releases. svn path=/trunk/; revision=34433
2010-10-07From Tobias Witek (bug 5282):Martin Mathieson1-17/+16
In some cases, the UMTS FP dissector currently calls upper-layer dissectors (e.g. UMTS MAC) only when a proto-tree is present. Effectively, this causes the RLC reassembly to fail in certain cases. The attached patch solves the problem by slightly moving the calls to 'call_dissector()'. svn path=/trunk/; revision=34399
2010-09-15Add expert info for timing adjustment control message, and tweak a label.Martin Mathieson1-3/+8
svn path=/trunk/; revision=34123
2010-08-27Allow 3GPP release info to be displayed.Martin Mathieson1-1/+60
svn path=/trunk/; revision=33950
2010-08-25Show (again?) MAC-d PDUs inside MAC-es PDUs.Martin Mathieson1-2/+15
svn path=/trunk/; revision=33918
2010-08-16Set length of 'PDU Block Header' subtrees.Martin Mathieson1-2/+15
svn path=/trunk/; revision=33812
2010-08-12Fix a duplicate/copy-pasted filter field name.Martin Mathieson1-1/+1
svn path=/trunk/; revision=33782
2010-08-04Update bit_offset whether calling MAC dissector or not.Martin Mathieson1-1/+1
svn path=/trunk/; revision=33711
2010-08-03Add a preference to call MAC for TBs (on by default).Martin Mathieson1-325/+212
Improve info column display for HS-DSCH Capacity Request messages. Removed calls to check_col(). Removed a few tabs. svn path=/trunk/; revision=33698
2010-01-22Fix some gcc -Wshadow warningsBill Meier1-2/+1
svn path=/trunk/; revision=31623
2009-11-29From Tobias Witek:Anders Broman1-0/+30
Add support for UMTS FP over UDP. https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=4218 svn path=/trunk/; revision=31113
2009-11-05From Tobias Witek:Anders Broman1-41/+89
w protocols: UMTS RLC (ETSI TS 125 322), UMTS MAC (ETSI TS 125 321) https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=3495 svn path=/trunk/; revision=30838
2009-09-24Don't guard col_append_str with check_colKovarththanan Rajaratnam1-4/+1
svn path=/trunk/; revision=30125
2009-08-09Don't guard col_set_str (COL_PROTOCOL) with col_checkKovarththanan Rajaratnam1-2/+1
svn path=/trunk/; revision=29340
2009-07-07From Kovarththanan Rajaratnam:Stig Bjørlykke1-2/+2
More FT_XXX cleanup. svn path=/trunk/; revision=28971
2009-06-18From Kovarththanan Rajaratnam via bug 3548:Stig Bjørlykke1-60/+60
(1) Trailing/leading spaces are removed from 'name's/'blurb's (2) Duplicate 'blurb's are replaced with NULL (3) Empty ("") 'blurb's are replaced with NULL (4) BASE_NONE, NULL, 0x0 are used for 'display', 'strings' and 'bitmask' fields for FT_NONE, FT_BYTES, FT_IPv4, FT_IPv6, FT_ABSOLUTE_TIME, FT_RELATIVE_TIME, FT_PROTOCOL, FT_STRING and FT_STRINGZ field types (5) Only allow non-zero value for 'display' if 'bitmask' is non-zero svn path=/trunk/; revision=28770
2008-12-20Fix various typos and spelling errors (mostly in text strings)Bill Meier1-1/+1
svn path=/trunk/; revision=27065
2008-12-17Fix typos and spelling (mostly in text strings) Bill Meier1-6/+6
svn path=/trunk/; revision=27028
2008-06-18Show enhanced high speed channels more clearly.Martin Mathieson1-2/+30
svn path=/trunk/; revision=25472
2008-06-12Show correct seqno in info column.Martin Mathieson1-2/+2
svn path=/trunk/; revision=25446
2008-06-12Dissect BCH channels (expect control messages only).Martin Mathieson1-1/+31
svn path=/trunk/; revision=25445
2008-06-06Fix RACH extended IE handling.Martin Mathieson1-37/+154
Flags have different meanings depending upon radio mode... svn path=/trunk/; revision=25435
2008-06-05Fix operator precedence problem.Martin Mathieson1-1/+1
svn path=/trunk/; revision=25430
2008-06-04- Make FP radio division mode/speed explicit in struct for R7Martin Mathieson1-12/+84
- Various R7 fixes svn path=/trunk/; revision=25425
2008-05-27Missed "bytes" -> "bits" changes.Martin Mathieson1-2/+2
svn path=/trunk/; revision=25387
2008-05-27Type 2 hsdsch data is different (size in bytes and byte-aligned).Martin Mathieson1-4/+57
svn path=/trunk/; revision=25386
2008-05-27Fix max pdu size in hsdsch alloc type 2.Martin Mathieson1-2/+2
svn path=/trunk/; revision=25385
2008-05-25More R7 tweaks and comment updates.Martin Mathieson1-27/+56
svn path=/trunk/; revision=25376
2008-05-20When extending values, extra bits are always m.s.Martin Mathieson1-19/+34
svn path=/trunk/; revision=25328
2008-05-20Enable FP R7 support.Martin Mathieson1-59/+106
This commit adds a header file needed by my PDCP dissector. (not yet ready to be added). svn path=/trunk/; revision=25326
2008-05-12HS-DSCH type 2 bug fix + prettification.Martin Mathieson1-16/+65
svn path=/trunk/; revision=25277
2008-05-11Added HS-DSCH data frame type 2 (currently only compile-tested).Martin Mathieson1-6/+250
svn path=/trunk/; revision=25271
2008-05-09Add a couple of missing HS-DSCH data frame fields.Martin Mathieson1-2/+39
svn path=/trunk/; revision=25267
2008-05-02Initialise variable.Martin Mathieson1-0/+1
(sorry about the build breakage, these new message formats will be tested soon and it looks like I forgot to compile-test the last change I made...). svn path=/trunk/; revision=25220
2008-05-02Fix (what I presume to be) a typo to prevent compile error.Bill Meier1-1/+1
svn path=/trunk/; revision=25219
2008-05-02More R7 additions.Martin Mathieson1-2/+38
Main missing part is new HSDSCH data frame type 2. svn path=/trunk/; revision=25217
2008-05-02Updated common control messages to R7.Martin Mathieson1-24/+107
svn path=/trunk/; revision=25216
2008-04-28Fix test for unlimited credits value in new alloc format.Martin Mathieson1-2/+2
svn path=/trunk/; revision=25185
2008-04-25Add comment explaining that case is safe.Martin Mathieson1-0/+1
svn path=/trunk/; revision=25178
2008-04-25Add cast to avoid Windows warning.Martin Mathieson1-1/+1
svn path=/trunk/; revision=25177
2008-04-25Fixed some old problems found while starting to add R7 support.Martin Mathieson1-33/+186
svn path=/trunk/; revision=25171
2007-11-08Apply yet another set of the optimization patches:Anders Broman1-1/+1
-set_str2add_str_val_to_str svn path=/trunk/; revision=23406
2007-10-23Make groups of PDUs filterable as large FT_BYTES itemsMartin Mathieson1-2/+2
(where the initial length isn't readily available when item is first added) Note that this still won't work where an initial length of 0 is given for the item that will later be extended using proto_item_set_len(), as the pointer value part of the zero-length array will reamin NULL... svn path=/trunk/; revision=23253
2007-10-22Show multi-byte variable length fields using FT_BYTES|BASE_HEX.Martin Mathieson1-32/+25
Note that there is still a problem with 'Apply as filter' filters. They seem to remember the initial length of the item, and not the final length set using proto_item_set_len() (this is the case for groups of TBs/PDUs). Will investigate when time allows... svn path=/trunk/; revision=23239
2007-05-09Cast values to correct sizes for number of bits to squelch Win32 warningsGraham Bloice1-3/+3
svn path=/trunk/; revision=21737
2007-05-09Unless I've missed something, the number of subframes can be as many asGuy Harris1-1/+1
16 (4 bits, 0-origin, so that's 15 + 1 as the maximum). svn path=/trunk/; revision=21733
2007-05-08From Kriang Lerdsuwanakij:Martin Mathieson1-174/+201
This patch adds the handling of Spare Extension bytes to UMTS Frame Protocol. It also handles the case when the presence of CRC in dedicated channels is not known (i.e. when FP from a K12/K15 log is dissected). The new functionality is placed in the new function "dissect_spare_extension_and_crc". The "dch_crc_present" field inside "struct fp_info" (file packet-umts_fp.h) is also extended to handle the case of unknown CRC presence. Much of other changes is to update "offset" variable and return it so that the location of Spare Extension and CRC is available. The patch also include a small tweak to handle Frame Protocol information saved from K15. Some fields appear 8 bytes later compared to K12. The changes are in the file packet-k12.c. svn path=/trunk/; revision=21726