aboutsummaryrefslogtreecommitdiffstats
path: root/epan/dissectors/packet-ucp.c
AgeCommit message (Collapse)AuthorFilesLines
2013-11-14Create/use value_string_ext for some value-string-arrays.Bill Meier1-569/+586
Define several char arrays as const. Add editor modelines. Do some minor whitespace changes. svn path=/trunk/; revision=53316
2013-11-09Add data parameter to tcp_dissect_pdus() as well as convert it to using ↵Michael Mann1-58/+55
"new" style dissectors. Now that "bytes consumed" can be determined, should tcp_dissect_pdus() take advantage of that? Should tcp_dissect_pdus return length (bytes consumed)? There are many dissectors that just call tcp_dissect_pdus() then return tvb_length(tvb). Seems like that could all be rolled into one. svn path=/trunk/; revision=53198
2013-09-22emem -> wmem conversion:Pascal Quantin1-2/+2
- ep_tvb_get_bits() -> wmem_packet_tvb_get_bits() - tvb_g_memdup()/ep_tvb_memdup() -> tvb_memdup() - tvb_fake_unicode()/tvb_get_ephemeral_faked_unicode() -> tvb_get_faked_unicode() - tvb_get_g_string()/tvb_get_ephemeral_string()/tvb_get_seasonal_string() -> tvb_get_string() - tvb_get_g_unicode_string()/tvb_get_ephemeral_unicode_string() -> tvb_get_unicode_string() - tvb_get_ephemeral_string_enc() -> tvb_get_string_enc() - update docs accordingly svn path=/trunk/; revision=52172
2013-09-12emem -> wmem ("tshark -v" tested)Jörg Mayer1-2/+2
svn path=/trunk/; revision=51979
2013-08-10Fix (-W)documentation error found by ClangAlexis La Goutte1-2/+0
packet-ucp.c:781:5: error: '\return' command used in a comment that is attached to a function returning void [-Werror,-Wdocumentation] * \return For 'int'-types, the value of the field. ~^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ packet-ucp.c:954:17: error: parameter 'field' not found in the function declaration [-Werror,-Wdocumentation] * \param field The actual field, whose value needs displaying ^~~~~ svn path=/trunk/; revision=51270
2013-06-14Remove check_col() and the occasional tree.Michael Mann1-7/+5
svn path=/trunk/; revision=49923
2013-03-29Rename value string (and similar) functions to use a consistent pattern. ThisEvan Huus1-1/+1
was done using textual search+replace, not anything syntax-aware, so presumably it got most comments as well (except where there were typos). Use a consistent coding style, and make proper use of the WS_DLL_* defines. Group the functions appropriately in the header. I ended up getting rid of most of the explanatory comments since many of them duplicated what was in the value_string.c file (and were out of sync with the recent updates I made to those in r48633). Presumably most of the comments should be in the .h file not the .c file, but there's enough churn ahead that it's not worth fixing yet. Part of https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=8467 svn path=/trunk/; revision=48634
2013-03-19From beroset:Anders Broman1-1/+1
remove C++ incompatibilities https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=8416 svn path=/trunk/; revision=48430
2013-02-24Fix some Dead Store (Dead assignement/Dead increment) Warning found by ClangAlexis La Goutte1-1/+1
svn path=/trunk/; revision=47859
2012-12-26Fix a bunch of warnings.Guy Harris1-11/+11
Cast away some implicit 64-bit-to-32-bit conversion errors due to use of sizeof. Cast away some implicit 64-bit-to-32-bit conversion errors due to use of strtol() and strtoul(). Change some data types to avoid those implicit conversion warnings. When assigning a constant to a float, make sure the constant isn't a double, by appending "f" to the constant. Constify a bunch of variables, parameters, and return values to eliminate warnings due to strings being given const qualifiers. Cast away those warnings in some cases where an API we don't control forces us to do so. Enable a bunch of additional warnings by default. Note why at least some of the other warnings aren't enabled. randpkt.c and text2pcap.c are used to build programs, so they don't need to be in EXTRA_DIST. If the user specifies --enable-warnings-as-errors, add -Werror *even if the user specified --enable-extra-gcc-flags; assume they know what they're doing and are willing to have the compile fail due to the extra GCC warnings being treated as errors. svn path=/trunk/; revision=46748
2012-09-20We always HAVE_CONFIG_H so don't bother checking whether we have it or not.Jeff Morriss1-3/+1
svn path=/trunk/; revision=45017
2012-09-10Initial commit to support yet another method of passing data between dissectors.Jakub Zawadzki1-1/+1
Add new parameter 'data' to heur_dissector_t and new_dissector_t, for now it's always NULL svn path=/trunk/; revision=44860
2012-08-10Use val_to_str_const() where appropriate;Bill Meier1-1/+1
Also (for a few files): - create/use some extended value strings; - remove unneeded #include files; - remove unneeded variable initialization; - re-order fcns slightly so prefs_reg_handoff...() at end, etc svn path=/trunk/; revision=44438
2012-06-28Update FSF address - part II.Jakub Zawadzki1-1/+1
svn path=/trunk/; revision=43538
2012-05-15Remove unneeded includes (ctype.h, stdio.h);Bill Meier1-8/+7
In one case, define our own size for a string buffer (instead of using a magic constant 'BUFSIZ'); In a few cases: do some whitespace, indentation & reformatting cleanup. svn path=/trunk/; revision=42634
2012-05-11Get rid of remaining Booleans-as-encoding-arguments inGuy Harris1-5/+21
proto_tree_add_item() calls. svn path=/trunk/; revision=42561
2011-11-14The Originator protocol identifier is not present in the "provisioning ↵Chris Maynard1-2/+4
actions operation -61", only the "session management operatin -60". Fixes https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=6570. svn path=/trunk/; revision=39834
2011-10-27Fix proto_tree_add_item( encoding args;Bill Meier1-1/+1
Do whitespace cleanup (for a few files). svn path=/trunk/; revision=39640
2011-10-21For proto_tree_add_item(..., proto_xxx, ...)use ENC_NA as the encoding arg.Bill Meier1-1/+1
Also: remove trailing whitespace for a number of files. svn path=/trunk/; revision=39503
2011-10-15Convert proto_tree_add_item() 'encoding' arg for field types FT_STRING, ↵Bill Meier1-1/+1
FT_STRINGZ, FT_UINT_STRING as follows: 1. If there's no character encoding (ENC_ASCII, ...) specified then use ENC_ASCII. 2. For all but FT_UINT_STRING, always use ENC_NA (replacing any existing True/1/FALSE/0 /ENC_BIG_ENDIAN/ENC_LITTLE_ENDIAN). svn path=/trunk/; revision=39426
2011-10-04Use ENC_NA as encoding for proto_tree_add_item() calls which directly ↵Bill Meier1-2/+2
reference an hf item (in hf[] with types: FT_NONE FT_BYTES FT_IPV6 FT_IPXNET FT_OID Note: Encoding field set to ENC_NA only if the field was previously TRUE|FALSE|ENC_LITTLE_ENDIAN|ENC_BIG_ENDIAN svn path=/trunk/; revision=39260
2011-04-22Use the return value of proto_item_add_subtree()Jeff Morriss1-2/+3
svn path=/trunk/; revision=36807
2011-04-18Removed some unneeded assignments.Stig Bjørlykke1-2/+2
Found by clang. svn path=/trunk/; revision=36698
2010-12-06Make some (preference) variables static.Jeff Morriss1-1/+1
svn path=/trunk/; revision=35134
2010-07-21(Trivial) add a few comments about date/time formats.Bill Meier1-20/+21
svn path=/trunk/; revision=33600
2010-05-13As suggested in ↵Jeff Morriss1-8/+2
http://www.wireshark.org/lists/wireshark-dev/200809/msg00075.html (as referenced in https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=2907 ) and https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=3411 : Write a new convenience routine for finding a conversation and, if it is not found, create it. The frame number and addresses are taken from pinfo (as is the common case). Use this function in a bunch of dissectors. svn path=/trunk/; revision=32790
2010-05-03Rework code to handle multiple messages in a packet.Bill Meier1-178/+180
Fixes Bug #4709. See: https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=4709 svn path=/trunk/; revision=32654
2010-04-26Various:Bill Meier1-1406/+1421
- Fix bugs which caused incorrect packet-bytes highlighting for certain fields; - Display all "extended services" fields; - Minor code cleanup in several places; - Whitespace: Tabs ==> spaces. (More changes yet to come to handle multiple PDUs in a single packet). svn path=/trunk/; revision=32567
2010-04-26Remove some boilerplate text; Shorten a few long lines.Bill Meier1-8/+6
svn path=/trunk/; revision=32565
2010-04-06#include <string.h> not needed.Bill Meier1-1/+0
svn path=/trunk/; revision=32410
2009-12-19For fields of type FT_ABSOLUTE_TIME, have the "display" value be one ofGuy Harris1-8/+8
ABSOLUTE_TIME_LOCAL or ABSOLUTE_TIME_UTC, indicating whether to display the date/time in local time or UTC. (int)ABSOLUTE_TIME_LOCAL == (int)BASE_NONE, so there's no source or binary compatiblity issue, although we might want to eliminate BASE_NONE at some point and have the BASE_ values used with integral types start at 0, so that you can't specify BASE_NONE for an integral field. svn path=/trunk/; revision=31319
2009-08-16Switch a bunch of dissectors over to using tvb_new_subset_remaining()Kovarththanan Rajaratnam1-1/+1
svn path=/trunk/; revision=29446
2009-08-09Don't guard col_set_str (COL_PROTOCOL) with col_checkKovarththanan Rajaratnam1-4/+2
svn path=/trunk/; revision=29340
2009-07-08From Kovarththanan Rajaratnam:Anders Broman1-1/+1
No letter-shortcuts in Telephony menu. https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=3678 svn path=/trunk/; revision=29028
2009-06-18From Kovarththanan Rajaratnam via bug 3548:Stig Bjørlykke1-8/+8
(1) Trailing/leading spaces are removed from 'name's/'blurb's (2) Duplicate 'blurb's are replaced with NULL (3) Empty ("") 'blurb's are replaced with NULL (4) BASE_NONE, NULL, 0x0 are used for 'display', 'strings' and 'bitmask' fields for FT_NONE, FT_BYTES, FT_IPv4, FT_IPv6, FT_ABSOLUTE_TIME, FT_RELATIVE_TIME, FT_PROTOCOL, FT_STRING and FT_STRINGZ field types (5) Only allow non-zero value for 'display' if 'bitmask' is non-zero svn path=/trunk/; revision=28770
2009-06-05Have tap listeners specify whether the "packet" routine requiresGuy Harris1-1/+1
a protocol tree; the column values. This includes stats-tree listeners. Have the routines to build the packet list, and to retap packets, honor those requirements. This means that cf_retap_packets() no longer needs an argument to specify whether to construct the column values or not, so get rid of that argument. This also means that there's no need for a tap to have a fake filter to ensure that the protocol tree will be built, so don't set up a fake "frame" filter. While we're at it, clean up some cases where "no filter" was represented as a null string rather than a null pointer. Have a routine to return an indication of the number of tap listeners with filters; use that rather than the global num_tap_filters. Clean up some indentation and some gboolean vs. gint items. svn path=/trunk/; revision=28645
2009-05-26Misc dissector cleanup:Bill Meier1-21/+21
- Make some fcns & vars static - hf[] blurbs: "" and repeated text --> NULL - Move proto_register & proto_reg_handoff to end of source - packet-catapult-dct2000: simplify proto_reg_handoff - Use consistent indentation svn path=/trunk/; revision=28488
2009-05-01From Reinhard Speyerer:Jaap Keuter1-1/+1
This patch fixes several misspellings/typos in Wireshark SVN revision 28201. svn path=/trunk/; revision=28229
2009-02-10Remove an ugly hack:Ulf Lamping1-2/+2
There was an ugly hack while creating the menu, that tried to detect the stat_group a stats_tree belongs to by looking at the name string. That makes it unnecessarily hard to understand how the menu is really created. Fix: Add a new function stats_tree_register_with_group() that takes the stat_group as a parameter. Use this function where a stats_tree doesn't fit into the default "unsorted" group. svn path=/trunk/; revision=27407
2008-12-20Fix various typos and spelling errors (mostly in text strings)Bill Meier1-6/+6
svn path=/trunk/; revision=27065
2008-12-17Fix typos and spelling (mostly in text strings) Bill Meier1-1/+1
svn path=/trunk/; revision=27028
2008-07-11Change the stats tree API to use signed chars instead of guint8s for all itsJeff Morriss1-7/+9
strings; this should fix a number of signed/unsigned char warnings. Reindent a bunch, too. svn path=/trunk/; revision=25716
2008-05-03From Abhik Sarkar:Jaap Keuter1-74/+184
This patch adds basic support for stats to the UCP dissector using the Stats Tree API. svn path=/trunk/; revision=25222
2008-03-04match_strval() may return NULL so don't blindly pass its return value into ↵Jeff Morriss1-1/+1
col_add_*() or proto_add_*(); use val_to_str() (returning "Unknown (%d)" if no match is found) instead. svn path=/trunk/; revision=24557
2007-12-17Bug 2116 - From Lawrence Reisler :Sake Blok1-1/+3
During a regular Wireshark trace of UCP packets running over ethernet, I noted that Wireshark said the login packet was malformed, even though it looked OK and the server responded correctly. After looking at the UCP protocol, it became clear that Wireshark was parsing a type 60 message which only has one Reserverd field (RES1) and expecting it to have two Reserved fields (RES1 and RES2) like a type 61 message. This is because it is using the same function to parse both messages, and does not have a conditional for the type 60 field. svn path=/trunk/; revision=23903
2007-03-26From Sebastien Tandel Ronnie Sahlberg1-2/+2
fixes for various compiler warnings svn path=/trunk/; revision=21210
2006-10-31change the signature for the get_pdu_len() function pointer passed to ↵Ronnie Sahlberg1-1/+1
tcp_dissect_pdus() to also include a packet_info pointer. there are many reasons why some protocols actually need to be able to access the pinfo structure while determining the pdu size svn path=/trunk/; revision=19751
2006-05-21change a whole bunch of ethereal into wiresharkRonnie Sahlberg1-3/+3
svn path=/trunk/; revision=18196
2006-04-08Fix bug 597:Anders Broman1-10/+66
- Add TCP reassembly to get the proper packet length - Add "result = check_ucp(tvb, &endpkt);" in dissect_udp_commong to fill some variables used. svn path=/trunk/; revision=17843
2006-01-06Bill Meier: More spelling fixesJörg Mayer1-2/+2
svn path=/trunk/; revision=16965
generated by cgit v1.2.3 (git 2.25.1) at 2024-10-06 08:34:47 +0000