aboutsummaryrefslogtreecommitdiffstats
path: root/epan/dissectors/packet-tango.c
AgeCommit message (Collapse)AuthorFilesLines
2015-04-23idl2wrs: don't use -1 for the protocol-item length.Jeff Morriss1-1/+1
It doesn't work any more for empty (length==0) PDUs. Similar to bug 10646/Ifb96768969a43c59367b73e7bb940ceeb02cf6b0 (for RPC). Untested as I'm not set up to build IDL dissectors now. Bug: 11134 Change-Id: I77aacc2590acbacbe02edb1768e754f92f87bc23 Reviewed-on: https://code.wireshark.org/review/8163 Reviewed-by: Michael Mann <mmann78@netscape.net> Reviewed-by: Evan Huus <eapache@gmail.com>
2014-04-25Cleanup "excess" from trying to support sequence of "native types". Last ↵Michael Mann1-105/+71
installment of bug 9532. Cleaned up wireshark_gen.py so that it no longer generates duplicate fields and greatly minimized the number of useless hf_ variables generated. Change-Id: I26b2ddb5b65fcde99787cc2771348aa1b37f919f Reviewed-on: https://code.wireshark.org/review/1329 Reviewed-by: Anders Broman <a.broman58@gmail.com>
2014-04-23Continuation of bug 9532.Michael Mann1-34/+62
Ie4d1edfd67a8e6f02834573f29f07baf79058534 created a several duplicate hf_ registrations. That led to the exposure of some other potential problems with generating sequences. Still not quite complete, but want to pacify the buildbots, so there is a small amount of manual editing to comment out a few duplicated hfs in packet-parlay.c. Change-Id: I0ff8a9795e213ab966db8d6333b9477bad06250b Reviewed-on: https://code.wireshark.org/review/1302 Reviewed-by: Michael Mann <mmann78@netscape.net>
2014-04-23Bugfix generating a sequence of "native" types. Bug 9532.Michael Mann1-4/+25
Previously a sequence of "native" types (int, float, etc) generated a proto_tree_add_uint (for the loop over the sequence) and a proto_tree_add_XXX (for the "native" type), but only 1 hf variable was created for the "loop" field, so DISSECTOR_ASSERT_NOT_REACHED would be generated if "native" type != uint. Now a separate hf_ variable is generated for the "loop" and "native" type. Also update existing IDL dissectors with new generator logic. Change-Id: Ie4d1edfd67a8e6f02834573f29f07baf79058534 Reviewed-on: https://code.wireshark.org/review/1274 Reviewed-by: Anders Broman <a.broman58@gmail.com>
2014-03-04Remove all $Id$ from top of fileAlexis La Goutte1-2/+0
(Using sed : sed -i '/^ \* \$Id\$/,+1 d') Fix manually some typo (in export_object_dicom.c and crc16-plain.c) Change-Id: I4c1ae68d1c4afeace8cb195b53c715cf9e1227a8 Reviewed-on: https://code.wireshark.org/review/497 Reviewed-by: Anders Broman <a.broman58@gmail.com>
2013-12-04Regenerate dissector after change to add prototypeAlexis La Goutte1-1/+3
svn path=/trunk/; revision=53779
2013-12-03Regenerate idl dissector after last change in generator !Alexis La Goutte1-178/+191
svn path=/trunk/; revision=53756
2013-12-02Character conversion error.Anders Broman1-1/+1
svn path=/trunk/; revision=53731
2013-12-02Add pragmas to remove warnings, this should go into the generation script.Anders Broman1-0/+4
svn path=/trunk/; revision=53730
2013-09-08expert_add_info_format_text -> expert_add_info_textMichael Mann1-46/+46
svn path=/trunk/; revision=51849
2013-05-24Use new expert info API in idl dissectors. These generated about 50% of the ↵Michael Mann1-47/+64
add_expert_info_format() calls. svn path=/trunk/; revision=49561
2013-01-22Fix for CID 761911-761984 and CID 761985-761994.Jaap Keuter1-0/+72
Try to convince Coverity that the passed in item pointer is appreciated, but not used. This time see if it pleases the Windows compiler too. svn path=/trunk/; revision=47217
2013-01-22Revert 47201 it does not compile on Windows.Anders Broman1-69/+0
svn path=/trunk/; revision=47208
2013-01-21Fix for CID 761911-761984 and CID 761985-761994.Jaap Keuter1-0/+69
Try to convince Coverity that the passed in item pointer is appreciated, but not used. svn path=/trunk/; revision=47201
2013-01-19Following r47157, this tries to suppress similar Coverity issues.Jaap Keuter1-0/+56
svn path=/trunk/; revision=47160
2012-12-26Change wireshark_gen.py to make the operation argument to routines aGuy Harris1-79/+79
"const char *", as it is now expected to be. Regenerate the dissectors. Update the URL for OmniOrb. In README.parlay, use idl2wrs in the sample command. svn path=/trunk/; revision=46765
2012-11-13Use proto_tree_add_<signed integer> functions for signed giop datatypesMichael Mann1-30/+30
svn path=/trunk/; revision=46021
2012-11-05Add a few more expert_add_info_format calls to giop dissector which requires ↵Michael Mann1-861/+285
packet_info* structure and proto_item* to be filtered down through the generated functions. Also removed some excessive whitespace. svn path=/trunk/; revision=45911
2012-10-11Make idl2wrs dissectors filterable - Part 1Michael Mann1-1259/+877
Updated wireshark_gen.py to generate hf_ variables for all of the IDL "types". The "simple" types use proto_tree_add_* (not text), while the "complex" types use the GIOP dissector API. checkhf.pl generates some warnings because (some of) the hf_ variables are being generated for the "complex" types, but are not being used. That will be done in Part 2. expert_add_info_format now linked to a real item instead of being attached to a duplicative proto_tree_add_text(). This cleaned up literally thousands of unnecessary proto_tree_add_text()s svn path=/trunk/; revision=45472
2012-09-20We always HAVE_CONFIG_H so don't bother checking whether we have it or not.Jeff Morriss1-3/+1
svn path=/trunk/; revision=45017
2012-09-05Replace process_RequestOperation macro by a real function to speedup ↵Pascal Quantin1-28/+36
compilation time svn path=/trunk/; revision=44779
2012-08-08From Michael Mann on -dev:Jeff Morriss1-1/+1
The idl2wrs generated dissectors don't follow the convention of using the filter name registered with the protocol as the start of any display filter name. This patch fixes that. svn path=/trunk/; revision=44325
2012-08-08Use expert infos instead of g_warning when something unexpected is found.Jeff Morriss1-138/+277
svn path=/trunk/; revision=44324
2012-07-08Add a function to packet-giop.c that does what the code that Jeff Morriss1-820/+95
template_get_CDR_string (in wireshark_gen.py) did. This eliminates another whole pile of function-local variables in packet-parlay.c. Unfortunately it doesn't seem to speed up compilation (or eliminate the variable tracking size limit problem). But it does eliminate a lot of lines of code... svn path=/trunk/; revision=43610
2012-07-08Eliminate a lot of function-local variables by not storing the result ofJeff Morriss1-326/+265
(several of the) get_CDR_*() functions: instead call the function directly in the proto_tree_add_text() calls. Eliminate a lot of global variables that are only later used in (a single) strcmp(). All the GIOP dissectors are built-in now; don't include the (#if'd out) plugin registration code in the generated dissector. Try to clean up the formatting of the generated code a bit. Regenerate the IDL dissectors; as noted in r39932, this seems to involve a lot of function re-ordering in packet-parlay.c (making the delta bigger). These changes decrease the time to compile packet-parlay.c by, on my system, about half. But it still complains: variable tracking size limit exceeded with -fvar-tracking-assignments, retrying without and it still takes "too long." svn path=/trunk/; revision=43609
2012-06-28Update Free Software Foundation address.Jakub Zawadzki1-1/+1
(COPYING will be updated in next commit) svn path=/trunk/; revision=43536
2012-06-01Make the tango dissector a builtin dissector.Anders Broman1-0/+4394
svn path=/trunk/; revision=42967