aboutsummaryrefslogtreecommitdiffstats
path: root/epan/dissectors/packet-syslog.c
AgeCommit message (Collapse)AuthorFilesLines
2015-08-27Remove calls of tvb_ensure_length_remaining.Michael Mann1-1/+1
The remaining calls seem to fall into 3 categories: 1. passing it to tvb_find_line_end when -1 (for length) will do. 2. duplicating the checking of tvb_reported_length_remaining, which is already in use near the tvb_ensure_length_remaining call. 3. Those that (probably) need tvb_ensure_capture_length_remaining Change-Id: I1e77695251e055644bcbbb89f3c181c65d1671ca Reviewed-on: https://code.wireshark.org/review/10268 Petri-Dish: Michael Mann <mmann78@netscape.net> Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org> Reviewed-by: Anders Broman <a.broman58@gmail.com>
2014-12-25Deleting unnecessary #includes from dissectors.Martin Mathieson1-1/+0
Fifth batch (packet-rtp.c -> end). Will look at cleaning up and committing script afterwards. Change-Id: I8ed61dc941d98d3f7259a9d1f74e214eb7b4bfa2 Reviewed-on: https://code.wireshark.org/review/6052 Reviewed-by: Martin Mathieson <martin.r.mathieson@googlemail.com>
2014-12-21Cleanup use of #includes in non-generated epan/dissector/*.cBill Meier1-2/+0
Specifically: - Set packet.h to be the first wireshark #include after config.h and "system" #includes. packet.h added as an #include in some cases when missing. - Remove some #includes included (directly/indirectly) in packet.h. E.g., glib.h. (Done only for those files including packet.h). - As needed, move "system" #includes to be after config.h and before wireshark #includes. - Rework various #include file specifications for consistency. - Misc. Change-Id: Ifaa1a14b50b69fbad38ea4838a49dfe595c54c95 Reviewed-on: https://code.wireshark.org/review/5923 Petri-Dish: Alexis La Goutte <alexis.lagoutte@gmail.com> Reviewed-by: Bill Meier <wmeier@newsguy.com>
2014-10-20Get rid of calls to ctype.h functions.Guy Harris1-2/+1
They don't handle values outside the range -1 to 127, and their behavior is locale-dependent. Use g_ascii_isXXX() and g_ascii_toXXX() instead of isXXX() and toXXX(). If you're checking for printable ASCII, don't use isascii() and don't use iscntrl(), use g_ascii_isprint(). If you're checking for graphical ASCII, i.e. printable ASCII except for a space, use g_ascii_isgraph(). Use ws_xton() to convert a hex digit character to the corresponding numeric value. Change-Id: Id3039bc586fbf66d8736c2df248c790c0d7a2330 Reviewed-on: https://code.wireshark.org/review/4851 Reviewed-by: Guy Harris <guy@alum.mit.edu>
2014-10-05Add editor modelines; Adjust whitespace as needed.Bill Meier1-110/+123
Change-Id: I6e70c933ae61a97377235d67b2f6a1b3d67dc155 Reviewed-on: https://code.wireshark.org/review/4484 Reviewed-by: Bill Meier <wmeier@newsguy.com>
2014-06-20Rename dissector_add_handle() to dissector_add_for_decode_as().Guy Harris1-1/+1
Hopefully that name makes it clear what the routiner's purpose is, and will encourage people to use it rather than using dissector_add_uint() with a bogus integer value. Change-Id: Ic5be456d0ad40b176aab01712ab7b13aed5de2a8 Reviewed-on: https://code.wireshark.org/review/2483 Reviewed-by: Guy Harris <guy@alum.mit.edu>
2014-06-19Revert "Fixup: tvb_ensure_length_remaining -> ↵Michael Mann1-1/+1
tvb_ensure_captured_length_remaining" See https://www.wireshark.org/lists/wireshark-dev/201406/msg00131.html This reverts commit 021e7afc9fcba09094d0e2143cc434a34e3b09dc. Change-Id: I0640eabce5ce8c4ff3a88ebf848b499f8bb8ed2f Reviewed-on: https://code.wireshark.org/review/2429 Reviewed-by: Michael Mann <mmann78@netscape.net>
2014-06-18Fixup: tvb_ensure_length_remaining -> tvb_ensure_captured_length_remainingDario Lombardo1-1/+1
Change-Id: I0228f3b6b7067bc0ce51f9d359f99fd18feb2b66 Reviewed-on: https://code.wireshark.org/review/2378 Reviewed-by: Anders Broman <a.broman58@gmail.com>
2014-03-04Remove all $Id$ from top of fileAlexis La Goutte1-2/+0
(Using sed : sed -i '/^ \* \$Id\$/,+1 d') Fix manually some typo (in export_object_dicom.c and crc16-plain.c) Change-Id: I4c1ae68d1c4afeace8cb195b53c715cf9e1227a8 Reviewed-on: https://code.wireshark.org/review/497 Reviewed-by: Anders Broman <a.broman58@gmail.com>
2013-12-10- Forward declaration of register functions.Anders Broman1-0/+3
svn path=/trunk/; revision=53918
2013-08-05Keep result of [new_]register_dissector in some dissectors.Jakub Zawadzki1-4/+3
svn path=/trunk/; revision=51156
2013-06-14Remove check_col() and the occasional tree.Michael Mann1-1/+1
svn path=/trunk/; revision=49923
2012-11-17From Stephen Wall:Jaap Keuter1-0/+2
This patch allows one to specify telnet or syslog as the protocol in an SSL Decrypt profile. svn path=/trunk/; revision=46057
2012-09-20We always HAVE_CONFIG_H so don't bother checking whether we have it or not.Jeff Morriss1-3/+1
svn path=/trunk/; revision=45017
2012-08-10Use val_to_str_const() where appropriate;Bill Meier1-4/+4
Also (for a few files): - create/use some extended value strings; - remove unneeded #include files; - remove unneeded variable initialization; - re-order fcns slightly so prefs_reg_handoff...() at end, etc svn path=/trunk/; revision=44438
2012-06-28Update Free Software Foundation address.Jakub Zawadzki1-1/+1
(COPYING will be updated in next commit) svn path=/trunk/; revision=43536
2012-06-09Allow syslog to work with "Decode As" for TCP.Chris Maynard1-0/+1
Fixes https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=5241 svn path=/trunk/; revision=43174
2012-05-15Remove unneeded #includes (stdlib, stdio, ctypes, time);Bill Meier1-2/+2
In a few cases: do some whitespace, indentation cleanup & reformatting. svn path=/trunk/; revision=42632
2011-12-13Fix tvbuff memory leak.Bill Meier1-8/+8
svn path=/trunk/; revision=40186
2011-10-15Convert proto_tree_add_item() 'encoding' arg for field types FT_STRING, ↵Bill Meier1-1/+1
FT_STRINGZ, FT_UINT_STRING as follows: 1. If there's no character encoding (ENC_ASCII, ...) specified then use ENC_ASCII. 2. For all but FT_UINT_STRING, always use ENC_NA (replacing any existing True/1/FALSE/0 /ENC_BIG_ENDIAN/ENC_LITTLE_ENDIAN). svn path=/trunk/; revision=39426
2011-09-01Update my email address (the old one still works but I don't use it for ↵Jeff Morriss1-1/+1
Wireshark related stuff). svn path=/trunk/; revision=38841
2011-03-25remove two unused assignmentsRonnie Sahlberg1-2/+2
coverity 1050 svn path=/trunk/; revision=36329
2010-12-20Rename the routines that handle dissector tables with unsigned integerGuy Harris1-1/+1
keys to have _uint in their names, to match the routines that handle dissector tables with string keys. (Using _port can confuse people into thinking they're intended solely for use with TCP/UDP/etc. ports when, in fact, they work better for things such as Ethernet types, where the binding of particular values to particular protocols are a lot stronger.) svn path=/trunk/; revision=35224
2010-04-03Remove unneeded #include <stdio.h>Bill Meier1-1/+0
svn path=/trunk/; revision=32367
2009-08-09Don't guard col_clear with col_checkKovarththanan Rajaratnam1-2/+1
svn path=/trunk/; revision=29344
2009-08-09Don't guard col_set_str (COL_PROTOCOL) with col_checkKovarththanan Rajaratnam1-2/+1
svn path=/trunk/; revision=29340
2009-04-03Some size_t cleanups.Guy Harris1-3/+3
svn path=/trunk/; revision=27951
2008-06-30Create the MTP3 TVB (if any) with a reported length that mirrors the ↵Jeff Morriss1-5/+9
reported length of the frame. That way subdissector exceptions on short frames will (properly) show up as 'packet size limited during capture'. svn path=/trunk/; revision=25637
2008-06-26Fix a comment: the subdissector won't /assert/ out it will /except/ out if ↵Jeff Morriss1-1/+1
the MSU is truncated. svn path=/trunk/; revision=25613
2008-06-26From Abhik Sarkar via https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=2647 :Jeff Morriss1-4/+15
The syslog dissector could crash if the "packlog" MSU is truncated such that the hex string ends in with a nibble. From me: Check if that will happen and chop off the nibble before giving it to convert_string_to_hex() so we'll dissect as much of the MSU as possible. svn path=/trunk/; revision=25612
2008-04-07- Remove GLIB1 codeStephen Fisher1-1/+0
- Change ugly GLIB version checking statements to GLIB_CHECK_VERSION - Remove ws_strsplit files because we no longer need to borrow GLIB2's g_strsplit code for the no longer supported GLIB1 builds svn path=/trunk/; revision=24829
2007-03-27Include ws_strsplit.h to override glib 1.2's (buggy) g_strsplit() as per rev ↵Jeff Morriss1-2/+3
20804 svn path=/trunk/; revision=21226
2007-03-22From Abhik Sarkar: call add_new_data_source() on generated (MTP3) tvb so ↵Jeff Morriss1-1/+5
that users can see the bytes in a (new) byte pane. svn path=/trunk/; revision=21109
2007-02-19Declare nbytes to match what the routine getting a pointer to itGuy Harris1-1/+1
expects. svn path=/trunk/; revision=20843
2007-02-01From Abhik Sarkar: support for decoding SS7 MSUs embedded in a syslog messageJeff Morriss1-69/+174
(as generated by the Cisco ITP packet logging facility). svn path=/trunk/; revision=20665
2006-05-21change a whole bunch of ethereal into wiresharkRonnie Sahlberg1-4/+4
svn path=/trunk/; revision=18196
2006-02-21Fix for bug 758: Adding facility codes 12-15 according to RFC 3164Jaap Keuter1-10/+11
svn path=/trunk/; revision=17361
2006-01-29Use tvb_format_text() on the message, to handle non-printable charactersGuy Harris1-15/+3
(including tabs and newlines). svn path=/trunk/; revision=17118
2005-10-27get rid of a strcpyRonnie Sahlberg1-1/+1
svn path=/trunk/; revision=16339
2004-07-18Move dissectors to epan/dissectors directory.Gilbert Ramirez1-0/+253
Also move ncp222.py, x11-fields, process-x11-fields.pl, make-reg-dotc, and make-reg-dotc.py. Adjust #include lines in files that include packet-*.h files. svn path=/trunk/; revision=11410