aboutsummaryrefslogtreecommitdiffstats
path: root/epan/dissectors/packet-smtp.c
AgeCommit message (Collapse)AuthorFilesLines
2009-08-09Don't guard col_set_str (COL_PROTOCOL) with col_checkKovarththanan Rajaratnam1-2/+1
svn path=/trunk/; revision=29340
2009-06-18From Kovarththanan Rajaratnam via bug 3548:Stig Bjørlykke1-10/+10
(1) Trailing/leading spaces are removed from 'name's/'blurb's (2) Duplicate 'blurb's are replaced with NULL (3) Empty ("") 'blurb's are replaced with NULL (4) BASE_NONE, NULL, 0x0 are used for 'display', 'strings' and 'bitmask' fields for FT_NONE, FT_BYTES, FT_IPv4, FT_IPv6, FT_ABSOLUTE_TIME, FT_RELATIVE_TIME, FT_PROTOCOL, FT_STRING and FT_STRINGZ field types (5) Only allow non-zero value for 'display' if 'bitmask' is non-zero svn path=/trunk/; revision=28770
2009-04-03size_t fix (you won't get more than 2^31-1 bytes there).Guy Harris1-1/+1
svn path=/trunk/; revision=27953
2008-11-23From Didier Gautheron (bug 3056):Stig Bjørlykke1-30/+36
1) do more work when tree is NULL, otherwise data desegmentation doesn't work. 2) set desegment_len to DESEGMENT_ONE_MORE_SEGMENT rather than 1 when searching for end of line. 3) set frame_data->pdu_type for STARTTLS cmd and use se_alloc0 rather than se_alloc 4) restore pinfo can_desegment to saved_can_desegment or ssl can't desegment packets. 5) move TLS call before searching for cmd. It doesn't deal with rejected TLS negotation. Not hard to do but I haven't a capture, it anyone can share one. svn path=/trunk/; revision=26826
2008-10-11From Ward van Wanrooij (bug 2955):Stig Bjørlykke1-4/+7
Add the fragment to the defragmentation sequence if the SMTP dissector encouters a packet that contains both a DATA fragment and the terminating \r\n.\r\n sequence. svn path=/trunk/; revision=26419
2008-09-30Minor proto_reg_handoff cleanup: use find_dissector when appropriate.Bill Meier1-1/+1
svn path=/trunk/; revision=26308
2008-09-10strncasecmp ==> g_ascii_strncasecmpBill Meier1-1/+1
svn path=/trunk/; revision=26172
2008-09-07Move the advancement of the packet offset outside the "if (tree)".Guy Harris1-11/+10
This fixes bug 2856. svn path=/trunk/; revision=26159
2008-09-07Style and indentation cleanups.Guy Harris1-106/+39
Don't initialize a variable that's set (in the handoff registration routine) before being used. Now that we're GLib 2.0-only, use g_ascii_isalpha() rather than rolling our own. svn path=/trunk/; revision=26157
2008-09-07Add support for TLS-over-SMTP.Guy Harris1-109/+157
svn path=/trunk/; revision=26156
2008-09-06Have a line_is_smtp_command() routine to check whether a line is an SMTPGuy Harris1-20/+69
command, and use that in the parsing loop (that means we don't have to treat 4-character commands and non-4-character commands separately). svn path=/trunk/; revision=26155
2008-09-06Add some comments.Guy Harris1-0/+8
svn path=/trunk/; revision=26153
2008-09-05Move another comment next to the code to which it refers.Guy Harris1-4/+4
svn path=/trunk/; revision=26144
2008-09-05Move a comment to the right place.Guy Harris1-10/+9
svn path=/trunk/; revision=26143
2008-09-05Clean up indentation.Guy Harris1-455/+455
svn path=/trunk/; revision=26142
2008-05-14Fix some of the Errors/warnings detected by checkapi.Bill Meier1-3/+5
svn path=/trunk/; revision=25290
2008-04-13Initialize linelen to avoid a warning.Stig Bjørlykke1-1/+1
svn path=/trunk/; revision=24994
2008-04-13Support for RFC 2920 SMTP Command Pipelining. Graeme Lunt1-55/+118
The client can send multiple requests before waiting for responses. Multiple requests/responses are delimited in the info column using " | ". Also changed to using "C:" (client) and "S:" (server) to save space in the info column and align with examples in RFC 2821. Lack of support for PIPELINING was shown up during Sake's session at SharkFest08! svn path=/trunk/; revision=24989
2008-04-09Remove:Anders Broman1-4/+0
#ifdef NEED_G_ASCII_STRCASECMP_H #include "g_ascii_strcasecmp.h" #endif svn path=/trunk/; revision=24859
2007-12-28Add submission port dissection.Jaap Keuter1-0/+5
svn path=/trunk/; revision=23957
2007-11-27strcasecmp(), strncasecmp(), g_strcasecmp(), and g_strncasecmp() delendaGuy Harris1-6/+10
est. Use g_ascii_strcasecmp() and g_ascii_strncasecmp(), and supply our own versions if they're missing from GLib (as is the case with GLib 1.x). In the code to build the list of named fields for Diameter, don't use g_strdown(); do our own g_ascii_-style upper-case to lower-case mapping in the hash function and use g_ascii_strcasecmp() in the compare function. We do this because there is no guarantee that toupper(), tolower(), and functions that use them will, for example, map between "I" and "i" in all locales; in Turkish locales, for example, there are, in both upper case and lower case, versions of "i" with and without a dot, and the upper-case version of "i" is "I"-with-a-dot and the lower-case version of "I" is "i"-without-a-dot. This causes strings that should match not to match. This finishes fixing bug 2010 - an earlier checkin prevented the crash (as there are other ways to produce the same crash, e.g. a bogus dictionary.xml file), but didn't fix the case-insensitive string matching. svn path=/trunk/; revision=23623
2007-10-23Apply the small performance enhancment patches for:Anders Broman1-1/+1
- if offset is 0, tvb_length is the same as tvb_length_remaining, just faster. Replace - col_append_fstr() with faster col_append_str() - col_add_str() with col_set_str() when it's safe svn path=/trunk/; revision=23252
2007-08-15Added support for RFC3030 (BDAT) in SMTP.Stig Bjørlykke1-38/+113
Added data fragment length to COL_INFO. Changed some 0/1 values to boolean. http://bugs.wireshark.org/bugzilla/show_bug.cgi?id=1736 svn path=/trunk/; revision=22516
2007-07-04New preference to allow for the reassembly of SMTP DATA and subsequent ↵Graeme Lunt1-20/+180
dissection as Internet Message Format (imf). (imf dissector in separate patch). svn path=/trunk/; revision=22240
2007-03-28Remove almost all of the casts I committed recently and in place ofStephen Fisher1-4/+4
them, add -Wno-pointer-sign to CFLAGS when gcc will accept it. svn path=/trunk/; revision=21253
2007-03-28Fix a bunch of warnings, add svn:keywords Id and svn:eol-style nativeStephen Fisher1-4/+4
to packet-iuup.c. svn path=/trunk/; revision=21244
2006-10-25Allow DCT2000 support to find a couple of more protocols.Martin Mathieson1-1/+4
Try to squash some warnings seen on the ubuntu buildbot log svn path=/trunk/; revision=19683
2006-05-21change a whole bunch of ethereal into wiresharkRonnie Sahlberg1-3/+3
svn path=/trunk/; revision=18196
2005-08-12remove some unused variables from scsiRonnie Sahlberg1-25/+3
change two gmemchunks in smtp to se_alloc() and remove one now redundant init routine. svn path=/trunk/; revision=15308
2005-02-02From Jon Ringle:Anders Broman1-2/+2
1) Added a setup_frame parameter to conversation_t 2) Used the conversation_t next to maintain a list of conversations with the same src/dest tuple but different setup_frame number. 3) Changed the signature of find_conversation() and conversation_new() to pass in the frame number. 4) Adjusted packet-sdp to select RTP conversation if both m=audio and m=image are present, and T.38 conversation if only m=image is present. I expect that RTP/T.38 dissecting to be better, but I don't have a way to generate T.38 packets. svn path=/trunk/; revision=13243
2004-09-27Move prefs.c and prefs.h into the epan subdirectory.Guy Harris1-1/+1
svn path=/trunk/; revision=12115
2004-08-21Prevent the word "desegmentation" at the GUI, but use reassembling at that ↵Ulf Lamping1-2/+3
places, as we also use "defragmentation" and "reassembling". Use reassembling as the general term for such actions. I (hopefully) didn't changed any protocol fields or preference file names, but only the GUI labels appearing in the protocol display and the protocol preferences. Also added a note to the protocol preferences (where appropriate), that you have to enable "Allow subdissectors to reassemble TCP streams" at the corresponding protocol settings for TCP reassembling to take effect. If you encounter any mistakes I've made here, please let me know... svn path=/trunk/; revision=11784
2004-08-06From Albert Chin: rename resolv.{ch} to addr_resolv.{ch}, so that anGuy Harris1-1/+1
include of <resolv.h> in any system header file gets the system <resolv.h> (needed for builds on Tru64 with GTK+ 1.2[.x]). svn path=/trunk/; revision=11615
2004-07-18Move dissectors to epan/dissectors directory.Gilbert Ramirez1-0/+597
Also move ncp222.py, x11-fields, process-x11-fields.pl, make-reg-dotc, and make-reg-dotc.py. Adjust #include lines in files that include packet-*.h files. svn path=/trunk/; revision=11410
generated by cgit v1.2.3 (git 2.25.1) at 2024-09-23 12:16:04 +0000