aboutsummaryrefslogtreecommitdiffstats
path: root/epan/dissectors/packet-smpp.c
AgeCommit message (Collapse)AuthorFilesLines
2013-11-10Add missing includes in order to remove exceptions.h from proto.h (next commit).Jakub Zawadzki1-0/+1
svn path=/trunk/; revision=53230
2013-11-09Add data parameter to tcp_dissect_pdus() as well as convert it to using ↵Michael Mann1-14/+16
"new" style dissectors. Now that "bytes consumed" can be determined, should tcp_dissect_pdus() take advantage of that? Should tcp_dissect_pdus return length (bytes consumed)? There are many dissectors that just call tcp_dissect_pdus() then return tvb_length(tvb). Seems like that could all be rolled into one. svn path=/trunk/; revision=53198
2013-10-29From didier gautheron: remove redundant or use faster col_xxx functionsBill Meier1-1/+0
- when the text parameter is constant col_add_str() and col_set_str() are equivalent but col_set_str() is faster. - same for replace col_append_fstr and col_append_str - remove col_clear() when it's redundant: + before a col_set/col_add if the dissector can't throw an exception. - replace col_append() after a col_clear() with faster col_add... or col_set https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=9344 svn path=/trunk/; revision=52948
2013-09-22More emem -> wmem conversion:Pascal Quantin1-2/+2
- tvb_get_g_stringz()/tvb_get_ephemeral_stringz()/tvb_get_seasonal_stringz() -> tvb_get_stringz() - tvb_get_g_stringz_enc()/tvb_get_ephemeral_stringz_enc() -> tvb_get_stringz_enc() - tvb_get_ephemeral_unicode_stringz() -> tvb_get_unicode_stringz() - tvb_bcd_dig_to_ep_str() -> tvb_bcd_dig_to_wmem_packet_str() - update docs accordingly svn path=/trunk/; revision=52180
2013-09-14emem -> wmemJörg Mayer1-6/+6
svn path=/trunk/; revision=52038
2013-06-14Remove check_col() and the occasional tree.Michael Mann1-20/+18
svn path=/trunk/; revision=49923
2013-03-29Rename value string (and similar) functions to use a consistent pattern. ThisEvan Huus1-4/+4
was done using textual search+replace, not anything syntax-aware, so presumably it got most comments as well (except where there were typos). Use a consistent coding style, and make proper use of the WS_DLL_* defines. Group the functions appropriately in the header. I ended up getting rid of most of the explanatory comments since many of them duplicated what was in the value_string.c file (and were out of sync with the recent updates I made to those in r48633). Presumably most of the comments should be in the .h file not the .c file, but there's enough churn ahead that it's not worth fixing yet. Part of https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=8467 svn path=/trunk/; revision=48634
2013-03-19From beroset:Anders Broman1-1/+1
remove C++ incompatibilities https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=8416 svn path=/trunk/; revision=48430
2013-03-17Fix some Dead Store (Dead assignement/Dead increment) Warning found by ClangAlexis La Goutte1-1/+1
svn path=/trunk/; revision=48376
2012-12-26Fix a bunch of warnings.Guy Harris1-4/+4
Cast away some implicit 64-bit-to-32-bit conversion errors due to use of sizeof. Cast away some implicit 64-bit-to-32-bit conversion errors due to use of strtol() and strtoul(). Change some data types to avoid those implicit conversion warnings. When assigning a constant to a float, make sure the constant isn't a double, by appending "f" to the constant. Constify a bunch of variables, parameters, and return values to eliminate warnings due to strings being given const qualifiers. Cast away those warnings in some cases where an API we don't control forces us to do so. Enable a bunch of additional warnings by default. Note why at least some of the other warnings aren't enabled. randpkt.c and text2pcap.c are used to build programs, so they don't need to be in EXTRA_DIST. If the user specifies --enable-warnings-as-errors, add -Werror *even if the user specified --enable-extra-gcc-flags; assume they know what they're doing and are willing to have the compile fail due to the extra GCC warnings being treated as errors. svn path=/trunk/; revision=46748
2012-09-20We always HAVE_CONFIG_H so don't bother checking whether we have it or not.Jeff Morriss1-3/+1
svn path=/trunk/; revision=45017
2012-09-10Initial commit to support yet another method of passing data between dissectors.Jakub Zawadzki1-1/+1
Add new parameter 'data' to heur_dissector_t and new_dissector_t, for now it's always NULL svn path=/trunk/; revision=44860
2012-07-31Updated GSM dissectors display filters per checkfiltername.plMichael Mann1-2/+2
Tried to provide consistency with GSM dissector (protocol) names, even if the filenames now don't match the dissector name. svn path=/trunk/; revision=44162
2012-06-28Update FSF address - part II.Jakub Zawadzki1-1/+1
svn path=/trunk/; revision=43538
2012-05-07General minor cleanup including:Bill Meier1-229/+223
- remove unneeded #includes; - use val_to_str_const() as appropriate; - reformat hf[] entries; - reformat long lines; - use #if 0/#endif to coment out code instead of /* ... */; - remove boilerplate comments; - whitespace & indentation svn path=/trunk/; revision=42487
2012-03-18From Reinhard Speyerer: Fix several misspellings/typos in WiresharkBill Meier1-1/+1
https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=6967 svn path=/trunk/; revision=41645
2012-02-17(Re)fix https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=6712 :Jeff Morriss1-8/+23
The change made in r40742 turned out to not be portable (FreeBSD doesn't have the timezone global variable), so use another method to determine the current timezone. Also fix a bug introduced by r40742's change to display this timestamp in UTC: if the reported (by the message) time zone has a negative offset to UTC, shift it forward (not backward) to get UTC (and the opposite for positive offsets). svn path=/trunk/; revision=41044
2012-02-05From Stipe Tolj:Anders Broman1-4/+24
Ensure that ALL response PDUs are displayed, and the corresponding description text for the reserved or vendor-specific error code is displayed. https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=6108 svn path=/trunk/; revision=40848
2012-01-27Fix https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=6712 :Jeff Morriss1-4/+12
Since SMPP knows the time zone of its (absolute) times and since we don't have access to a mktime() routine that doesn't take into account the local time zone (and since I don't think repeatedly setting the TZ environment variable is a healthy choice): 1) subtract the 'timezone' (or '_timezone' on Windows) back out after calling mktime() 2) then adjust the time to take into the protocol-specified time zone 3) and (finally) display the time in UTC (since we don't have the infrastructure to display it in the protocol-specified time zone). (I *think* (1) is portable: POSIX says that variable should exist...) svn path=/trunk/; revision=40742
2012-01-23Fix some duplicate display filter names.Chris Maynard1-1/+1
svn path=/trunk/; revision=40669
2011-10-21For proto_tree_add_item(..., proto_xxx, ...)use ENC_NA as the encoding arg.Bill Meier1-1/+1
Also: remove trailing whitespace for a number of files. svn path=/trunk/; revision=39503
2011-10-11Fix a number of benign bugs wherein proto_tree_add_uint was intended (rather ↵Bill Meier1-38/+38
than proto_tree_add_item). Tip o' the hat to Guy ... svn path=/trunk/; revision=39356
2011-10-11Revert SVN #39345; (There's a better way ...)Bill Meier1-17/+20
svn path=/trunk/; revision=39355
2011-10-10Fix some benign bugs in proto_tree_add_item() 'encoding' arg.Bill Meier1-20/+17
svn path=/trunk/; revision=39345
2011-10-04Use ENC_NA as encoding for proto_tree_add_item() calls which directly ↵Bill Meier1-22/+22
reference an hf item (in hf[] with types: FT_NONE FT_BYTES FT_IPV6 FT_IPXNET FT_OID Note: Encoding field set to ENC_NA only if the field was previously TRUE|FALSE|ENC_LITTLE_ENDIAN|ENC_BIG_ENDIAN svn path=/trunk/; revision=39260
2011-09-24Make buildbot happyAlexis La Goutte1-1/+1
svn path=/trunk/; revision=39121
2011-09-24From Abhik Sarkar via https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=2384Alexis La Goutte1-7/+250
SMPP+ which is customized by Huawei company can't be decoded From me : Convert "space tabs" to spaces svn path=/trunk/; revision=39119
2011-05-27Treat TVBs as opaque: use the accessor functions instead of accessing the fieldsJeff Morriss1-1/+1
directly. svn path=/trunk/; revision=37420
2011-04-22Don't assume that a proto_item is equivalent to a proto_tree.Jeff Morriss1-27/+26
Use the return value from proto_item_add_subtree(). svn path=/trunk/; revision=36806
2011-01-16There's no need to pass the result of tvb_get_ptr() as the 'value' inJeff Morriss1-7/+5
proto_tree_add_*(): just use proto_tree_add_item(). Replace some tvb_get_ptr()s with tvb_get_ephemeral_string() or tvb_get_const_stringz(). Use tvb_memeql() & tvb_memcmp(). svn path=/trunk/; revision=35558
2010-12-06Fix various typos and spelling errors.Bill Meier1-1/+1
svn path=/trunk/; revision=35126
2009-12-19For fields of type FT_ABSOLUTE_TIME, have the "display" value be one ofGuy Harris1-4/+4
ABSOLUTE_TIME_LOCAL or ABSOLUTE_TIME_UTC, indicating whether to display the date/time in local time or UTC. (int)ABSOLUTE_TIME_LOCAL == (int)BASE_NONE, so there's no source or binary compatiblity issue, although we might want to eliminate BASE_NONE at some point and have the BASE_ values used with integral types start at 0, so that you can't specify BASE_NONE for an integral field. svn path=/trunk/; revision=31319
2009-10-25From Jakub Zawadzki:Anders Broman1-4/+2
Cleanup dissector code - use proper memory functions. https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=4164 svn path=/trunk/; revision=30691
2009-08-09Don't guard col_set_str (COL_PROTOCOL) with col_checkKovarththanan Rajaratnam1-2/+1
svn path=/trunk/; revision=29340
2009-07-08From Kovarththanan Rajaratnam:Anders Broman1-4/+1
No letter-shortcuts in Telephony menu. https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=3678 svn path=/trunk/; revision=29028
2009-06-18From Kovarththanan Rajaratnam via bug 3548:Stig Bjørlykke1-24/+21
(1) Trailing/leading spaces are removed from 'name's/'blurb's (2) Duplicate 'blurb's are replaced with NULL (3) Empty ("") 'blurb's are replaced with NULL (4) BASE_NONE, NULL, 0x0 are used for 'display', 'strings' and 'bitmask' fields for FT_NONE, FT_BYTES, FT_IPv4, FT_IPv6, FT_ABSOLUTE_TIME, FT_RELATIVE_TIME, FT_PROTOCOL, FT_STRING and FT_STRINGZ field types (5) Only allow non-zero value for 'display' if 'bitmask' is non-zero svn path=/trunk/; revision=28770
2009-06-05Have tap listeners specify whether the "packet" routine requiresGuy Harris1-1/+1
a protocol tree; the column values. This includes stats-tree listeners. Have the routines to build the packet list, and to retap packets, honor those requirements. This means that cf_retap_packets() no longer needs an argument to specify whether to construct the column values or not, so get rid of that argument. This also means that there's no need for a tap to have a fake filter to ensure that the protocol tree will be built, so don't set up a fake "frame" filter. While we're at it, clean up some cases where "no filter" was represented as a null string rather than a null pointer. Have a routine to return an indication of the number of tap listeners with filters; use that rather than the global num_tap_filters. Clean up some indentation and some gboolean vs. gint items. svn path=/trunk/; revision=28645
2009-04-22smpp: Fix potential crash(es): Mark hf[] entries with a range_string[] with ↵Bill Meier1-4/+4
BASE_RANGE_STRING in 'display' field; svn path=/trunk/; revision=28124
2009-04-02Fix a typo.Gerald Combs1-1/+1
svn path=/trunk/; revision=27929
2009-04-02The format argument of val_to_str() formats a guint32, not a char *. FixesGerald Combs1-1/+1
bug 3383. svn path=/trunk/; revision=27928
2009-04-01From Abhik Sarkar: SMPP TLV tag value_strings.Bill Meier1-2187/+2255
"I have chosen _not_ to use the value_string array in the header field for the tag because the information appears in too many places - once in the sub-tree and again once in the field which displays the value. Displaying the tag name again in the tag field would make the same information appear three times in four lines." See Bug #3369 [https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=3369] From me: Use consistent indentation throughout packet-smpp.c svn path=/trunk/; revision=27922
2009-03-29More size_t casts.Anders Broman1-2/+2
svn path=/trunk/; revision=27887
2009-03-18Removed C++ style comments.Stig Bjørlykke1-2/+2
svn path=/trunk/; revision=27791
2009-03-18improve dissection of optional parameters. In particular, make the tag and ↵Richard van der Hoff1-26/+68
length fields explicit. svn path=/trunk/; revision=27780
2009-02-10Remove an ugly hack:Ulf Lamping1-2/+3
There was an ugly hack while creating the menu, that tried to detect the stat_group a stats_tree belongs to by looking at the name string. That makes it unnecessarily hard to understand how the menu is really created. Fix: Add a new function stats_tree_register_with_group() that takes the stat_group as a parameter. Use this function where a stats_tree doesn't fit into the default "unsorted" group. svn path=/trunk/; revision=27407
2009-01-07From Robert Groenenberg:Jaap Keuter1-2/+0
The SMPP optional parameter 'network_error_code' is decoded incorrectly. This field is present in SMPP (v3.4 and higher) deliver_sm messages containing a delivery notification. This TLV contains 3 bytes of data, which is decoded in two steps, each adjusting the offset in the message. After that the offset is increased *again*, causing the next TLVs to not recognised. Removing the indicated increase in offset fixes the problem. svn path=/trunk/; revision=27177
2008-12-17Fix some typos and spelling (mostly in text strings)Bill Meier1-1/+1
svn path=/trunk/; revision=27037
2008-12-17Fix typos and spelling (mostly in text strings) Bill Meier1-1/+1
svn path=/trunk/; revision=27028
2008-09-30Minor proto_reg_handoff cleanup: use find_dissector when appropriate.Bill Meier1-1/+1
svn path=/trunk/; revision=26308
2008-07-22From Abhik Sarkar via https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=2707Jeff Morriss1-11/+567
The SMPP dissector currently supports only version 3.4. The latest version of the protocol is version 5.0 and it has been around for a while. However, the usage of this version of the protocol is only now picking up. This patch adds basic support for SMPP 5.0. By basic I mean: - New Operations and Responses. - New TLVs. - New Error codes. - Any changes to earlier values. svn path=/trunk/; revision=25787
generated by cgit v1.2.3 (git 2.25.1) at 2024-09-27 18:01:51 +0000