aboutsummaryrefslogtreecommitdiffstats
path: root/epan/dissectors/packet-smb-sidsnooping.c
AgeCommit message (Collapse)AuthorFilesLines
2016-06-19Revert "tap: change glib functions to wmem."Pascal Quantin1-5/+5
This reverts commit 2e9f3c5d366eaa7139fc877b5301392166b3f985. It breaks the registration of codec, dissector and libwiretap plugins. Change-Id: I4ef91dd192f765adf87ea9fe9f3693e25dbd24de Reviewed-on: https://code.wireshark.org/review/16012 Petri-Dish: Pascal Quantin <pascal.quantin@gmail.com> Reviewed-by: Pascal Quantin <pascal.quantin@gmail.com>
2016-06-17tap: change glib functions to wmem.Dario Lombardo1-5/+5
Change-Id: I878ae6b121a669f9b7f4e1e57bc079f0cb44c0bf Reviewed-on: https://code.wireshark.org/review/15270 Petri-Dish: Dario Lombardo <lomato@gmail.com> Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org> Reviewed-by: Evan Huus <eapache@gmail.com> Reviewed-by: Anders Broman <a.broman58@gmail.com>
2016-01-24Add the packet number to the packet_info structure, and use it.Guy Harris1-3/+3
That removes most of the uses of the frame number field in the frame_data structure. Change-Id: Ie22e4533e87f8360d7c0a61ca6ffb796cc233f22 Reviewed-on: https://code.wireshark.org/review/13509 Reviewed-by: Guy Harris <guy@alum.mit.edu>
2015-11-27SMB sidsnooping: use sid as key and name as valuePeter Wu1-54/+7
Fixes "cast from 'const char *' to 'char *' drops const qualifier [-Wcast-qual]", but changes the internal representation of sid_name_table. Change-Id: Ia853c3cf3010ea0cd1e2c975a23dd97e15be0fd6 Reviewed-on: https://code.wireshark.org/review/12157 Petri-Dish: Peter Wu <peter@lekensteyn.nl> Reviewed-by: Dario Lombardo <lomato@gmail.com> Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org> Reviewed-by: João Valverde <j@v6e.pt> Reviewed-by: Anders Broman <a.broman58@gmail.com>
2015-11-07Remove some unnecessary includes.Guy Harris1-2/+0
Either remove them completely, or put them inside an #ifdef. Change-Id: Iceff4909e250c17812f38d94e067f7c37ab72e1b Reviewed-on: https://code.wireshark.org/review/11630 Reviewed-by: Guy Harris <guy@alum.mit.edu>
2015-07-03Split four more init routines into init/cleanupPeter Wu1-31/+16
Three of them are trivial movements, the smb-sidsnooping is an odd one. Ronnie Sahlberg disabled the sid_name_snooping feature on 9 July 2007. There is a preference to override it though... For now add a TODO marker and ensure that the hash tables are always initialized. Change-Id: I61f5e215c9fa72a6785fb48eaa2d50c1975d7483 Reviewed-on: https://code.wireshark.org/review/9227 Reviewed-by: Michael Mann <mmann78@netscape.net>
2014-12-26Fix some dissectors doing termio (fprintf(stderr,..), g_warning()).Bill Meier1-3/+4
- Use report_...failure() (in most cases). - Also: Do some misc fixes in certain disectors - re-arrange order of #includes - Fixup preferences help text Change-Id: I385f6f97257f365f53ce611df02f57f9257dc5f9 Reviewed-on: https://code.wireshark.org/review/6039 Petri-Dish: Bill Meier <wmeier@newsguy.com> Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org> Reviewed-by: Michael Mann <mmann78@netscape.net>
2014-12-25Deleting unnecessary #includes from dissectors.Martin Mathieson1-2/+0
Fifth batch (packet-rtp.c -> end). Will look at cleaning up and committing script afterwards. Change-Id: I8ed61dc941d98d3f7259a9d1f74e214eb7b4bfa2 Reviewed-on: https://code.wireshark.org/review/6052 Reviewed-by: Martin Mathieson <martin.r.mathieson@googlemail.com>
2014-12-21Cleanup use of #includes in non-generated epan/dissector/*.cBill Meier1-5/+3
Specifically: - Set packet.h to be the first wireshark #include after config.h and "system" #includes. packet.h added as an #include in some cases when missing. - Remove some #includes included (directly/indirectly) in packet.h. E.g., glib.h. (Done only for those files including packet.h). - As needed, move "system" #includes to be after config.h and before wireshark #includes. - Rework various #include file specifications for consistency. - Misc. Change-Id: Ifaa1a14b50b69fbad38ea4838a49dfe595c54c95 Reviewed-on: https://code.wireshark.org/review/5923 Petri-Dish: Alexis La Goutte <alexis.lagoutte@gmail.com> Reviewed-by: Bill Meier <wmeier@newsguy.com>
2014-10-04Add editor modelines; Reformat as appropriate.Bill Meier1-3/+16
Change-Id: I8e9c58b75eea85877d22024201e5d8d0e9a3dbfd Reviewed-on: https://code.wireshark.org/review/4459 Reviewed-by: Bill Meier <wmeier@newsguy.com>
2014-09-16Fix spelling: cant-->can't, wont-->won't, etcBill Meier1-1/+1
Change-Id: I4497f1b8b6eab0e576d9dd31b732965f9a6679c6 Reviewed-on: https://code.wireshark.org/review/4124 Reviewed-by: Bill Meier <wmeier@newsguy.com>
2014-03-04Remove all $Id$ from top of fileAlexis La Goutte1-2/+0
(Using sed : sed -i '/^ \* \$Id\$/,+1 d') Fix manually some typo (in export_object_dicom.c and crc16-plain.c) Change-Id: I4c1ae68d1c4afeace8cb195b53c715cf9e1227a8 Reviewed-on: https://code.wireshark.org/review/497 Reviewed-by: Anders Broman <a.broman58@gmail.com>
2013-12-14Fix [-Wmissing-prototypes]Jakub Zawadzki1-6/+2
svn path=/trunk/; revision=54095
2013-09-15emem -> wmem (except uat or init routines)Pascal Quantin1-2/+2
svn path=/trunk/; revision=52087
2013-09-13Replace some emem with wmem.Evan Huus1-2/+2
The windows-common dissector seems to make excessive use of strbufs - I converted them and simplified a bit, but it could probably be simplified more. svn path=/trunk/; revision=52008
2013-03-18From beroset:Anders Broman1-12/+12
remove C++ incompatibilities https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=8416 svn path=/trunk/; revision=48399
2013-02-07Use proto_registrar_get_id_byname() instead of proto_registrar_get_byname();Bill Meier1-40/+14
The code is slightly cleaner and the use of proto_registrar_get_id_byname() enables an additional checkhf test to reduce false positives. Also: comment out 2 unused hf_... vars in packet-smb-sidsnooping.c (found by checkhf) svn path=/trunk/; revision=47541
2012-09-20We always HAVE_CONFIG_H so don't bother checking whether we have it or not.Jeff Morriss1-3/+1
svn path=/trunk/; revision=45017
2012-06-28Update Free Software Foundation address.Jakub Zawadzki1-1/+1
(COPYING will be updated in next commit) svn path=/trunk/; revision=43536
2010-01-22Fix some gcc -Wshadow warningsBill Meier1-5/+5
svn path=/trunk/; revision=31623
2009-12-30From babi via bug 4352:Stig Bjørlykke1-0/+2
* wslua doesnt null-terminate a char array properly after one strncpy call * packet-smb-sidsnooping (disabled now but someone might enable it again) has a potential overflow crash (i think?) svn path=/trunk/; revision=31392
2009-10-25From Jakub Zawadzki:Anders Broman1-2/+1
Cleanup dissector code - use proper memory functions. https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=4164 svn path=/trunk/; revision=30691
2009-08-21Sanitize epan includesKovarththanan Rajaratnam1-3/+3
svn path=/trunk/; revision=29499
2009-06-05Have tap listeners specify whether the "packet" routine requiresGuy Harris1-2/+8
a protocol tree; the column values. This includes stats-tree listeners. Have the routines to build the packet list, and to retap packets, honor those requirements. This means that cf_retap_packets() no longer needs an argument to specify whether to construct the column values or not, so get rid of that argument. This also means that there's no need for a tap to have a fake filter to ensure that the protocol tree will be built, so don't set up a fake "frame" filter. While we're at it, clean up some cases where "no filter" was represented as a null string rather than a null pointer. Have a routine to return an indication of the number of tap listeners with filters; use that rather than the global num_tap_filters. Clean up some indentation and some gboolean vs. gint items. svn path=/trunk/; revision=28645
2009-03-29More size_t casts.Anders Broman1-1/+1
svn path=/trunk/; revision=27887
2008-06-27Fix some checkAPIs warnings.Gerald Combs1-8/+4
svn path=/trunk/; revision=25617
2008-03-01Rewrote to use g_strlcpy and g_strlcat.Stig Bjørlykke1-1/+2
svn path=/trunk/; revision=24525
2007-08-28rename dcerpc_smb_store_pol_name to dcerpc_store_polhnd_nameRonnie Sahlberg1-1/+1
rename dcerpc_smb_fetch_pol to dcerpc_fetch_polhnd_data and also make it take an additional parameter to return the "type" of the policy handle, if such a type was stored. extend the pol_value structure used to track policy handles to also store a type to represent what created the policy handle types could be USER/ALIAS/CONNECT/... etc handles returned from the SAMR interface add a new helper function dcerpc_store_polhnd_type() track policy handles between request/responses for dcerpc update the samr.cnf file to make the samr dissectors for SetSecurity/QuerySecurity dissect the specific bits for the security descriptor correctly based on whether the policy handle refers to a CONNECT/DOMAIN/USER/ALIAS or GROUP svn path=/trunk/; revision=22703
2007-07-09disabling sid snooping in the codeRonnie Sahlberg1-5/+13
this module was never really finished and was therefore semi-useless. disabled now since the change to samr broke it and the real fix to unbreak it would be a substantial rewrite of it (and adding a nice gui so one can see which sids are mapped...) disabled it but did not remove it since i do think the module is useful IF it is completed with a lot more operations. svn path=/trunk/; revision=22271
2007-01-18Add separate union entries to fvalue.value for signed and unsignedMartin Mathieson1-3/+3
32-bit numbers. Separate signed and unsigned accessors have been added and used where appropriate. Definitely not for 0.99.5. svn path=/trunk/; revision=20472
2006-05-31Tethereal/tethereal -> TShark/tshark.Gerald Combs1-2/+2
svn path=/trunk/; revision=18268
2006-05-28Ethereal->WiresharkAnders Broman1-2/+2
svn path=/trunk/; revision=18234
2006-05-21change a whole bunch of ethereal into wiresharkRonnie Sahlberg1-2/+2
svn path=/trunk/; revision=18196
2006-01-16done:Jörg Mayer1-2/+1
packet-ntp.c: Rather confused and incorrect use of g_snprintf return value packet-pim.c: whitespace change packet-icmpv6.c: g_snprintf takes trailing \0 into account, fix off by 1 error packet-clnp.c: Fix incorrect use of g_snprintf return value packet-isakmp.c: g_snprintf takes trailing \0 into account packet-tr.c: Fix incorrect use of g_snprintf return value packet-radius.c: Fix incorrect use of g_snprintf return value packet-radius.h: constify a string variable packet-ldap.c: The return value isn't needed, so don't use it incorrectly packet-tcp.c: Fix incorrect use of g_snprintf return value packet-windows-common.c: Remove unneeded DISSECTOR_ASSERT packet-smb-sidsnooping.c: g_snprintf takes trailing \0 into account packet-pvfs2.c: g_snprintf takes trailing \0 into account packet-ptp.c: Remove #include snprintf packet-ppp.c: Fix incorrect use of g_snprintf return value packet-ospf.c: Fix incorrect use of g_snprintf return value packet-mip6.c: snprintf -> g_snprintf packet-bootp.c: Remove a commented out bad use of g_snprintf packet-ber.c: snprintf -> g_snprintf, g_snprintf takes trailing \0 into account 2do: 52 packet-ieee80211.c: 2DO 2 packet-nfs.c: 2DO - too many side effects 33 packet-bgp.c: 2DO 18 packet-dns.c: 2DO 14 packet-dcm.c: 2DO 13 packet-x11.c: 2DO 11 packet-kerberos.c: 2DO 10 packet-diameter.c: 2DO 9 packet-snmp.c: 2DO 9 packet-pgm.c: 2DO 7 packet-nbns.c: 2DO 6 packet-fcswils.c: 2DO 5 packet-wccp.c: 2DO 5 packet-cops.c: 2DO 4 packet-wtp.c: 2DO svn path=/trunk/; revision=17038
2005-09-17Move some headers for stuff defined by a dissector into epan/dissectorsGuy Harris1-1/+1
- and rename smb.h to packet-smb.h, as it's packet-smb.c's header file. svn path=/trunk/; revision=15845
2005-09-17Move a pile of protocol-related headers from the top-level sourceGuy Harris1-1/+1
directory to the epan directory. Some of them should perhaps ultimately be moved to epan/dissectors, if they pertain only to stuff exported by a particular dissector. Fix Gerald's e-mail address in files we're moving. svn path=/trunk/; revision=15844
2005-08-27sprintf removalRonnie Sahlberg1-1/+1
svn path=/trunk/; revision=15554
2005-08-13some more gmemchunk -> se_alloc() updatesRonnie Sahlberg1-23/+3
there are only 5 gmemchunks left but they have different litetime for their allocations than the 100+ ones that have been removed. The remaining 5 should be converted some other way. svn path=/trunk/; revision=15328
2005-01-01Make the signatures of functions passed to "register_tap_listener()"Guy Harris1-13/+12
match what "register_tap_listener()" expects (rather than squelching warnings about the differences by casting function pointers to "void *"). Make static some functions not used outside the module in which they're defined. svn path=/trunk/; revision=12913
2005-01-01As we've made the tap_specific_data field of a tap_packet_t structure aGuy Harris1-3/+3
const pointer (so that we don't get complaints when we make the tap-specific data argument to "tap_queue_packet()" a const pointer, allowing dissectors to hand const data to a tap without a complaint), we should make the tap per-packet function take a const pointer as an argument as well. Do so. In some taps, use _U_, or actually use the argument, rather than sticking in dummy "X = X" assignments to fake use of parameters. (This means that the tap functions in question no longer have the notion that they act on a particular static structure wired in.) svn path=/trunk/; revision=12910
2004-12-25a lot of warnings removed, most of them about pointer to int casts without ↵Ulf Lamping1-7/+7
using the appropriate GLib macros svn path=/trunk/; revision=12832
2004-09-29Move the tap infrastructure to the epan directory.Guy Harris1-1/+1
svn path=/trunk/; revision=12128
2004-07-18Move dissectors to epan/dissectors directory.Gilbert Ramirez1-0/+457
Also move ncp222.py, x11-fields, process-x11-fields.pl, make-reg-dotc, and make-reg-dotc.py. Adjust #include lines in files that include packet-*.h files. svn path=/trunk/; revision=11410
generated by cgit v1.2.3 (git 2.25.1) at 2024-09-28 01:59:12 +0000