aboutsummaryrefslogtreecommitdiffstats
path: root/epan/dissectors/packet-sip.c
AgeCommit message (Collapse)AuthorFilesLines
2013-03-27tvb_reported_length_remaining() can return -1, so be sure to properly handle ↵Chris Maynard1-3/+3
it if it does. #BACKPORT(1.6, 1.8) svn path=/trunk/; revision=48578
2013-03-19From beroset:Anders Broman1-6/+6
remove C++ incompatibilities https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=8416 svn path=/trunk/; revision=48430
2013-03-17Fix some Dead Store (Dead assignement/Dead increment) Warning found by ClangAlexis La Goutte1-1/+0
svn path=/trunk/; revision=48378
2013-03-10Off by one error in name length.Anders Broman1-1/+1
svn path=/trunk/; revision=48234
2013-03-08Add new SIP headers.Anders Broman1-278/+343
svn path=/trunk/; revision=48192
2013-02-28From Hadriel Kaplan via ↵Pascal Quantin1-1/+1
https://www.wireshark.org/lists/wireshark-dev/201302/msg00216.html : Fix dissection of method name in case of RAck header svn path=/trunk/; revision=47936
2013-02-26Fix spelling/typos found using a list of commonly misspelled words.Bill Meier1-2/+2
The misspellings were mostly in comments but some were in text strings visible to the user. svn path=/trunk/; revision=47899
2013-02-26it's ==> its & its ==> it's as needed.Bill Meier1-1/+1
svn path=/trunk/; revision=47891
2013-02-17Only allow one packet to act as an SDP response. This should probably be ↵Michael Mann1-1/+1
caught at a higher layer (SIP), but the safety net should be there. Also, cleanup SIP "response error" range. Fixes crash in bug 8343 (https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=8343) svn path=/trunk/; revision=47705
2013-02-14Fix crash with SDP setup mechanism, bug 8323 ↵Michael Mann1-3/+8
(https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=8323) The issue was that hash tables were being accessed after they were freed from a "rejected answer". The code was also too generous in considering many SIP status codes as "rejected answers", so now less SIP status codes are treated as "rejected answers" and are ignored by the transport API. svn path=/trunk/; revision=47652
2013-02-12SDP in 183 session progress is also SDP_EXCHANGE_ANSWER_ACCEPT.Anders Broman1-1/+1
Without this patch I get a crash on Linux and lots of STATUS_ACCESS_VIOLATION and a single STATUS_INTEGER_DIVIDE_BY_ZERO on windows. svn path=/trunk/; revision=47639
2013-02-12SDP in 180 ringing is also SDP_EXCHANGE_ANSWER_ACCEPT.Anders Broman1-1/+1
Without this patch I get a crash on Linux and lots of STATUS_ACCESS_VIOLATION and a single STATUS_INTEGER_DIVIDE_BY_ZERO on windows. svn path=/trunk/; revision=47638
2013-02-08Handle SIP "resends" within SDP. This is to handle "duplicate" OFFERs so ↵Michael Mann1-0/+2
they don't end up being handled by setup_sdp_transport() because the current frame couldn't match a request (due to duplication). setup_sdp_transport_resend() should be unnecessary once all higher layers use setup_sdp_transport() and the "registration" code within dissect_sdp() is removed. svn path=/trunk/; revision=47572
2013-02-08Support SDP context over SIP.Michael Mann1-31/+44
Added setup_sdp_transport() to allow higher layer protocols to call SDP with context to correctly setup an OFFER/ANSWER within SDP (which doesn't have its own transport layer). I attempted to keep backwards compatibility until all higher layer protocols set up OFFER/ANSWER context. If OFFER/ANSWER (request/response) can't be found (which would be the case for higher layer protocols without context), Wireshark should resort to the old behavior of applying SDP information as it sees packets. This patch includes integration with SIP as it appears to have the most bug reports. Other higher layer protocols will be done later. Most are mentioned in bug 2368. Fixes bug 2368 (https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=2368) and all its duplicates Fixes bug 2992 (https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=2992) and all its duplicates svn path=/trunk/; revision=47564
2012-12-26Fix a bunch of warnings.Guy Harris1-4/+4
Cast away some implicit 64-bit-to-32-bit conversion errors due to use of sizeof. Cast away some implicit 64-bit-to-32-bit conversion errors due to use of strtol() and strtoul(). Change some data types to avoid those implicit conversion warnings. When assigning a constant to a float, make sure the constant isn't a double, by appending "f" to the constant. Constify a bunch of variables, parameters, and return values to eliminate warnings due to strings being given const qualifiers. Cast away those warnings in some cases where an API we don't control forces us to do so. Enable a bunch of additional warnings by default. Note why at least some of the other warnings aren't enabled. randpkt.c and text2pcap.c are used to build programs, so they don't need to be in EXTRA_DIST. If the user specifies --enable-warnings-as-errors, add -Werror *even if the user specified --enable-extra-gcc-flags; assume they know what they're doing and are willing to have the compile fail due to the extra GCC warnings being treated as errors. svn path=/trunk/; revision=46748
2012-12-03Wrong check for quote_offset.Anders Broman1-1/+1
Fixes Bug 8042 - SIP infinite loop. https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=8042 svn path=/trunk/; revision=46340
2012-10-09Set fence after finishing writing to the info col in order to showAnders Broman1-22/+27
info from more than one (SIP) message in the frame. svn path=/trunk/; revision=45429
2012-09-20We always HAVE_CONFIG_H so don't bother checking whether we have it or not.Jeff Morriss1-3/+1
svn path=/trunk/; revision=45017
2012-09-11Add data parameter to dissector_try_heuristicJakub Zawadzki1-1/+1
svn path=/trunk/; revision=44871
2012-09-10Initial commit to support yet another method of passing data between dissectors.Jakub Zawadzki1-3/+3
Add new parameter 'data' to heur_dissector_t and new_dissector_t, for now it's always NULL svn path=/trunk/; revision=44860
2012-08-13Fix typo in commentJörg Mayer1-1/+1
svn path=/trunk/; revision=44469
2012-07-20Pass in proper offset to dfilter_sip_status_line(). Was seeing problemsMartin Mathieson1-6/+14
with 180 + 200 responses in same frame (over TCP). svn path=/trunk/; revision=43841
2012-06-28Update Free Software Foundation address.Jakub Zawadzki1-1/+1
(COPYING will be updated in next commit) svn path=/trunk/; revision=43536
2012-06-09Add sip.to.tag and sip.from.tag filters.Chris Maynard1-3/+25
Fixes https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=5226 svn path=/trunk/; revision=43175
2012-04-28Another unnecessary assignment removed to fix clang warning.Martin Mathieson1-1/+1
svn path=/trunk/; revision=42316
2012-04-13gunzip gzip:ed SIP bodies.Anders Broman1-4/+31
svn path=/trunk/; revision=42043
2012-03-13From Michael Mann via https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=6938 :Jeff Morriss1-6/+6
Don't limit CSeq to 2**31-1 (2147483647): use stroul() instead of atoi() in several places. svn path=/trunk/; revision=41516
2012-01-14Remove obsolete comments referring to mem_chunks.Bill Meier1-1/+1
svn path=/trunk/; revision=40507
2011-11-20Get rid of Warnings.Anders Broman1-2/+2
svn path=/trunk/; revision=39954
2011-11-19The URI parameter parser always has to advance current_offset in theGuy Harris1-4/+2
loop, otherwise you get stuck in an infinite loop. (Where in RFC 3261 does it mention the use of commas in URI parameters?) Should fix bug 6598. svn path=/trunk/; revision=39952
2011-11-19Clean up indentation.Guy Harris1-49/+46
svn path=/trunk/; revision=39950
2011-11-19Fix Warnings.Anders Broman1-9/+9
svn path=/trunk/; revision=39948
2011-11-15Check the return value of dissect_sip_name_addr_or_addr_spec()Anders Broman1-1/+6
Should fix the recent fuzz failures. Thanks Chris for isolating the offending packet. svn path=/trunk/; revision=39867
2011-11-15Squelch a warning. (This code probably needs a review; we really need aGuy Harris1-0/+1
better general framework for parsing text-based protocols.) svn path=/trunk/; revision=39866
2011-11-15More indentation cleanup.Guy Harris1-11/+11
svn path=/trunk/; revision=39864
2011-11-15Clean up indentation.Guy Harris1-48/+48
svn path=/trunk/; revision=39863
2011-11-15packet-sip.c:1469: warning: unused variable 'contact_param_end_offset'Anders Broman1-1/+1
svn path=/trunk/; revision=39862
2011-11-15Restore dissection of contact parameters.Anders Broman1-22/+66
svn path=/trunk/; revision=39861
2011-11-14packet-sip.c:1412: warning: 'uri_param_end_offset' may be used uninitialized ↵Anders Broman1-1/+1
in this function svn path=/trunk/; revision=39828
2011-11-14From Johan Wåhl:Anders Broman1-34/+257
- dissect Route and Via header. - Dissect URI parameters. svn path=/trunk/; revision=39827
2011-11-11Add some checks for "character not found"; this should fix someGuy Harris1-1/+5
fuzz-testing failures we're seeing. svn path=/trunk/; revision=39795
2011-11-10packet-sip.c:1442: warning: 'c' may be used uninitialized in this functionAnders Broman1-1/+1
svn path=/trunk/; revision=39783
2011-11-10-Improve dissection of auth itemsAnders Broman1-4/+150
(https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=6553) - Add parameter items to the tree for some often trunkated lines. svn path=/trunk/; revision=39782
2011-11-08packet_info's in_error_pkt is now a bitfield like in_gre_pkt.Chris Maynard1-4/+4
svn path=/trunk/; revision=39764
2011-10-26Fix proto_tree_add_item() encoding args;Bill Meier1-8/+8
Also: remove unneeded #include. svn path=/trunk/; revision=39614
2011-10-21For proto_tree_add_item(..., proto_xxx, ...)use ENC_NA as the encoding arg.Bill Meier1-2/+2
Also: remove trailing whitespace for a number of files. svn path=/trunk/; revision=39503
2011-10-15Convert proto_tree_add_item() 'encoding' arg for field types FT_STRING, ↵Bill Meier1-15/+15
FT_STRINGZ, FT_UINT_STRING as follows: 1. If there's no character encoding (ENC_ASCII, ...) specified then use ENC_ASCII. 2. For all but FT_UINT_STRING, always use ENC_NA (replacing any existing True/1/FALSE/0 /ENC_BIG_ENDIAN/ENC_LITTLE_ENDIAN). svn path=/trunk/; revision=39426
2011-10-13From Horaci Macias:Anders Broman1-0/+8
Parse User-to-User header http://tools.ietf.org/html/draft-ietf-cuss-sip-uui-02 https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=6432 svn path=/trunk/; revision=39402
2011-10-04Use ENC_NA as encoding for proto_tree_add_item() calls which directly ↵Bill Meier1-1/+1
reference an hf item (in hf[] with types: FT_NONE FT_BYTES FT_IPV6 FT_IPXNET FT_OID Note: Encoding field set to ENC_NA only if the field was previously TRUE|FALSE|ENC_LITTLE_ENDIAN|ENC_BIG_ENDIAN svn path=/trunk/; revision=39260
2011-09-19Move stuff inside if(tree)Anders Broman1-51/+48
svn path=/trunk/; revision=39038
generated by cgit v1.2.3 (git 2.25.1) at 2024-09-28 18:30:44 +0000