Age | Commit message (Collapse) | Author | Files | Lines |
|
FT_STRINGZ, FT_UINT_STRING as follows:
1. If there's no character encoding (ENC_ASCII, ...) specified
then use ENC_ASCII.
2. For all but FT_UINT_STRING, always use ENC_NA
(replacing any existing True/1/FALSE/0
/ENC_BIG_ENDIAN/ENC_LITTLE_ENDIAN).
svn path=/trunk/; revision=39426
|
|
non-autogenerated epan/dissectors:
Specifically: Replace FALSE|0 and TRUE|1 by ENC_BIG_ENDIAN|ENC_LITTLE_ENDIAN as
the encoding parameter for proto_tree_add_item() calls which directly reference
an item in hf[] which has a type of:
FT_BOOLEAN
FT_IPv4
FT_EUI64
FT_GUID
FT_UINT_STRING
Also: For type FT_ITv6 use ENC_NA. (This was missed in SVN #39260)
svn path=/trunk/; revision=39328
|
|
reference an hf item (in hf[] with types:
FT_NONE
FT_BYTES
FT_IPV6
FT_IPXNET
FT_OID
Note: Encoding field set to ENC_NA only if the field was previously TRUE|FALSE|ENC_LITTLE_ENDIAN|ENC_BIG_ENDIAN
svn path=/trunk/; revision=39260
|
|
Condense all SCTP CRC routines to wsutil/crc32.[ch]. Also made
crc32_ccitt_table not explicitly accessible (must use crc32_ccitt_table_lookup).
https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=6298
svn path=/trunk/; revision=39233
|
|
This time keep the tvb routines in epan.
Now we can use common crc routines outside epan.
svn path=/trunk/; revision=38810
|
|
svn path=/trunk/; revision=38803
|
|
This way we can use the crc routines in wiretap.
svn path=/trunk/; revision=38800
|
|
svn path=/trunk/; revision=38085
|
|
svn path=/trunk/; revision=37308
|
|
Found by clang.
svn path=/trunk/; revision=36685
|
|
retranmissions (in COL_INFO). (Obviously this only works if TSN analysis is
enabled.)
This should make it more obvious to users which chunks are retransmissions and
will help avoid confusing the subdissector(s).
svn path=/trunk/; revision=36159
|
|
svn path=/trunk/; revision=35895
|
|
Based on a patch submitted by Thomas Dreibholz.
See https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=5616
svn path=/trunk/; revision=35672
|
|
do the same as the non-tvb equivalents but take a TVB and an offset instead
of a pointer to an array of bytes.
Their purpose is to prevent (many) dissectors from doing:
ip_to_str(tvb_get_ptr(...)).
(About the names and the location: I like the names as they are but the names
imply that they should live in tvbuff.c. That would make some sense but
I didn't want to pull to_str.h into tvbuff.c...)
svn path=/trunk/; revision=35519
|
|
svn path=/trunk/; revision=35486
|
|
fragment->len was left unitialized.)
Also (unrelated): save a couple of calls to tvb_reported_length() since the
value is already stored in a variable.
svn path=/trunk/; revision=35485
|
|
not be NULL terminated. Use tvb_get_ephemeral_string() instead.
svn path=/trunk/; revision=35375
|
|
causes (should have been in rev 35366).
When generating TVB subsets, limit the subset's backing and reported lengths to
the (captured) TVB length and the reported TVB length, respectively.
This allows us to dissect most of the packet in
https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=5546
before asserting out.
It also yields similar better behavior when the capture is limited by a
snapshot length.
svn path=/trunk/; revision=35368
|
|
- "reported length" to be minimum of the entity's length (taken from the
packet) or the reported length of the TVB.
- "backing length" to be the minimum of the reported length (above) or the
(captured) length of the TVB.
This prevents tvb_new_subset() from generating an exception if the entity's
length (in the packet) is bogus (bigger than what's in the TVB) which allows
dissection to continue to a point where we can show the user what the problem
is.
When dissecting chunks, add an expert info if the item's length is bigger than
what was on the wire (the reported length). (The same could also be done for
parameters and error causes.)
This makes captures like that in https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=5546
easier to understand.
It also starts getting this dissector using the reported length instead of the
(captured) TVB length (there's more to be done with other tvb subsets).
svn path=/trunk/; revision=35366
|
|
keys to have _uint in their names, to match the routines that handle
dissector tables with string keys. (Using _port can confuse people into
thinking they're intended solely for use with TCP/UDP/etc. ports when,
in fact, they work better for things such as Ethernet types, where the
binding of particular values to particular protocols are a lot
stronger.)
svn path=/trunk/; revision=35224
|
|
Update IANA assignments.
Use available checksum routines.
Some cleanup and use of convenience macros.
svn path=/trunk/; revision=34922
|
|
subdissector the first fragment of a fragmented message so that an exception
in the first chunk doesn't abort dissection of subsquent chunks in the frame.
Restore pinfo->private_data after an exception was thrown by a subdissector.
This is necessary in case a subdissector had changed it but was unable to
restore it (due to the exception).
svn path=/trunk/; revision=34420
|
|
the "end" variable.
In some cases the usage may have been benign since it can be seen by code inspection that the maximum value of the end variable can't exceed the maximum value of the loop variable.
However, on general principles, all the usages have been fixed.
svn path=/trunk/; revision=33692
|
|
svn path=/trunk/; revision=33225
|
|
"representation" - we already use "representation" to refer to the text
representation of fields.
Change some routines with an endianness argument to make it a
representation argument instead;
svn path=/trunk/; revision=32929
|
|
from which to choose; use that for protocol fields in some protocols
(modify the CORBA generator to use it, and manually update the generated
CORBA dissectors accordingly).
svn path=/trunk/; revision=32777
|
|
proto_tree_add_item(), use the new REP_BIG_ENDIAN and REP_LITTLE_ENDIAN
values.
Use those #defines in variables that represent the byte order, as well.
svn path=/trunk/; revision=32776
|
|
svn path=/trunk/; revision=32735
|
|
svn path=/trunk/; revision=32686
|
|
svn path=/trunk/; revision=31522
|
|
- Make x2ap work.
svn path=/trunk/; revision=30746
|
|
svn path=/trunk/; revision=30744
|
|
svn path=/trunk/; revision=30574
|
|
* Remove check_col guards
svn path=/trunk/; revision=30127
|
|
This fixes bug 3928.
svn path=/trunk/; revision=29520
|
|
svn path=/trunk/; revision=29446
|
|
svn path=/trunk/; revision=29340
|
|
additional cast in the hopes that they squelch "dereferencing
type-punned pointer" warnings.
svn path=/trunk/; revision=29318
|
|
svn path=/trunk/; revision=29068
|
|
(1) Trailing/leading spaces are removed from 'name's/'blurb's
(2) Duplicate 'blurb's are replaced with NULL
(3) Empty ("") 'blurb's are replaced with NULL
(4) BASE_NONE, NULL, 0x0 are used for 'display', 'strings' and 'bitmask' fields
for FT_NONE, FT_BYTES, FT_IPv4, FT_IPv6, FT_ABSOLUTE_TIME, FT_RELATIVE_TIME,
FT_PROTOCOL, FT_STRING and FT_STRINGZ field types
(5) Only allow non-zero value for 'display' if 'bitmask' is non-zero
svn path=/trunk/; revision=28770
|
|
* Add Varun Notibala to AUTHORS.
* Add support for NR-SACK and fix stability problems.
svn path=/trunk/; revision=28642
|
|
http://wiki.wireshark.org/Development/Optimization
svn path=/trunk/; revision=28356
|
|
svn path=/trunk/; revision=27585
|
|
svn path=/trunk/; revision=27037
|
|
renamed to ppids)
svn path=/trunk/; revision=26958
|
|
svn path=/trunk/; revision=26771
|
|
svn path=/trunk/; revision=26702
|
|
frame numbers before running the read filter], don't do the TSN
analysis. (We can't anyway because we don't have a valid frame
number...)
Without this change if you load a capture file in the
GUI while using a read filter, every SCTP TSN is marked as a
retransmission of that in frame 0.
svn path=/trunk/; revision=26226
|
|
http://www.ietf.org/internet-drafts/draft-tuexen-tsvwg-sctp-sack-immediately-00.txt
svn path=/trunk/; revision=26184
|
|
svn path=/trunk/; revision=26055
|