aboutsummaryrefslogtreecommitdiffstats
path: root/epan/dissectors/packet-sctp.c
AgeCommit message (Collapse)AuthorFilesLines
2011-10-15Convert proto_tree_add_item() 'encoding' arg for field types FT_STRING, ↵Bill Meier1-1/+1
FT_STRINGZ, FT_UINT_STRING as follows: 1. If there's no character encoding (ENC_ASCII, ...) specified then use ENC_ASCII. 2. For all but FT_UINT_STRING, always use ENC_NA (replacing any existing True/1/FALSE/0 /ENC_BIG_ENDIAN/ENC_LITTLE_ENDIAN). svn path=/trunk/; revision=39426
2011-10-10 Convert 'encoding' parameter of certain proto_tree_add_item() calls in ↵Bill Meier1-1/+1
non-autogenerated epan/dissectors: Specifically: Replace FALSE|0 and TRUE|1 by ENC_BIG_ENDIAN|ENC_LITTLE_ENDIAN as the encoding parameter for proto_tree_add_item() calls which directly reference an item in hf[] which has a type of: FT_BOOLEAN FT_IPv4 FT_EUI64 FT_GUID FT_UINT_STRING Also: For type FT_ITv6 use ENC_NA. (This was missed in SVN #39260) svn path=/trunk/; revision=39328
2011-10-04Use ENC_NA as encoding for proto_tree_add_item() calls which directly ↵Bill Meier1-16/+16
reference an hf item (in hf[] with types: FT_NONE FT_BYTES FT_IPV6 FT_IPXNET FT_OID Note: Encoding field set to ENC_NA only if the field was previously TRUE|FALSE|ENC_LITTLE_ENDIAN|ENC_BIG_ENDIAN svn path=/trunk/; revision=39260
2011-10-03From Michael Mann:Anders Broman1-14/+10
Condense all SCTP CRC routines to wsutil/crc32.[ch]. Also made crc32_ccitt_table not explicitly accessible (must use crc32_ccitt_table_lookup). https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=6298 svn path=/trunk/; revision=39233
2011-08-31Second try to move crc routines to libwsutil.Stig Bjørlykke1-1/+1
This time keep the tvb routines in epan. Now we can use common crc routines outside epan. svn path=/trunk/; revision=38810
2011-08-30Revert r38800, as the crc routines contains some tvb functions.Stig Bjørlykke1-1/+1
svn path=/trunk/; revision=38803
2011-08-30Move all crc routines to libwsutil.Stig Bjørlykke1-1/+1
This way we can use the crc routines in wiretap. svn path=/trunk/; revision=38800
2011-07-18Fix gcc 4.6 "set but not used [-Wunused-but-set-variable]" warnings.Bill Meier1-4/+3
svn path=/trunk/; revision=38085
2011-05-19Don't assign to an unused 'proto item *': Coverity 1033 & 906Bill Meier1-4/+3
svn path=/trunk/; revision=37308
2011-04-17Corrected equality check in frag_equal().Stig Bjørlykke1-4/+4
Found by clang. svn path=/trunk/; revision=36685
2011-03-07Don't pass retransmitted chunks to subdissectors. Instead just mark them asJeff Morriss1-17/+34
retranmissions (in COL_INFO). (Obviously this only works if TSN analysis is enabled.) This should make it more obvious to users which chunks are retransmissions and will help avoid confusing the subdissector(s). svn path=/trunk/; revision=36159
2011-02-10Obtained from Thomas Dreibholz: Update SCTP PPIDs.Michael Tüxen1-1/+16
svn path=/trunk/; revision=35895
2011-01-26Add expert info related to gap ack blocks.Michael Tüxen1-2/+35
Based on a patch submitted by Thomas Dreibholz. See https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=5616 svn path=/trunk/; revision=35672
2011-01-13Introduce, and start using, tvb_ip_to_str() and tvb_ip6_to_str(). TheseJeff Morriss1-4/+4
do the same as the non-tvb equivalents but take a TVB and an offset instead of a pointer to an array of bytes. Their purpose is to prevent (many) dissectors from doing: ip_to_str(tvb_get_ptr(...)). (About the names and the location: I like the names as they are but the names imply that they should live in tvbuff.c. That would make some sense but I didn't want to pull to_str.h into tvbuff.c...) svn path=/trunk/; revision=35519
2011-01-11Don't attempt to reassemble short (reported_len > len) chunks.Jeff Morriss1-0/+7
svn path=/trunk/; revision=35486
2011-01-11Don't store message fragments whose length is 0: there's no point. (OtherwiseJeff Morriss1-9/+11
fragment->len was left unitialized.) Also (unrelated): save a couple of calls to tvb_reported_length() since the value is already stored in a variable. svn path=/trunk/; revision=35485
2011-01-05Don't pass the result of tvb_get_ptr() into a %s format string: the string mayJeff Morriss1-1/+1
not be NULL terminated. Use tvb_get_ephemeral_string() instead. svn path=/trunk/; revision=35375
2011-01-05Use reported length (instead of the captured length) when dissecting errorJeff Morriss1-66/+93
causes (should have been in rev 35366). When generating TVB subsets, limit the subset's backing and reported lengths to the (captured) TVB length and the reported TVB length, respectively. This allows us to dissect most of the packet in https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=5546 before asserting out. It also yields similar better behavior when the capture is limited by a snapshot length. svn path=/trunk/; revision=35368
2011-01-04When generating a tvb subset for chunks, parameters, and error causes, set the:Jeff Morriss1-22/+55
- "reported length" to be minimum of the entity's length (taken from the packet) or the reported length of the TVB. - "backing length" to be the minimum of the reported length (above) or the (captured) length of the TVB. This prevents tvb_new_subset() from generating an exception if the entity's length (in the packet) is bogus (bigger than what's in the TVB) which allows dissection to continue to a point where we can show the user what the problem is. When dissecting chunks, add an expert info if the item's length is bigger than what was on the wire (the reported length). (The same could also be done for parameters and error causes.) This makes captures like that in https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=5546 easier to understand. It also starts getting this dissector using the reported length instead of the (captured) TVB length (there's more to be done with other tvb subsets). svn path=/trunk/; revision=35366
2010-12-20Rename the routines that handle dissector tables with unsigned integerGuy Harris1-5/+5
keys to have _uint in their names, to match the routines that handle dissector tables with string keys. (Using _port can confuse people into thinking they're intended solely for use with TCP/UDP/etc. ports when, in fact, they work better for things such as Ethernet types, where the binding of particular values to particular protocols are a lot stronger.) svn path=/trunk/; revision=35224
2010-11-17Separate out/update comment block.Jaap Keuter1-99/+50
Update IANA assignments. Use available checksum routines. Some cleanup and use of convenience macros. svn path=/trunk/; revision=34922
2010-10-08Catch exceptions from subdissectors, even when we're not handing theJeff Morriss1-27/+44
subdissector the first fragment of a fragmented message so that an exception in the first chunk doesn't abort dissection of subsquent chunks in the frame. Restore pinfo->private_data after an exception was thrown by a subdissector. This is necessary in case a subdissector had changed it but was unable to restore it (due to the exception). svn path=/trunk/; revision=34420
2010-08-02Fix cases where the type of a for loop variable is smaller than the type of ↵Bill Meier1-3/+3
the "end" variable. In some cases the usage may have been benign since it can be seen by code inspection that the maximum value of the end variable can't exceed the maximum value of the loop variable. However, on general principles, all the usages have been fixed. svn path=/trunk/; revision=33692
2010-06-14Update SCTP PPIDs.Michael Tüxen1-0/+2
svn path=/trunk/; revision=33225
2010-05-24Refer to the endianness arguments as "encoding" rather thanGuy Harris1-122/+122
"representation" - we already use "representation" to refer to the text representation of fields. Change some routines with an endianness argument to make it a representation argument instead; svn path=/trunk/; revision=32929
2010-05-13Create a new REP_NA value for fields where there are no representationsGuy Harris1-2/+2
from which to choose; use that for protocol fields in some protocols (modify the CORBA generator to use it, and manually update the generated CORBA dissectors accordingly). svn path=/trunk/; revision=32777
2010-05-12Instead of using private #defines for the last argument toGuy Harris1-121/+120
proto_tree_add_item(), use the new REP_BIG_ENDIAN and REP_LITTLE_ENDIAN values. Use those #defines in variables that represent the byte order, as well. svn path=/trunk/; revision=32776
2010-05-10Indentation & whitespace cleanup (including: "4 space tabs" ==> spaces)Bill Meier1-486/+486
svn path=/trunk/; revision=32735
2010-05-06Add PPID 28 IRCPAnders Broman1-0/+1
svn path=/trunk/; revision=32686
2010-01-13Display correct chunk type for unknown chunks.Michael Tüxen1-3/+3
svn path=/trunk/; revision=31522
2009-10-28- Remove check_col.Anders Broman1-4/+3
- Make x2ap work. svn path=/trunk/; revision=30746
2009-10-28Update SCTP ppids, fix a faulty #define.Anders Broman1-0/+3
svn path=/trunk/; revision=30744
2009-10-16(Trivial) Fix a typo in a comment.Bill Meier1-1/+1
svn path=/trunk/; revision=30574
2009-09-24* Prefer col_append_str instead of col_append_fstr for constant stringsKovarththanan Rajaratnam1-10/+5
* Remove check_col guards svn path=/trunk/; revision=30127
2009-08-23Update list of PPIDs.Michael Tüxen1-3/+13
This fixes bug 3928. svn path=/trunk/; revision=29520
2009-08-16Switch a bunch of dissectors over to using tvb_new_subset_remaining()Kovarththanan Rajaratnam1-1/+1
svn path=/trunk/; revision=29446
2009-08-09Don't guard col_set_str (COL_PROTOCOL) with col_checkKovarththanan Rajaratnam1-2/+1
svn path=/trunk/; revision=29340
2009-08-06Those items are 32 bits or longer, so the cast should be safe; add anGuy Harris1-2/+2
additional cast in the hopes that they squelch "dereferencing type-punned pointer" warnings. svn path=/trunk/; revision=29318
2009-07-12Fix a typoBill Meier1-1/+1
svn path=/trunk/; revision=29068
2009-06-18From Kovarththanan Rajaratnam via bug 3548:Stig Bjørlykke1-134/+134
(1) Trailing/leading spaces are removed from 'name's/'blurb's (2) Duplicate 'blurb's are replaced with NULL (3) Empty ("") 'blurb's are replaced with NULL (4) BASE_NONE, NULL, 0x0 are used for 'display', 'strings' and 'bitmask' fields for FT_NONE, FT_BYTES, FT_IPv4, FT_IPv6, FT_ABSOLUTE_TIME, FT_RELATIVE_TIME, FT_PROTOCOL, FT_STRING and FT_STRINGZ field types (5) Only allow non-zero value for 'display' if 'bitmask' is non-zero svn path=/trunk/; revision=28770
2009-06-05* Fix name of Irene in AUTHORS.Michael Tüxen1-116/+346
* Add Varun Notibala to AUTHORS. * Add support for NR-SACK and fix stability problems. svn path=/trunk/; revision=28642
2009-05-13Apply some of the patches from:Anders Broman1-4/+2
http://wiki.wireshark.org/Development/Optimization svn path=/trunk/; revision=28356
2009-03-03Use the SCTP ppid for S1AP.Anders Broman1-0/+1
svn path=/trunk/; revision=27585
2008-12-17Fix some typos and spelling (mostly in text strings)Bill Meier1-1/+1
svn path=/trunk/; revision=27037
2008-12-10put the SCTP PPI for current DATA chunk into packet_info (and ppid array ↵Tomas Kukosa1-4/+6
renamed to ppids) svn path=/trunk/; revision=26958
2008-11-13Fix a warning.Guy Harris1-1/+1
svn path=/trunk/; revision=26771
2008-11-05Fix a trivial typoBill Meier1-1/+1
svn path=/trunk/; revision=26702
2008-09-17If we're dissecting for a read filter in the GUI [tshark assignsJeff Morriss1-8/+20
frame numbers before running the read filter], don't do the TSN analysis. (We can't anyway because we don't have a valid frame number...) Without this change if you load a capture file in the GUI while using a read filter, every SCTP TSN is marked as a retransmission of that in frame 0. svn path=/trunk/; revision=26226
2008-09-12Add support forMichael Tüxen1-2/+10
http://www.ietf.org/internet-drafts/draft-tuexen-tsvwg-sctp-sack-immediately-00.txt svn path=/trunk/; revision=26184
2008-08-21Add an expert info noting an a_rwnd of 0.Jeff Morriss1-2/+9
svn path=/trunk/; revision=26055