aboutsummaryrefslogtreecommitdiffstats
path: root/epan/dissectors/packet-scsi.c
AgeCommit message (Collapse)AuthorFilesLines
2014-03-11packet-scsi.c minor changes - add WWN dissection and fix a typoYaniv Kaul1-4/+7
Change-Id: I0ef84e088988f1a40863ab54b722faace8bacc31 Reviewed-on: https://code.wireshark.org/review/592 Reviewed-by: Alexis La Goutte <alexis.lagoutte@gmail.com> Reviewed-by: Anders Broman <a.broman58@gmail.com>
2014-03-04Remove all $Id$ from top of fileAlexis La Goutte1-2/+0
(Using sed : sed -i '/^ \* \$Id\$/,+1 d') Fix manually some typo (in export_object_dicom.c and crc16-plain.c) Change-Id: I4c1ae68d1c4afeace8cb195b53c715cf9e1227a8 Reviewed-on: https://code.wireshark.org/review/497 Reviewed-by: Anders Broman <a.broman58@gmail.com>
2013-12-26Fix Dead Store (Dead assignement/Dead increment) warning found by ClangAlexis La Goutte1-9/+9
svn path=/trunk/; revision=54457
2013-12-26Fix -Wunused-const-variable found by ClangAlexis La Goutte1-0/+2
svn path=/trunk/; revision=54456
2013-12-26From Yaniv Kaul via https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=9595Alexis La Goutte1-8/+10
Small changes (mainly textual) to packet-scsi.c The attached patch fixes small issues in SCSI dissection: 1. Extends the meaning of some fields (for example, the mysterious 'LBPME' becomes 'LBPME (logical block provisioning management enabled) / TPE' 2. Adds another ASC value which is important to me - 'Thin Provisioning Soft Threshold Reached' . Added comment where to get all of them (at http://www.t10.org/lists/asc-alph.txt or http://www.t10.org/lists/asc-num.txt) 3. Fixes a small typo: scsi.extcopy.dest_lba is 'Destination LBA', not 'Source LBA' (silly copy-paste mistake). svn path=/trunk/; revision=54455
2013-12-23Reove _U_ from some function parameters ...Bill Meier1-4/+4
svn path=/trunk/; revision=54386
2013-12-23Change types to try to avoid warnings.Martin Mathieson1-2/+4
svn path=/trunk/; revision=54385
2013-12-23From Yaniv Kaul via https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=9551Alexis La Goutte1-6/+460
Dissect SCSI XCOPY and RECEIVE COPY Parameters commands From me : Fix encoding-args Fix trailing whitespace svn path=/trunk/; revision=54381
2013-12-12Create/use a number of extended value-strings;Bill Meier1-67/+68
Remove or comment out dups from several value-string arrays; Sort a number of value-string arrays; Reformat many hf[] entries; Remove some unneeded initializers; Add editor-modelines; Use consistent indentation; Reformat whitespace. svn path=/trunk/; revision=53968
2013-12-11- Make local functions static.Anders Broman1-1/+4
- Forward declaration of register functions. svn path=/trunk/; revision=53942
2013-10-23#if 0 numerous "unused const variables" (mostly value-string-arrays);Bill Meier1-0/+2
Also; fix a few "set but not used" warnings. svn path=/trunk/; revision=52780
2013-10-13whitespace fixes; mostly: remove trailing blanksBill Meier1-1/+1
svn path=/trunk/; revision=52591
2013-09-14emem -> wmemJörg Mayer1-6/+6
svn path=/trunk/; revision=52038
2013-08-15From Yaniv Kaul via https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=9040Evan Huus1-3/+24
Small fixes and enhancements to SCSI INQUIRY results. svn path=/trunk/; revision=51362
2013-08-13From Yaniv Kaul:Anders Broman1-1/+11
small addition to SCSI dissection (media rotation speed analysis) https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=9030 svn path=/trunk/; revision=51330
2013-08-08Remove a couple of set-but-no-longer-used variables.Jeff Morriss1-4/+2
svn path=/trunk/; revision=51225
2013-08-08Use convert_proto_tree_add_text.pl to make many more fields filterable.Michael Mann1-584/+916
Someone may want to check that the display filter naming scheme is consistent, I at least tried to make it consistent with the new filters created. May want to also add subtrees for the bit flags that used to be grouped in a single proto_tree_add_text. svn path=/trunk/; revision=51223
2013-08-07From Javier Godoy:Anders Broman1-2/+28
Dissect SCSI OSD attribute identification sense data descriptor. https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=8971 svn path=/trunk/; revision=51179
2013-08-05SCSI dissector does not parse PERSISTENT RESERVE commands correctly. Bug ↵Michael Mann1-9/+35
9012 (https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=9012). From Bart Van Assche. Changes: - Add REGISTER AND MOVE and REPLACE LOST RESERVATION service actions. - Decode the PARAMETER LIST LENGTH field correctly - this is a four byte field instead of a two byte field. - For the REGISTER AND MOVE service action, add support for decoding the RELATIVE TARGET PORT IDENTIFIER, TRANSPORT ID LENGTH and TransportID fields. - Fix parsing of the SERVICE ACTION field - this field is five bits wide instead of four. - Move the definition of the "scsi.persresv.control.unreg" field just below the other REGISTER AND MOVE service action parameter list fields. See also http://www.t10.org/cgi-bin/ac.pl?t=f&f=spc4r36h.pdf. - Only display persistent reservation information in a PERSISTENT RESERVE IN response if the ALLOCATION LENGTH field in the request was not zero. - Correct the offset of the (SPC-2) SCOPE-SPECIFIC ADDRESS field. This field starts at offset 16 and not at offset 8. - Correct the offsets of the SCOPE and TYPE fields. These fields are both contained in the byte at offset 21. - Correct the base of the TRANSPORTID LENGTH field from BASE_HEX into BASE_NONE since this is the base required by non-numeric types. For more information, see also: * http://www.t10.org/cgi-bin/ac.pl?t=f&f=spc4r36h.pdf * http://www.t10.org/cgi-bin/ac.pl?t=f&f=spc2r20.pdf svn path=/trunk/; revision=51152
2013-07-23From Javier Godoy via https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=8963Alexis La Goutte1-0/+1
packet-scsi.c add asc/ascq code 2C:0A Add ASC/ASCQ code 2C:0Ah "PARTITION OR COLLECTION CONTAINS USER OBJECTS" (SPC-4 svn path=/trunk/; revision=50828
2013-07-23From Javier Godoy via https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=8965Alexis La Goutte1-1/+1
Packet-scsi.c: fix subtree reference: ett_sense_osd_completed The field hf_scsi_sns_osd_object_completed should be dissected under ett_sense_osd_completed instead of ett_sense_osd_not_initiated (It was a copy-paste error in attachment 10967 from bug 8790) svn path=/trunk/; revision=50827
2013-07-17Remove fragment_data, add fragment_head, fragment_item - for now alias it to ↵Jakub Zawadzki1-1/+1
the same structure. This is begin of work to split fragment head and fragments items. svn path=/trunk/; revision=50708
2013-07-03Fix typo (Missing CR)Alexis La Goutte1-1/+2
svn path=/trunk/; revision=50342
2013-06-29Fix warning from fix-encoding-argsAlexis La Goutte1-1/+1
epan/dissectors/packet-scsi.c: FT_BYTES: proto_tree_add_item(tree, hf_scsi_report_opcodes_cdb_usage_data, tvb_v, offset_v+4, length, [[ENC_BIG_ENDIAN]-->[ENC_NA]]); svn path=/trunk/; revision=50246
2013-06-29Fix some Dead Store (Dead assignement/Dead increment) Warning found by ClangAlexis La Goutte1-1/+1
svn path=/trunk/; revision=50235
2013-06-14Remove check_col() and the occasional tree.Michael Mann1-30/+18
svn path=/trunk/; revision=49923
2013-06-13From Javier Godoy via https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=8794 :Jeff Morriss1-4/+4
Display the value of unknown sense descriptor codes in the tree item. Also fix the length of the subtree. svn path=/trunk/; revision=49916
2013-06-12From Javier GodoyMartin Kaiser1-4/+63
dissect SCSI OSD error identification sense data descriptor from me - TABs -> spaces - fix compiler errors about unused return values - don't use another subtree within the descriptor payload https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=8790 svn path=/trunk/; revision=49901
2013-06-12From Javier Godoy:Anders Broman1-7/+38
dissect SCSI field pointer sense key specific information https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=8789 svn path=/trunk/; revision=49895
2013-06-11TABs -> spacesMartin Kaiser1-162/+176
add editor modelines svn path=/trunk/; revision=49891
2013-06-11From Javier GodoyMartin Kaiser1-9/+65
dissect SCSI descriptor format sense data from me - replace TABs with spaces - delete unused variable "flags" - set format string for proto_tree_add_text() - use val_to_str_const() https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=8786 svn path=/trunk/; revision=49890
2013-06-11From Javier Godoy:Anders Broman1-16/+200
update SCSI version descriptors defined in SPC-4 revision 36g (scsi_verdesc_val). https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=8784 svn path=/trunk/; revision=49877
2013-06-09From Javier Godoy:Anders Broman1-3/+4
SCSI (SPC) sense key specific information field must not include SKSV. https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=8782 #Backport 1.10 1.8 svn path=/trunk/; revision=49863
2013-05-27SCSI Add decoding of Block Device Characteristics VPD pageRonnie Sahlberg1-1/+54
svn path=/trunk/; revision=49592
2013-05-27SCSI: Print the INQUIRY EVPD page name in the info columnRonnie Sahlberg1-2/+6
svn path=/trunk/; revision=49591
2013-05-27SCSI: add dissection of Tiemout Descriptor for REPORT SUPPORTED OPCODESRonnie Sahlberg1-5/+45
svn path=/trunk/; revision=49590
2013-05-19SCSI: Add support for report-one-command structure for REPORT SUPPORTED OPCODESRonnie Sahlberg1-2/+31
svn path=/trunk/; revision=49415
2013-05-19SCSI: REPORT SUPPORTED OPCODES print the reporing options in human readableRonnie Sahlberg1-1/+8
text. svn path=/trunk/; revision=49414
2013-05-18SCSI: Add dissection of REPORT SUPPORTED OPCODESRonnie Sahlberg1-2/+181
svn path=/trunk/; revision=49408
2013-04-01Typo's. That is all.Jaap Keuter1-4/+4
svn path=/trunk/; revision=48685
2013-03-29Rename value string (and similar) functions to use a consistent pattern. ThisEvan Huus1-5/+5
was done using textual search+replace, not anything syntax-aware, so presumably it got most comments as well (except where there were typos). Use a consistent coding style, and make proper use of the WS_DLL_* defines. Group the functions appropriately in the header. I ended up getting rid of most of the explanatory comments since many of them duplicated what was in the value_string.c file (and were out of sync with the recent updates I made to those in r48633). Presumably most of the comments should be in the .h file not the .c file, but there's enough churn ahead that it's not worth fixing yet. Part of https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=8467 svn path=/trunk/; revision=48634
2013-03-22Don't wire into the reassembly code the notion that reassemblies shouldGuy Harris1-7/+6
be done on flows from one address to another; reassembly for protocols running atop TCP should be done on flows from one TCP endpoint to another. We do this by: adding "reassembly table" as a data structure; associating hash tables for both in-progress reassemblies and completed reassemblies with that data structure (currently, not all reassemblies use the latter; they might keep completed reassemblies in the first table); having functions to create and destroy keys in that table; offering standard routines for doing address-based and address-and-port-based flow processing, so that dissectors not needing their own specialized flow processing can just use them. This fixes some mis-reassemblies of NIS YPSERV YPALL responses (where the second YPALL response is processed as if it were a continuation of a previous response between different endpoints, even though said response is already reassembled), and also allows the DCE RPC-specific stuff to be moved out of epan/reassembly.c into the DCE RPC dissector. svn path=/trunk/; revision=48491
2013-03-19From beroset:Anders Broman1-5/+5
remove C++ incompatibilities https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=8416 svn path=/trunk/; revision=48430
2013-03-17Fix some Dead Store (Dead assignement/Dead increment) Warning found by ClangAlexis La Goutte1-2/+2
svn path=/trunk/; revision=48381
2013-03-12SPC-3 and later has a 16-bit allocation length for the INQUIRY allocationRonnie Sahlberg1-2/+2
length. While SPC-2 only has one byte for allocation length Change this to treat allocation length as a 16 bit quantity starting one byte prior to the current single byte that wireshark dissects. This makes it correct for SPC-3 and later and still works for SPC-2 since that first byte is reserverd, == must be 0, in SPC-2 and prior. svn path=/trunk/; revision=48258
2013-01-29Add missing 'hf_scsi_persresv_control_unreg' hf[] entry.Bill Meier1-39/+41
(Found by checkhf) Do some minor whitespace cleanup. svn path=/trunk/; revision=47341
2013-01-22Fix bug found by VS Code Analysis: warning C6336: Arithmetic operator has ↵Chris Maynard1-1/+2
precedence over question operator, use parentheses to clarify intent svn path=/trunk/; revision=47202
2012-12-18SCSI: PERSISTENT_RESERVE_IN add names for service action 2/3 report ↵Ronnie Sahlberg1-1/+5
capabilities/read full status svn path=/trunk/; revision=46584
2012-11-20SCSI: Sense buffers come in two flavors. Start decoding the descriptor format.Ronnie Sahlberg1-7/+35
svn path=/trunk/; revision=46097
2012-09-24From Steve Magnani via ↵Pascal Quantin1-10/+10
https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=7753 : Fix display of WRITE BUFFER and SEND DIAGNOSTIC fields in SCSI dissector svn path=/trunk/; revision=45111
generated by cgit v1.2.3 (git 2.25.1) at 2024-09-23 07:53:24 +0000