aboutsummaryrefslogtreecommitdiffstats
path: root/epan/dissectors/packet-scsi-sbc.c
AgeCommit message (Collapse)AuthorFilesLines
2021-12-19Replace g_snprintf() with snprintf() (dissectors)João Valverde1-13/+13
Use macros from inttypes.h with format strings.
2021-02-10SCSI: use BASE_DEC_HEX for counts/lengths/etc..Guy Harris1-1/+1
Show values that are sequence numbers, counts, lengths, and the like in decimal, with the hex value after it in parentheses for the benefit of those who count to 16 rather than 10.
2020-06-19Fix the type of arrays of pointers to hf_ values for bitfield routines.Guy Harris1-35/+35
The static arrays are supposed to be arrays of const pointers to int, not arrays of non-const pointers to const int. Fixing that means some bugs (scribbling on what's *supposed* to be a const array) will be caught (see packet-ieee80211-radiotap.c for examples, the first of which inspired this change and the second of which was discovered while testing compiles with this change), and removes the need for some annoying casts. Also make some of those arrays static while we're at it. Update documentation and dissector-generator tools. Change-Id: I789da5fc60aadc15797cefecfd9a9fbe9a130ccc Reviewed-on: https://code.wireshark.org/review/37517 Petri-Dish: Guy Harris <gharris@sonic.net> Tested-by: Petri Dish Buildbot Reviewed-by: Anders Broman <a.broman58@gmail.com>
2019-07-26HTTPS (almost) everywhere.Guy Harris1-1/+1
Change all wireshark.org URLs to use https. Fix some broken links while we're at it. Change-Id: I161bf8eeca43b8027605acea666032da86f5ea1c Reviewed-on: https://code.wireshark.org/review/34089 Reviewed-by: Guy Harris <guy@alum.mit.edu>
2018-02-12dissectors: use SPDX identifiers.Dario Lombardo1-13/+1
Change-Id: I92c94448e6641716d03158a5f332c8b53709423a Reviewed-on: https://code.wireshark.org/review/25756 Petri-Dish: Dario Lombardo <lomato@gmail.com> Reviewed-by: Anders Broman <a.broman58@gmail.com>
2015-09-11initial write atomicRonnie Sahlberg1-1/+31
Change-Id: I77be80c015945e495573003d461783a0380ded09 Signed-off-by: Ronnie Sahlberg <ronniesahlberg@gmail.com> Reviewed-on: https://code.wireshark.org/review/10479
2014-12-25Deleting unnecessary #includes from dissectors.Martin Mathieson1-2/+0
Fifth batch (packet-rtp.c -> end). Will look at cleaning up and committing script afterwards. Change-Id: I8ed61dc941d98d3f7259a9d1f74e214eb7b4bfa2 Reviewed-on: https://code.wireshark.org/review/6052 Reviewed-by: Martin Mathieson <martin.r.mathieson@googlemail.com>
2014-12-21Cleanup use of #includes in non-generated epan/dissector/*.cBill Meier1-1/+0
Specifically: - Set packet.h to be the first wireshark #include after config.h and "system" #includes. packet.h added as an #include in some cases when missing. - Remove some #includes included (directly/indirectly) in packet.h. E.g., glib.h. (Done only for those files including packet.h). - As needed, move "system" #includes to be after config.h and before wireshark #includes. - Rework various #include file specifications for consistency. - Misc. Change-Id: Ifaa1a14b50b69fbad38ea4838a49dfe595c54c95 Reviewed-on: https://code.wireshark.org/review/5923 Petri-Dish: Alexis La Goutte <alexis.lagoutte@gmail.com> Reviewed-by: Bill Meier <wmeier@newsguy.com>
2014-07-25Empty proto_reg_handoff_* are not needed, remove some.Jakub Zawadzki1-6/+0
Change-Id: I957b01aa00bbff3c48192388c7ad9e601d79c778 Reviewed-on: https://code.wireshark.org/review/3196 Reviewed-by: Bill Meier <wmeier@newsguy.com>
2014-07-09convert to proto_tree_add_subtree[_format]Michael Mann1-4/+2
Change-Id: I8d66b1bc7dbdfee3d4bf6fd3b3c21c6323b66f44 Reviewed-on: https://code.wireshark.org/review/2946 Reviewed-by: Michael Mann <mmann78@netscape.net>
2014-06-17Add support for WRITE_LONG16 & REPORT_REFERRALS to scsi dissectorAnish Bhatt1-30/+132
Picking up leftover work on https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=8843 Change-Id: Ie3df55ae3309cf68f64b2aa184fb2904d1200cb5 Signed-off-by: Anish Bhatt <anish@chelsio.com> Reviewed-on: https://code.wireshark.org/review/2239 Reviewed-by: Anders Broman <a.broman58@gmail.com>
2014-03-04Remove all $Id$ from top of fileAlexis La Goutte1-2/+0
(Using sed : sed -i '/^ \* \$Id\$/,+1 d') Fix manually some typo (in export_object_dicom.c and crc16-plain.c) Change-Id: I4c1ae68d1c4afeace8cb195b53c715cf9e1227a8 Reviewed-on: https://code.wireshark.org/review/497 Reviewed-by: Anders Broman <a.broman58@gmail.com>
2013-12-26From Yaniv Kaul via https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=9595Alexis La Goutte1-2/+2
Small changes (mainly textual) to packet-scsi.c The attached patch fixes small issues in SCSI dissection: 1. Extends the meaning of some fields (for example, the mysterious 'LBPME' becomes 'LBPME (logical block provisioning management enabled) / TPE' 2. Adds another ASC value which is important to me - 'Thin Provisioning Soft Threshold Reached' . Added comment where to get all of them (at http://www.t10.org/lists/asc-alph.txt or http://www.t10.org/lists/asc-num.txt) 3. Fixes a small typo: scsi.extcopy.dest_lba is 'Destination LBA', not 'Source LBA' (silly copy-paste mistake). svn path=/trunk/; revision=54455
2013-12-23From Yaniv Kaul via https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=9551Alexis La Goutte1-2/+3
Dissect SCSI XCOPY and RECEIVE COPY Parameters commands From me : Fix encoding-args Fix trailing whitespace svn path=/trunk/; revision=54381
2013-12-12Create/use a number of extended value-strings;Bill Meier1-87/+88
Remove or comment out dups from several value-string arrays; Sort a number of value-string arrays; Reformat many hf[] entries; Remove some unneeded initializers; Add editor-modelines; Use consistent indentation; Reformat whitespace. svn path=/trunk/; revision=53968
2013-12-11- Make local functions static.Anders Broman1-0/+2
- Forward declaration of register functions. svn path=/trunk/; revision=53942
2013-11-09Don't include <epan/strutil.h> when not needed.Jakub Zawadzki1-1/+0
svn path=/trunk/; revision=53194
2013-10-23#if 0 numerous "unused const variables" (mostly value-string-arrays);Bill Meier1-0/+2
Also; fix a few "set but not used" warnings. svn path=/trunk/; revision=52780
2013-06-14Remove check_col() and the occasional tree.Michael Mann1-94/+70
svn path=/trunk/; revision=49921
2013-05-26SCSI: Add dissection of the data-out buffer for SANITIZE service action ↵Ronnie Sahlberg1-3/+48
OVERWRITE svn path=/trunk/; revision=49589
2013-05-25SCSI: Add basic decoding of SANITIZE opcodeRonnie Sahlberg1-2/+65
svn path=/trunk/; revision=49582
2013-05-18SCSI: Add dissection of REPORT SUPPORTED OPCODESRonnie Sahlberg1-1/+2
svn path=/trunk/; revision=49408
2013-02-20fix dead assignmentMartin Kaiser1-1/+0
http://www.wireshark.org/download/automated/analysis/scan-build-2013-02-20-2/report-OsH7hZ.html#EndPath svn path=/trunk/; revision=47782
2013-02-20TABs -> spacesMartin Kaiser1-580/+594
add modelines svn path=/trunk/; revision=47781
2013-01-31Use '#if 0 ... #endif' rather than /** ... **/ to comment outBill Meier1-8/+8
unused hf[] entries (which I should have done in the first place). svn path=/trunk/; revision=47390
2013-01-26Comment out cases of unused hf array entries found by checkhf.Bill Meier1-2/+6
svn path=/trunk/; revision=47302
2012-09-20We always HAVE_CONFIG_H so don't bother checking whether we have it or not.Jeff Morriss1-3/+1
svn path=/trunk/; revision=45017
2012-09-11SCSI: PMI and LBA are no longer part of READCAPACITY10 in current versions ↵Ronnie Sahlberg1-21/+0
of SBC svn path=/trunk/; revision=44867
2012-09-11SCSI: SBC, print the subcommand name in the info column for service-action-inRonnie Sahlberg1-0/+5
svn path=/trunk/; revision=44866
2012-09-11SCSI: SBC: READCAPACITY16 no longer have PMI or LBA in the request in modern ↵Ronnie Sahlberg1-14/+2
versions of the standard svn path=/trunk/; revision=44865
2012-07-25Converted scsi dissectors display filter format from scsi.<protocol> to ↵Michael Mann1-91/+91
scsi_<protocol> (matching their registered filter name) svn path=/trunk/; revision=43993
2012-07-14Add support for SCSI SBC ORWRITE commandRonnie Sahlberg1-1/+33
svn path=/trunk/; revision=43711
2012-07-14Add support for SCSI SBC COMPARE_AND_WRITE opcodeRonnie Sahlberg1-1/+32
svn path=/trunk/; revision=43709
2012-06-28Update Free Software Foundation address.Jakub Zawadzki1-1/+1
(COPYING will be updated in next commit) svn path=/trunk/; revision=43536
2012-05-29SCSI SBC: Add dissection of GET_LBA_STATUS commandRonnie Sahlberg1-2/+89
svn path=/trunk/; revision=42897
2012-04-28SCSI SBC: Add dissection of the ANCHOR and UNMAP bits in WRITESAME10/16Ronnie Sahlberg1-0/+12
svn path=/trunk/; revision=42307
2012-04-09Add missing const attribute to some char *Jakub Zawadzki1-1/+1
Fix some "assignment discards qualifiers from pointer target type", etc svn path=/trunk/; revision=41993
2012-03-30SCSI SBC: Add the new fields that have been added to READ_CAPACITY16Ronnie Sahlberg1-0/+50
svn path=/trunk/; revision=41864
2012-03-27SCSI SBC : Add decode for UNMAP commandRonnie Sahlberg1-2/+84
svn path=/trunk/; revision=41795
2011-10-24Fix encoding arg for various fcn calls:Bill Meier1-65/+65
- proto_tree_add_bits_item - proto_tree_add_bits_ret_val - proto_tree_add_bitmask - tvb_get_bits - tvb_get_bits16 - tvb_get_bits24 - tvb_get_bits32 - tvb_get_bits64 svn path=/trunk/; revision=39539
2011-10-06Convert 'encoding' parameter of certain proto_tree_add_item() calls in ↵Bill Meier1-78/+78
non-autogenerated epan/dissectors: Specifically: Replace FALSE|0 and TRUE|1 by ENC_BIG_ENDIAN|ENC_LITTLE_ENDIAN as the encoding parameter for proto_tree_add_item() calls which directly reference an item in hf[] which has a type of: FT_UINT8 FT_UINT16 FT_UINT24 FT_UINT32 FT_UINT64 FT_INT8 FT_INT16 FT_INT24 FT_INT32 FT_INT64 FT_FLOAT FT_DOUBLE svn path=/trunk/; revision=39288
2011-10-05Use ENC_NA as encoding for proto_tree_add_item() calls which directly ↵Bill Meier1-5/+5
reference an hf item with types in hf[] of: FT_NONE FT_BYTES FT_IPV6 FT_IPXNET FT_OID svn path=/trunk/; revision=39261
2010-12-06Improve dissection of bit-oriented fields. Patch from Richard Sharpe viaChris Maynard1-327/+152
bug #5466 with some minor whitespace modifications from me and a fix of an invalid offset introduced with the patch. Fuzz testing still needs to be done. I can't seem to get the fuzz tester to work with the capture files attached to the bug report. svn path=/trunk/; revision=35137
2010-04-06#include <string.h> not needed.Bill Meier1-1/+0
svn path=/trunk/; revision=32410
2009-06-18From Kovarththanan Rajaratnam via bug 3548:Stig Bjørlykke1-69/+69
(1) Trailing/leading spaces are removed from 'name's/'blurb's (2) Duplicate 'blurb's are replaced with NULL (3) Empty ("") 'blurb's are replaced with NULL (4) BASE_NONE, NULL, 0x0 are used for 'display', 'strings' and 'bitmask' fields for FT_NONE, FT_BYTES, FT_IPv4, FT_IPv6, FT_ABSOLUTE_TIME, FT_RELATIVE_TIME, FT_PROTOCOL, FT_STRING and FT_STRINGZ field types (5) Only allow non-zero value for 'display' if 'bitmask' is non-zero svn path=/trunk/; revision=28770
2008-12-17Fix some typos and spelling (mostly in text strings)Bill Meier1-1/+1
svn path=/trunk/; revision=27037
2008-08-26#include <emem.h> not req'dBill Meier1-1/+0
svn path=/trunk/; revision=26091
2008-08-25#include <prefs.h> not req'dBill Meier1-1/+0
svn path=/trunk/; revision=26089
2007-05-29Use G_GINT64_MODIFIER, rather than the PRI[douxX]64 macros, for GLibGuy Harris1-9/+9
routines and routines using those routines. GLib might use different modifiers for 64-bit quantities than the platform's C library does. svn path=/trunk/; revision=21990
2007-04-13another attempt to let windows buildbot becoming greenSebastien Tandel1-66/+66
fix rev21398 (gcc warning fix) svn path=/trunk/; revision=21412