aboutsummaryrefslogtreecommitdiffstats
path: root/epan/dissectors/packet-rtps2.c
AgeCommit message (Collapse)AuthorFilesLines
2013-04-04RTPS Cleanup, Part 3 (final)Michael Mann1-7682/+0
Merged packet-rtps.c and packet-rtps2.c into a single dissector. It appears packet-rtps2.[ch] "API" needs to be externally available, otherwise I would have rolled (the newly merged) packet-rtps.h into packet-rtps.c as well. Converted many of the remaining proto_tree_add_text to proto_tree_add_item/expert_info and cleaned up the manual string manipulation so checkAPIs.pl is happy. Added a "cooked" capture file to the SampleCaptures page on the wiki for future fuzztesting/regression. svn path=/trunk/; revision=48727
2013-03-23Fix some Dead Store (Dead assignement/Dead increment) Warning found by ClangAlexis La Goutte1-8/+8
svn path=/trunk/; revision=48507
2013-03-19From beroset:Anders Broman1-1/+1
remove C++ incompatibilities https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=8416 svn path=/trunk/; revision=48430
2013-03-09RTPS Cleanup, Part 2Michael Mann1-2010/+368
1. Convert more proto_tree_add_text to proto_tree_add_<something else>/expert_info. checkAPIs.pl is happy (for packet-rtps.c), but the raw number is a bit deceiving because of macros and wrappers. 2. Fixed the offending "uses snprintf + strlen to assemble strings" in packet-rtps.c. The exact same code is used in packet-rtps2.c, so just proper refactoring will fix it. There is still too much unnecessary use of g_snprintf/g_strlcpy/strlen, but that's for a later date. 3. Removed most of the "useless" wrapper functions. Again, the number of proto_tree_add_text is deceiving, so the number of hfs that really need to be created is much larger. 4. Whitespace cleanup. Removed a lot of whitespace so I could see more code on the screen, to help determine duplication between packet-rtps.c and packet-rtps2.c Comments/descriptions of fields remain untouched. The more I trim, the more I think this should all be in a single dissector file, which will be the goal of the next update. Trying to patch this in somewhat manageable chunks. Also need to submit sample traces generated for (fuzz)testing. svn path=/trunk/; revision=48206
2013-03-05Unused parameter.Anders Broman1-1/+1
svn path=/trunk/; revision=48084
2013-03-05RTPS Cleanup, Part 1Michael Mann1-531/+280
1. Cleanup COL_INFO processing 2. Add expert_info for "octet_to_next_header" ranges 3. Check "RTPS" all at once 4. Remove some unnecessary function declaration. Next is probably consolidating packet-rtps.c and packet-rtps2.c as there seems to be a lot of duplicative functionality. svn path=/trunk/; revision=48082
2013-02-14Fix potential buffer overflow in RTPS and RTPS2 dissectors by allocating ↵Michael Mann1-2/+3
enough memory to fit the "indentation space". Bug 8332 (https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=8332) svn path=/trunk/; revision=47658
2013-01-31Use '#if 0 ... #endif' rather than /** ... **/ to comment outBill Meier1-6/+6
unused hf[] entries (which I should have done in the first place). svn path=/trunk/; revision=47390
2013-01-26Comment out cases of unused hf array entries found by checkhf.Bill Meier1-5/+10
svn path=/trunk/; revision=47302
2012-12-26Fix a bunch of warnings.Guy Harris1-10/+10
Cast away some implicit 64-bit-to-32-bit conversion errors due to use of sizeof. Cast away some implicit 64-bit-to-32-bit conversion errors due to use of strtol() and strtoul(). Change some data types to avoid those implicit conversion warnings. When assigning a constant to a float, make sure the constant isn't a double, by appending "f" to the constant. Constify a bunch of variables, parameters, and return values to eliminate warnings due to strings being given const qualifiers. Cast away those warnings in some cases where an API we don't control forces us to do so. Enable a bunch of additional warnings by default. Note why at least some of the other warnings aren't enabled. randpkt.c and text2pcap.c are used to build programs, so they don't need to be in EXTRA_DIST. If the user specifies --enable-warnings-as-errors, add -Werror *even if the user specified --enable-extra-gcc-flags; assume they know what they're doing and are willing to have the compile fail due to the extra GCC warnings being treated as errors. svn path=/trunk/; revision=46748
2012-09-20We always HAVE_CONFIG_H so don't bother checking whether we have it or not.Jeff Morriss1-3/+1
svn path=/trunk/; revision=45017
2012-09-10Initial commit to support yet another method of passing data between dissectors.Jakub Zawadzki1-4/+3
Add new parameter 'data' to heur_dissector_t and new_dissector_t, for now it's always NULL svn path=/trunk/; revision=44860
2012-08-08Use ep_strbufs instead of trying to track string offsets manuallyGerald Combs1-32/+25
and overflowing a buffer. Fixes a crash in bug 7568 discovered by Laurent Butti. We do the Dance Of The String Offset Pointers in several other places. They should probably be changed to ep_strbufs as well. svn path=/trunk/; revision=44320
2012-06-28Update FSF address - part II.Jakub Zawadzki1-1/+1
svn path=/trunk/; revision=43538
2011-10-28From Adam Mitz:Anders Broman1-4/+4
The RTPS2 dissector doesn't handle octetsToNextHeader properly in INFO_RELY submessages. https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=6506 svn path=/trunk/; revision=39646
2011-10-26Fix proto_tree_add_item() encoding args;Bill Meier1-63/+63
Use gboolean instead of int in certain cases. svn path=/trunk/; revision=39616
2011-10-21Fix for bug 6449:Jaap Keuter1-14/+16
Last RTPS2 submessage could have zero as octets_to_next_header. From me: coding style unused parameters. svn path=/trunk/; revision=39506
2011-10-21For proto_tree_add_item(..., proto_xxx, ...)use ENC_NA as the encoding arg.Bill Meier1-1/+1
Also: remove trailing whitespace for a number of files. svn path=/trunk/; revision=39503
2011-10-06Convert 'encoding' parameter of certain proto_tree_add_item() calls in ↵Bill Meier1-2/+2
non-autogenerated epan/dissectors: Specifically: Replace FALSE|0 and TRUE|1 by ENC_BIG_ENDIAN|ENC_LITTLE_ENDIAN as the encoding parameter for proto_tree_add_item() calls which directly reference an item in hf[] which has a type of: FT_UINT8 FT_UINT16 FT_UINT24 FT_UINT32 FT_UINT64 FT_INT8 FT_INT16 FT_INT24 FT_INT32 FT_INT64 FT_FLOAT FT_DOUBLE svn path=/trunk/; revision=39288
2011-10-05Use ENC_NA as encoding for proto_tree_add_item() calls which directly ↵Bill Meier1-1/+1
reference an hf item with types in hf[] of: FT_NONE FT_BYTES FT_IPV6 FT_IPXNET FT_OID svn path=/trunk/; revision=39261
2011-09-02Add a link to protocol specification.Bill Meier1-0/+2
svn path=/trunk/; revision=38866
2011-09-02Increase MAX_BITMAP_SIZE from 200 to 256.Bill Meier1-1/+1
See: Bug 6276: https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=6276 Verified in the Spec: The Real-time Publish-Subscribe Wire Protocol DDS Interoperability Wire Protocol Specification Version 2.1 svn path=/trunk/; revision=38865
2011-07-18Fix gcc 4.6 "set but not used [-Wunused-but-set-variable]" warnings.Bill Meier1-16/+13
svn path=/trunk/; revision=38095
2011-05-17Add items to subtree rather than tree: Coverity 1026;Bill Meier1-18/+17
Don't assign to an unused variable: Coverity 1027; #include <stdlib.h> not req'd. svn path=/trunk/; revision=37225
2011-03-23Fix bugs: 'if ((flags & 0x2) == 1)' ==> 'if ((flags & 0x2) != 0)'Bill Meier1-24/+24
Coverity 346 & 347 svn path=/trunk/; revision=36292
2011-01-30Fix various instances of "unreachable code".Bill Meier1-1/+1
svn path=/trunk/; revision=35713
2010-04-15From Clark Tucker:Anders Broman1-9/+43
RTPS2 dissector update. https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=4672 svn path=/trunk/; revision=32473
2010-04-03Remove unneeded #include <stdio.h>Bill Meier1-1/+0
svn path=/trunk/; revision=32367
2010-04-03(Trivial): indentation & whitespace cleanup.Bill Meier1-7/+7
svn path=/trunk/; revision=32366
2010-01-25From Didier Gautheron via bug 4419:Stig Bjørlykke1-16/+0
se_alloc and ep_alloc never return NULL and se_alloc0 already initialized data with 0. svn path=/trunk/; revision=31654
2010-01-22Fixes for gcc -Wshadow warnings; Fix indentation and do other minor cleanup ↵Bill Meier1-31/+31
in a few cases. svn path=/trunk/; revision=31617
2009-11-19From Fabrizio Bertocci:Jaap Keuter1-53/+379
I'm submitting an updated version of the RTPS & RTPS2 packet dissector. While the RTPS packet dissector doesn't have too many changes (except for few comments perhaps), the RTPS 2 packet dissector includes now dissecting of the latest addition to the RTPS protocol (batched data, sessions, sparse data types). svn path=/trunk/; revision=31026
2009-09-20Use ep_alloc() instead of g_malloc() for packet scoped allocationsKovarththanan Rajaratnam1-2/+1
svn path=/trunk/; revision=29998
2009-09-20Use tvb_get_ephemeral_string() to avoid memleak.Kovarththanan Rajaratnam1-1043/+1034
svn path=/trunk/; revision=29996
2009-08-09Don't guard col_clear with col_checkKovarththanan Rajaratnam1-3/+1
svn path=/trunk/; revision=29346
2009-08-09Don't guard col_set_str (COL_INFO/COL_PROTOCOL) with col_checkKovarththanan Rajaratnam1-3/+1
svn path=/trunk/; revision=29345
2009-06-18From Kovarththanan Rajaratnam via bug 3548:Stig Bjørlykke1-12/+9
(1) Trailing/leading spaces are removed from 'name's/'blurb's (2) Duplicate 'blurb's are replaced with NULL (3) Empty ("") 'blurb's are replaced with NULL (4) BASE_NONE, NULL, 0x0 are used for 'display', 'strings' and 'bitmask' fields for FT_NONE, FT_BYTES, FT_IPv4, FT_IPv6, FT_ABSOLUTE_TIME, FT_RELATIVE_TIME, FT_PROTOCOL, FT_STRING and FT_STRINGZ field types (5) Only allow non-zero value for 'display' if 'bitmask' is non-zero svn path=/trunk/; revision=28770
2009-04-08More ethereal --> wiresharkBill Meier1-1/+1
svn path=/trunk/; revision=27994
2009-04-06The last of the size_t fixes in epan/dissectors.Gerald Combs1-24/+21
svn path=/trunk/; revision=27980
2009-03-29Define certain fcns as static (if not used externally).Bill Meier1-2/+2
Also: whiule we're at it: - fix hf[] blurbs as appropriate to use NULL; - fix some indentation svn path=/trunk/; revision=27890
2009-03-13From Jakub Zawadzki (bug 3331):Stig Bjørlykke1-3/+2
g_free() is NULL safe, so we don't need check against it. svn path=/trunk/; revision=27718
2009-02-06#include <conversation.h> not req'd ....Bill Meier1-1/+0
svn path=/trunk/; revision=27389
2009-01-28Minor changes mostly related to proto_register & proto_reg_handoff;Bill Meier1-17/+1
- Use 'dissector standard template format' - Remove 'once-only' ["if (!initialized) ..."] if not req'd - Misc Also: adjust some indentation svn path=/trunk/; revision=27324
2008-12-20Fix various typos and spelling errors (mostly in text strings)Bill Meier1-20/+20
svn path=/trunk/; revision=27065
2008-12-17Fix some typos and spelling (mostly in text strings)Bill Meier1-1/+1
svn path=/trunk/; revision=27037
2008-10-31Fix some "format not a string literal and no format arguments" warnings.Stig Bjørlykke1-1/+1
svn path=/trunk/; revision=26649
2008-10-31Fix some "format not a string literal and no format arguments" warnings.Stig Bjørlykke1-5/+5
svn path=/trunk/; revision=26648
2008-08-13Removed a C++ style comment.Stig Bjørlykke1-1/+1
svn path=/trunk/; revision=26004
2008-08-13PRI[duox]64 isn't being defined on all platforms, breaking the build,Guy Harris1-5/+5
and we don't want to use it in any case, as PRI[duox]64 might be different from G_GUINT64_MODIFIER followed by [duox], and the latter is what GLib's formatter supports, and that's the formatter we use. svn path=/trunk/; revision=25996
2008-08-13Fix:Anders Broman1-3/+3
packet-rtps.c:1462: warning: unused parameter 'label' packet-rtps.c:2767: warning: unused parameter 'label' packet-rtps2.c:1687: warning: unused parameter 'label' packet-rtps2.c:3049: warning: unused parameter 'label' packet-rtps2.c:3147: warning: unused parameter 'label' svn path=/trunk/; revision=25995
generated by cgit v1.2.3 (git 2.25.1) at 2024-10-05 05:26:28 +0000