aboutsummaryrefslogtreecommitdiffstats
path: root/epan/dissectors/packet-rtps.c
AgeCommit message (Collapse)AuthorFilesLines
2019-08-02rtps: Fix Dead Store (Dead assignement/Dead increment) Warning found by ClangAlexis La Goutte1-1/+1
Change-Id: I88f159f7823026cff82892a59d72a017777fcbab Reviewed-on: https://code.wireshark.org/review/34160 Petri-Dish: Alexis La Goutte <alexis.lagoutte@gmail.com> Tested-by: Petri Dish Buildbot Reviewed-by: Ismael Mendez <ismael@rti.com> Reviewed-by: Anders Broman <a.broman58@gmail.com>
2019-08-01RTPS: Filter added for detecting starts and end of coherent setsIsmael Mendez Matamoros1-25/+235
Starts and end of coherents ssets can be filtered now. Also those packets show the coherent end start or end sequence number. Change-Id: I7f9579f8d935b1f4a7f924bb3030fe6fc646ae5a Reviewed-on: https://code.wireshark.org/review/33840 Petri-Dish: Alexis La Goutte <alexis.lagoutte@gmail.com> Tested-by: Petri Dish Buildbot Reviewed-by: Alexis La Goutte <alexis.lagoutte@gmail.com>
2019-07-01RTPS: Topic Information feature not working with RTI Connext DDS 6ismaelrti1-38/+6
Default QoS is not sent anymore.Topic Information feature expects the Reliability, Durability and Ownership fields in the discovery Data(w) packet, so it will never be shown in Connext > 6.0.0. Since there is a link to the Data(w) packet, there is no need to show Reliability, Durability and Ownership. Change-Id: Ie23395916e5dc6ea8e13e4de502f0eb811d63814 Reviewed-on: https://code.wireshark.org/review/33727 Petri-Dish: Alexis La Goutte <alexis.lagoutte@gmail.com> Tested-by: Petri Dish Buildbot Reviewed-by: Anders Broman <a.broman58@gmail.com>
2019-06-28RTPS: Decompress ZLIB compressed serialized Type Objectismaelrti1-10/+65
Type Object parameter can be sent compressed using zlib to save bandwidth. This data can be decompressed and dissected as an usual Type Object. Change-Id: Id226b01daff225bb8e21aea765dcc5f7a0165bb7 Reviewed-on: https://code.wireshark.org/review/33738 Petri-Dish: Anders Broman <a.broman58@gmail.com> Tested-by: Petri Dish Buildbot Reviewed-by: Anders Broman <a.broman58@gmail.com>
2019-06-25RTPS: Micro release and revision versions swappedismaelrti1-6/+27
In Connext DDS Micro versions lower than 3.0.0 revison version is placed before release version in the packet. From 3.0.0 release version is followed by revision version. Bug: 15868 Change-Id: I6c0db7b687e1d452737b4545cf5f0605b527f603 Reviewed-on: https://code.wireshark.org/review/33692 Petri-Dish: Alexis La Goutte <alexis.lagoutte@gmail.com> Tested-by: Petri Dish Buildbot Reviewed-by: Alexis La Goutte <alexis.lagoutte@gmail.com>
2019-04-10rtps: fix conflict on value_stringAlexis La Goutte1-1/+0
Field 'parameterId' (rtps.param.id) has a conflicting entry in its value_string: 15 is at indices 67 (PID_DOMAIN_ID) and 74 (PID_IS_RELIABLE [deprecated]) Change-Id: I34081c099da808d85236d9e255d6fe256fdf9cf7 Reviewed-on: https://code.wireshark.org/review/31632 Petri-Dish: Alexis La Goutte <alexis.lagoutte@gmail.com> Tested-by: Petri Dish Buildbot Reviewed-by: Anders Broman <a.broman58@gmail.com>
2019-04-04epan: Convert our PROTO_ITEM_ macros to inline functions.Gerald Combs1-12/+12
Convert our various PROTO_ITEM_ macros to inline functions and document them. Change-Id: I070b15d4f70d2189217a177ee8ba2740be36327c Reviewed-on: https://code.wireshark.org/review/32706 Reviewed-by: Gerald Combs <gerald@wireshark.org> Petri-Dish: Gerald Combs <gerald@wireshark.org> Reviewed-by: Anders Broman <a.broman58@gmail.com>
2019-03-18rtps: fix ipv4 address prints.Dario Lombardo1-3/+2
Change-Id: I6f21e800e5e35e109dda4d6dca25f3a85fe02cb1 Reviewed-on: https://code.wireshark.org/review/32443 Reviewed-by: Dario Lombardo <lomato@gmail.com> Petri-Dish: Dario Lombardo <lomato@gmail.com> Tested-by: Petri Dish Buildbot Reviewed-by: João Valverde <j@v6e.pt>
2019-03-15rtps: fix format in val_to_str().Dario Lombardo1-1/+1
Add a more explanatory message as well. Bug: 15606 Change-Id: Ia462113e108c9e3fa0cbb0f0a8fb33a6ec3a0673 Reviewed-on: https://code.wireshark.org/review/32419 Petri-Dish: Dario Lombardo <lomato@gmail.com> Tested-by: Petri Dish Buildbot Reviewed-by: Anders Broman <a.broman58@gmail.com>
2019-03-13RTPS: Support for Data Representation QoS policy and XCDRv2ismaelrti1-4/+69
New Data Representation tasgs added for XCDR2 to encapsulation kind. Added new field Type Consistency Enforcement QoS Policy dissection Change-Id: I15280fd1642d78533b304c22b614549ba8775e56 Reviewed-on: https://code.wireshark.org/review/32392 Reviewed-by: Juan Jose Martin Carrascosa <juanjo@rti.com> Petri-Dish: Anders Broman <a.broman58@gmail.com> Tested-by: Petri Dish Buildbot Reviewed-by: Anders Broman <a.broman58@gmail.com>
2019-01-17RTPS: Possible buffer overrun fixed in PID_TYPEOBJECT_LB dissection.ismaelrti1-13/+11
In PID_TYPEOBJECT_LB dissection class_id_enum_names char* array has been replaced by a string_values so it won't cause any issue if the read index value is out of bounds. Bug: 15405 Change-Id: I0dc9d8d00024a2fbb03fca7238ab709b91b059aa Reviewed-on: https://code.wireshark.org/review/31484 Petri-Dish: João Valverde <j@v6e.pt> Tested-by: Petri Dish Buildbot Reviewed-by: Gerald Combs <gerald@wireshark.org> Reviewed-by: Anders Broman <a.broman58@gmail.com>
2018-12-27Try to squeeze some bytes out of the frame_data structure.Guy Harris1-1/+1
Make the time stamp precision a 4-bit bitfield, so, when combined with the other bitfields, we have 32 bits. That means we put the flags at the same structure level as the time stamp precision, so they can be combined; that gets rid of an extra "flags." for references to the flags. Put the two pointers next to each other, and after a multiple of 8 bytes worth of other fields, so that there's no padding before or between them. It's still not down to 64 bytes, which is the next lower power of 2, so there's more work to do. Change-Id: I6f3e9d9f6f48137bbee8f100c152d2c42adb8fbe Reviewed-on: https://code.wireshark.org/review/31213 Petri-Dish: Guy Harris <guy@alum.mit.edu> Tested-by: Petri Dish Buildbot Reviewed-by: Guy Harris <guy@alum.mit.edu>
2018-12-04RTPS: Added dissection of Support Type Object LBismaelrti1-2/+51
Added dissection of Support Type Object LB type. Change-Id: I7e654faed4874a87865f1d94a372eb8f00dde412 Reviewed-on: https://code.wireshark.org/review/30903 Petri-Dish: Anders Broman <a.broman58@gmail.com> Tested-by: Petri Dish Buildbot Reviewed-by: Anders Broman <a.broman58@gmail.com>
2018-12-03RTPS: Acknack analysis hidden when dissecting GAP field.ismaelrti1-7/+8
GAP field dissection shows an acknack analysis. This analysis doesn't make any sense in the GAP field. Change-Id: I9c4cca2b722390112b6a350bd2310b48874e5c9d Reviewed-on: https://code.wireshark.org/review/30897 Petri-Dish: Anders Broman <a.broman58@gmail.com> Tested-by: Petri Dish Buildbot Reviewed-by: Anders Broman <a.broman58@gmail.com>
2018-11-23RTPS: Extra fields dissected in RTI DDS field PID_TYPE_CONSISTENCY.ismaelrti1-3/+81
In RTI Connext DDS 5.3.3 and later PID_TYPE_CONSISTENCY has six new fields: Ignore Sequence Bounds, Ignore String Bounds, Ignore Member Names, Prevent Type Widening, Force Type Validation, Ignore Enum Literal Names. Change-Id: I456097a3baf733351dcb86f2cba0a3f03d2fc100 Reviewed-on: https://code.wireshark.org/review/30753 Petri-Dish: Anders Broman <a.broman58@gmail.com> Tested-by: Petri Dish Buildbot Reviewed-by: Anders Broman <a.broman58@gmail.com>
2018-11-23RTPS: Topic Information Feature used with APP_ACK and APP_ACK_CONFismaelrti1-9/+16
packets. Topic Information Feature used to link packets belonging to the same topic now is used in APP_ACK and APP_ACK_CONF packets. Change-Id: Ib4e1dd4dfed41962bc76e8600a1213247a3bf588 Reviewed-on: https://code.wireshark.org/review/30752 Petri-Dish: Anders Broman <a.broman58@gmail.com> Tested-by: Petri Dish Buildbot Reviewed-by: Anders Broman <a.broman58@gmail.com>
2018-11-16RTPS: RTPS 2.3 Domain ID and Domain Tag support.ismaelrti1-2/+34
Added dissection of field PID_DOMAIN_TAG. PID_DOMAIN_ID moved to PID_RTI_DOMAIN_ID and PID_IS_RELIABLE moved to PID_DOMAIN_ID. Change-Id: Ie189b2d2e66b705df202e7ee3e752aea5ddee271 Reviewed-on: https://code.wireshark.org/review/30664 Petri-Dish: Peter Wu <peter@lekensteyn.nl> Tested-by: Petri Dish Buildbot Reviewed-by: Peter Wu <peter@lekensteyn.nl>
2018-11-13RTPS: APP_ACK_CONF submessage dissection fixed.ismaelrti1-1/+1
Count field of APP_ACK_CONF submessage was dissected using a signed integer rather than unsigned. That avoids the dissection to be concluded due to a wrong type error. Change-Id: Ie5f85ce5b3d745d74e1b50d96a77560fb854034b Reviewed-on: https://code.wireshark.org/review/30605 Petri-Dish: Anders Broman <a.broman58@gmail.com> Tested-by: Petri Dish Buildbot Reviewed-by: Anders Broman <a.broman58@gmail.com>
2018-10-31RTPS: fixed issues in the reassembly logic of DATA_FRAGJuanjo Martin1-28/+43
When a DATA_FRAG contains more than one fragment, the logic does not work. This has been fixed. Bug: 15249 Change-Id: I6a4291abee436114c6d57700dbe908af13fbb166 Reviewed-on: https://code.wireshark.org/review/30435 Petri-Dish: Anders Broman <a.broman58@gmail.com> Tested-by: Petri Dish Buildbot Reviewed-by: Anders Broman <a.broman58@gmail.com>
2018-10-25RTPS: Added Endpoint Discovery reassemblyJuanjo Martin1-3/+5
Added reassembly of the Endpoint Discovery Data and added the writer id to the fragment_add_check() function as the data to be used to identify fragments belonging to the same packet. Also changed the order of the modification of the INFO column for Discovery fragments (first add status, then the [Reassembled] tag). Change-Id: I1e830a07cecbfffe8a8fa9514e54d2e0aefb59c1 Reviewed-on: https://code.wireshark.org/review/30379 Petri-Dish: Anders Broman <a.broman58@gmail.com> Tested-by: Petri Dish Buildbot Reviewed-by: Anders Broman <a.broman58@gmail.com>
2018-10-25RTPS: Added RTPS reassembly for DATA_FRAGsJuanjo Martin1-9/+134
The RTPS dissector now reassembles and shows the full sample when it has been fragmented into several DATA_FRAG submessages. There is a boolean preference to enable this feature (disabled by default due to the potential memory consumption it can cause). Change-Id: I394c042acdd54953ad6a082b385a5b94c9097cd5 Bug: 15227 Reviewed-on: https://code.wireshark.org/review/30297 Petri-Dish: Peter Wu <peter@lekensteyn.nl> Tested-by: Petri Dish Buildbot Reviewed-by: Anders Broman <a.broman58@gmail.com>
2018-10-19Adding vendor id 0x010F (eProsima Fast-RTPS) to RTPS dissectorMiguel Company1-0/+1
Change-Id: Id8ffdde5daddeb82e465bf729faf4e18f97552f6 Reviewed-on: https://code.wireshark.org/review/30244 Reviewed-by: Anders Broman <a.broman58@gmail.com> Petri-Dish: Anders Broman <a.broman58@gmail.com> Tested-by: Petri Dish Buildbot Reviewed-by: Peter Wu <peter@lekensteyn.nl>
2018-09-09RTPS: fixed large data issuesJuanjo Martin1-46/+66
Now the inline_qos has the right size, the encapsulation id is displayed only for the first fragment and fragments are dissected as raw bytes (fixing the incompatibility with Parametrized samples) Change-Id: Ib65dd017f9bfb4f23aa763438cb5ab3579f79c90 Reviewed-on: https://code.wireshark.org/review/29408 Petri-Dish: Anders Broman <a.broman58@gmail.com> Tested-by: Petri Dish Buildbot Reviewed-by: Anders Broman <a.broman58@gmail.com>
2018-06-28rtps: Fixed multichannel locator fields orderIsmael Mendez Matamoros1-1/+67
Change-Id: Ib84b659022f9dfb64f5869410c85c64193a3c3f8 Reviewed-on: https://code.wireshark.org/review/28425 Petri-Dish: Anders Broman <a.broman58@gmail.com> Tested-by: Petri Dish Buildbot Reviewed-by: Anders Broman <a.broman58@gmail.com>
2018-06-21rtps: Fixed min_length in rtps_data dissectionIsmael Mendez Matamoros1-1/+1
Change-Id: I46402f714d70466cafbe736baf570149c78c6dbf Reviewed-on: https://code.wireshark.org/review/28363 Reviewed-by: Anders Broman <a.broman58@gmail.com>
2018-06-08rtps: Added data tagsIsmael Mendez Matamoros1-1/+64
Change-Id: If75d2457e07afd245a92b05b7884fc622def0213 Reviewed-on: https://code.wireshark.org/review/28114 Reviewed-by: Juan Jose Martin Carrascosa <juanjo@rti.com> Petri-Dish: Anders Broman <a.broman58@gmail.com> Tested-by: Petri Dish Buildbot Reviewed-by: Anders Broman <a.broman58@gmail.com>
2018-05-16rtps: fix issue found by PVS Studio (V1001)Alexis La Goutte1-4/+1
The 'offset' variable is assigned but is not used until the end of the function Change-Id: I699c8ea4c6533b9834aefbd12b920b04876773ee Reviewed-on: https://code.wireshark.org/review/27504 Reviewed-by: Peter Wu <peter@lekensteyn.nl> Petri-Dish: Peter Wu <peter@lekensteyn.nl> Tested-by: Petri Dish Buildbot Reviewed-by: Anders Broman <a.broman58@gmail.com>
2018-03-07dissectors: more SPDX license convertions.Dario Lombardo1-13/+1
Change-Id: I96e1f1cdbaaf49d65705ecacc903f73cf0e47d7c Reviewed-on: https://code.wireshark.org/review/26334 Petri-Dish: Dario Lombardo <lomato@gmail.com> Tested-by: Petri Dish Buildbot Reviewed-by: Jaap Keuter <jaap.keuter@xs4all.nl>
2018-02-13WMEM: Add strjoin routines.Craig Jackson1-14/+6
Add wmem versions corresponding to g_strjoin() and g_strjoinv(). Modify packet-rtps.c to use wmem routines_ where it is now using g_ routines causing mallocs. Change-Id: I92c890a8b8f29a973e103676d8e5a681ee5abd50 Reviewed-on: https://code.wireshark.org/review/25764 Reviewed-by: Anders Broman <a.broman58@gmail.com>
2017-12-28rtps: remove unused ei entry.Dario Lombardo1-3/+1
Change-Id: I3bb1470e6c5225a431bc49de9e6032e2016a1824 Reviewed-on: https://code.wireshark.org/review/25020 Petri-Dish: Dario Lombardo <lomato@gmail.com> Tested-by: Petri Dish Buildbot Reviewed-by: Michael Mann <mmann78@netscape.net>
2017-12-28rtps: remove unneeded check (CID: 1158869).Dario Lombardo1-1/+1
Change-Id: Ib9b2902c56fb569366e62a1d85b173862d29e61f Reviewed-on: https://code.wireshark.org/review/25019 Petri-Dish: Dario Lombardo <lomato@gmail.com> Tested-by: Petri Dish Buildbot Reviewed-by: Anders Broman <a.broman58@gmail.com>
2017-12-04RTPS: Added new PIDs to SecurityJuanjo Martin1-4/+218
Change-Id: I91ffb48ac5435d4eb45b60f8083762b2151de2c3 Reviewed-on: https://code.wireshark.org/review/24671 Petri-Dish: Anders Broman <a.broman58@gmail.com> Tested-by: Petri Dish Buildbot Reviewed-by: Anders Broman <a.broman58@gmail.com>
2017-12-01RTPS: Fixed a quick typo in a hf itemJuanjo Martin1-1/+1
Change-Id: I71315900a4fd5130ab051854bc70dbc4ba9afc2b Reviewed-on: https://code.wireshark.org/review/24672 Reviewed-by: Anders Broman <a.broman58@gmail.com>
2017-11-30RTPS: Added link to the DCPSPublicationData frame numberJuanjo Martin1-7/+18
Added a link inside the Topic Information feature so users can quickly go to the discovery data associated with the writer sending this submessage. Change-Id: I3a89630a275e5d857e8bbf86dc5171c9f0921d5b Reviewed-on: https://code.wireshark.org/review/24646 Petri-Dish: Anders Broman <a.broman58@gmail.com> Tested-by: Petri Dish Buildbot Reviewed-by: Michael Mann <mmann78@netscape.net>
2017-11-30RTPS: Added new endpoints for the Security specJuanjo Martin1-30/+39
Change-Id: Ia827c43b161a2b64804b0eac220b428eb853d255 Reviewed-on: https://code.wireshark.org/review/24647 Petri-Dish: Anders Broman <a.broman58@gmail.com> Tested-by: Petri Dish Buildbot Reviewed-by: Michael Mann <mmann78@netscape.net>
2017-11-29RTPS: Added DataWriter QoS to topic information featureJuanjo Martin1-6/+50
Change-Id: Ib8d9c4f75543ed05c1bf69589069ed2425e3394e Reviewed-on: https://code.wireshark.org/review/24555 Petri-Dish: Anders Broman <a.broman58@gmail.com> Tested-by: Petri Dish Buildbot Reviewed-by: Anders Broman <a.broman58@gmail.com>
2017-11-29RTPS: Added locator and product version to Micro DDSJuanjo Martin1-17/+28
Change-Id: Icfb1c505865f5a32152cc056173baae8f7d01f36 Reviewed-on: https://code.wireshark.org/review/24603 Petri-Dish: Anders Broman <a.broman58@gmail.com> Tested-by: Petri Dish Buildbot Reviewed-by: Anders Broman <a.broman58@gmail.com>
2017-11-23RTPS: Topic Information feature now available for all the submessagesJuanjo Martin1-56/+107
Before, the topic information feature showed the topic information only for DATA submessages. Now it is working for all the submessages. Change-Id: Ic2fe0ac1de2377a1db627f6498ac6d5159c9cb13 Reviewed-on: https://code.wireshark.org/review/24442 Petri-Dish: Anders Broman <a.broman58@gmail.com> Tested-by: Petri Dish Buildbot Reviewed-by: Michael Mann <mmann78@netscape.net>
2017-07-28RTPS: Added Secure DDS PID parameter + small fix for endiannessJuanjo Martin1-7/+40
Change-Id: I8d9c53cee9c7eff0f46c61c63bc3a46859ad7577 Reviewed-on: https://code.wireshark.org/review/22832 Petri-Dish: Pascal Quantin <pascal.quantin@gmail.com> Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org> Reviewed-by: Pascal Quantin <pascal.quantin@gmail.com>
2017-07-28RTPS: Fixed Secure DDS minor detailsJuanjo Martin1-22/+110
Change-Id: I896764009887fedddbd41183f9b0d292119939d1 Reviewed-on: https://code.wireshark.org/review/22804 Petri-Dish: Alexis La Goutte <alexis.lagoutte@gmail.com> Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org> Reviewed-by: Anders Broman <a.broman58@gmail.com>
2017-06-17Expose RTPS dissector for Lua.Michael Mann1-0/+13
See https://ask.wireshark.org/questions/61824/how-to-get-a-reference-to-an-existing-heuristic-dissector-in-lua-in-order-to-wrap-rtps Change-Id: I926b974da8e2de35c64cc46cba7b38e71368fcdd Reviewed-on: https://code.wireshark.org/review/22137 Reviewed-by: Michael Mann <mmann78@netscape.net>
2017-04-04RTPS: fix no previous prototype for function 'rtps_util_add_timestamp' ↵Alexis La Goutte1-1/+1
[-Wmissing-prototypes] Change-Id: I2757f6442b9f3d37897225a90dd6d848e4a9c373 Reviewed-on: https://code.wireshark.org/review/20889 Petri-Dish: Alexis La Goutte <alexis.lagoutte@gmail.com> Reviewed-by: Michael Mann <mmann78@netscape.net>
2017-03-26Don't speak of RTPS time_t as an "NTP" time.Guy Harris1-46/+51
It's some weird hybrid of UN*X time and NTP time stamps, using UN*X's epoch and NTP's seconds/fractions split. I'm sure they had their reasons for not using something like struct timespec or regular NTP time, and instead inventing something that's halfway in between them. Change-Id: I1f39ec1368af52b82adfa2a22677dfa6e9341309 Reviewed-on: https://code.wireshark.org/review/20711 Reviewed-by: Guy Harris <guy@alum.mit.edu>
2017-01-28wmem_map_new -> wmem_map_new_autoresetMichael Mann1-8/+2
A few dissectors can benefit from the conversion. Change-Id: I3b7d54926b79314009e271960aff61870a115390 Reviewed-on: https://code.wireshark.org/review/19826 Reviewed-by: Michael Mann <mmann78@netscape.net>
2017-01-28Updated parsing of ParticipantMessageData submessages.Adam Mitz1-12/+8
Zero-length octet sequences don't need to show <MISSING> for their contents. Change-Id: I89662ff8cd29563981ba9e1b34dc82023b6a070e Reviewed-on: https://code.wireshark.org/review/19755 Reviewed-by: Juan Jose Martin Carrascosa <juanjo@rti.com> Reviewed-by: Anders Broman <a.broman58@gmail.com>
2017-01-24RTPS: avoid errors when encountering empty sequences of stringsAdam Mitz1-5/+12
Change-Id: Ida9d2e6d632104ec3c6594f5ec500fec49a971a4 Reviewed-on: https://code.wireshark.org/review/19754 Reviewed-by: Michael Mann <mmann78@netscape.net> Petri-Dish: Michael Mann <mmann78@netscape.net> Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org> Reviewed-by: Anders Broman <a.broman58@gmail.com>
2017-01-24RTPS: updated ContentFilterProperty field names to match the specAdam Mitz1-23/+23
Change-Id: I17a8b51dbcb502624a83177135b31fdbe72fa118 Reviewed-on: https://code.wireshark.org/review/19753 Reviewed-by: Michael Mann <mmann78@netscape.net> Reviewed-by: Anders Broman <a.broman58@gmail.com>
2017-01-04RTPS: Added dissection for Parametrized user dataJuanjo Martin1-1/+78
Before we were showing an expert warning saying that it was not supported. Now we show the parametrized data dissected in the form sequence of (id, length, value) Added also filters so it is possible to filter on the ids (useful in RTPS) Bug: 13278 Change-Id: I8569830305bc303febe6f3460221e7a52867a34d Reviewed-on: https://code.wireshark.org/review/19458 Petri-Dish: Alexis La Goutte <alexis.lagoutte@gmail.com> Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org> Reviewed-by: Anders Broman <a.broman58@gmail.com>
2016-12-13Adjust proto_tree_add_uint_format_value calls to use unit stringMichael Mann1-11/+11
Several calls to proto_tree_add_uint_format_value could be better served using BASE_UNIT_STRING with a "unit string" in hf_ field. There also a few cases where proto_tree_add_uint_format_value could just be proto_tree_add_uint. Added a few more "common" unit string values to unit_strings.[ch] Change-Id: Iaedff82c515269c9c31ab9100dff19f5563c932d Reviewed-on: https://code.wireshark.org/review/19242 Petri-Dish: Michael Mann <mmann78@netscape.net> Reviewed-by: Michael Mann <mmann78@netscape.net>
2016-12-05RTPS: Cleanup endian handlingMichael Mann1-730/+602
1. Rather than pass a boolean that has to be continually evaluated, just pass the necessary encoding (ENC_LITTLE_ENDIAN or ENC_BIG_ENDIAN) 2. Incorporate more use of proto_tree_add_item_ret_[u]int 3. Remove NEXT_guint16 and NEXT_guint32 because we now have tvb_get_guint16 and tvb_get_guint32 Change-Id: Ib1c3488450b4e727d2c1943ba4e577faf2350dcc Reviewed-on: https://code.wireshark.org/review/19103 Petri-Dish: Michael Mann <mmann78@netscape.net> Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org> Reviewed-by: Anders Broman <a.broman58@gmail.com>
generated by cgit v1.2.3 (git 2.25.1) at 2024-09-23 09:17:43 +0000