aboutsummaryrefslogtreecommitdiffstats
path: root/epan/dissectors/packet-rtmpt.c
AgeCommit message (Collapse)AuthorFilesLines
2013-07-15Fix warning: ISO C does not allow extra ';' outside of a function.Chris Maynard1-2/+2
svn path=/trunk/; revision=50638
2013-06-14Remove check_col() and the occasional tree.Michael Mann1-17/+14
svn path=/trunk/; revision=49921
2013-05-21Use col_set_fence() functionality to remove an unnecessary global variable.Michael Mann1-12/+10
svn path=/trunk/; revision=49472
2013-05-16Make the rtmpt max packet size that Jeff just halved a preference, so thatEvan Huus1-13/+17
people who really want it can set it higher again. svn path=/trunk/; revision=49322
2013-05-16Temporarily lower the max packet size for this dissector in order to silenceJeff Morriss1-2/+5
the fuzz bot (see https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=6898 and all of its duplicates--and the bugs marked as duplicates of those duplicates). Halving the packet size seems to work for most of the captures I've tried; we'll see if the buildbot agrees. If someone can figure out a good way to control the memory usage of this dissector then the limit could be increased again. svn path=/trunk/; revision=49321
2013-03-29Rename value string (and similar) functions to use a consistent pattern. ThisEvan Huus1-1/+1
was done using textual search+replace, not anything syntax-aware, so presumably it got most comments as well (except where there were typos). Use a consistent coding style, and make proper use of the WS_DLL_* defines. Group the functions appropriately in the header. I ended up getting rid of most of the explanatory comments since many of them duplicated what was in the value_string.c file (and were out of sync with the recent updates I made to those in r48633). Presumably most of the comments should be in the .h file not the .c file, but there's enough churn ahead that it's not worth fixing yet. Part of https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=8467 svn path=/trunk/; revision=48634
2013-03-17From beroset:Anders Broman1-16/+16
remove C++ incompatibilities https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=8416 svn path=/trunk/; revision=48356
2013-01-31Use '#if 0 ... #endif' rather than /** ... **/ to comment outBill Meier1-4/+4
unused hf[] entries (which I should have done in the first place). svn path=/trunk/; revision=47390
2013-01-26Comment out cases of unused hf array entries found by checkhf.Bill Meier1-3/+7
svn path=/trunk/; revision=47302
2012-11-18Fix some blurbs that matched the field tag.Guy Harris1-194/+194
De-RTMP-ize more AMF-related names and move more of the AMF stuff together. svn path=/trunk/; revision=46069
2012-11-18Move all the AMF stuff under the AMF protocol, as AMF, while it's usedGuy Harris1-241/+236
with RTMP, can be sent over HTTP, for example, as well. svn path=/trunk/; revision=46068
2012-11-17There's no point in initializing variables to 0 when we unconditionally assignEvan Huus1-2/+2
a new value to them on the very next line. Caught by cppcheck. svn path=/trunk/; revision=46058
2012-11-16Add casts to let the compiler know that we know what we're doing here.Guy Harris1-4/+4
svn path=/trunk/; revision=46049
2012-11-16Thank you, llvm-gcc, for eliminating much of the dataflow analysis thatGuy Harris1-1/+1
regular gcc does. Time to start using clang, I guess.... svn path=/trunk/; revision=46048
2012-11-16Add support for dissecting AMF messages; register the dissector for themGuy Harris1-300/+1037
as handling the application/x-amf media type. Add support for dissecting AMF3. Dissect AMF0 dates as milliseconds-since-the-Epoch. Dissect AMF0 typed objects. Add URLs for various Adobe specs for RTMP, AMF0 and AMF3. svn path=/trunk/; revision=46047
2012-10-29From report of Sergio Garcia Murillo via ↵Alexis La Goutte1-3/+6
https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=7906 Nelly Mosser (Control: 0x66) at 11Khz incorrectly displayed as 8Khz From me Fix issue and add link to SWF documentation ( http://www.adobe.com/content/dam/Adobe/en/devnet/swf/pdf/swf_file_format_spec_v10.pdf ) svn path=/trunk/; revision=45827
2012-09-20We always HAVE_CONFIG_H so don't bother checking whether we have it or not.Jeff Morriss1-3/+1
svn path=/trunk/; revision=45017
2012-06-28Update Free Software Foundation address.Jakub Zawadzki1-1/+1
(COPYING will be updated in next commit) svn path=/trunk/; revision=43536
2012-06-04Fix some Dead Store (Dead assignement/Dead increment) Warning found by ClangAlexis La Goutte1-1/+0
svn path=/trunk/; revision=43091
2012-05-10Get rid of remaining Booleans-as-encoding-arguments inGuy Harris1-2/+13
proto_tree_add_item() calls. svn path=/trunk/; revision=42542
2012-04-12Give some URLs for descriptions of RTMP.Guy Harris1-1/+12
svn path=/trunk/; revision=42039
2012-03-16FT_BOOLEAN hf[] entries with a 0 'bitmask' should have 'display' = BASE_NONE;Bill Meier1-26/+27
In some cases: Use val_to_str_const() instead of val_to_str(); Reformat long lines; Do some general whitespace changes. svn path=/trunk/; revision=41587
2012-01-23Fix some duplicate display filter names.Chris Maynard1-2/+2
svn path=/trunk/; revision=40669
2012-01-16The frame number is an unsigned integer, so there's no guarantee that itGuy Harris1-3/+3
won't equal (guint32)-1. Fortunately, frame numbers are 1-based, so there *is* a guarantee that it won't equal 0. svn path=/trunk/; revision=40544
2011-12-15Conform indentation to that specified by the modeline; Reformat long lines.Bill Meier1-723/+789
svn path=/trunk/; revision=40212
2011-12-15Fix some tvb memory leaks; Fix a typo.Bill Meier1-4/+4
svn path=/trunk/; revision=40211
2011-10-21For proto_tree_add_item(..., proto_xxx, ...)use ENC_NA as the encoding arg.Bill Meier1-1/+1
Also: remove trailing whitespace for a number of files. svn path=/trunk/; revision=39503
2011-10-15Convert proto_tree_add_item() 'encoding' arg for field types FT_STRING, ↵Bill Meier1-1/+1
FT_STRINGZ, FT_UINT_STRING as follows: 1. If there's no character encoding (ENC_ASCII, ...) specified then use ENC_ASCII. 2. For all but FT_UINT_STRING, always use ENC_NA (replacing any existing True/1/FALSE/0 /ENC_BIG_ENDIAN/ENC_LITTLE_ENDIAN). svn path=/trunk/; revision=39426
2011-10-06Convert 'encoding' parameter of certain proto_tree_add_item() calls in ↵Bill Meier1-27/+27
non-autogenerated epan/dissectors: Specifically: Replace FALSE|0 and TRUE|1 by ENC_BIG_ENDIAN|ENC_LITTLE_ENDIAN as the encoding parameter for proto_tree_add_item() calls which directly reference an item in hf[] which has a type of: FT_UINT8 FT_UINT16 FT_UINT24 FT_UINT32 FT_UINT64 FT_INT8 FT_INT16 FT_INT24 FT_INT32 FT_INT64 FT_FLOAT FT_DOUBLE svn path=/trunk/; revision=39288
2011-10-04Use ENC_NA as encoding for proto_tree_add_item() calls which directly ↵Bill Meier1-8/+8
reference an hf item (in hf[] with types: FT_NONE FT_BYTES FT_IPV6 FT_IPXNET FT_OID Note: Encoding field set to ENC_NA only if the field was previously TRUE|FALSE|ENC_LITTLE_ENDIAN|ENC_BIG_ENDIAN svn path=/trunk/; revision=39260
2011-09-21Fix vi "modeline" so it works;Bill Meier1-1/+1
See https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=5748 svn path=/trunk/; revision=39074
2011-07-18Fix gcc 4.6 "set but not used [-Wunused-but-set-variable]" warnings.Bill Meier1-6/+0
svn path=/trunk/; revision=38095
2011-05-20Don't assign to a proto_item* if the value won't be used:Bill Meier1-5/+4
Fixes Coverity 903,935,968,985,997,999,1024,1025,1134; Remove unneeded #includes; Do whitespace cleanup. svn path=/trunk/; revision=37331
2011-02-25From Herbert Oppmann: Fix "RTMP dissector unknown audio codec"Bill Meier1-5/+12
" The [...] variable rtmpt_audio_codecs should be enhanced. According to [Flash Developer's Guide] 10 = HE-AAC and 11 = Speex are missing. There is also [Adobe "RTMP Specification V1.0] which additionally lists 3 = INTEL (not used), 7 = G711A, 8 = G711U and 9 = NellyMoser 16kHz. " From me: All but 'Intel (not used)' added to the list of audio codecs svn path=/trunk/; revision=36073
2010-12-20Rename the routines that handle dissector tables with unsigned integerGuy Harris1-2/+2
keys to have _uint in their names, to match the routines that handle dissector tables with string keys. (Using _port can confuse people into thinking they're intended solely for use with TCP/UDP/etc. ports when, in fact, they work better for things such as Ethernet types, where the binding of particular values to particular protocols are a lot stronger.) svn path=/trunk/; revision=35224
2010-10-30From John Sullivan:Jaap Keuter1-604/+1863
Improve RTMP dissection: * Handle multi-byte csids * Handle extended timestamps * Better timestamp defaulting/calculations * Dechunking should now cope with any clean high quality capture without error (still loses sync on missing/out of order packets, but that's very hard to deal with) * Dissect tunnelled RTMPT * Dissect more packet types * Dissect more AMF0 data types * Dissect audio/video control information * Use official packet/type names * Several new fields * Function call/response frame linking * Push several useful bits of data up the dissection tree or into the info column for ease of use svn path=/trunk/; revision=34720
2010-05-13As suggested in ↵Jeff Morriss1-14/+10
http://www.wireshark.org/lists/wireshark-dev/200809/msg00075.html (as referenced in https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=2907 ) and https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=3411 : Write a new convenience routine for finding a conversation and, if it is not found, create it. The frame number and addresses are taken from pinfo (as is the common case). Use this function in a bunch of dissectors. svn path=/trunk/; revision=32790
2010-04-06#include <string.h> not needed.Bill Meier1-2/+0
svn path=/trunk/; revision=32410
2009-11-09Conversation is unused in dissect_rtmpt_tcp().Stig Bjørlykke1-1/+2
svn path=/trunk/; revision=30905
2009-10-25From Jakub Zawadzki:Anders Broman1-16/+8
Cleanup dissector code - use proper memory functions. https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=4164 svn path=/trunk/; revision=30691
2009-08-09Don't guard col_clear with col_checkKovarththanan Rajaratnam1-2/+1
svn path=/trunk/; revision=29344
2009-08-09Don't guard col_set_str (COL_PROTOCOL) with col_checkKovarththanan Rajaratnam1-2/+2
svn path=/trunk/; revision=29340
2009-07-12Make iCommand a guint8.Anders Broman1-1/+1
svn path=/trunk/; revision=29074
2009-07-12From Nick Ford:Jaap Keuter1-212/+527
Chunks handled individually rather than as complete messages which have the risk of being fragmented and unrecognizable. Added FLV data type. Allow simultaneous RTMP streams to be handled independently. svn path=/trunk/; revision=29069
2009-07-07From Kovarththanan Rajaratnam:Stig Bjørlykke1-1/+1
More FT_XXX cleanup. svn path=/trunk/; revision=28971
2009-06-18From Kovarththanan Rajaratnam via bug 3548:Stig Bjørlykke1-2/+2
(1) Trailing/leading spaces are removed from 'name's/'blurb's (2) Duplicate 'blurb's are replaced with NULL (3) Empty ("") 'blurb's are replaced with NULL (4) BASE_NONE, NULL, 0x0 are used for 'display', 'strings' and 'bitmask' fields for FT_NONE, FT_BYTES, FT_IPv4, FT_IPv6, FT_ABSOLUTE_TIME, FT_RELATIVE_TIME, FT_PROTOCOL, FT_STRING and FT_STRINGZ field types (5) Only allow non-zero value for 'display' if 'bitmask' is non-zero svn path=/trunk/; revision=28770
2009-05-08FT_BOOLEAN fields w/o bitmasks really should use BASE_NONE (not BASE_DEC,...).Bill Meier1-1/+1
svn path=/trunk/; revision=28317
2009-03-23Removed some "initializer does not fit or is out of range" warnings.Stig Bjørlykke1-2/+2
svn path=/trunk/; revision=27826
2008-08-26#include <emem.h> not req'dBill Meier1-1/+0
svn path=/trunk/; revision=26091
2008-03-13Partial fix for bug 2153Jaap Keuter1-1/+1
AMF object ID is in the lower 6 bits of the octet svn path=/trunk/; revision=24619
generated by cgit v1.2.3 (git 2.25.1) at 2024-10-07 07:59:29 +0000