aboutsummaryrefslogtreecommitdiffstats
path: root/epan/dissectors/packet-rtcp.c
AgeCommit message (Collapse)AuthorFilesLines
2014-03-04Remove all $Id$ from top of fileAlexis La Goutte1-2/+0
(Using sed : sed -i '/^ \* \$Id\$/,+1 d') Fix manually some typo (in export_object_dicom.c and crc16-plain.c) Change-Id: I4c1ae68d1c4afeace8cb195b53c715cf9e1227a8 Reviewed-on: https://code.wireshark.org/review/497 Reviewed-by: Anders Broman <a.broman58@gmail.com>
2014-02-14Make checkAPI HappyAlexis La Goutte1-1/+1
Change-Id: I885fb33685eb0ff06a1cf97e6cd671e6b6ee2eaa Reviewed-on: https://code.wireshark.org/review/215 Reviewed-by: Alexis La Goutte <alexis.lagoutte@gmail.com> Tested-by: Alexis La Goutte <alexis.lagoutte@gmail.com>
2014-02-14New RTCP REMB dissector – Bug 9757Owen Williams1-2/+132
Change-Id: I0f455f58bdec8dc3787da96a3bfc43ac41dc48f8 Reviewed-on: https://code.wireshark.org/review/202 Reviewed-by: Alexis La Goutte <alexis.lagoutte@gmail.com> Tested-by: Alexis La Goutte <alexis.lagoutte@gmail.com>
2013-12-21Add missing includesJakub Zawadzki1-0/+1
svn path=/trunk/; revision=54332
2013-12-12- Make local functions static.Anders Broman1-1/+4
- Forward declaration of register functions. svn path=/trunk/; revision=53958
2013-11-23Create the ability to have packet scoped "proto" data. Bug 9470 ↵Michael Mann1-6/+6
(https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=9470) I'm not sold on the name or module the proto_data functions live in, but I believe the function arguments are solid and gives us the most flexibility for the future. And search/replace of a function name is easy enough to do. The big driving force for getting this in sooner rather than later is the saved memory on ethernet packets (and IP packets soon), that used to have file_scope() proto data when all it needed was packet_scope() data (technically packet_info->pool scoped), strictly for Decode As. All dissectors that use p_add_proto_data() only for Decode As functionality have been converted to using packet_scope(). All other dissectors were converted to using file_scope() which was the original scope for "proto" data. svn path=/trunk/; revision=53520
2013-11-02Require dissector_try_string to pass a data parameter to its subdissectors. ↵Michael Mann1-1/+1
There weren't that many calls, so might as well modify the function than create a need for dissector_try_string_new. svn path=/trunk/; revision=53049
2013-10-23#if 0 numerous "unused const variables" (mostly value-string-arrays);Bill Meier1-1/+1
Also; fix a few "set but not used" warnings. svn path=/trunk/; revision=52780
2013-10-13whitespace fixes; mostly: remove trailing blanksBill Meier1-4/+4
svn path=/trunk/; revision=52591
2013-09-22emem -> wmem conversion:Pascal Quantin1-3/+3
- ep_tvb_get_bits() -> wmem_packet_tvb_get_bits() - tvb_g_memdup()/ep_tvb_memdup() -> tvb_memdup() - tvb_fake_unicode()/tvb_get_ephemeral_faked_unicode() -> tvb_get_faked_unicode() - tvb_get_g_string()/tvb_get_ephemeral_string()/tvb_get_seasonal_string() -> tvb_get_string() - tvb_get_g_unicode_string()/tvb_get_ephemeral_unicode_string() -> tvb_get_unicode_string() - tvb_get_ephemeral_string_enc() -> tvb_get_string_enc() - update docs accordingly svn path=/trunk/; revision=52172
2013-09-16Convert proto_tree_add_uint_format to proto_tree_add_uint_format_value if ↵Michael Mann1-2/+2
hf_ field name is the first part of the formatted string. This was all manual inspection and most cases were either: 1. Case sensitivity differences between hf_ field name and formatted string. 2. Unnecessary whitespace between hf_ field name and colon in formatted string There are cases where the hf_ field name doesn't quite match the proto_tree_add_uint_format, but it's close enough that one of them should be "right", I'm just not sure which is, I just know the string in proto_tree_add_uint_format is the one displayed. svn path=/trunk/; revision=52098
2013-09-15emem -> wmemMartin Kaiser1-7/+7
svn path=/trunk/; revision=52075
2013-09-15Convert proto_tree_add_uint_format to proto_tree_add_uint_format_value if ↵Michael Mann1-6/+6
hf_ field name is the first part of the formatted string. This was done with a perl script on the dissectors directory (packet-*.c), followed by manual inspection of the output. The manual inspection yielded a few cases that really should have been proto_tree_add_uint or proto_tree_add_item, so I updated them accordingly. The script didn't catch as many as I would have liked, but it's a start. The most common (ab)use of proto_tree_add_uint_format was for appending strings to CRC/checksum values to note good or bad CRC/checksum. svn path=/trunk/; revision=52045
2013-09-09expert_add_info_format_text -> expert_add_info_formatMichael Mann1-7/+7
svn path=/trunk/; revision=51852
2013-08-25Batch of filterable expert infos.Michael Mann1-43/+25
svn path=/trunk/; revision=51518
2013-05-12Add the posibillity to use a key for per-packet-data.Anders Broman1-6/+6
svn path=/trunk/; revision=49259
2013-04-11Mark unavailable XR record elements more clearly then just a comment.Jaap Keuter1-14/+35
svn path=/trunk/; revision=48824
2013-03-23Fix some Dead Store (Dead assignement/Dead increment) Warning found by ClangAlexis La Goutte1-2/+1
svn path=/trunk/; revision=48503
2013-03-17From beroset:Anders Broman1-13/+13
remove C++ incompatibilities https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=8416 svn path=/trunk/; revision=48383
2013-02-26it's ==> its & its ==> it's as needed.Bill Meier1-2/+2
svn path=/trunk/; revision=47891
2013-01-31Use '#if 0 ... #endif' rather than /** ... **/ to comment outBill Meier1-2/+2
unused hf[] entries (which I should have done in the first place). svn path=/trunk/; revision=47390
2013-01-26Comment out cases of unused hf array entries found by checkhf.Bill Meier1-1/+3
svn path=/trunk/; revision=47302
2012-12-26Fix a bunch of warnings.Guy Harris1-2/+2
Cast away some implicit 64-bit-to-32-bit conversion errors due to use of sizeof. Cast away some implicit 64-bit-to-32-bit conversion errors due to use of strtol() and strtoul(). Change some data types to avoid those implicit conversion warnings. When assigning a constant to a float, make sure the constant isn't a double, by appending "f" to the constant. Constify a bunch of variables, parameters, and return values to eliminate warnings due to strings being given const qualifiers. Cast away those warnings in some cases where an API we don't control forces us to do so. Enable a bunch of additional warnings by default. Note why at least some of the other warnings aren't enabled. randpkt.c and text2pcap.c are used to build programs, so they don't need to be in EXTRA_DIST. If the user specifies --enable-warnings-as-errors, add -Werror *even if the user specified --enable-extra-gcc-flags; assume they know what they're doing and are willing to have the compile fail due to the extra GCC warnings being treated as errors. svn path=/trunk/; revision=46748
2012-10-22Avoid potential infinite loops. Fixes ↵Chris Maynard1-6/+8
https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=7879 #BACKPORT (1.8, 1.6) svn path=/trunk/; revision=45717
2012-10-09Replace non ASCII chars.Anders Broman1-5/+5
svn path=/trunk/; revision=45421
2012-10-09Add initial support for three new RTCP packet types: AVB, RSI and TOKEN.Jaap Keuter1-8/+120
svn path=/trunk/; revision=45416
2012-09-26Show the PID field of the transport feedback NACK as "RTCP TransportGuy Harris1-10/+9
Feedback NACK PID", not just as "RTCP Transport Feedback NACK", and give the field a name for that. Use it in the protocol tree for the bits of the BLP field, rather than making it a hidden field there. Clean up the tags appended to the BLP field. svn path=/trunk/; revision=45157
2012-09-26Just append the ": " to the generic NACK BLP item, don't replace itsGuy Harris1-8/+3
text. Don't put empty items into the bitfield tree. Show the BLP field as hex, as it's a bitfield. (What should *really* happen is that it should display each 1 bit in the usual fashion, with the ".... ...1 .... ...." display, but have that bit be an *integral* field with the appropriate PID for the NACKed packet - i.e., display hf_rtcp_rtpfb_nack_pid, with the value rtcp_rtpfb_nack_pid + i + 1, and with the bitfield stuff in the displayed representation.) svn path=/trunk/; revision=45155
2012-09-26replaced decode_boolean_bitfield calls with itemized filtersMichael Mann1-5/+5
svn path=/trunk/; revision=45152
2012-09-20We always HAVE_CONFIG_H so don't bother checking whether we have it or not.Jeff Morriss1-3/+1
svn path=/trunk/; revision=45017
2012-09-10Initial commit to support yet another method of passing data between dissectors.Jakub Zawadzki1-3/+1
Add new parameter 'data' to heur_dissector_t and new_dissector_t, for now it's always NULL svn path=/trunk/; revision=44860
2012-07-23Mark pinfo as unused.Anders Broman1-1/+1
svn path=/trunk/; revision=43927
2012-07-23Add dissector tables for RTCP extended feedback messages ↵Michael Mann1-6/+21
(https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=5764) svn path=/trunk/; revision=43926
2012-06-28Update Free Software Foundation address.Jakub Zawadzki1-1/+1
(COPYING will be updated in next commit) svn path=/trunk/; revision=43536
2012-06-24Fix https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=7386 :Pascal Quantin1-4/+25
Fix dissection of Packet Receipt Times Report Block svn path=/trunk/; revision=43467
2012-05-17Fix the fix ....Bill Meier1-1/+1
svn path=/trunk/; revision=42685
2012-05-17Silence a "may be used uninitialiuzed" warning.....Bill Meier1-1/+1
svn path=/trunk/; revision=42684
2012-05-17General cleanup including as appropriate:Bill Meier1-462/+471
- Remove unneeded #include files (string.h, addr_resolv.h); - Remove unneeded 'if(!initialized){...}' in proto_reg_handoff(); - Reformat hf[] entries; - Remove unneeded variable initializations; - "localize" some variables; - Whitespace/indentation/long lines/formatting (in one case: re-order code slightly to not do col_set_str() & etc until after initial "frame acceptance testing" by dissector. svn path=/trunk/; revision=42683
2012-05-04As suggested in ↵Jeff Morriss1-3/+3
http://www.wireshark.org/lists/wireshark-dev/201204/msg00062.html : Don't use ENC_BIG_ENDIAN or ENC_LITTLE_ENDIAN with ENC_ASCII: ASCII has no endianism, so ENC_NA is more appropriate. svn path=/trunk/; revision=42432
2012-03-07Fix incorrect packet-details display of certain 1 bit FT_BOOLEAN fields.Bill Meier1-2/+2
(Use a valid 'parent field width' in the hf[] 'display' field. svn path=/trunk/; revision=41396
2011-10-27Fix proto_tree_add_item( encoding args;Bill Meier1-3550/+3550
Do whitespace cleanup (for a few files). svn path=/trunk/; revision=39640
2011-10-21For proto_tree_add_item(..., proto_xxx, ...)use ENC_NA as the encoding arg.Bill Meier1-17/+17
Also: remove trailing whitespace for a number of files. svn path=/trunk/; revision=39503
2011-10-15Convert proto_tree_add_item() 'encoding' arg for field types FT_STRING, ↵Bill Meier1-5/+5
FT_STRINGZ, FT_UINT_STRING as follows: 1. If there's no character encoding (ENC_ASCII, ...) specified then use ENC_ASCII. 2. For all but FT_UINT_STRING, always use ENC_NA (replacing any existing True/1/FALSE/0 /ENC_BIG_ENDIAN/ENC_LITTLE_ENDIAN). svn path=/trunk/; revision=39426
2011-10-10 Convert 'encoding' parameter of certain proto_tree_add_item() calls in ↵Bill Meier1-5/+5
non-autogenerated epan/dissectors: Specifically: Replace FALSE|0 and TRUE|1 by ENC_BIG_ENDIAN|ENC_LITTLE_ENDIAN as the encoding parameter for proto_tree_add_item() calls which directly reference an item in hf[] which has a type of: FT_BOOLEAN FT_IPv4 FT_EUI64 FT_GUID FT_UINT_STRING Also: For type FT_ITv6 use ENC_NA. (This was missed in SVN #39260) svn path=/trunk/; revision=39328
2011-10-06Convert 'encoding' parameter of certain proto_tree_add_item() calls in ↵Bill Meier1-67/+67
non-autogenerated epan/dissectors: Specifically: Replace FALSE|0 and TRUE|1 by ENC_BIG_ENDIAN|ENC_LITTLE_ENDIAN as the encoding parameter for proto_tree_add_item() calls which directly reference an item in hf[] which has a type of: FT_UINT8 FT_UINT16 FT_UINT24 FT_UINT32 FT_UINT64 FT_INT8 FT_INT16 FT_INT24 FT_INT32 FT_INT64 FT_FLOAT FT_DOUBLE svn path=/trunk/; revision=39288
2011-10-04Use ENC_NA as encoding for proto_tree_add_item() calls which directly ↵Bill Meier1-11/+11
reference an hf item (in hf[] with types: FT_NONE FT_BYTES FT_IPV6 FT_IPXNET FT_OID Note: Encoding field set to ENC_NA only if the field was previously TRUE|FALSE|ENC_LITTLE_ENDIAN|ENC_BIG_ENDIAN svn path=/trunk/; revision=39260
2011-08-01Fix gcc 4.6 "set but not used [-Wunused-but-set-variable]" warning.Bill Meier1-4/+2
svn path=/trunk/; revision=38298
2011-07-27from T. Loebner:Anders Broman1-70/+248
Dissector for XR IDMS from ETSI TS 182 063 v3.5.2 Annex W https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=6163 svn path=/trunk/; revision=38225
2011-07-18Fix gcc 4.6 "set but not used [-Wunused-but-set-variable]" warnings.Bill Meier1-10/+9
svn path=/trunk/; revision=38095
2011-05-10From Olivier Crete via bug 5761: Compute the FCI size correctly for RTCP RTPFB.Chris Maynard1-4/+4
svn path=/trunk/; revision=37052