aboutsummaryrefslogtreecommitdiffstats
path: root/epan/dissectors/packet-rtcp.c
AgeCommit message (Collapse)AuthorFilesLines
2007-05-31From Lars Ruoff:Stephen Fisher1-4/+4
find attached several trivial diffs for viewing RTP SSRC values in Hex rather than Dec at various places in the UI. Also includes change from BASE_DEC to BASE_HEX_DEC for corresponding RTP and RTCP dissector header fields. svn path=/trunk/; revision=22017
2007-05-29When reporting roundtrip delay, show delay since timestamp of LSR frame.Martin Mathieson1-10/+35
svn path=/trunk/; revision=21985
2007-05-15Fix problem from previous commit (confused myself with FT_UINT_STRING ↵Martin Mathieson1-5/+14
needing length of 1 when adding to tree...), and show display-name in info column. svn path=/trunk/; revision=21790
2007-05-15TBCP fixes:Martin Mathieson1-16/+27
- more careful checking of packet length - skip padding at end of SDES items block - formatting svn path=/trunk/; revision=21789
2007-04-13fix gcc warningSebastien Tandel1-1/+1
svn path=/trunk/; revision=21416
2007-03-23fix some more warnings (type casts)Ulf Lamping1-2/+2
svn path=/trunk/; revision=21141
2007-03-20Try to squash a warning seen by win32 buildbotMartin Mathieson1-1/+1
svn path=/trunk/; revision=21074
2007-03-06Append ms calculation to DLSR field.Martin Mathieson1-20/+25
Show number of bytes derived from length field. svn path=/trunk/; revision=20982
2007-02-24Add basic support for RFC4585.Anders Broman1-1/+100
svn path=/trunk/; revision=20916
2007-01-04Check in trivial changes before generating a big diff...Martin Mathieson1-1/+0
svn path=/trunk/; revision=20304
2007-01-02Fix for bug 1279 (Negative values for RTCP round trip delayMartin Mathieson1-33/+34
cannot be stored in guint32). - Makes the threshold preference value an absolute value. - There is now a separate expert info item for -ve roundtrips N.B. There is still a problem with filtering -ve values on this FT_INT32 field, i.e. rtcp.roundtrip-delay < 0 never matches with frames that it should (even if rtcp.roundtrip-delay == -3 can be used to match specific frames...). svn path=/trunk/; revision=20264
2006-12-21TBCP changes:Martin Mathieson1-24/+18
- Fix 'ignored' flag that wasn't wide enough to take result - Use FP_UINT_STRING in a couple of places svn path=/trunk/; revision=20183
2006-11-09Use value_string for info column. Also use fences to handle compound packetsMartin Mathieson1-34/+7
svn path=/trunk/; revision=19872
2006-11-02Don't try to report -ve roundtrip delaysMartin Mathieson1-3/+14
svn path=/trunk/; revision=19778
2006-10-26Try to declare and cast away warningsMartin Mathieson1-3/+7
svn path=/trunk/; revision=19709
2006-10-20Report roundtrip delay as expert itemMartin Mathieson1-1/+7
svn path=/trunk/; revision=19627
2006-08-21Use FT_UINT_STRING for TBCP DENY reason-phraseMartin Mathieson1-24/+7
svn path=/trunk/; revision=18968
2006-08-09Minor TBCP fixesMartin Mathieson1-8/+31
svn path=/trunk/; revision=18860
2006-08-02Update to TBCP ("PoC1" application). This is based on the "Approved Version ↵Martin Mathieson1-162/+536
1.0 09 Jun 2006" - updated to the current (approved) spec. I'm not sure how backwards-compatible this is with older drafts... - prettified the existing code, including more details in the info column Also included is a fix to the way the offset at the end of an RTCP BYE packet is calculated (taking into account the NULL. This avoids the 'length wrong' expert item) svn path=/trunk/; revision=18820
2006-07-28as per RFC 3611 - 4.1.1 run length is 14 bits not 15.Luis Ontanon1-1/+1
Fixes Bug 1022 svn path=/trunk/; revision=18805
2006-06-08rtcp.profile-specific-extension was defined twiceJörg Mayer1-12/+0
svn path=/trunk/; revision=18400
2006-06-06From Martin Mathieson:Anders Broman1-4/+55
- shows profile-specific extension data at the end of SR/RR reports (if packet length has not yet been reached after parsing normal data) and advances offset (further packets were not recognised+dissected as this data wasn't being skipped). - checks that the length of the RTCP data in the whole frame matches the combined length from the length fields (the last check in RFC 3550, "A.2 RTCP Header Validity Checks") with a generated field and expert info when wrong. - reports the length field in all of the message types consistently (the length was confusingly shown multiplied by 4 only in APP packets...) svn path=/trunk/; revision=18357
2006-05-29From Martin Mathieson:Anders Broman1-5/+40
- shows profile-specific extension data at the end of SR/RR reports (if packet length has not yet been reached after parsing normal data) and advances offset (further packets were not recognised+dissected as this data wasn't being skipped). svn path=/trunk/; revision=18245
2006-05-21change a whole bunch of ethereal into wiresharkRonnie Sahlberg1-2/+2
svn path=/trunk/; revision=18196
2006-04-19From Martin mathieson:Anders Broman1-2/+2
While looking at bug 882 (which seems to have been fixed since 0.10.14) I noticed the RTCP heuristic dissector wasn't picking up the frame. This patch fixes the parenthesis to test the packet-type properly. svn path=/trunk/; revision=17914
2006-04-13From Martin Mathieson:Anders Broman1-3/+5
- Also show vpi/vci in info column svn path=/trunk/; revision=17859
2006-04-06Better read NTP LSW from the right spotJaap Keuter1-1/+1
svn path=/trunk/; revision=17836
2006-04-06From: Martin MathiesonJaap Keuter1-75/+68
- fixes bug 863 (RTCP sender report's NTP time display incorrect - use using wrong bytes) - makes NTP timestamp MSW and LSW proper filterable fields, displaying them in dec and hex - when doing roundtrip calculations, rationalise fields added, add link to LSR frame whenever it matches svn path=/trunk/; revision=17834
2006-01-30From Andrei Emeltchenko:Anders Broman1-11/+45
OMA again has changed the format of the 2 RTCP packets: RTCP Grant and RTCP Taken In RTCP Grant instead of spare 2 bytes there are: magic number and item_len. In RTCP Taken there is an extra field "Number of participants" like in Grant. http://www.openmobilealliance.org/release_program/docs/CopyrightClick.asp?pck=PoC&file=V1_0-20051104-C/OMA-TS-PoC-UserPlane-V1_0-20051104-C.pdf svn path=/trunk/; revision=17125
2006-01-03From Martin MathiesonAnders Broman1-3/+8
I keep finding finding traces that show new problems with this code. This patch fixes 2 problems: - I've seen RTCP frames containing a SR and RR with identical source info and the lsr matching the current MSW/LSW timestamp of the SR. Don't want to do calculation without real roundtrip info - calculating the gap between the 2 frames was still wrong (sigh) svn path=/trunk/; revision=16934
2005-12-31Fixes Bug 531 (Incorrect Interpretation of Bit vector and RLE RTCP XR Blocks).Luis Ontanon1-1/+1
svn path=/trunk/; revision=16921
2005-12-22From Martin Mathieson:Anders Broman1-1/+1
there are only 1000 ms in one second svn path=/trunk/; revision=16882
2005-12-07Why duplicate the code of "tvb_get_string()" when you could just useGuy Harris1-29/+29
"tvb_get_string()"? Why even bother with "tvb_get_string()" when you can just use "proto_tree_add_item()" with a string item? Make sure that the prefix in a PRIV item isn't bigger than the item itself. That fixes bug 603. svn path=/trunk/; revision=16716
2005-12-07From Martin M various updates and fixesRonnie Sahlberg1-0/+5
Hi, Some tiddly changes: pppoe- don't create an empty discovery tags tree when the payload length is 0 chap- make chap.value work as a filterable field rtcp- append the packet type to the protocol tree name  svn path=/trunk/; revision=16712
2005-12-02rtcp fix for sdes_prefix_stringRonnie Sahlberg1-0/+1
svn path=/trunk/; revision=16656
2005-11-09From Andrei EmeltchenkoAnders Broman1-46/+135
I have added new RTCP POC fields as OMA standard says. With some additions. svn path=/trunk/; revision=16452
2005-11-07The return value of tvb_get_ptr() is a const ptr; assign it to a constGuy Harris1-7/+2
ptr. The answer to the question "??????????????????????????????????????????????????????????????????" is "No - the return value of tvb_get_ptr() is a reference, not an allocated copy, and it cannot be freed and doesn't need to be freed." svn path=/trunk/; revision=16426
2005-11-07Display MSW and LSW as NTP timestamp as well.Anders Broman1-3/+14
svn path=/trunk/; revision=16421
2005-09-21get rid of strcpy in packet-ntp.cRonnie Sahlberg1-3/+3
at the same time change ntp_fmt_ts to return a pointer to ian ep-allocated buffer. remove the redundant buffer parameter in the signature and change all callers. svn path=/trunk/; revision=15939
2005-08-28add missing value_string terminationRonnie Sahlberg1-0/+4
svn path=/trunk/; revision=15584
2005-08-24EVERYTHING IN THE BUILDBOT IS GOING TO BE RED!!! Sorry! Ulf Lamping1-8/+6
I've done more than a day to change the timestamp resolution from microseconds to nanoseconds. As I really don't want to loose those changes, I'm going to check in the changes I've done so far. Hopefully someone else will give me a helping hand with the things left ... What's done: I've changed the timestamp resolution from usec to nsec in almost any place in the sources. I've changed parts of the implementation in nstime.s/.h and a lot of places elsewhere. As I don't understand the editcap source (well, I'm maybe just too tired right now), hopefully someone else might be able to fix this soon. Doing all those changes, we get native nanosecond timestamp resolution in Ethereal. After fixing all the remaining issues, I'll take a look how to display this in a convenient way... As I've also changed the wiretap timestamp resolution from usec to nsec we might want to change the wiretap version number... svn path=/trunk/; revision=15520
2005-08-24Properly initialize our hf_ arrays. Make hf_rtcp_app_poc1_conn_session_typeGerald Combs1-4/+4
an FT_UINT8 instead of an FT_BOOLEAN. This keeps the Solaris builder from crashing while running "-G values". svn path=/trunk/; revision=15519
2005-08-22From Timo Metsala:Anders Broman1-3/+291
Updates the PoC floor control parsing to comply to the latest version of the specification. svn path=/trunk/; revision=15511
2005-08-17remove g_malloc()s from rtcpRonnie Sahlberg1-4/+2
svn path=/trunk/; revision=15382
2005-08-12more gmemchunk -> se_alloc() improvementsRonnie Sahlberg1-22/+6
svn path=/trunk/; revision=15312
2005-08-10rename ep_tvb_get_string() to tvb_get_ephemeral_string() asnd update the ↵Ronnie Sahlberg1-1/+1
documentation in README.developer svn path=/trunk/; revision=15270
2005-07-30Make some funtions static. More char -> const char warning fixesJörg Mayer1-2/+2
svn path=/trunk/; revision=15146
2005-07-24some more dissectors converted to ep_tvb_get_stringRonnie Sahlberg1-2/+1
again at least one obvious memleak was found in the old code svn path=/trunk/; revision=15031
2005-06-07From: Martin MathiesonLuis Ontanon1-3/+3
fix cases where %d has been used instead of %u... svn path=/trunk/; revision=14583
2005-02-24Clean up white space.Guy Harris1-48/+45
"decode_boolean_bitfield()" returns a "const char *" - don't cast it to a "gchar *" and modify what it points to. Instead, just use "other_decode_bitfield_value()". svn path=/trunk/; revision=13494