aboutsummaryrefslogtreecommitdiffstats
path: root/epan/dissectors/packet-rohc.c
AgeCommit message (Collapse)AuthorFilesLines
2017-02-16Squelch a compiler warning.Guy Harris1-2/+2
All we care about is whether the bit in question is set or not, so just test whether (value & BIT) != 0. Change-Id: I6a1eb6b09a7e64d4da9cf92423a44be17625310f Reviewed-on: https://code.wireshark.org/review/20129 Reviewed-by: Guy Harris <guy@alum.mit.edu>
2017-02-16ROHC: Basic support for RTP extension 3John Viklund1-5/+522
Change-Id: Ifcc9d3791c54c484a2ec6f6e566a07e7dfc9fe7e Reviewed-on: https://code.wireshark.org/review/20088 Petri-Dish: Alexis La Goutte <alexis.lagoutte@gmail.com> Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org> Reviewed-by: Anders Broman <a.broman58@gmail.com>
2017-02-15Display 4 octets SDVL with 3 bits in ROHCJohn Viklund1-1/+1
Four octets self-describing variable-length in ROHC has three bits discriminator, not four as previously displayed. Change-Id: Ibe366aed3ac822abd0046efe71e9b4e4c633524f Reviewed-on: https://code.wireshark.org/review/20112 Reviewed-by: Alexis La Goutte <alexis.lagoutte@gmail.com> Petri-Dish: Alexis La Goutte <alexis.lagoutte@gmail.com> Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org> Reviewed-by: Jaap Keuter <jaap.keuter@xs4all.nl>
2016-07-21Add proto_tree_add_checksum.Michael Mann1-2/+2
This is an attempt to standardize display/handling of checksum fields for all dissectors. The main target is for dissectors that do validation, but dissectors that just report the checksum were also included just to make them easier to find in the future. Bug: 10620 Bug: 12058 Ping-Bug: 8859 Change-Id: Ia8abd86e42eaf8ed50de6b173409e914b17993bf Reviewed-on: https://code.wireshark.org/review/16380 Petri-Dish: Michael Mann <mmann78@netscape.net> Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org> Reviewed-by: Jeff Morriss <jeff.morriss.ws@gmail.com> Reviewed-by: Michael Mann <mmann78@netscape.net>
2016-03-20Create call_data_dissector() to call data dissector.Michael Mann1-6/+4
This saves many dissectors the need to find the data dissector and store a handle to it. There were also some that were finding it, but not using it. For others this was the only reason for their handoff function, so it could be eliminated. Change-Id: I5d3f951ee1daa3d30c060d21bd12bbc881a8027b Reviewed-on: https://code.wireshark.org/review/14530 Petri-Dish: Michael Mann <mmann78@netscape.net> Reviewed-by: Michael Mann <mmann78@netscape.net>
2016-03-20Manually add protocol dependencies derived from find_dissector.Michael Mann1-2/+2
Started by grepping call_dissector_with_data, call_dissector_only and call_dissector and traced the handles passed into them to a find_dissector within the dissector. Then replaced find_dissector with find_dissector_add_dependency and added the protocol id from the dissector. "data" dissector was not considered to be a dependency. Change-Id: I15d0d77301306587ef8e7af5876e74231816890d Reviewed-on: https://code.wireshark.org/review/14509 Petri-Dish: Michael Mann <mmann78@netscape.net> Reviewed-by: Michael Mann <mmann78@netscape.net>
2016-01-29RoHC: fix an assert when dissecting partially an IR-DYN packetPascal Quantin1-1/+3
Change-Id: Ibcb0a109a38524481bc8639bc73ab73acd07ca1a Reviewed-on: https://code.wireshark.org/review/13598 Reviewed-by: Pascal Quantin <pascal.quantin@gmail.com>
2016-01-25Move the proto data stuff out of frame_data.[ch].Guy Harris1-0/+1
It's not tied to the frame_data structure any more, so it belongs by itself. Clean up some #includes while we're at it; in particular, frame_data.h doesn't use anything related to tvbuffs, so don't have it gratuitiously include tvbuff.h. Change-Id: Ic32922d4a3840bac47007c5d4c546b8842245e0c Reviewed-on: https://code.wireshark.org/review/13518 Reviewed-by: Guy Harris <guy@alum.mit.edu>
2016-01-24Add the packet number to the packet_info structure, and use it.Guy Harris1-4/+4
That removes most of the uses of the frame number field in the frame_data structure. Change-Id: Ie22e4533e87f8360d7c0a61ca6ffb796cc233f22 Reviewed-on: https://code.wireshark.org/review/13509 Reviewed-by: Guy Harris <guy@alum.mit.edu>
2016-01-08Fix a lot of typos and misspellingsmoshekaplan1-1/+1
Change-Id: I8512cfa1d424f82a873a0e0e1d22c7b075fdd7f3 Reviewed-on: https://code.wireshark.org/review/13069 Reviewed-by: Alexis La Goutte <alexis.lagoutte@gmail.com> Petri-Dish: Alexis La Goutte <alexis.lagoutte@gmail.com> Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org> Reviewed-by: Michael Mann <mmann78@netscape.net>
2015-12-09new_register_dissector -> register_dissector for dissector directory.Michael Mann1-1/+1
Change-Id: Ie39ef054a4a942687bd079f3a4d8c2cc55d5f22c Reviewed-on: https://code.wireshark.org/review/12485 Petri-Dish: Michael Mann <mmann78@netscape.net> Reviewed-by: Michael Mann <mmann78@netscape.net>
2015-07-03Call reassembly_table_destroy and move g_hash_table_destroyPeter Wu1-5/+7
This patch moves g_hash_table_destroy calls from the init routine to the cleanup routine. Besides that, the conditional check for the hash table has been removed, assuming that init is always paired with a cleanup call. If reassembly_table_init is found, a reassembly_table_destroy call is prepended to the cleanup function as well. Comments have been removed from the init function as well as these did not seem to have additional value ("destroy hash table" is clear from the context). The changes were automatically generated using https://git.lekensteyn.nl/peter/wireshark-notes/diff/one-off/cleanup-rewrite.py?id=4d11f07180d9c115eb14bd860e9a47d82d3d1dcd Manually edited files (for assignment auditing): dvbci, ositp, sccp, tcp. Other files that needed special attention due to the use of register_postseq_cleanup_routine: - ipx: keep call, do not add another cleanup routine. - ncp: remove empty mncp_postseq_cleanup. mncp_hash_lookup is used even if a frame is visited before (see dissect_ncp_common), hence the hash table cannot be destroyed here. Do it in cleanup instead. - ndps: add cleanup routine to kill reassembly table, but do not destroy the hash table as it is already done in ndps_postseq_cleanup. Change-Id: I95a72b3df2978b2c13fefff6bd6821442193d0ed Reviewed-on: https://code.wireshark.org/review/9223 Reviewed-by: Michael Mann <mmann78@netscape.net>
2015-06-23Remove more deprecated tvb_lengthEvan Huus1-16/+16
Change-Id: I36603453c2563406f82663683930088dedd5f39c Reviewed-on: https://code.wireshark.org/review/9041 Reviewed-by: Evan Huus <eapache@gmail.com>
2014-12-21Cleanup use of #includes in non-generated epan/dissector/*.cBill Meier1-4/+0
Specifically: - Set packet.h to be the first wireshark #include after config.h and "system" #includes. packet.h added as an #include in some cases when missing. - Remove some #includes included (directly/indirectly) in packet.h. E.g., glib.h. (Done only for those files including packet.h). - As needed, move "system" #includes to be after config.h and before wireshark #includes. - Rework various #include file specifications for consistency. - Misc. Change-Id: Ifaa1a14b50b69fbad38ea4838a49dfe595c54c95 Reviewed-on: https://code.wireshark.org/review/5923 Petri-Dish: Alexis La Goutte <alexis.lagoutte@gmail.com> Reviewed-by: Bill Meier <wmeier@newsguy.com>
2014-11-13Eliminate proto_tree_add_text for some dissectors.Michael Mann1-28/+70
Change-Id: Ide14bcac0b1563bee4260ac9c1a280ba99e97e71 Reviewed-on: https://code.wireshark.org/review/5261 Reviewed-by: Michael Mann <mmann78@netscape.net> Petri-Dish: Michael Mann <mmann78@netscape.net> Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org> Reviewed-by: Anders Broman <a.broman58@gmail.com>
2014-07-06convert to proto_tree_add_subtree[_format]Michael Mann1-41/+26
Change-Id: Ia2567695ffed30c990eda3740b08bfab101cea96 Reviewed-on: https://code.wireshark.org/review/2883 Reviewed-by: Michael Mann <mmann78@netscape.net>
2014-06-19Revert "Fixup: tvb_* -> tvb_captured"Michael Mann1-16/+16
https://www.wireshark.org/lists/wireshark-dev/201406/msg00131.html This reverts commit 246fe2ca4c67d8c98caa84e2f57694f6322e2f96. Change-Id: Ib24bae0198c13a84bd7f731bf4af921212109a8f Reviewed-on: https://code.wireshark.org/review/2430 Reviewed-by: Michael Mann <mmann78@netscape.net>
2014-06-18Fixup: tvb_* -> tvb_capturedDario Lombardo1-16/+16
Change-Id: I9209c1271967405c34c1b6fa43e1726a4d3a5a3f Reviewed-on: https://code.wireshark.org/review/2377 Reviewed-by: Anders Broman <a.broman58@gmail.com>
2014-05-28Minor: use VALS macro (as per convention); Add editor modelines; Do ↵Bill Meier1-2/+15
whitespace changes. Change-Id: I6007c1b2098d06e4a892474dd07f06a7538f94ef Reviewed-on: https://code.wireshark.org/review/1843 Reviewed-by: Bill Meier <wmeier@newsguy.com>
2014-03-04Remove all $Id$ from top of fileAlexis La Goutte1-2/+0
(Using sed : sed -i '/^ \* \$Id\$/,+1 d') Fix manually some typo (in export_object_dicom.c and crc16-plain.c) Change-Id: I4c1ae68d1c4afeace8cb195b53c715cf9e1227a8 Reviewed-on: https://code.wireshark.org/review/497 Reviewed-by: Anders Broman <a.broman58@gmail.com>
2013-12-12- Make local functions static.Anders Broman1-0/+2
- Forward declaration of register functions. svn path=/trunk/; revision=53958
2013-11-23Create the ability to have packet scoped "proto" data. Bug 9470 ↵Michael Mann1-11/+11
(https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=9470) I'm not sold on the name or module the proto_data functions live in, but I believe the function arguments are solid and gives us the most flexibility for the future. And search/replace of a function name is easy enough to do. The big driving force for getting this in sooner rather than later is the saved memory on ethernet packets (and IP packets soon), that used to have file_scope() proto data when all it needed was packet_scope() data (technically packet_info->pool scoped), strictly for Decode As. All dissectors that use p_add_proto_data() only for Decode As functionality have been converted to using packet_scope(). All other dissectors were converted to using file_scope() which was the original scope for "proto" data. svn path=/trunk/; revision=53520
2013-11-10pinfo->private_data is no longer being used, so adjust the logic accordingly.Michael Mann1-3/+4
svn path=/trunk/; revision=53237
2013-10-29From didier gautheron: remove redundant or use faster col_xxx functionsBill Meier1-3/+3
- when the text parameter is constant col_add_str() and col_set_str() are equivalent but col_set_str() is faster. - same for replace col_append_fstr and col_append_str - remove col_clear() when it's redundant: + before a col_set/col_add if the dissector can't throw an exception. - replace col_append() after a col_clear() with faster col_add... or col_set https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=9344 svn path=/trunk/; revision=52948
2013-10-24CID 700176: Dereference null return value (NULL_RETURNS)Jörg Mayer1-0/+2
Not sure whether this is really possible, but add a dissector_assert just to be safe. svn path=/trunk/; revision=52820
2013-10-20Fix -Wshadow errorEvan Huus1-5/+5
svn path=/trunk/; revision=52726
2013-10-20Pass ROHC "private data" from PDCP-LTE using dissector data parameter ↵Michael Mann1-25/+14
instead of using pinfo->private_data. Passing data through the dissector parameter eliminates the need for ROHC dissector to save/restore private_data. svn path=/trunk/; revision=52723
2013-09-09expert_add_info_format_text -> expert_add_info_formatMichael Mann1-1/+1
svn path=/trunk/; revision=51852
2013-08-25Batch of filterable expert infos.Michael Mann1-7/+20
svn path=/trunk/; revision=51518
2013-08-19Change some dissectors to use pinfo memory pool instead of malloc if it can ↵Pascal Quantin1-9/+8
trigger an exception between between buffer allocation and tvb_set_free_cb call svn path=/trunk/; revision=51427
2013-08-19Do not use ephemeral memory when adding a new data sourcePascal Quantin1-1/+2
svn path=/trunk/; revision=51423
2013-08-17Squelch a (bogus) warning about next_tvb being unused initialised.Martin Mathieson1-1/+1
svn path=/trunk/; revision=51404
2013-08-16Initialize val_len to avoid Clang warning: The right operand of '-' is a ↵Chris Maynard1-16/+19
garbage value. While in there, add some protection against tvb_length_remaining() possibly returning -1, or possibly being less than val_len. #BACKPORT(1.10) svn path=/trunk/; revision=51395
2013-08-05Keep result of [new_]register_dissector in some dissectors.Jakub Zawadzki1-8/+7
svn path=/trunk/; revision=51156
2013-05-18Do not display payload twice when using uncompressed profilePascal Quantin1-1/+3
svn path=/trunk/; revision=49407
2013-05-16Add partial dissection of IR packet with IP profilePascal Quantin1-10/+23
svn path=/trunk/; revision=49331
2013-05-12Add the posibillity to use a key for per-packet-data.Anders Broman1-11/+11
svn path=/trunk/; revision=49259
2013-04-25Enhance dissection of feedbackPascal Quantin1-6/+16
svn path=/trunk/; revision=49032
2013-03-19From beroset:Anders Broman1-6/+6
remove C++ incompatibilities https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=8416 svn path=/trunk/; revision=48430
2013-02-28Fix dissection of feedback with large CIDPascal Quantin1-0/+1
svn path=/trunk/; revision=47955
2013-02-25Dissect more feedback optionsPascal Quantin1-17/+35
svn path=/trunk/; revision=47887
2013-02-24Fix display typePascal Quantin1-1/+1
svn path=/trunk/; revision=47870
2013-02-24Various enhancements to ROHC dissector:Pascal Quantin1-90/+571
- fix dissection of type 0 packets with large CID - add dissection of type 1 and 2 packets (extension 3 dissection to be done) - add dissection of UDP checksum svn path=/trunk/; revision=47869
2013-02-23Add dissection of uncompressed IP-IDPascal Quantin1-34/+32
svn path=/trunk/; revision=47844
2013-02-23Enhance dissection of uncompressed profile and type 0 packets.Pascal Quantin1-31/+68
Always restore saved private data when returning from dissector. svn path=/trunk/; revision=47840
2013-02-22When dissecting a feedback, if no context info is present use private data ↵Pascal Quantin1-4/+18
if available svn path=/trunk/; revision=47826
2013-02-21Dissect Feedback type 1/2 packets for UDP and Uncompressed profilesPascal Quantin1-48/+72
svn path=/trunk/; revision=47806
2013-01-31Use '#if 0 ... #endif' rather than /** ... **/ to comment outBill Meier1-2/+2
unused hf[] entries (which I should have done in the first place). svn path=/trunk/; revision=47390
2013-01-26Comment out cases of unused hf array entries found by checkhf.Bill Meier1-1/+3
svn path=/trunk/; revision=47302
2012-09-20We always HAVE_CONFIG_H so don't bother checking whether we have it or not.Jeff Morriss1-3/+1
svn path=/trunk/; revision=45017
generated by cgit v1.2.3 (git 2.25.1) at 2024-06-13 14:46:16 +0000