aboutsummaryrefslogtreecommitdiffstats
path: root/epan/dissectors/packet-rlc.c
AgeCommit message (Collapse)AuthorFilesLines
2014-12-23Deleting unnecessary #includes from dissectors.Martin Mathieson1-4/+0
Fourth batch (packet-mac-lte.c -> packet-rtp.c). Will look at cleaning up and committing script afterwards. Change-Id: Id921f07f4b274f0cfb77ce81abe4a285fdb8b644 Reviewed-on: https://code.wireshark.org/review/6023 Petri-Dish: Martin Mathieson <martin.r.mathieson@googlemail.com> Reviewed-by: Martin Mathieson <martin.r.mathieson@googlemail.com>
2014-12-21Cleanup use of #includes in non-generated epan/dissector/*.cBill Meier1-3/+0
Specifically: - Set packet.h to be the first wireshark #include after config.h and "system" #includes. packet.h added as an #include in some cases when missing. - Remove some #includes included (directly/indirectly) in packet.h. E.g., glib.h. (Done only for those files including packet.h). - As needed, move "system" #includes to be after config.h and before wireshark #includes. - Rework various #include file specifications for consistency. - Misc. Change-Id: Ifaa1a14b50b69fbad38ea4838a49dfe595c54c95 Reviewed-on: https://code.wireshark.org/review/5923 Petri-Dish: Alexis La Goutte <alexis.lagoutte@gmail.com> Reviewed-by: Bill Meier <wmeier@newsguy.com>
2014-11-13Eliminate proto_tree_add_text for some dissectors.Michael Mann1-1/+2
Change-Id: Ide14bcac0b1563bee4260ac9c1a280ba99e97e71 Reviewed-on: https://code.wireshark.org/review/5261 Reviewed-by: Michael Mann <mmann78@netscape.net> Petri-Dish: Michael Mann <mmann78@netscape.net> Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org> Reviewed-by: Anders Broman <a.broman58@gmail.com>
2014-09-16Fix spelling: cant-->can't, wont-->won't, etcBill Meier1-3/+3
Change-Id: I4497f1b8b6eab0e576d9dd31b732965f9a6679c6 Reviewed-on: https://code.wireshark.org/review/4124 Reviewed-by: Bill Meier <wmeier@newsguy.com>
2014-07-06convert to proto_tree_add_subtree[_format]Michael Mann1-4/+2
Change-Id: Ia2567695ffed30c990eda3740b08bfab101cea96 Reviewed-on: https://code.wireshark.org/review/2883 Reviewed-by: Michael Mann <mmann78@netscape.net>
2014-06-19Revert "Fixup: tvb_* -> tvb_captured"Michael Mann1-21/+21
https://www.wireshark.org/lists/wireshark-dev/201406/msg00131.html This reverts commit 246fe2ca4c67d8c98caa84e2f57694f6322e2f96. Change-Id: Ib24bae0198c13a84bd7f731bf4af921212109a8f Reviewed-on: https://code.wireshark.org/review/2430 Reviewed-by: Michael Mann <mmann78@netscape.net>
2014-06-18Fixup: tvb_* -> tvb_capturedDario Lombardo1-21/+21
Change-Id: I9209c1271967405c34c1b6fa43e1726a4d3a5a3f Reviewed-on: https://code.wireshark.org/review/2377 Reviewed-by: Anders Broman <a.broman58@gmail.com>
2014-06-17Set the rlc len field before we try to use it in an expert info.Evan Huus1-1/+1
Bug:9795 Change-Id: I740a9fe36278995cf6e590206f600c037789f0eb Reviewed-on: https://code.wireshark.org/review/2344 Reviewed-by: Evan Huus <eapache@gmail.com>
2014-03-04Remove all $Id$ from top of fileAlexis La Goutte1-2/+0
(Using sed : sed -i '/^ \* \$Id\$/,+1 d') Fix manually some typo (in export_object_dicom.c and crc16-plain.c) Change-Id: I4c1ae68d1c4afeace8cb195b53c715cf9e1227a8 Reviewed-on: https://code.wireshark.org/review/497 Reviewed-by: Anders Broman <a.broman58@gmail.com>
2013-12-21Add missing includesJakub Zawadzki1-0/+1
svn path=/trunk/; revision=54332
2013-12-12- Forward declaration of register functions.Anders Broman1-0/+3
svn path=/trunk/; revision=53963
2013-12-08Try to please OSX-10.5-x86 buildbotPascal Quantin1-1/+1
svn path=/trunk/; revision=53863
2013-12-08Fix indent (use 4 spaces) and add modelinesAlexis La Goutte1-275/+288
svn path=/trunk/; revision=53846
2013-12-08RLC dissector cannot assemble PDUs with SNs skipped and wrap-arounded. Bug ↵Michael Mann1-26/+62
9505 (https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=9505) From Nobuyuki Tsushima svn path=/trunk/; revision=53845
2013-11-23Create the ability to have packet scoped "proto" data. Bug 9470 ↵Michael Mann1-26/+26
(https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=9470) I'm not sold on the name or module the proto_data functions live in, but I believe the function arguments are solid and gives us the most flexibility for the future. And search/replace of a function name is easy enough to do. The big driving force for getting this in sooner rather than later is the saved memory on ethernet packets (and IP packets soon), that used to have file_scope() proto data when all it needed was packet_scope() data (technically packet_info->pool scoped), strictly for Decode As. All dissectors that use p_add_proto_data() only for Decode As functionality have been converted to using packet_scope(). All other dissectors were converted to using file_scope() which was the original scope for "proto" data. svn path=/trunk/; revision=53520
2013-09-15emem -> wmemJörg Mayer1-14/+15
svn path=/trunk/; revision=52069
2013-09-09expert_add_info_format_text -> expert_add_info_formatMichael Mann1-1/+1
svn path=/trunk/; revision=51852
2013-09-07Batch of filterable expert infoMichael Mann1-36/+61
svn path=/trunk/; revision=51823
2013-07-02Remove "global" proto_malformed and update some of the expert_info items ↵Michael Mann1-63/+29
that really aren't "malformed". svn path=/trunk/; revision=50324
2013-06-17Apply r49983 to other dissectorsPascal Quantin1-1/+1
svn path=/trunk/; revision=49984
2013-06-17Remove preceding zeroesPascal Quantin1-1/+1
svn path=/trunk/; revision=49973
2013-05-12Add the posibillity to use a key for per-packet-data.Anders Broman1-26/+26
svn path=/trunk/; revision=49259
2013-03-23Fix some Dead Store (Dead assignement/Dead increment) Warning found by ClangAlexis La Goutte1-1/+0
svn path=/trunk/; revision=48498
2013-03-02From beroset:Anders Broman1-54/+55
remove C++ incompatibilities https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=8416 svn path=/trunk/; revision=48006
2013-02-19How can I get a new tvbuff that starts at an offset within a givenGuy Harris1-1/+1
tvbuff and runs to the end of the tvbuff? Let me count the ways.... Replace a bunch of different ways of doing that (some incorrect, in that they're not properly handling tvbuffs where the captured and reported lengths are different) with tvb_new_subset_remaining(). svn path=/trunk/; revision=47751
2012-12-09Add release number to UMTS and LTE RLCPascal Quantin1-1/+1
svn path=/trunk/; revision=46486
2012-12-05Fix numerous instances of a variable/parameter name "shadowing" a library ↵Bill Meier1-13/+13
function name; (At least some (gcc ?) compilers give a "shadow" warning for these). svn path=/trunk/; revision=46402
2012-09-20We always HAVE_CONFIG_H so don't bother checking whether we have it or not.Jeff Morriss1-2/+0
svn path=/trunk/; revision=45017
2012-09-10Initial commit to support yet another method of passing data between dissectors.Jakub Zawadzki1-1/+1
Add new parameter 'data' to heur_dissector_t and new_dissector_t, for now it's always NULL svn path=/trunk/; revision=44860
2012-08-18Move deciphering routine in a function and adapt it for unacknowledged modePascal Quantin1-229/+249
svn path=/trunk/; revision=44568
2012-08-15Miscellaneous changes:Pascal Quantin1-50/+79
- move channel information before header dissection - add channel information to TM and RLC Control PDUs - take into account rlc information in rlc_is_ciphered function - update function prototypes according to the coding rules used in packet-rlc.c svn path=/trunk/; revision=44535
2012-08-14more ephemeral memory cleanupMichael Mann1-2/+1
svn path=/trunk/; revision=44496
2012-08-10From Jacob Nordgren and Rishie Sharma:Anders Broman1-21/+50
RLC: changed so reassembly fail flag is set per channel instead of globally. RLC: added reset channel function Added support for reconfigurin HSDSCH flows, and E-DCH flows (just needs to figure out when it should become active for 'overloaded' ports), also changed slightly how ehs headers are configured in nbap. Removed extra (debugging) port in nbap This is the last patch set for a while. svn path=/trunk/; revision=44423
2012-08-10From Jacob Nordgren and Rishie Sharma:Anders Broman1-39/+47
RLC: fixed weird dereferencing of things that were not pointers svn path=/trunk/; revision=44418
2012-08-09Not usre if this makes sense. At least the compiler doesn't complainMichael Tüxen1-14/+14
anymore. svn path=/trunk/; revision=44399
2012-08-09Don't define HAVE_UMTS_KASUMI to anything unless we actually have it.Jeff Morriss1-8/+9
Use #ifdef HAVE_UMTS_KASUMI instead of #if HAVE_UMTS_KASUMI Put $Id$ tag in kasumi.h svn path=/trunk/; revision=44398
2012-08-09Fix a couple of typos.Anders Broman1-4/+4
svn path=/trunk/; revision=44395
2012-08-09Small fixes:Pascal Quantin1-94/+97
- put back return NULL in line 947 that got removed in r44384: it is mandatory to avoid accessing non initialized variables. Change rlc_channel_assign a bit to fix what was the root cause of this removal (I guess) - put back add_channel_info in dissect_rlc_am (removed by error?) - fix some typo errors - fix indentation a bit svn path=/trunk/; revision=44393
2012-08-09Put #if HAVE_UMTS_KASUMI around a statics that won't be used unless itMartin Mathieson1-1/+4
is defined. svn path=/trunk/; revision=44390
2012-08-09Mark parameters as unused when we don't have kasumi.Anders Broman1-3/+4
Cast the result of strlen to int. svn path=/trunk/; revision=44388
2012-08-09From Jacob Nordgren and Rishie Sharma:Anders Broman1-1884/+2160
FP: fixed so hsdsch type 1 also uses communication context id Added experimental conditional decryption support. svn path=/trunk/; revision=44384
2012-08-07Various fixes:Pascal Quantin1-7/+24
- in UM mode, LI size boundary is at 125 bytes (regression introduced in r44292) - define RLC_LI_UPPERLAYER outside of rlc_li_size enum as it is confusing: when set in preferences it means that the dissector will use the variable, 7 bits or 15 bits LI as indicated in the rlc_info struct (so using one of the rlc_li_size enum value); it is not a new LI value - add value_string array for direction - add BCCH channel to UDP framing format - initialize p2p_dir when using UDP framing format svn path=/trunk/; revision=44318
2012-08-07From Jacob Nordgren and Rishie Sharma:Anders Broman1-25/+107
- umts_fp: fixed so CS content is not malformed content - RLC: added channel tree so you can filter on rbid etc - umts_fp,rlc,mac: added some hdsch-common code svn path=/trunk/; revision=44292
2012-08-02Fix a few issues:Pascal Quantin1-11/+17
- restore test on ciphered and deciphered variables removed in r44035: they are used by dct2000 and fp_hint dissectors - rename channel information lchid to rbid: the corresponding variable is supposed to contain a Radio Bearer Identity and not a Logical Channel Identity and was already used like this in dct2000 and fp_hint dissectors or with UDP framing protocol. Please add a new variable in rlc_info structure if the lchid is really useful - do not display channel information when the direction is unknown (useful for UDP framing protocol for ex) - add channel information to UM dissection also As a rule of thumb, please check that the changes do not break existing dissectors: UMTS RLC dissection can be configured in packet-catapult-dct2000.c, packet-fp_hint.c, through the UDP framing protocol explained in packet-rlc.h and not only in packet-umts_fp.c and packet-umts-mac.c svn path=/trunk/; revision=44223
2012-08-02Remove a created-but-unused subtree (and its ett). It's not obvious to meJeff Morriss1-4/+0
whether this tree was going to be used for something or not. svn path=/trunk/; revision=44218
2012-08-02From Jacob Nordgren and Rishie Sharma:Anders Broman1-6/+24
NBAP: fixed segfault, FP: aesthetic fix, RLC: added channel info to GUI, MAC-is: fixed case with reassembly when a middle segment arrives MAC, RLC, added preferences for LI-size and TSN-size svn path=/trunk/; revision=44205
2012-07-27Fix a few Clang warnings (dead assignment, function call argument is an ↵Pascal Quantin1-5/+4
uninitialized value) Remove misleading U-RNTI display: it is useless for RLC dissection and the variable is a placeholder used for re-assembly that can contain other identifiers than the real U-RNTI (see packet-umts_fp.c) svn path=/trunk/; revision=44070
2012-07-27From Jacob Nordgren and Rishie Sharma:Anders Broman1-0/+6
- Added basic support for tracking flows over reconfigured transport channels + mindor bugfixes - small fix in rrc, and some small cleanups svn path=/trunk/; revision=44062
2012-07-26Mark unused parameter as such.Michael Tüxen1-1/+1
svn path=/trunk/; revision=44039
2012-07-26If def offending codeAnders Broman1-0/+2
packet-rlc.c:2290:7: error: variable ‘i’ set but not used [-Werror=unused-but-set-variable] svn path=/trunk/; revision=44037
generated by cgit v1.2.3 (git 2.25.1) at 2024-06-28 10:22:36 +0000