aboutsummaryrefslogtreecommitdiffstats
path: root/epan/dissectors/packet-rlc-lte.c
AgeCommit message (Collapse)AuthorFilesLines
2015-07-24RLC LTE: fix dissection when only header is captured but full PDU length is ↵Pascal Quantin1-2/+2
reported Change-Id: I67654bb0ca30d9bb56c9a4b3be179161ecd0de3a Reviewed-on: https://code.wireshark.org/review/9776 Reviewed-by: Pascal Quantin <pascal.quantin@gmail.com>
2015-07-17Remove all preferences related to enabling/disabling heuristic dissectors.Michael Mann1-18/+2
The preferences are still supported for backwards compatibility, but the heuristic_protos file has final say on the "preference" to enable/disable a heuristic dissector. Also add parameter to heur_dissector_add() for the "default" enable/disable of a heuristic dissector. With this parameter, a few more (presumably weak) heuristic dissectors have been "registered" but of course default to being disabled. Change-Id: I51bebb2146ef3fbb8418d4f5c7f2cb2b58003a22 Reviewed-on: https://code.wireshark.org/review/9610 Petri-Dish: Michael Mann <mmann78@netscape.net> Reviewed-by: Roland Knall <rknall@gmail.com> Reviewed-by: Hadriel Kaplan <hadrielk@yahoo.com> Reviewed-by: Michael Mann <mmann78@netscape.net>
2015-07-12Add "user presentable" and "unique string ids" to heuristic table entries.Michael Mann1-1/+1
This allows better presentation of heuristic dissectors to the end user. Change-Id: I2ff3985ab914e83c2989880cc0c7b9904045b3f6 Reviewed-on: https://code.wireshark.org/review/9602 Petri-Dish: Michael Mann <mmann78@netscape.net> Reviewed-by: Michael Mann <mmann78@netscape.net>
2015-07-03Call reassembly_table_destroy and move g_hash_table_destroyPeter Wu1-19/+10
This patch moves g_hash_table_destroy calls from the init routine to the cleanup routine. Besides that, the conditional check for the hash table has been removed, assuming that init is always paired with a cleanup call. If reassembly_table_init is found, a reassembly_table_destroy call is prepended to the cleanup function as well. Comments have been removed from the init function as well as these did not seem to have additional value ("destroy hash table" is clear from the context). The changes were automatically generated using https://git.lekensteyn.nl/peter/wireshark-notes/diff/one-off/cleanup-rewrite.py?id=4d11f07180d9c115eb14bd860e9a47d82d3d1dcd Manually edited files (for assignment auditing): dvbci, ositp, sccp, tcp. Other files that needed special attention due to the use of register_postseq_cleanup_routine: - ipx: keep call, do not add another cleanup routine. - ncp: remove empty mncp_postseq_cleanup. mncp_hash_lookup is used even if a frame is visited before (see dissect_ncp_common), hence the hash table cannot be destroyed here. Do it in cleanup instead. - ndps: add cleanup routine to kill reassembly table, but do not destroy the hash table as it is already done in ndps_postseq_cleanup. Change-Id: I95a72b3df2978b2c13fefff6bd6821442193d0ed Reviewed-on: https://code.wireshark.org/review/9223 Reviewed-by: Michael Mann <mmann78@netscape.net>
2015-03-03Replace tvb_get_ptr calls with a better API choice.Michael Mann1-3/+1
Just reduces the overall tvb_get_ptr usage count in the dissector directory. Change-Id: I455dc4cc9b082ecccdd254a2e5121f3353b5a812 Reviewed-on: https://code.wireshark.org/review/7491 Reviewed-by: Anders Broman <a.broman58@gmail.com>
2014-12-23Deleting unnecessary #includes from dissectors.Martin Mathieson1-3/+0
Fourth batch (packet-mac-lte.c -> packet-rtp.c). Will look at cleaning up and committing script afterwards. Change-Id: Id921f07f4b274f0cfb77ce81abe4a285fdb8b644 Reviewed-on: https://code.wireshark.org/review/6023 Petri-Dish: Martin Mathieson <martin.r.mathieson@googlemail.com> Reviewed-by: Martin Mathieson <martin.r.mathieson@googlemail.com>
2014-12-21Cleanup use of #includes in non-generated epan/dissector/*.cBill Meier1-2/+0
Specifically: - Set packet.h to be the first wireshark #include after config.h and "system" #includes. packet.h added as an #include in some cases when missing. - Remove some #includes included (directly/indirectly) in packet.h. E.g., glib.h. (Done only for those files including packet.h). - As needed, move "system" #includes to be after config.h and before wireshark #includes. - Rework various #include file specifications for consistency. - Misc. Change-Id: Ifaa1a14b50b69fbad38ea4838a49dfe595c54c95 Reviewed-on: https://code.wireshark.org/review/5923 Petri-Dish: Alexis La Goutte <alexis.lagoutte@gmail.com> Reviewed-by: Bill Meier <wmeier@newsguy.com>
2014-12-09LTE: Update MAC and RLC dissectors to Release 12Pascal Quantin1-30/+152
Change-Id: I036a0d1180b6481e8cc27210ed44eda4ba078a27 Reviewed-on: https://code.wireshark.org/review/5659 Reviewed-by: Martin Mathieson <martin.r.mathieson@googlemail.com> Petri-Dish: Alexis La Goutte <alexis.lagoutte@gmail.com> Reviewed-by: Pascal Quantin <pascal.quantin@gmail.com>
2014-09-09Eliminate proto_tree_add_text from some of the dissectors.Michael Mann1-3/+3
Other minor cleanups while in the area. Change-Id: I99096ade9c69a4c148962d45bb6b0bd775040ba1 Reviewed-on: https://code.wireshark.org/review/4020 Petri-Dish: Michael Mann <mmann78@netscape.net> Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org> Reviewed-by: Michael Mann <mmann78@netscape.net>
2014-08-15(Minor) add editor-modelines; Adjust whitespace as needed.Bill Meier1-7/+20
Change-Id: Ife2ec66c7985149d3e31e96e9eade3903d235cc4 Reviewed-on: https://code.wireshark.org/review/3617 Reviewed-by: Bill Meier <wmeier@newsguy.com>
2014-06-12Fix a regression, as -1 can no longer means until the end of the tvbMartin Mathieson1-2/+2
Change-Id: I2bbb9c5f62984f0365a3cad6b60401ee70418e74 Reviewed-on: https://code.wireshark.org/review/2158 Reviewed-by: Martin Mathieson <martin.r.mathieson@googlemail.com>
2014-06-07tvb_new_subset -> tvb_new_subset_length when length parameters are equal.Michael Mann1-3/+3
tvb_new_subset -> tvb_new_subset_remaining it appears that's what the intention is. Change-Id: I2334bbf3f10475b3c22391392fc8b6864454de2d Reviewed-on: https://code.wireshark.org/review/1999 Reviewed-by: Pascal Quantin <pascal.quantin@gmail.com>
2014-06-05When have more than one SDU in the same RLC PDU, make sure output from all ↵Martin Mathieson1-0/+8
of them stays in the INFO column Change-Id: I7b2555101f3a1a596a4108a13240d21786054671 Reviewed-on: https://code.wireshark.org/review/1985 Reviewed-by: Martin Mathieson <martin.r.mathieson@googlemail.com>
2014-05-05MAC/RLC/PDCP LTE: replace obsolete APIsPascal Quantin1-14/+14
Change-Id: I5368cc7b1986c6a87cb70a3fd3cb5e589d73f870 Reviewed-on: https://code.wireshark.org/review/1520 Reviewed-by: Martin Mathieson <martin.r.mathieson@googlemail.com>
2014-04-27Change preference default to use RRC-signalled value for SN field length of ↵Martin Mathieson1-1/+1
DRBs. Change-Id: Ibc56c901938f490f1fb0fede7e2fe0fbfc659250 Reviewed-on: https://code.wireshark.org/review/1402 Reviewed-by: Martin Mathieson <martin.r.mathieson@googlemail.com>
2014-03-04Remove all $Id$ from top of fileAlexis La Goutte1-2/+0
(Using sed : sed -i '/^ \* \$Id\$/,+1 d') Fix manually some typo (in export_object_dicom.c and crc16-plain.c) Change-Id: I4c1ae68d1c4afeace8cb195b53c715cf9e1227a8 Reviewed-on: https://code.wireshark.org/review/497 Reviewed-by: Anders Broman <a.broman58@gmail.com>
2014-02-25Remove trailing whitespace.Bill Meier1-1/+1
Change-Id: Ia03a1cd4590aceda30ead4aa93ad413d90c6aea6 Reviewed-on: https://code.wireshark.org/review/372 Reviewed-by: Bill Meier <wmeier@newsguy.com> Tested-by: Bill Meier <wmeier@newsguy.com>
2014-01-10Move UEId to the beginning of summary shown in info column, plus only look ↵Martin Mathieson1-7/+8
for existing reassembly info when not starting a new SDU svn path=/trunk/; revision=54691
2013-12-12- Forward declaration of register functions.Anders Broman1-0/+3
svn path=/trunk/; revision=53963
2013-11-23Create the ability to have packet scoped "proto" data. Bug 9470 ↵Michael Mann1-12/+12
(https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=9470) I'm not sold on the name or module the proto_data functions live in, but I believe the function arguments are solid and gives us the most flexibility for the future. And search/replace of a function name is easy enough to do. The big driving force for getting this in sooner rather than later is the saved memory on ethernet packets (and IP packets soon), that used to have file_scope() proto data when all it needed was packet_scope() data (technically packet_info->pool scoped), strictly for Decode As. All dissectors that use p_add_proto_data() only for Decode As functionality have been converted to using packet_scope(). All other dissectors were converted to using file_scope() which was the original scope for "proto" data. svn path=/trunk/; revision=53520
2013-11-22Tweak filter names for expert items, mostly to consistently use - rather than _Martin Mathieson1-15/+16
svn path=/trunk/; revision=53514
2013-11-11Include rohc struct inside pdcp instead of repeating all of the fieldsMartin Mathieson1-1/+1
svn path=/trunk/; revision=53262
2013-11-10Add missing includes in order to remove exceptions.h from proto.h (next commit).Jakub Zawadzki1-0/+1
svn path=/trunk/; revision=53230
2013-11-04Don't show the channel information twice in the protocol root proto_itemMartin Mathieson1-12/+2
svn path=/trunk/; revision=53077
2013-09-09expert_add_info_format_text -> expert_add_info_formatMichael Mann1-21/+21
svn path=/trunk/; revision=51852
2013-09-05Batch of filterable expert info.Michael Mann1-36/+81
Some of the FT_NONE hf_ variables were removed in favor of proto_tree_add_expert. It may also be possible to remove some of the booleans surrounding the expert info. New expert display filters may need to be double-checked to make sure they make sense. svn path=/trunk/; revision=51760
2013-08-30Convert a few dissectors from EMEM to WMEM APIPascal Quantin1-13/+14
svn path=/trunk/; revision=51597
2013-08-19Do not use ephemeral memory when adding a new data sourcePascal Quantin1-1/+2
svn path=/trunk/; revision=51423
2013-07-28Align info column for UM MCCH/MTCH PDUsPascal Quantin1-1/+6
svn path=/trunk/; revision=50976
2013-07-26Fix Frame Indicator analysis logicPascal Quantin1-41/+47
svn path=/trunk/; revision=50920
2013-07-26Align info column for AM/UM/TM PDUsPascal Quantin1-2/+2
svn path=/trunk/; revision=50910
2013-07-26Add Channel ID to MTCH PDUsPascal Quantin1-1/+2
svn path=/trunk/; revision=50909
2013-07-25Add a smarter UM analysis for MCCH/MTCH channelsPascal Quantin1-1/+9
svn path=/trunk/; revision=50891
2013-07-16Allow to perform sequence analysis when only RLC headers are loggedPascal Quantin1-9/+11
svn path=/trunk/; revision=50663
2013-07-03Clear info column when using UDP framingPascal Quantin1-2/+12
svn path=/trunk/; revision=50373
2013-06-17Apply r49983 to other dissectorsPascal Quantin1-1/+1
svn path=/trunk/; revision=49984
2013-05-12Add the posibillity to use a key for per-packet-data.Anders Broman1-12/+12
svn path=/trunk/; revision=49259
2013-05-06Don't throw away UM re-assembly state when see MAC retx frame.Martin Mathieson1-2/+5
svn path=/trunk/; revision=49188
2013-04-01Typo's. That is all.Jaap Keuter1-4/+4
svn path=/trunk/; revision=48685
2013-03-16From beroset:Anders Broman1-19/+19
remove C++ incompatibilities https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=8416 svn path=/trunk/; revision=48337
2013-02-26it's ==> its & its ==> it's as needed.Bill Meier1-1/+1
svn path=/trunk/; revision=47891
2013-02-19How can I get a new tvbuff that starts at an offset within a givenGuy Harris1-2/+2
tvbuff and runs to the end of the tvbuff? Let me count the ways.... Replace a bunch of different ways of doing that (some incorrect, in that they're not properly handling tvbuffs where the captured and reported lengths are different) with tvb_new_subset_remaining(). svn path=/trunk/; revision=47751
2013-02-16Set more preferences to be on by default.Martin Mathieson1-8/+9
svn path=/trunk/; revision=47689
2013-01-04replace "unsigned" datatype with "guint". Some mpeg files needed "unsigned ↵Michael Mann1-9/+9
int" instead. bugs 7825-7827 (https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=7825) svn path=/trunk/; revision=46928
2012-12-16Fix some clang warnings.Martin Mathieson1-4/+4
svn path=/trunk/; revision=46549
2012-12-11Dissect eMBMS MTCH LCIDsPascal Quantin1-3/+38
svn path=/trunk/; revision=46504
2012-12-09Add release number to UMTS and LTE RLCPascal Quantin1-1/+1
svn path=/trunk/; revision=46486
2012-11-29Add versions of a function that doesn't need do substitute specifiers.Martin Mathieson1-6/+21
svn path=/trunk/; revision=46298
2012-11-29Make all enum_val_t's const.Jeff Morriss1-3/+3
svn path=/trunk/; revision=46292
2012-11-17Add channel type & ID to sequence analysis expert item strings.Martin Mathieson1-33/+63
Also simplify a hash function - haven't measured collisions, but before change sometimes wrong results would get attached. Don't think I fixed it, and don't understand how equality function could have matched even if hash function were colliding... svn path=/trunk/; revision=46063
generated by cgit v1.2.3 (git 2.25.1) at 2024-07-02 05:54:06 +0000