aboutsummaryrefslogtreecommitdiffstats
path: root/epan/dissectors/packet-reload-framing.c
AgeCommit message (Collapse)AuthorFilesLines
2014-03-19Exported PDU: add support for data length on the wirePascal Quantin1-2/+3
Change-Id: Iff14ec4d0297ec85f3597b33871fb0ab5256a597 Reviewed-on: https://code.wireshark.org/review/728 Reviewed-by: Anders Broman <a.broman58@gmail.com>
2014-03-17Revert "Try to make the heuristic a bit more efficient."Bill Meier1-5/+5
(based upon an OK from Anders). (The commit caused 'reload_framing_info' to be referenced before being set). This reverts commit b3ce4ecc1460fc0171d65e69549e155b447d851a. svn path=/trunk/; revision=52004 Change-Id: If715e1cad041fd832f460411cc652d9b5764d069 Reviewed-on: https://code.wireshark.org/review/718 Reviewed-by: Bill Meier <wmeier@newsguy.com> Tested-by: Bill Meier <wmeier@newsguy.com>
2014-03-04Remove all $Id$ from top of fileAlexis La Goutte1-2/+0
(Using sed : sed -i '/^ \* \$Id\$/,+1 d') Fix manually some typo (in export_object_dicom.c and crc16-plain.c) Change-Id: I4c1ae68d1c4afeace8cb195b53c715cf9e1227a8 Reviewed-on: https://code.wireshark.org/review/497 Reviewed-by: Anders Broman <a.broman58@gmail.com>
2013-12-12- Forward declaration of register functions.Anders Broman1-0/+3
svn path=/trunk/; revision=53963
2013-11-09Add data parameter to tcp_dissect_pdus() as well as convert it to using ↵Michael Mann1-13/+8
"new" style dissectors. Now that "bytes consumed" can be determined, should tcp_dissect_pdus() take advantage of that? Should tcp_dissect_pdus return length (bytes consumed)? There are many dissectors that just call tcp_dissect_pdus() then return tvb_length(tvb). Seems like that could all be rolled into one. svn path=/trunk/; revision=53198
2013-10-14Try to pptimize heuristics slightly.Anders Broman1-4/+4
svn path=/trunk/; revision=52603
2013-10-13whitespace fixes; mostly: remove trailing blanksBill Meier1-1/+1
svn path=/trunk/; revision=52591
2013-09-13Try to make the heuristic a bit more efficient.Anders Broman1-5/+5
svn path=/trunk/; revision=52004
2013-08-31Convert another 10 dissectors to wmem.Evan Huus1-11/+11
svn path=/trunk/; revision=51612
2013-06-18Add ability to export decrypted SSL/DTLS PDUsPascal Quantin1-5/+37
svn path=/trunk/; revision=50001
2013-05-27Batch of filterable expert infosMichael Mann1-1/+10
svn path=/trunk/; revision=49600
2013-03-18From beroset:Anders Broman1-8/+8
remove C++ incompatibilities https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=8416 svn path=/trunk/; revision=48409
2012-12-26Fix a bunch of warnings.Guy Harris1-2/+2
Cast away some implicit 64-bit-to-32-bit conversion errors due to use of sizeof. Cast away some implicit 64-bit-to-32-bit conversion errors due to use of strtol() and strtoul(). Change some data types to avoid those implicit conversion warnings. When assigning a constant to a float, make sure the constant isn't a double, by appending "f" to the constant. Constify a bunch of variables, parameters, and return values to eliminate warnings due to strings being given const qualifiers. Cast away those warnings in some cases where an API we don't control forces us to do so. Enable a bunch of additional warnings by default. Note why at least some of the other warnings aren't enabled. randpkt.c and text2pcap.c are used to build programs, so they don't need to be in EXTRA_DIST. If the user specifies --enable-warnings-as-errors, add -Werror *even if the user specified --enable-extra-gcc-flags; assume they know what they're doing and are willing to have the compile fail due to the extra GCC warnings being treated as errors. svn path=/trunk/; revision=46748
2012-12-05Fix numerous instances of a variable/parameter name "shadowing" a library ↵Bill Meier1-23/+23
function name; (At least some (gcc ?) compilers give a "shadow" warning for these). svn path=/trunk/; revision=46402
2012-12-03Fix 2 bugs in heuristic tests which resulted in various false positives;Bill Meier1-12/+17
I believe this fix addresses the remaining issues for Bug #6047. https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=6047 Also: - Fix {-Wshadow] warning; - Use tvb_get_ntoh24() in 2 places; - Add ToDo comment about a TCP reassembly issue. svn path=/trunk/; revision=46338
2012-09-20We always HAVE_CONFIG_H so don't bother checking whether we have it or not.Jeff Morriss1-3/+1
svn path=/trunk/; revision=45017
2012-09-11Add data parameter to call_dissector_only.Jakub Zawadzki1-1/+1
svn path=/trunk/; revision=44872
2012-09-10Initial commit to support yet another method of passing data between dissectors.Jakub Zawadzki1-2/+2
Add new parameter 'data' to heur_dissector_t and new_dissector_t, for now it's always NULL svn path=/trunk/; revision=44860
2012-08-16Add editor modelines;Bill Meier1-33/+45
Do minor whitespace reformatting. svn path=/trunk/; revision=44539
2012-08-10Use val_to_str_const() where appropriate;Bill Meier1-2/+2
Also (for a few files): - create/use some extended value strings; - remove unneeded #include files; - remove unneeded variable initialization; - re-order fcns slightly so prefs_reg_handoff...() at end, etc svn path=/trunk/; revision=44438
2012-07-21Fix mis-allocated key size as caught by valgrind.Evan Huus1-6/+11
We have to divide the 'length' field to work with guint32 pointer arithmetic, but we still want to allocate and memcpy the original length value, since both of those operate in raw bytes, not blocks of sizeof(guint32). svn path=/trunk/; revision=43901
2012-07-21The se_tree_* functions are destructive to the key, so save and restoreEvan Huus1-0/+11
the key around each call. Fixes part of https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=7509 svn path=/trunk/; revision=43898
2012-07-21The 32-bit-key tree code assumes that the pointer to the key can be castGuy Harris1-2/+5
to a pointer to a guint32 and dereferenced. On some platforms, such as SPARC, this requires that the pointer be aligned on a 4-byte boundary; there is no guarantee that the data field of an address structure is aligned on a 4-byte boundary, so allocate a buffer for a copy of that data and copy the data into it, and free it when we're done with it. Should fix bug 7501. svn path=/trunk/; revision=43880
2012-06-28Update FSF address - part II.Jakub Zawadzki1-1/+1
svn path=/trunk/; revision=43538
2011-10-21For proto_tree_add_item(..., proto_xxx, ...)use ENC_NA as the encoding arg.Bill Meier1-1/+1
Also: remove trailing whitespace for a number of files. svn path=/trunk/; revision=39503
2011-10-06From Stéphane Bryant: improvements in RELOAD dissectionBill Meier1-58/+186
- Follow closely draft-ietf-p2psip-base-18 - Added support for draft-ietf-p2psip-base-18, draft-ietf-p2psip-sip-06, draft-ietf-p2psip-service-discovery-03, draft-ietf-p2psip-self-tuning-04, draft-ietf-p2psip-diagnostics-06, draft-zong-p2psip-drr-00, - Handoff to the xml dissectors for configuration data - export the message content dissection function in the new packet-reload.h file for use in related protocols (draft-hautakorpi-p2psip-with-hip-01) https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=6317 From me: - Fix a few C++ style comments; - Fix: packet-reload.c(2156) ... conversion from 'guint64' to 'guint32', possible loss of data packet-reload.c(3528) ... conversion from 'guint64' to 'guint32', possible loss of data Note: Additional fix yet req'd since checkhf.pl gives: ERROR: NO ARRAY: packet-reload.c, hf_reload_dmflag_underlay_hop Unused entry: packet-reload.c, hf_reload_storeddata_signature Unused entry: packet-reload.c, hf_reload_storeddataspecifiers (Compile is OK). svn path=/trunk/; revision=39301
2011-10-06Convert 'encoding' parameter of certain proto_tree_add_item() calls in ↵Bill Meier1-5/+5
non-autogenerated epan/dissectors: Specifically: Replace FALSE|0 and TRUE|1 by ENC_BIG_ENDIAN|ENC_LITTLE_ENDIAN as the encoding parameter for proto_tree_add_item() calls which directly reference an item in hf[] which has a type of: FT_UINT8 FT_UINT16 FT_UINT24 FT_UINT32 FT_UINT64 FT_INT8 FT_INT16 FT_INT24 FT_INT32 FT_INT64 FT_FLOAT FT_DOUBLE svn path=/trunk/; revision=39288
2011-06-09Only count an ACK if it's part of an existing conversation, otherwise weGerald Combs1-3/+8
get a lot of false positives. svn path=/trunk/; revision=37631
2011-05-29- Added new SignatureIdentity values.Anders Broman1-1/+1
From Marc Petit-Huguenin: - Removed directResponseForwarding. - The certificate_type enum is now defined as RFC 6091's CertificateType so moved the definition to packet-ssl-utils.[ch]. - Fixed invalid values for CERTIFICATE_BY_NODE and CERTIFICATE_BY_USER Kinds. https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=5967 svn path=/trunk/; revision=37452
2011-05-13From Michael Chen via https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=5863 :Jeff Morriss1-7/+4
1. Reload framing protocol no longer encapsulates the Reload message, instead the latter is in its own tree following Reload framing, much like IP, UDP, etc. 2. Similarly, DTLS no longer encapsulates its data payload if the payload can be dissected. The recognized payload is in its own tree following the DTLS, much like IP, UDP, etc. 4. DTLS now has its own heuristic table for dissecting its payload, and reload-framing is added to this DTLS heuristic table. 6. DTLS will try to dissect its payload if the agreed upon cipher is RSA-NULL-MD5 (0x0001) or RSA-NULL-SHA (0x0002), even when DTLS is not configured with the client/server private keys. Still to do: make DTLS a heuristic dissector on top of UDP (item 3 in the bug). svn path=/trunk/; revision=37110
2011-05-06From Marc Petit-Huguenin via ↵Jeff Morriss1-37/+37
https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=5894 : - Use "RELOAD" everywhere. - Fix invalid variable name "reload_framing.probe_information.type". - Fix various names to match the spec. - Dissect the X.509 certificate embedded in RELOAD messages. - Use tls_signature_algorithm and tls_hash_algorithm tables in packet-ssl-utils. From me: take out the tabs. Keep the long dissector name when registering the protocols. svn path=/trunk/; revision=37003
2011-03-28From Stephane Bryant via ↵Jeff Morriss1-0/+3
https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=5787 : Register the reload-framing dissector by name. Needed when RELOAD is not used over udp/tcp (but tls, for example) svn path=/trunk/; revision=36380
2011-03-27Fix Coverity 393: "DEADCODE"; Add an XXX commentBill Meier1-2/+2
svn path=/trunk/; revision=36373
2011-03-22Allocate correct size of reload_frame.Stig Bjørlykke1-1/+1
Coverity 714. svn path=/trunk/; revision=36263
2010-12-20Rename the routines that handle dissector tables with unsigned integerGuy Harris1-2/+2
keys to have _uint in their names, to match the routines that handle dissector tables with string keys. (Using _port can confuse people into thinking they're intended solely for use with TCP/UDP/etc. ports when, in fact, they work better for things such as Ethernet types, where the binding of particular values to particular protocols are a lot stronger.) svn path=/trunk/; revision=35224
2010-11-24Tighten the heuristic.Anders Broman1-12/+25
svn path=/trunk/; revision=35020
2010-11-22From Stephane Bryant via ↵Jeff Morriss1-0/+403
https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=5358 : This is a dissector for reload framed message: ReLOAD packets can be inserted in frame message, as described in draft-ietf-p2psip-base-10 From me: remove some unnecessary includes. svn path=/trunk/; revision=35005