aboutsummaryrefslogtreecommitdiffstats
path: root/epan/dissectors/packet-rdp.c
AgeCommit message (Collapse)AuthorFilesLines
2014-03-04Remove all $Id$ from top of fileAlexis La Goutte1-2/+0
(Using sed : sed -i '/^ \* \$Id\$/,+1 d') Fix manually some typo (in export_object_dicom.c and crc16-plain.c) Change-Id: I4c1ae68d1c4afeace8cb195b53c715cf9e1227a8 Reviewed-on: https://code.wireshark.org/review/497 Reviewed-by: Anders Broman <a.broman58@gmail.com>
2013-12-18initialize info_flags, fix compile errorMartin Kaiser1-1/+1
svn path=/trunk/; revision=54237
2013-12-18Use FT_STRING for string-valued fields.Guy Harris1-69/+85
Have RDP_FI_STRING set for all string-valued fields, with: RDP_FI_UNICODE set if the string is always "Unicode" (assumed to be UTF-16-encoded); RDP_FI_ANSI set if the string is always "ANSI" (we should try to use the code page indication); neither set if the string is "Unicode" or "ANSI" depending on the INFO_UNICODE flag in the packet (the only strings that work that way are in TS_INFO_PACKET or TS_EXTENDED_INFO_PACKET packets, which also have the flags field with INFO_UNICODE). Use proto_tree_add_item() to add the string items. While we're at it, pull the code to get conversation data, creating it if necessary, into a routine. svn path=/trunk/; revision=54235
2013-12-14rdp_field_info_t struct: Pass pointer to hfJakub Zawadzki1-233/+233
This should fix most of errors: warning: initializer element is not computable at load time [enabled by default] svn path=/trunk/; revision=54090
2013-12-13Fix [-Wmissing-prototypes]Anders Broman1-0/+3
svn path=/trunk/; revision=54025
2013-12-13Fix 4 instances of Visual Studio Code Analysis warnings C6001: Using ↵Chris Maynard1-4/+4
uninitialized memory 'pduType2', 'numberCapabilities' (2x), and 'pduType' svn path=/trunk/; revision=54013
2013-09-22emem -> wmem conversion:Pascal Quantin1-2/+2
- ep_tvb_get_bits() -> wmem_packet_tvb_get_bits() - tvb_g_memdup()/ep_tvb_memdup() -> tvb_memdup() - tvb_fake_unicode()/tvb_get_ephemeral_faked_unicode() -> tvb_get_faked_unicode() - tvb_get_g_string()/tvb_get_ephemeral_string()/tvb_get_seasonal_string() -> tvb_get_string() - tvb_get_g_unicode_string()/tvb_get_ephemeral_unicode_string() -> tvb_get_unicode_string() - tvb_get_ephemeral_string_enc() -> tvb_get_string_enc() - update docs accordingly svn path=/trunk/; revision=52172
2013-09-15emem -> wmemJörg Mayer1-2/+3
svn path=/trunk/; revision=52069
2013-03-19From beroset:Anders Broman1-5/+5
remove C++ incompatibilities https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=8416 svn path=/trunk/; revision=48430
2013-01-31Use '#if 0 ... #endif' rather than /** ... **/ to comment outBill Meier1-8/+8
unused hf[] entries (which I should have done in the first place). svn path=/trunk/; revision=47390
2013-01-26Initialize some hf_... vars to -1;Bill Meier1-1/+1
(Reduces the number of checkhf false positives) svn path=/trunk/; revision=47310
2013-01-26Comment out cases of unused hf array entries found by checkhf.Bill Meier1-4/+12
svn path=/trunk/; revision=47302
2012-11-23Improve dissection;Bill Meier1-300/+239
- Properly handle DataBlocks with optional fields at end; - Fix a few field dissections; General code cleanup; - Remove almost all tests using tvb_length_remaining(): If there's not enough data available, just let an exception be thrown. - Fix a memory leak; - Simplify code in various places. - Add a reference to the (a ?) Microsoft spec for RDP. Fixes Bug #7862 in a more complete manner than SVN #45566. svn path=/trunk/; revision=46158
2012-10-15(try to) fix https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=7862Martin Kaiser1-2/+8
tvb_length_remaining() may return -1 if that happens in dissect_rdp_fields(), return an error the caller that calls dissect_rdp_fields() from a for loop detects the error and exits (others should handle the error as well, this is missing for now) svn path=/trunk/; revision=45566
2012-09-20We always HAVE_CONFIG_H so don't bother checking whether we have it or not.Jeff Morriss1-3/+1
svn path=/trunk/; revision=45017
2012-08-10Use val_to_str_const() where appropriate;Bill Meier1-6/+6
Also (for a few files): - create/use some extended value strings; - remove unneeded #include files; - remove unneeded variable initialization; - re-order fcns slightly so prefs_reg_handoff...() at end, etc svn path=/trunk/; revision=44438
2012-07-09From Evan Huus:Anders Broman1-11/+1
Grab-bag of unused variables. https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=7452 svn path=/trunk/; revision=43616
2012-06-28Update Free Software Foundation address.Jakub Zawadzki1-1/+1
(COPYING will be updated in next commit) svn path=/trunk/; revision=43536
2012-05-12General cleanup:Bill Meier1-397/+395
- Fix two minor bugs which resulted in missing entries in packet details pane; - Remove packet-rdp.h: It's not used elsewhere; - Define 3 global fcns as static: they're only referenced within packet-rdp.c;; - Localize some variable definitions & remove uneeded variable initializations; - ... - Fix whitespace and indentation. svn path=/trunk/; revision=42605
2012-05-10Get rid of remaining Booleans-as-encoding-arguments inGuy Harris1-7/+13
proto_tree_add_item() calls. This involves marking string fields as special. XXX - we need ENC_UTF_16 so that we can make the Unicode strings just be FT_STRING and add them with ENC_UTF_16|ENC_LITTLE_ENDIAN. svn path=/trunk/; revision=42536
2012-04-04Fix CID 1287: rdp_info can't be NULL here so there's no need to check for itJeff Morriss1-6/+4
being NULL. svn path=/trunk/; revision=41929
2012-03-31Fix off by one shift errors introduced in r39530 where it seemed proper[1]Jakub Zawadzki1-1/+1
[1] I'm unsure of packet-dtpt, so I haven't patch it. svn path=/trunk/; revision=41873
2011-12-28min() -> MIN().Chris Maynard1-2/+2
svn path=/trunk/; revision=40313
2011-12-28Fix memory leaks involving tvb_get_string[z]().Chris Maynard1-6/+6
svn path=/trunk/; revision=40312
2011-11-27Various Minor cleanup:Bill Meier1-1/+0
- Remove unneeded #includes; - Use val_to_str_const() in several places; - Reformat long lines; - Fix whitepace and indentation. svn path=/trunk/; revision=40016
2011-11-19Revert 39946Anders Broman1-5/+4
svn path=/trunk/; revision=39947
2011-11-19See if this fixes "warning: initializer element is not computable at load time"Anders Broman1-4/+5
svn path=/trunk/; revision=39946
2011-10-30Clang Cat is watching you fail to check for a null pointer.Guy Harris1-2/+4
svn path=/trunk/; revision=39668
2011-10-23Replace use of tvb_get_ephemeral_faked_unicode() by use of ↵Bill Meier1-1/+1
tvb_get_ephemeral_unicode_string(); Fix encoding arg as needed. svn path=/trunk/; revision=39530
2011-10-23(Trivial) Whitespace cleanup.Bill Meier1-11/+11
svn path=/trunk/; revision=39513
2011-10-21For proto_tree_add_item(..., proto_xxx, ...)use ENC_NA as the encoding arg.Bill Meier1-1/+1
Also: remove trailing whitespace for a number of files. svn path=/trunk/; revision=39503
2011-10-04Use ENC_NA as encoding for proto_tree_add_item() calls which directly ↵Bill Meier1-17/+17
reference an hf item (in hf[] with types: FT_NONE FT_BYTES FT_IPV6 FT_IPXNET FT_OID Note: Encoding field set to ENC_NA only if the field was previously TRUE|FALSE|ENC_LITTLE_ENDIAN|ENC_BIG_ENDIAN svn path=/trunk/; revision=39260
2011-09-25Fix a compile error.Bill Meier1-1/+1
svn path=/trunk/; revision=39130
2011-09-25Minor cleanup:Bill Meier1-33/+34
- Fix two cases of "set but unused" as reported by GCC 4.6; - remove _U_ from parameters which are actually used; - printf --> REPORT_DISSECTOR_BUG; - define a function as static; svn path=/trunk/; revision=39129
2011-09-25Bug 6369: Graeme Lunt1-1/+2
Unprotected array write. svn path=/trunk/; revision=39125
2011-09-21(Trivial) Remove trailing whitespace from lines for a few files.Bill Meier1-97/+97
svn path=/trunk/; revision=39084
2011-09-21Basic RDP dissection, which can dissect the connection sequence. Graeme Lunt1-0/+2848
A work in progress. Can be used with the SSL dissector to decrypt Enhanced RDP Security SSL. With Standard RDP Security (e.g those on Wiki), the PDUs are all encrypted after the SecurityExchange PDU. Wiki to be updated with an example SSL protected capture and associated key material. svn path=/trunk/; revision=39066