aboutsummaryrefslogtreecommitdiffstats
path: root/epan/dissectors/packet-radius.c
AgeCommit message (Collapse)AuthorFilesLines
2019-01-01Add a "failed" return for tap packet routines.Guy Harris1-3/+3
This allows taps that can fail to report an error and fail; a failed tap's packet routine won't be called again, so they don't have to keep track of whether they've failed themselves. We make the return value from the packet routine an enum. Don't have a separate type for the per-packet routine for "follow" taps; they're expected to act like tap packet routines, so just use the type for tap packet routines. One tap packet routine returned -1; that's not a valid return value, and wasn't one before this change (the return value was a boolean), so presume the intent was "don't redraw". Another tap routine's early return, without doing any work, returned TRUE; this is presumably an error (no work done, no need to redraw), so presumably it should be "don't redraw". Clean up some white space while we're at it. Change-Id: Ia7d2b717b2cace4b13c2b886e699aa4d79cc82c8 Reviewed-on: https://code.wireshark.org/review/31283 Reviewed-by: Guy Harris <guy@alum.mit.edu>
2018-09-05Radius: Fix offset for multiple VSA in one AVPUli Heilmeier1-2/+3
When there are multiple VSAs in one AVP we should forward the vendor_offset. The length field includes the type field therefore we have to subtract it. Bug: 15073 Change-Id: If365ebca493208d67b3283fe876d2d1b0bda64af Reviewed-on: https://code.wireshark.org/review/29421 Petri-Dish: Alexis La Goutte <alexis.lagoutte@gmail.com> Tested-by: Petri Dish Buildbot Reviewed-by: Alexis La Goutte <alexis.lagoutte@gmail.com>
2018-05-17radius: fix memleaks in dissect_attribute_value_pairsPeter Wu1-8/+16
CLEANUP_PUSH_PFX with "eap_buffer" and "vsa_buffer_table" was ineffective because these pointers are initially NULL. Bug: 14429 Change-Id: I5e6c457df714543bd384f93cdfa012f6122f9aa9 Link: https://bugs.chromium.org/p/oss-fuzz/issues/detail?id=6279 Reviewed-on: https://code.wireshark.org/review/27537 Petri-Dish: Peter Wu <peter@lekensteyn.nl> Tested-by: Petri Dish Buildbot Reviewed-by: Peter Wu <peter@lekensteyn.nl>
2018-05-17radius: fix issue found by PVS Studio (V519)Alexis La Goutte1-2/+0
The 'rad_info->code' variable is assigned values twice successively. The 'rad_info->ident' variable is assigned values twice successively Change-Id: I53140ee84c053b3950d13c577a3c98479149aa00 Reviewed-on: https://code.wireshark.org/review/27596 Reviewed-by: Anders Broman <a.broman58@gmail.com>
2018-02-12dissectors: use SPDX identifiers.Dario Lombardo1-13/+1
Change-Id: I92c94448e6641716d03158a5f332c8b53709423a Reviewed-on: https://code.wireshark.org/review/25756 Petri-Dish: Dario Lombardo <lomato@gmail.com> Reviewed-by: Anders Broman <a.broman58@gmail.com>
2017-10-29Add conversation endpoint typeMichael Mann1-3/+3
For the moment this mirrors the port_type enumeration (PT_XXX), but the intent is to move away from using "port types", eliminating most (if not all) Added conversation_pt_to_endpoint_type() so that conversations deal with the correct enumeration. This is for dissector that use pinfo->ptype as input to conversation APIs. Explicit use of port types are converted to using ENDPOINT_XXX type. Change-Id: Ia0bf553a3943b702c921f185407e03ce93ebf0ef Reviewed-on: https://code.wireshark.org/review/24166 Petri-Dish: Michael Mann <mmann78@netscape.net> Tested-by: Petri Dish Buildbot Reviewed-by: Michael Mann <mmann78@netscape.net>
2017-10-26Add a ws_in6_addr typedef for struct e_in6_addr.Guy Harris1-1/+1
That allows a parallel typedef of ws_in4_addr for guint32. Change-Id: I03b230247065e0e3840eb87635315a8e523ef562 Reviewed-on: https://code.wireshark.org/review/24073 Reviewed-by: Guy Harris <guy@alum.mit.edu>
2017-09-28radius: display in same fashion as DiameterJoakim Karlsson1-14/+15
* Change order to display AVP name/type first * Added "val=" before value * Added "vnd=" before vendor Change-Id: Iabafa6de5bc4b77dfa475cba390bc5c99da71d3f Reviewed-on: https://code.wireshark.org/review/23760 Petri-Dish: Anders Broman <a.broman58@gmail.com> Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org> Reviewed-by: Anders Broman <a.broman58@gmail.com>
2017-09-07RADIUS: Use two dictionaries (personal + system)João Valverde1-26/+25
Instead of choosing one or the other. Ping-Bug: 6466 Change-Id: Ia95b79190d12ad0fa8af06a12743f042f73a7602 Reviewed-on: https://code.wireshark.org/review/23029 Petri-Dish: Alexis La Goutte <alexis.lagoutte@gmail.com> Petri-Dish: João Valverde <j@v6e.pt> Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org> Reviewed-by: João Valverde <j@v6e.pt>
2017-08-23RADIUS: Add comment for RFC 6929 preferenceJoão Valverde1-0/+4
Change-Id: I084923204cd1017f9e50052b41106ab44dc9b1af Reviewed-on: https://code.wireshark.org/review/23176 Petri-Dish: Anders Broman <a.broman58@gmail.com> Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org> Reviewed-by: Anders Broman <a.broman58@gmail.com>
2017-08-16RADIUS: Remove some shortcuts in how we handle Ascend-Data-FilterJoão Valverde1-21/+24
Do it via type "abinary" like the comment suggests. Note: VSA "abinary" code path untested. Ping-Bug: 11630 Change-Id: Ie8ebbb2fdbc9f04faad40150652277f1396ea030 Reviewed-on: https://code.wireshark.org/review/22973 Petri-Dish: Alexis La Goutte <alexis.lagoutte@gmail.com> Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org> Reviewed-by: Anders Broman <a.broman58@gmail.com>
2017-08-16RADIUS: Add preference to disable RFC 6929 extended attributesJoão Valverde1-0/+9
This is an ugly workaround for the fact that attributes 241-246 are currently hardcoded as extended type. This is to restore previous functionality to dissect some Ascend AVPs that shouldn't be using the IANA allocation space. Ping-Bug: 11630 Change-Id: I6bebefd21fe5149f5f57b3280c9992a0eca85e62 Reviewed-on: https://code.wireshark.org/review/22972 Petri-Dish: Alexis La Goutte <alexis.lagoutte@gmail.com> Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org> Reviewed-by: Anders Broman <a.broman58@gmail.com>
2017-08-13RADIUS: Initialize vendor attribute type to zeroJoão Valverde1-0/+1
Change-Id: Ic43363d93f6d573ddb8d3de3e0bd62624124d104 Reviewed-on: https://code.wireshark.org/review/23064 Reviewed-by: João Valverde <j@v6e.pt>
2017-08-07RADIUS: Minor cleanupJoão Valverde1-11/+11
Have "avp_is_extended" fully control extended attribute properties. including "long-extended". Change-Id: I73b3636b08fe088b7dc4113b1b4144a97bc59efa Reviewed-on: https://code.wireshark.org/review/22989 Reviewed-by: João Valverde <j@v6e.pt>
2017-06-26Parse enterprise-numbers at run timeJoão Valverde1-3/+3
"enterprise-numbers" is converted to tab-separated values and renamed "enterprises". Unused fields are stripped. PENs are stored in a hash table loaded at run-time. User "enterprises" file is loaded from the personal config dir. Misc make-sminmpec.pl improvements and fixes. Note: names of type "Entity (formerly ...)" have the formerly part commented out for a cleaner output. Change-Id: I60c533afbe3e399077fbf432088064471ad3e1e2 Reviewed-on: https://code.wireshark.org/review/22246 Petri-Dish: João Valverde <j@v6e.pt> Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org> Reviewed-by: Peter Wu <peter@lekensteyn.nl> Reviewed-by: João Valverde <j@v6e.pt>
2017-06-16RADIUS: Add dictionary support for format= with BEGIN-VENDORJoão Valverde1-9/+21
Bug: 13745 Change-Id: Ibd00ea4818eb4b47a2c46324c1bfc878fef03d1e Reviewed-on: https://code.wireshark.org/review/22155 Petri-Dish: João Valverde <j@v6e.pt> Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org> Reviewed-by: Michael Mann <mmann78@netscape.net> Reviewed-by: Anders Broman <a.broman58@gmail.com>
2017-06-14RADIUS: Fix dissection for non-default VSA lengthsJoão Valverde1-7/+11
Ping-Bug: 13745 Change-Id: I1c9f69d0015ba9bea16d8300fbfd85abe110f829 Reviewed-on: https://code.wireshark.org/review/22136 Reviewed-by: João Valverde <j@v6e.pt>
2017-06-14RADIUS: Add comment explaining WiMAX non-standard VSA formatJoão Valverde1-0/+14
Change-Id: I5b3417c94ab10d4ed22258bdb2ef0f670dd2b995 Reviewed-on: https://code.wireshark.org/review/22118 Reviewed-by: João Valverde <j@v6e.pt>
2017-06-03RADIUS: Fix gda9363e202João Valverde1-1/+1
EVS value was incorrectly typed from the non-extended type space. Now it should display as unknown. Ping-Bug: 13745 Change-Id: I67cfa29d3edcd56e49c1f4eded117a26594f0a14 Reviewed-on: https://code.wireshark.org/review/21911 Reviewed-by: Michael Mann <mmann78@netscape.net>
2017-05-28RADIUS: Add Vendor ID, Vendor Type and Vendor Length fieldsJoão Valverde1-4/+30
Change-Id: I241bfb5d77374d8dd1428fb550d9e913a2d3570a Reviewed-on: https://code.wireshark.org/review/21756 Reviewed-by: Michael Mann <mmann78@netscape.net> Petri-Dish: Michael Mann <mmann78@netscape.net> Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org> Reviewed-by: Alexis La Goutte <alexis.lagoutte@gmail.com>
2017-05-25RADIUS: Add support for extended attributes (RFC 6929)João Valverde1-35/+96
Bug: 13176 Change-Id: I22cdce01d8e7d5b69c2013684a98a9a48acc0d13 Reviewed-on: https://code.wireshark.org/review/21727 Petri-Dish: Alexis La Goutte <alexis.lagoutte@gmail.com> Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org> Reviewed-by: Michael Mann <mmann78@netscape.net>
2017-04-08Clean up handling of enabled/disabled protocols/heuristic dissectors.Guy Harris1-1/+1
Add a "report a warning message" routine to the "report_err" code in libwsutil, and rename files and routines appropriately, as they don't only handle errors any more. Have a routine read_enabled_and_disabled_protos() that reads all the files that enable or disable protocols or heuristic dissectors, enables and disables them based on the contents of those files, and reports errors itself (as warnings) using the new "report a warning message" routine. Fix that error reporting to report separately on the disabled protocols, enabled protocols, and heuristic dissectors files. Have a routine to set up the enabled and disabled protocols and heuristic dissectors from the command-line arguments, so it's done the same way in all programs. If we try to enable or disable an unknown heuristic dissector via a command-line argument, report an error. Update a bunch of comments. Update the name of disabled_protos_cleanup(), as it cleans up information for disabled *and* enabled protocols and for heuristic dissectors. Support the command-line flags to enable and disable protocols and heuristic dissectors in tfshark. Change-Id: I9b8bd29947cccdf6dc34a0540b5509ef941391df Reviewed-on: https://code.wireshark.org/review/20966 Reviewed-by: Guy Harris <guy@alum.mit.edu>
2017-03-12radius: fix this condition has identical branches ↵Alexis La Goutte1-0/+2
[-Werror=duplicated-branches] found by gcc7 Change-Id: I654ead4d834af90e14568a54c7a914a3774c05bc Reviewed-on: https://code.wireshark.org/review/20470 Reviewed-by: Peter Wu <peter@lekensteyn.nl>
2017-03-02Rewrite dissectors to use Libgcrypt functions.Erik de Jong1-18/+35
As discussed on the mailinglist, rewriting dissectors to use Libgcrypt functions as Libgcrypt will be mandatory after change 20030. Removal of following functions: - crypt_md4 - crypt_rc4* - aes_cmac_encrypt_* - md5_* - sha1_* - sha256_* Further candidates: - aes_* - rijndael_* - ... Added functions: - ws_hmac_buffer Added const macros: - HASH_MD5_LENGTH - HASH_SHA1_LENGTH Changes on epan/crypt/* verified with captures from https://wiki.wireshark.org/HowToDecrypt802.11 Changes on packet-snmp.c and packet-radius.c verified with captures from https://wiki.wireshark.org/SampleCapture Changes on packet-tacacs.c verified with capture from http://ccie-in-3-months.blogspot.nl/2009/04/decoding-login-credentials-regardless.html Change-Id: Iea6ba2bf207cf0f1bf2117068fb1abcfeaafaa46 Link: https://www.wireshark.org/lists/wireshark-dev/201702/msg00011.html Reviewed-on: https://code.wireshark.org/review/20095 Petri-Dish: Peter Wu <peter@lekensteyn.nl> Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org> Reviewed-by: Peter Wu <peter@lekensteyn.nl>
2017-02-28radius: fix use-after-free after recent memleak fixesPeter Wu1-7/+12
The same data is referenced by the ID-to-name and name-to-ID mapping, so be make sure that the ID mapping is responsible (as the name mapping is just used for duplicate detection and while parsing dictionary files). Still to be done is fixing duplicate attribute numbers (by adding support for OIDs and changing TLV attribute type IDs to OIDs) and fixing duplicate attribute names (by prefixing the Vendor Names to them). Also not handled is fixing Value memleaks. Reproducers of the crash under ASAN: tshark -G fields >/dev/null tshark -r radius-ms-mppe-etrl-bug.cap (from bug 796) Change-Id: Ifa4055901072bc830e19fe06937af67ce524a3be Fixes: v2.3.0rc0-2536-gd4cf57100c ("Free radius dissector memory on shutdown") Reviewed-on: https://code.wireshark.org/review/20307 Reviewed-by: Peter Wu <peter@lekensteyn.nl> Petri-Dish: Peter Wu <peter@lekensteyn.nl> Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org> Reviewed-by: Michael Mann <mmann78@netscape.net>
2017-02-28radius: fix memleaks of value_stringPeter Wu1-1/+9
The value_string was taken from the GArray and added to radius_attr_info_t, but these were not properly freed. Change-Id: I8de2b84760887c41229a57881ff46cedcef1d22f Reviewed-on: https://code.wireshark.org/review/20311 Reviewed-by: Michael Mann <mmann78@netscape.net>
2017-02-27Free radius dissector memory on shutdownMichael Mann1-5/+44
Change-Id: I19eef65e8144d7cb6d5c9eea454581a532420c75 Reviewed-on: https://code.wireshark.org/review/20292 Reviewed-by: Dario Lombardo <lomato@gmail.com> Petri-Dish: Dario Lombardo <lomato@gmail.com> Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org> Reviewed-by: Michael Mann <mmann78@netscape.net>
2017-01-28wmem_map_new -> wmem_map_new_autoresetMichael Mann1-2/+2
A few dissectors can benefit from the conversion. Change-Id: I3b7d54926b79314009e271960aff61870a115390 Reviewed-on: https://code.wireshark.org/review/19826 Reviewed-by: Michael Mann <mmann78@netscape.net>
2016-12-31Dissectors don't need a journey of self discovery.Michael Mann1-4/+3
They already know who they are when they register themselves. Saving the handle then to avoid finding it later. Not sure if this will increase unnecessary register_dissector functions (instead of using create_dissector_handle in proto_reg_handoff function) when other dissectors copy/paste, but it should make startup time a few microseconds better. Change-Id: I3839be791b32b84887ac51a6a65fb5733e9f1f43 Reviewed-on: https://code.wireshark.org/review/19481 Petri-Dish: Michael Mann <mmann78@netscape.net> Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org> Reviewed-by: Anders Broman <a.broman58@gmail.com>
2016-11-26We only need the tvbuff length for EAP messages.Guy Harris1-6/+7
Change-Id: I22a5990e12a151c209288b9e879ae1f88c866904 Reviewed-on: https://code.wireshark.org/review/18956 Reviewed-by: Guy Harris <guy@alum.mit.edu>
2016-10-28RADIUS: fix fix spelling typo found by lintianAlexis La Goutte1-2/+2
Change-Id: Iea8c96064c39d0e4aee5db6c72a8c120c56e495e Reviewed-on: https://code.wireshark.org/review/18531 Reviewed-by: Anders Broman <a.broman58@gmail.com>
2016-10-13Convert most UDP dissectors to use "auto" preferences.Michael Mann1-36/+5
Similar to the "tcp.port" changes in I99604f95d426ad345f4b494598d94178b886eb67, convert dissectors that use "udp.port". More cleanup done on dissectors that use both TCP and UDP dissector tables, so that less preference callbacks exist. Change-Id: If07be9b9e850c244336a7069599cd554ce312dd3 Reviewed-on: https://code.wireshark.org/review/18120 Petri-Dish: Michael Mann <mmann78@netscape.net> Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org> Reviewed-by: Michael Mann <mmann78@netscape.net>
2016-06-27tvb_get_string_enc + proto_tree_add_item = proto_tree_add_item_ret_stringMichael Mann1-2/+3
Also some other tricks to remove unnecessary tvb_get_string_enc calls. Change-Id: I2f40d9175b6c0bb0b1364b4089bfaa287edf0914 Reviewed-on: https://code.wireshark.org/review/16158 Petri-Dish: Pascal Quantin <pascal.quantin@gmail.com> Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org> Reviewed-by: Michael Mann <mmann78@netscape.net> Reviewed-by: Pascal Quantin <pascal.quantin@gmail.com>
2016-06-26conversation: rename shadow variableDario Lombardo1-1/+1
Change-Id: I8f738b2e01d7f448b21cdc1b488b16b7dd581911 Reviewed-on: https://code.wireshark.org/review/16104 Reviewed-by: Anders Broman <a.broman58@gmail.com>
2016-06-15Allow control of individual columns to be (un)writable.Michael Mann1-3/+3
Most protocols just want to limit COL_INFO or COL_PROTOCOL so give that level of granularity. Bug: 12144 Bug: 5117 Bug: 11144 Change-Id: I8de9b7d2c69e90d3fbfc0a52c2bd78c3de58e2f8 Reviewed-on: https://code.wireshark.org/review/15894 Reviewed-by: Jeff Morriss <jeff.morriss.ws@gmail.com> Petri-Dish: Anders Broman <a.broman58@gmail.com> Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org> Reviewed-by: Anders Broman <a.broman58@gmail.com>
2016-06-15Change how dissectors do late-field-registration to avoid a double-registrationJeff Morriss1-5/+5
assertion. If a dissector forces registration of fields during dissection it needs to do so in a way that clears the prefix registration. Otherwise epan will call the registration routine a 2nd time (which will cause us to assert out) if a user types a display filter (with the dissector's prefix) that doesn't exist. Update the proto_register_prefix() comments to reflect this. Change-Id: I3ce29243395fb55192bb5dfd950baa88410ac136 Reviewed-on: https://code.wireshark.org/review/15881 Petri-Dish: Jeff Morriss <jeff.morriss.ws@gmail.com> Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org> Reviewed-by: Jaap Keuter <jaap.keuter@xs4all.nl>
2016-06-06Move ip6_to_str_buf() to to_str.c and make it take the buffer length.João Valverde1-1/+1
Also make it use ws_inet_ntop6() (rather than implementing the string conversion ourselves). Remove ip6_to_str_buf_len(). Change-Id: I1eff3a8941e00987c2ff0c4dcfda13476af86191 Reviewed-on: https://code.wireshark.org/review/15692 Reviewed-by: João Valverde <j@v6e.pt> Reviewed-by: Michael Mann <mmann78@netscape.net>
2016-04-04RADIUS: more formatting/white space cleanup.Jeff Morriss1-19/+19
Change-Id: I34c467c0bf602c9e866df55f25187a750aac4e88 Reviewed-on: https://code.wireshark.org/review/14807 Reviewed-by: Jeff Morriss <jeff.morriss.ws@gmail.com>
2016-03-31Add a NULL check: it's not sure we have a radius_call here.Jeff Morriss1-1/+1
Change-Id: I6037a02e6170d0ca8b978135f960213ed22bef97 Reviewed-on: https://code.wireshark.org/review/14710 Reviewed-by: Michael Mann <mmann78@netscape.net> Petri-Dish: Michael Mann <mmann78@netscape.net> Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org> Reviewed-by: Alexis La Goutte <alexis.lagoutte@gmail.com>
2016-03-31Ensure our fields are registered before starting dissection--even when !tree.Jeff Morriss1-13/+11
(The check to ensure the delayed field registration had been done was still wrapped inside an if(tree) but a bunch of proto_add_*()'s had been pulled out from under if(tree)'s thus causing some hf's to be used before registered.) Also simplify the code to ensure the fields are registered since we're doing it potentially many times per frame: do an integer comparison rather than looking up an hf by name. Add a note to the docs for proto_register_prefix() to make it clear that the initializer routine may not be called before the dissector is asked to dissect something. Change-Id: I5dc1154638a290c3a94149184d56570c3abb836a Reviewed-on: https://code.wireshark.org/review/14711 Petri-Dish: Jeff Morriss <jeff.morriss.ws@gmail.com> Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org> Reviewed-by: Michael Mann <mmann78@netscape.net>
2016-03-20Manually add protocol dependencies derived from find_dissector.Michael Mann1-1/+1
Started by grepping call_dissector_with_data, call_dissector_only and call_dissector and traced the handles passed into them to a find_dissector within the dissector. Then replaced find_dissector with find_dissector_add_dependency and added the protocol id from the dissector. "data" dissector was not considered to be a dependency. Change-Id: I15d0d77301306587ef8e7af5876e74231816890d Reviewed-on: https://code.wireshark.org/review/14509 Petri-Dish: Michael Mann <mmann78@netscape.net> Reviewed-by: Michael Mann <mmann78@netscape.net>
2016-03-15[RADIUS] Fix up formatting.Jeff Morriss1-492/+524
Remove a couple useless if(tree)'s while in there. Change-Id: Ie8de360f4590806eab0a4704b410341918251586 Reviewed-on: https://code.wireshark.org/review/14488 Reviewed-by: Jeff Morriss <jeff.morriss.ws@gmail.com>
2016-03-14Handle RADIUS ident reuse better.Jeff Morriss1-126/+160
Rather than storing RADIUS calls in a map keyed by the ident and conversation store a tree of calls (using the the same key). Store each (non-duplicate) call (request) in the tree, keyed by frame number. When looking for a match (or a duplicate) look for the most-recently-seen frame in the tree (i.e., the most recent frame with the same ident + conversation). Only declare a request a duplicate if the authenticator is identical (as per RFC 5080 section 2.2.2). Only store things in the map/tree on the first pass. Remove the 'request_ttl' preference: it's better to show the user when the response came back even if it was "late." (This also allows duplicate request detection inside of the TTL.) When telling the user about a duplicate don't tell them the ident again: they already know that. Tell them the frame number of the original. Use the FT_FRAMENUM_REQUEST/FT_FRAMENUM_RESPONSE hints. Move a couple structures from the header file to the C file: they're only used in the RADIUS dissector anyway. Bug: 4096 Change-Id: I0e8bc0d23cd6b219cecd82f5c4cd765d28a14d98 Reviewed-on: https://code.wireshark.org/review/14451 Petri-Dish: Jeff Morriss <jeff.morriss.ws@gmail.com> Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org> Reviewed-by: Michael Mann <mmann78@netscape.net>
2016-03-14wmem-ify the Radius call table.Jeff Morriss1-17/+52
This includes not making assumptions about the order in which a GHashTable or wmem_map implementation provides the keys to the GEqualFunc function (apparently the former's order is different than the latter). Change-Id: Ifbcb0f4f2c38b2ce6e44bf66c7246575af6299fa Reviewed-on: https://code.wireshark.org/review/14448 Reviewed-by: Michael Mann <mmann78@netscape.net>
2016-03-13Fix a FIXME: remove an if(tree).Jeff Morriss1-28/+25
The reason the notice in the INFO column disappeared when a display filter was added is because the column operation was wrapped in an if(tree). Change-Id: Ic8ff929d7ef601458b8650f8095f87282f9fde40 Reviewed-on: https://code.wireshark.org/review/14449 Reviewed-by: Michael Mann <mmann78@netscape.net>
2016-02-26Add free_address_wmem(), fix warnings [-Wcast-qual]João Valverde1-1/+1
Try to improve address API and also fix some constness warnings by not overloading the 'data' pointer to store malloc'ed buffers (use private pointer for that instead). Second try, now passing test suite. Change-Id: Idc101cd866b6d4f13500c9d59da5c7a38847fb7f Reviewed-on: https://code.wireshark.org/review/13946 Petri-Dish: João Valverde <j@v6e.pt> Reviewed-by: Alexis La Goutte <alexis.lagoutte@gmail.com> Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org> Reviewed-by: João Valverde <j@v6e.pt>
2016-02-08Revert "Add free_address_wmem() and other extensions to address API"João Valverde1-1/+1
This reverts commit 13ec77a9fc3af3b0b502820d0b55796c89997896. This commit introduces a segmentation fault for Lua code (uncovered by the test suite). Change-Id: Ibc273d1915cda9632697b9f138f0ae104d3fb65e Reviewed-on: https://code.wireshark.org/review/13813 Reviewed-by: João Valverde <j@v6e.pt>
2016-02-07Add free_address_wmem() and other extensions to address APIJoão Valverde1-1/+1
Try to improve 'address' API (to be easier/safer) and also avoid some constness warnings by not overloading the 'data' pointer to store malloc'ed buffers (use private pointer for that instead). Change-Id: I7456516b12c67620ceadac447907c12f5905bd49 Reviewed-on: https://code.wireshark.org/review/13463 Petri-Dish: João Valverde <j@v6e.pt> Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org> Reviewed-by: João Valverde <j@v6e.pt>
2016-01-24Add the packet number to the packet_info structure, and use it.Guy Harris1-7/+7
That removes most of the uses of the frame number field in the frame_data structure. Change-Id: Ie22e4533e87f8360d7c0a61ca6ffb796cc233f22 Reviewed-on: https://code.wireshark.org/review/13509 Reviewed-by: Guy Harris <guy@alum.mit.edu>
2016-01-23More structure assignments for nstime_t.Guy Harris1-2/+1
Change-Id: I4d320b50d7d74b6fc423014c9611a60d49c6be02 Reviewed-on: https://code.wireshark.org/review/13503 Reviewed-by: Guy Harris <guy@alum.mit.edu>
generated by cgit v1.2.3 (git 2.25.1) at 2024-06-16 09:19:55 +0000