aboutsummaryrefslogtreecommitdiffstats
path: root/epan/dissectors/packet-q931.c
AgeCommit message (Collapse)AuthorFilesLines
2013-11-16Avoid calling find_dissector(), cache result of [new_]register_dissector()Jakub Zawadzki1-10/+6
svn path=/trunk/; revision=53353
2013-09-22emem -> wmem conversion:Pascal Quantin1-4/+4
- ep_tvb_get_bits() -> wmem_packet_tvb_get_bits() - tvb_g_memdup()/ep_tvb_memdup() -> tvb_memdup() - tvb_fake_unicode()/tvb_get_ephemeral_faked_unicode() -> tvb_get_faked_unicode() - tvb_get_g_string()/tvb_get_ephemeral_string()/tvb_get_seasonal_string() -> tvb_get_string() - tvb_get_g_unicode_string()/tvb_get_ephemeral_unicode_string() -> tvb_get_unicode_string() - tvb_get_ephemeral_string_enc() -> tvb_get_string_enc() - update docs accordingly svn path=/trunk/; revision=52172
2013-09-15A few more dissectors converted to wmemPascal Quantin1-2/+2
svn path=/trunk/; revision=52071
2013-09-15Convert proto_tree_add_uint_format to proto_tree_add_uint_format_value if ↵Michael Mann1-12/+12
hf_ field name is the first part of the formatted string. This was done with a perl script on the dissectors directory (packet-*.c), followed by manual inspection of the output. The manual inspection yielded a few cases that really should have been proto_tree_add_uint or proto_tree_add_item, so I updated them accordingly. The script didn't catch as many as I would have liked, but it's a start. The most common (ab)use of proto_tree_add_uint_format was for appending strings to CRC/checksum values to note good or bad CRC/checksum. svn path=/trunk/; revision=52045
2013-07-17Remove fragment_data, add fragment_head, fragment_item - for now alias it to ↵Jakub Zawadzki1-1/+1
the same structure. This is begin of work to split fragment head and fragments items. svn path=/trunk/; revision=50708
2013-07-14Rewrite reassemble API to use TVBs instead of raw data.Jakub Zawadzki1-1/+1
(it seems to be working for TCP ^^) svn path=/trunk/; revision=50580
2013-06-14Remove check_col() and the occasional tree.Michael Mann1-18/+14
svn path=/trunk/; revision=49921
2013-03-22Don't wire into the reassembly code the notion that reassemblies shouldGuy Harris1-10/+9
be done on flows from one address to another; reassembly for protocols running atop TCP should be done on flows from one TCP endpoint to another. We do this by: adding "reassembly table" as a data structure; associating hash tables for both in-progress reassemblies and completed reassemblies with that data structure (currently, not all reassemblies use the latter; they might keep completed reassemblies in the first table); having functions to create and destroy keys in that table; offering standard routines for doing address-based and address-and-port-based flow processing, so that dissectors not needing their own specialized flow processing can just use them. This fixes some mis-reassemblies of NIS YPSERV YPALL responses (where the second YPALL response is processed as if it were a continuation of a previous response between different endpoints, even though said response is already reassembled), and also allows the DCE RPC-specific stuff to be moved out of epan/reassembly.c into the DCE RPC dissector. svn path=/trunk/; revision=48491
2013-03-19From beroset:Anders Broman1-1/+1
remove C++ incompatibilities https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=8416 svn path=/trunk/; revision=48425
2012-10-21Make Windows Buildbot happyAlexis La Goutte1-1/+1
svn path=/trunk/; revision=45691
2012-10-21Fix Passed-by-value struct argument contains uninitialized data Warning ↵Alexis La Goutte1-0/+3
found by Clang svn path=/trunk/; revision=45682
2012-10-21Fix some Dead Store (Dead assignement/Dead increment) Warning found by ClangAlexis La Goutte1-10/+9
svn path=/trunk/; revision=45680
2012-09-27Get rid of unused variable.Guy Harris1-3/+0
svn path=/trunk/; revision=45179
2012-09-27replaced decode_enumerated_bitfield calls with itemized filtersMichael Mann1-4/+14
svn path=/trunk/; revision=45176
2012-09-20We always HAVE_CONFIG_H so don't bother checking whether we have it or not.Jeff Morriss1-3/+1
svn path=/trunk/; revision=45017
2012-09-11Add data parameter to call_dissector_only.Jakub Zawadzki1-1/+1
svn path=/trunk/; revision=44872
2012-09-11Add data parameter to dissector_try_heuristicJakub Zawadzki1-1/+1
svn path=/trunk/; revision=44871
2012-09-10Initial commit to support yet another method of passing data between dissectors.Jakub Zawadzki1-2/+2
Add new parameter 'data' to heur_dissector_t and new_dissector_t, for now it's always NULL svn path=/trunk/; revision=44860
2012-09-07From Robert Bullen via ↵Jeff Morriss1-0/+2
https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=7683 : The reassembled fragments tree in the Packet Details view is awesome, but it lacks one thing: a field that exposes the reassembled data. tcp.data already exists for exposing a single TCP segment's payload as a byte array. It would be handy to have something similar for a single application layer PDU when TCP segment reassembly is involved. I propose tcp.reassembled.data, named and placed after the already existing field tcp.reassembled.length. My primary use case for this feature is outputting tcp.reassembled.data with tshark for further processing with a script. The attached patch implements this very feature. Because the reassembled fragment tree code is general purpose, i.e. not specific to just TCP, any dissector that relies upon it can add a similar field very cheaply. In that vein I've also implemented ip.reassembled.data and ipv6.reassembled.data, which expose reassembled fragment data as a single byte stream for IPv4 and IPv6, respectively. All other protocols that use the reassembly code have been left alone, other than inserting NULL into their initializer lists for the newly introduced struct field reassemble.h:fragment_items.hf_reassembled_data. svn path=/trunk/; revision=44802
2012-08-01Fix the 2nd part of Coverity CID 280361 (formerly 361): "Logically dead ↵Chris Maynard1-1/+1
code" that mmartin seems to have unintentionally missed in r36256. svn path=/trunk/; revision=44177
2012-06-28Update Free Software Foundation address.Jakub Zawadzki1-1/+1
(COPYING will be updated in next commit) svn path=/trunk/; revision=43536
2011-11-09Fix a number of proto_tree_add_item() encoding args.Bill Meier1-1/+1
svn path=/trunk/; revision=39774
2011-10-21For proto_tree_add_item(..., proto_xxx, ...)use ENC_NA as the encoding arg.Bill Meier1-1/+1
Also: remove trailing whitespace for a number of files. svn path=/trunk/; revision=39503
2011-10-10 Convert 'encoding' parameter of certain proto_tree_add_item() calls in ↵Bill Meier1-13/+13
non-autogenerated epan/dissectors: Specifically: Replace FALSE|0 and TRUE|1 by ENC_BIG_ENDIAN|ENC_LITTLE_ENDIAN as the encoding parameter for proto_tree_add_item() calls which directly reference an item in hf[] which has a type of: FT_BOOLEAN FT_IPv4 FT_EUI64 FT_GUID FT_UINT_STRING Also: For type FT_ITv6 use ENC_NA. (This was missed in SVN #39260) svn path=/trunk/; revision=39328
2011-10-06Convert 'encoding' parameter of certain proto_tree_add_item() calls in ↵Bill Meier1-7/+7
non-autogenerated epan/dissectors: Specifically: Replace FALSE|0 and TRUE|1 by ENC_BIG_ENDIAN|ENC_LITTLE_ENDIAN as the encoding parameter for proto_tree_add_item() calls which directly reference an item in hf[] which has a type of: FT_UINT8 FT_UINT16 FT_UINT24 FT_UINT32 FT_UINT64 FT_INT8 FT_INT16 FT_INT24 FT_INT32 FT_INT64 FT_FLOAT FT_DOUBLE svn path=/trunk/; revision=39288
2011-06-13Fix for bug 6009:Jaap Keuter1-1/+1
Information transfer rate is a 7 bit field. svn path=/trunk/; revision=37663
2011-03-22Remove redundant comparison.Martin Mathieson1-2/+0
Coverity CID 361. svn path=/trunk/; revision=36256
2011-02-11Check for places where tvb_bytes_to_str() or tvb_get_bytes_to_str_punct()Jeff Morriss1-3/+1
should be used (instead of the non-tvb functions with a call to tvb_get_ptr()). Use those functions in a bunch of places. svn path=/trunk/; revision=35911
2011-01-30Introduce "Fragment count" filter element for all protocols doing reassembly.Stig Bjørlykke1-0/+6
svn path=/trunk/; revision=35705
2011-01-16There's no need to pass the result of tvb_get_ptr() as the 'value' inJeff Morriss1-1/+1
proto_tree_add_*(): just use proto_tree_add_item(). Replace some tvb_get_ptr()s with tvb_get_ephemeral_string() or tvb_get_const_stringz(). Use tvb_memeql() & tvb_memcmp(). svn path=/trunk/; revision=35558
2010-12-20Rename the routines that handle dissector tables with unsigned integerGuy Harris1-10/+10
keys to have _uint in their names, to match the routines that handle dissector tables with string keys. (Using _port can confuse people into thinking they're intended solely for use with TCP/UDP/etc. ports when, in fact, they work better for things such as Ethernet types, where the binding of particular values to particular protocols are a lot stronger.) svn path=/trunk/; revision=35224
2010-11-15Fill value_strings.Anders Broman1-43/+48
svn path=/trunk/; revision=34875
2010-11-05Use value_string_ext fcns to access certain value_string arrays;Bill Meier1-84/+100
Sort certain value_string arrays so the values are in ascending order; Use val_to_str_ext() instead of for loops to do value_string array lookups (voip_calls.c). Minor whitespace cleanup. svn path=/trunk/; revision=34794
2010-11-04From Alexis La Goutte:Jaap Keuter1-2/+6
Fix false positive from checkhf. svn path=/trunk/; revision=34772
2010-11-04From Alexis La Goutte:Jaap Keuter1-4/+1
Replace all *_min()/*_max() by MIN() and MAX(). svn path=/trunk/; revision=34767
2010-05-03ignore unreassembled fragments if the first segment of the next message comes Tomas Kukosa1-1/+6
svn path=/trunk/; revision=32643
2010-04-03Remove unneeded #include <stdio.h>Bill Meier1-1/+0
svn path=/trunk/; revision=32367
2010-03-30Do not reassemble messages if segment is not complete (packet size limited ↵Tomas Kukosa1-1/+1
during capture) svn path=/trunk/; revision=32326
2010-03-19add some Q.931 messages from older specificationsTomas Kukosa1-0/+4
svn path=/trunk/; revision=32244
2010-03-17Add heuristic table for Q.931 User-specific protocolTomas Kukosa1-3/+20
svn path=/trunk/; revision=32218
2010-02-03Changed "reassembled_length" -> "reassembled.length".Stig Bjørlykke1-1/+1
svn path=/trunk/; revision=31776
2010-02-02Introduce "Reassembled length" filter element for all protocols doingStig Bjørlykke1-0/+6
reassembly. svn path=/trunk/; revision=31767
2010-01-22Fixes for gcc -Wshadow warnings; Fix indentation and do other minor cleanup ↵Bill Meier1-10/+10
in a few cases. svn path=/trunk/; revision=31617
2009-10-22From Gerasimos Dimitriadis:Anders Broman1-1/+1
DTAP: Progress description depends on coding standard. Changed to export value strings trough .h file https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=4146 svn path=/trunk/; revision=30661
2009-10-21From Gerasimos Dimitriadis:Anders Broman1-2/+2
DTAP: Call state depends on coding standard. https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=4145 svn path=/trunk/; revision=30655
2009-08-16Switch a bunch of dissectors over to using tvb_new_subset_remaining()Kovarththanan Rajaratnam1-1/+1
svn path=/trunk/; revision=29446
2009-08-09Don't guard col_set_str (COL_PROTOCOL) with col_checkKovarththanan Rajaratnam1-2/+1
svn path=/trunk/; revision=29340
2009-08-03From Gerasimos Dimitriadis:Jaap Keuter1-19/+92
Added decoding support for the High Layer Compatibility IE in DTAP and updated the relevant part in Q.931. Also some minor enhancements in Q.931. svn path=/trunk/; revision=29280
2009-06-18From Kovarththanan Rajaratnam via bug 3548:Stig Bjørlykke1-28/+28
(1) Trailing/leading spaces are removed from 'name's/'blurb's (2) Duplicate 'blurb's are replaced with NULL (3) Empty ("") 'blurb's are replaced with NULL (4) BASE_NONE, NULL, 0x0 are used for 'display', 'strings' and 'bitmask' fields for FT_NONE, FT_BYTES, FT_IPv4, FT_IPv6, FT_ABSOLUTE_TIME, FT_RELATIVE_TIME, FT_PROTOCOL, FT_STRING and FT_STRINGZ field types (5) Only allow non-zero value for 'display' if 'bitmask' is non-zero svn path=/trunk/; revision=28770
2009-05-13Apply some of the patches from:Anders Broman1-2/+1
http://wiki.wireshark.org/Development/Optimization svn path=/trunk/; revision=28356