aboutsummaryrefslogtreecommitdiffstats
path: root/epan/dissectors/packet-pdcp-nr.c
AgeCommit message (Collapse)AuthorFilesLines
2023-02-20Check that value_string values fit into field widthMartin Mathieson1-1/+1
2022-12-20PDCP-NR: Add a field to show/filter decrypted dataMartin Mathieson1-8/+24
2022-07-26PDCP_NR: Show direction in more sequence analysis expert outputMartin Mathieson1-6/+16
2022-05-24PDCP-NR: Fix a test (flagged by coverity)Martin Mathieson1-2/+4
2022-05-24PDCP-NR: Add separate UL/DL expert info ei items for missing SNsMartin Mathieson1-5/+13
2022-04-20libgcrypt: Require version 1.8.0John Thacker1-2/+0
Libgcrypt 1.8.x is required for a large amount of decryption support and is the current LTS version of libgcrypt. The 1.6 and 1.7 series have been end-of-life since 2017-06-30 and 2019-06-30, respectively. The Linux distributions that have versions of libgcrypt before 1.8.0 are nearing or at end of support (RHEL7, SLES 12, Debian stretch, Ubuntu 16.04LTS) and can be supported by the Wireshark 3.6 LTS release series. Remove an enormous amount of ifdefs based on libgcrypt versions 1.6.0, 1.7.0, and 1.8.0. There will be a second pass for the commons defines HAVE_LIBGCRYPT_AEAD, HAVE_LIBGCRYPT_CHACHA20, and HAVE_LIBGCRYPT_CHACHA20_POLY1305, which are now always defined. The ISAKMP dissector has some comments noting that some workarounds were used for libgcrypt 1.6 that aren't needed with 1.7; perhaps that could be updated now.
2022-04-19PDCP-NR: changes to make security keys work betterMartin Mathieson1-61/+221
2022-02-15Tools: Fix fix-encoding-args.pl ASCII string validationJoão Valverde1-1/+1
Do not require a useless ENC_NA parameter for string encodings. FT_STRING and FT_STRINGZ types don't have any ndianness. Follow-up to 6ec429622c9258eefd388caf21ce92ab5b9f54b4.
2021-12-19Replace g_strdup_printf() with ws_strdup_printf()João Valverde1-4/+4
Use macros from inttypes.h.
2021-12-19Replace g_snprintf() with snprintf() (dissectors)João Valverde1-2/+2
Use macros from inttypes.h with format strings.
2021-12-06PDCP-NR: For broadcast PDU, don't dissect header and MACMartin Mathieson1-20/+22
2021-07-29More fussing with masks.Martin Mathieson1-1/+1
Mostly longer masks with odd numbers of digits.
2021-03-04PDCP-NR: some decryption changes.Martin Mathieson1-90/+124
- show 'deciphering disabled' context setting in tree - decrypt DRBs even if don't think have seen securityModeComplete
2021-02-14PDCP: set key error strings with g_strdup_print)Martin Mathieson1-11/+5
2021-02-09PDCP NR: fix compilation without any ciphering algorithm availablePascal Quantin1-2/+4
2021-01-17PDCP-NR: Add ZUC Cipher/integrity calls.Martin Mathieson1-8/+60
As with Snow3G, we can't distribute Wireshark with NIA3/NEA3 implementations linked in, but provide f8/f9 calls that may be enabled in private builds.
2021-01-12PDCP-NR: Trivial updates to some commentsMartin Mathieson1-9/+6
2021-01-09PDCP-NR security fixesMartin Mathieson1-20/+20
- fix level of indirection of error strings for setting keys - don't try to decode undeciphered user-plane payloads
2021-01-05PDCP NR: Get DRB params when RLC not presentMartin Mathieson1-0/+24
2021-01-03PDCP-NR: Set 'cipheringDisabled' from RRCMartin Mathieson1-14/+24
2021-01-01PDCP-NR: Report errors for invalid keysMartin Mathieson1-18/+67
Using UAT callback mechanism for UAT config, and report_failure() from functions that would be called by private dissectors. Assuming there are no objections, will also do this for PDCP-LTE.
2020-12-31PDCP-NR: add ciphering and integrity checkingMartin Mathieson1-50/+1074
There may be some scope to share some code with PDCP-LTE, but it may make the code harder to read.
2020-09-25SDAP: Show presence in configuration, and summary in root.Martin Mathieson1-4/+29
2020-09-24SDAP: Add some long help, and fix filter name.Martin Mathieson1-4/+4
2020-02-01PDCP NR: call NR RRC dissector for signalling payloadPascal Quantin1-5/+33
Now that the NR RRC dissector has all its logical channel dissectors available, its time to call them. Change-Id: Id59da5af1bca3654f3c5fca5c81ce664454d4f1e Reviewed-on: https://code.wireshark.org/review/35999 Petri-Dish: Pascal Quantin <pascal@wireshark.org> Tested-by: Petri Dish Buildbot Reviewed-by: Pascal Quantin <pascal@wireshark.org>
2019-04-04epan: Convert our PROTO_ITEM_ macros to inline functions.Gerald Combs1-22/+22
Convert our various PROTO_ITEM_ macros to inline functions and document them. Change-Id: I070b15d4f70d2189217a177ee8ba2740be36327c Reviewed-on: https://code.wireshark.org/review/32706 Reviewed-by: Gerald Combs <gerald@wireshark.org> Petri-Dish: Gerald Combs <gerald@wireshark.org> Reviewed-by: Anders Broman <a.broman58@gmail.com>
2018-12-27Try to squeeze some bytes out of the frame_data structure.Guy Harris1-1/+1
Make the time stamp precision a 4-bit bitfield, so, when combined with the other bitfields, we have 32 bits. That means we put the flags at the same structure level as the time stamp precision, so they can be combined; that gets rid of an extra "flags." for references to the flags. Put the two pointers next to each other, and after a multiple of 8 bytes worth of other fields, so that there's no padding before or between them. It's still not down to 64 bytes, which is the next lower power of 2, so there's more work to do. Change-Id: I6f3e9d9f6f48137bbee8f100c152d2c42adb8fbe Reviewed-on: https://code.wireshark.org/review/31213 Petri-Dish: Guy Harris <guy@alum.mit.edu> Tested-by: Petri Dish Buildbot Reviewed-by: Guy Harris <guy@alum.mit.edu>
2018-11-11PDCP-NR: Show some config highlights in config root and Info column.Martin Mathieson1-0/+25
Also add convenience functions for getting/setting the PDCP-NR struct. Change-Id: Id30d380ecb2910e5f32e08b791657696bb513910 Reviewed-on: https://code.wireshark.org/review/30569 Petri-Dish: Martin Mathieson <martin.r.mathieson@googlemail.com> Tested-by: Petri Dish Buildbot Reviewed-by: Pascal Quantin <pascal.quantin@gmail.com>
2018-08-14WIP GTP: Make it possible to configure PDCP parameters to dissectAndersBroman1-2/+5
NR_RAN_CONT Change-Id: I7b3234e5a90ca61ede9f95e1078c92ec3b28634d Reviewed-on: https://code.wireshark.org/review/29043 Reviewed-by: Anders Broman <a.broman58@gmail.com>
2018-06-20PDCP NR: upgrade SDAP dissection to v15.0.0Pascal Quantin1-26/+33
Change-Id: I590ff86fd0964715ece691adbb7f475ff6662d81 Reviewed-on: https://code.wireshark.org/review/28348 Petri-Dish: Pascal Quantin <pascal.quantin@gmail.com> Tested-by: Petri Dish Buildbot Reviewed-by: Pascal Quantin <pascal.quantin@gmail.com>
2018-06-19PDCP NR: fix IP tvbuff creation when MAC-I is presentPascal Quantin1-1/+1
Change-Id: I5241af9068937bdeefe1d0ea6caaa49959cf2a44 Reviewed-on: https://code.wireshark.org/review/28335 Reviewed-by: Pascal Quantin <pascal.quantin@gmail.com>
2018-06-04PDCP NR: add SDAP header presence indication and dissectionPascal Quantin1-5/+79
Change-Id: I8e868e7c969bcd8d57925cd51271801cdc6e2351 Reviewed-on: https://code.wireshark.org/review/28017 Reviewed-by: Martin Mathieson <martin.r.mathieson@googlemail.com> Reviewed-by: Pascal Quantin <pascal.quantin@gmail.com>
2018-05-24PDCP NR: add a framing option to indicate MAC-I presence in user plane PDU ↵Pascal Quantin1-25/+24
(CID 1435480) Change-Id: I155e4fad0c42c4b2b10cf3a2cb71c0927190b8db Reviewed-on: https://code.wireshark.org/review/27780 Petri-Dish: Pascal Quantin <pascal.quantin@gmail.com> Tested-by: Petri Dish Buildbot Reviewed-by: Martin Mathieson <martin.r.mathieson@googlemail.com> Reviewed-by: Pascal Quantin <pascal.quantin@gmail.com>
2018-05-21PDCP NR: status bitmap starts at FMC+1Pascal Quantin1-3/+3
Moreover we are displaying a 32 bits count, so it can contain up to 10 digits. Change-Id: I93252f2f631658b1e36c939ba804b4481dc7523b Reviewed-on: https://code.wireshark.org/review/27683 Petri-Dish: Pascal Quantin <pascal.quantin@gmail.com> Tested-by: Petri Dish Buildbot Reviewed-by: Martin Mathieson <martin.r.mathieson@googlemail.com> Reviewed-by: Pascal Quantin <pascal.quantin@gmail.com>
2018-04-30pdcp-nr: Fix Dead Store (Dead assignement/Dead increment) Warning found by ClangAlexis La Goutte1-2/+0
Change-Id: I4f6ab2ff54c1b5d6c4892b6e76d47b5107c0a197 Reviewed-on: https://code.wireshark.org/review/27220 Petri-Dish: Alexis La Goutte <alexis.lagoutte@gmail.com> Reviewed-by: Martin Mathieson <martin.r.mathieson@googlemail.com>
2018-04-23PDCP NR: tweaks for framing formatPascal Quantin1-20/+16
For optional tags that act as a boolean, their presence is sufficient and not need to set a value after them. Change-Id: I3b4a6bbbdacf1a008e8df90a20c4eede4b0db1bd Reviewed-on: https://code.wireshark.org/review/27095 Petri-Dish: Pascal Quantin <pascal.quantin@gmail.com> Tested-by: Petri Dish Buildbot Reviewed-by: Pascal Quantin <pascal.quantin@gmail.com>
2018-04-20PDCP-NR: Fix Dead Store (Dead assignement/Dead increment) Warning found by ClangAlexis La Goutte1-1/+0
Change-Id: Ib2d5c13c4f483866ac4b07942bf14a957a99dfeb Reviewed-on: https://code.wireshark.org/review/27046 Reviewed-by: Anders Broman <a.broman58@gmail.com>
2018-04-14PDCP NR: remove a now meaningless commentPascal Quantin1-2/+0
Change-Id: Ie234abdad7be9fd6f68d6676bae37286ee5dca2f Reviewed-on: https://code.wireshark.org/review/26938 Reviewed-by: Pascal Quantin <pascal.quantin@gmail.com>
2018-04-14PDCP NR: reuse existing pdcp_nr_info structure after first passPascal Quantin1-86/+84
Change-Id: Ief847244d8f989e2639a0dbcf96e2c7a7b1fb69a Reviewed-on: https://code.wireshark.org/review/26933 Petri-Dish: Pascal Quantin <pascal.quantin@gmail.com> Tested-by: Petri Dish Buildbot Reviewed-by: Martin Mathieson <martin.r.mathieson@googlemail.com> Reviewed-by: Roland Knall <rknall@gmail.com>
2018-04-13PDCP NR: add expert info for unknown / missing UDP framing tagsPascal Quantin1-2/+21
Change-Id: I1b71d30e5e6d5a63e14fc6daf8e2cca2b9b6f7f6 Reviewed-on: https://code.wireshark.org/review/26915 Petri-Dish: Pascal Quantin <pascal.quantin@gmail.com> Tested-by: Petri Dish Buildbot Reviewed-by: Pascal Quantin <pascal.quantin@gmail.com>
2018-04-12PDCP NR: add SN length to PDCP context for user plane PDUsPascal Quantin1-0/+5
Change-Id: I49d215e65e424e605179747d350d4f36ccbc0d92 Reviewed-on: https://code.wireshark.org/review/26894 Reviewed-by: Martin Mathieson <martin.r.mathieson@googlemail.com> Reviewed-by: Pascal Quantin <pascal.quantin@gmail.com>
2018-04-12PDCP NR: rework UDP framing formatPascal Quantin1-11/+13
Change-Id: I6f4a17ed91d4cb6ea39b5938add6ee882b033687 Reviewed-on: https://code.wireshark.org/review/26893 Reviewed-by: Martin Mathieson <martin.r.mathieson@googlemail.com> Reviewed-by: Pascal Quantin <pascal.quantin@gmail.com>
2018-04-10"#if 0" out some currently-unused value_strings.Guy Harris1-0/+2
Change-Id: I1535b8ec430bbf119c6cc58464da820603454265 Reviewed-on: https://code.wireshark.org/review/26862 Reviewed-by: Guy Harris <guy@alum.mit.edu>
2018-04-10NR (5G) PDCPMartin Mathieson1-0/+1631
Tested with some hand-generated PDUs. Change-Id: Ic603d0ca4578d23121e438ac2458be34e63492d2 Reviewed-on: https://code.wireshark.org/review/26755 Petri-Dish: Martin Mathieson <martin.r.mathieson@googlemail.com> Tested-by: Petri Dish Buildbot Reviewed-by: Martin Mathieson <martin.r.mathieson@googlemail.com>
generated by cgit v1.2.3 (git 2.25.1) at 2024-05-15 05:49:13 +0000