aboutsummaryrefslogtreecommitdiffstats
path: root/epan/dissectors/packet-pana.c
AgeCommit message (Collapse)AuthorFilesLines
2015-12-09new_create_dissector_handle -> create_dissector_handle for dissector directory.Michael Mann1-1/+1
Some of the ASN.1 dissectors still generate a new_create_dissector_handle from the tool itself, so leave those for now. Change-Id: Ic6e5803b1444d7ac24070949f5fd557909a5641f Reviewed-on: https://code.wireshark.org/review/12484 Petri-Dish: Anders Broman <a.broman58@gmail.com> Reviewed-by: Michael Mann <mmann78@netscape.net>
2015-07-17Remove all preferences related to enabling/disabling heuristic dissectors.Michael Mann1-1/+1
The preferences are still supported for backwards compatibility, but the heuristic_protos file has final say on the "preference" to enable/disable a heuristic dissector. Also add parameter to heur_dissector_add() for the "default" enable/disable of a heuristic dissector. With this parameter, a few more (presumably weak) heuristic dissectors have been "registered" but of course default to being disabled. Change-Id: I51bebb2146ef3fbb8418d4f5c7f2cb2b58003a22 Reviewed-on: https://code.wireshark.org/review/9610 Petri-Dish: Michael Mann <mmann78@netscape.net> Reviewed-by: Roland Knall <rknall@gmail.com> Reviewed-by: Hadriel Kaplan <hadrielk@yahoo.com> Reviewed-by: Michael Mann <mmann78@netscape.net>
2015-07-12Add "user presentable" and "unique string ids" to heuristic table entries.Michael Mann1-1/+1
This allows better presentation of heuristic dissectors to the end user. Change-Id: I2ff3985ab914e83c2989880cc0c7b9904045b3f6 Reviewed-on: https://code.wireshark.org/review/9602 Petri-Dish: Michael Mann <mmann78@netscape.net> Reviewed-by: Michael Mann <mmann78@netscape.net>
2015-04-22Convert proto_tree_add_boolean to ↵Michael Mann1-46/+17
proto_tree_add_bitmask_[value|value_with_flags|list] Part 2 of a few Change-Id: Ic1f1aafe2ed02dce95b15c03a91cbd68807a5cf4 Reviewed-on: https://code.wireshark.org/review/8165 Petri-Dish: Alexis La Goutte <alexis.lagoutte@gmail.com> Reviewed-by: Michael Mann <mmann78@netscape.net>
2015-03-03Replace tvb_get_ptr calls with a better API choice.Michael Mann1-4/+2
Just reduces the overall tvb_get_ptr usage count in the dissector directory. Change-Id: I455dc4cc9b082ecccdd254a2e5121f3353b5a812 Reviewed-on: https://code.wireshark.org/review/7491 Reviewed-by: Anders Broman <a.broman58@gmail.com>
2015-01-30Cleanup:Bill Meier1-5/+3
Including: tvb_length...() ==> tvb_reported_length...() Remove some dead initializers; Localize some variables; Whitespace. Change-Id: Ide9490f248d558bb7e3af96a1fc17d8f911de4ef Reviewed-on: https://code.wireshark.org/review/6862 Reviewed-by: Bill Meier <wmeier@newsguy.com>
2015-01-25pana, gsm_abis_oml, rsl, netrom: Remove 'if (tree)'Bill Meier1-3/+1
Thou shalt call col_...() and/or a dissector under 'if(tree)' Change-Id: Ibe62bc8229cb759d5f8b092aa7143d8e2f799037 Reviewed-on: https://code.wireshark.org/review/6781 Reviewed-by: Bill Meier <wmeier@newsguy.com>
2014-12-21Cleanup use of #includes in non-generated epan/dissector/*.cBill Meier1-4/+0
Specifically: - Set packet.h to be the first wireshark #include after config.h and "system" #includes. packet.h added as an #include in some cases when missing. - Remove some #includes included (directly/indirectly) in packet.h. E.g., glib.h. (Done only for those files including packet.h). - As needed, move "system" #includes to be after config.h and before wireshark #includes. - Rework various #include file specifications for consistency. - Misc. Change-Id: Ifaa1a14b50b69fbad38ea4838a49dfe595c54c95 Reviewed-on: https://code.wireshark.org/review/5923 Petri-Dish: Alexis La Goutte <alexis.lagoutte@gmail.com> Reviewed-by: Bill Meier <wmeier@newsguy.com>
2014-09-30Add editor modelines; Adjust whitespace as needed.Bill Meier1-682/+695
Change-Id: I434da226c842298f4fb2a4335d06d51e164af2af Reviewed-on: https://code.wireshark.org/review/4394 Reviewed-by: Bill Meier <wmeier@newsguy.com>
2014-09-06Eliminate proto_tree_add_text from some of the dissectors.Michael Mann1-5/+6
Other minor cleanups while in the area. Change-Id: I8ea59205cfe6fab643d8fe01b75ce91532004fd9 Reviewed-on: https://code.wireshark.org/review/4004 Reviewed-by: Michael Mann <mmann78@netscape.net> Petri-Dish: Michael Mann <mmann78@netscape.net> Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org> Reviewed-by: Alexis La Goutte <alexis.lagoutte@gmail.com>
2014-07-05convert to proto_tree_add_subtree[_format]Michael Mann1-20/+9
Change-Id: I8df48b25de784a48a25f0e48aac1e1545ed92c35 Reviewed-on: https://code.wireshark.org/review/2865 Reviewed-by: Michael Mann <mmann78@netscape.net>
2014-06-20Rename dissector_add_handle() to dissector_add_for_decode_as().Guy Harris1-1/+1
Hopefully that name makes it clear what the routiner's purpose is, and will encourage people to use it rather than using dissector_add_uint() with a bogus integer value. Change-Id: Ic5be456d0ad40b176aab01712ab7b13aed5de2a8 Reviewed-on: https://code.wireshark.org/review/2483 Reviewed-by: Guy Harris <guy@alum.mit.edu>
2014-06-19Revert "Fixup: tvb_* -> tvb_captured"Michael Mann1-1/+1
https://www.wireshark.org/lists/wireshark-dev/201406/msg00131.html This reverts commit 246fe2ca4c67d8c98caa84e2f57694f6322e2f96. Change-Id: Ib24bae0198c13a84bd7f731bf4af921212109a8f Reviewed-on: https://code.wireshark.org/review/2430 Reviewed-by: Michael Mann <mmann78@netscape.net>
2014-06-18Fixup: tvb_* -> tvb_capturedDario Lombardo1-1/+1
Change-Id: I9209c1271967405c34c1b6fa43e1726a4d3a5a3f Reviewed-on: https://code.wireshark.org/review/2377 Reviewed-by: Anders Broman <a.broman58@gmail.com>
2014-06-07tvb_new_subset -> tvb_new_subset_length when length parameters are equal.Michael Mann1-3/+3
tvb_new_subset -> tvb_new_subset_remaining it appears that's what the intention is. Change-Id: I2334bbf3f10475b3c22391392fc8b6864454de2d Reviewed-on: https://code.wireshark.org/review/1999 Reviewed-by: Pascal Quantin <pascal.quantin@gmail.com>
2014-04-29Convert a few dissectors with simple request/response tracking from ↵Pascal Quantin1-5/+5
red/black tree to hash map Update the readme file accordingly Change-Id: I056d1ab1f77df641b83fa9b3618b6c25d66e1a83 Reviewed-on: https://code.wireshark.org/review/1420 Reviewed-by: Evan Huus <eapache@gmail.com> Reviewed-by: Anders Broman <a.broman58@gmail.com>
2014-03-04Remove all $Id$ from top of fileAlexis La Goutte1-2/+0
(Using sed : sed -i '/^ \* \$Id\$/,+1 d') Fix manually some typo (in export_object_dicom.c and crc16-plain.c) Change-Id: I4c1ae68d1c4afeace8cb195b53c715cf9e1227a8 Reviewed-on: https://code.wireshark.org/review/497 Reviewed-by: Anders Broman <a.broman58@gmail.com>
2014-02-12Add support for two AVPs newly defined in RFC 6786Yasuyuki Tanaka1-1/+5
- Encryption-Encap AVP (AVP code 12) - Encryption-Algorithm AVP (AVP code 13) Change-Id: I9a4245b526bc59c2ffa228ce46c80ce3250ef0b6 Reviewed-on: https://code.wireshark.org/review/189 Reviewed-by: Alexis La Goutte <alexis.lagoutte@gmail.com>
2013-12-14Fix some trivial warnings.Jakub Zawadzki1-0/+3
svn path=/trunk/; revision=54085
2013-10-23#if 0 numerous "unused const variables" (mostly value-string-arrays);Bill Meier1-0/+2
Also; fix a few "set but not used" warnings. svn path=/trunk/; revision=52780
2013-10-09Try to make more efficient heuristick checks.Anders Broman1-6/+4
svn path=/trunk/; revision=52468
2013-08-31Convert another 10 dissectors to wmem.Evan Huus1-9/+9
svn path=/trunk/; revision=51612
2013-06-14Remove check_col() and the occasional tree.Michael Mann1-3/+1
svn path=/trunk/; revision=49921
2013-03-19From beroset:Anders Broman1-6/+6
remove C++ incompatibilities https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=8416 svn path=/trunk/; revision=48425
2012-09-20We always HAVE_CONFIG_H so don't bother checking whether we have it or not.Jeff Morriss1-2/+0
svn path=/trunk/; revision=45017
2012-09-10Initial commit to support yet another method of passing data between dissectors.Jakub Zawadzki1-1/+1
Add new parameter 'data' to heur_dissector_t and new_dissector_t, for now it's always NULL svn path=/trunk/; revision=44860
2012-06-28Update FSF address - part II.Jakub Zawadzki1-1/+1
svn path=/trunk/; revision=43538
2011-08-08Remove unneeded #includes: proto.h,tvbuff.h,value_string.h,stdlib.h,...Bill Meier1-1/+0
svn path=/trunk/; revision=38413
2011-07-29From Colin O'Flynn & Robert Craige via ↵Alexis La Goutte1-3/+24
https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=6109 Add support for PANA Relay svn path=/trunk/; revision=38257
2011-06-19Fix gcc 4.6 "set but not used [-Wunused-but-set-variable]" warnings.Bill Meier1-2/+0
svn path=/trunk/; revision=37716
2010-10-04From Yasuyuki Tanaka: Fix PANA (RFC 5191) packets are dissected incorrectly.Bill Meier1-217/+215
(AVP length as being interpreted incorrectly). https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=5183 From me: General dissector code cleanup & bug fixing: - Show/dissect AVP "value" for non-vendor-specific AVPs; - Tighten & cleanup heuristic; - Fix some potential overflow issues; - #include <stdio.h> #include <stdlib.h> not req'd; - Fix some whitespace & formatting; svn path=/trunk/; revision=34366
2010-05-13As suggested in ↵Jeff Morriss1-14/+2
http://www.wireshark.org/lists/wireshark-dev/200809/msg00075.html (as referenced in https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=2907 ) and https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=3411 : Write a new convenience routine for finding a conversation and, if it is not found, create it. The frame number and addresses are taken from pinfo (as is the common case). Use this function in a bunch of dissectors. svn path=/trunk/; revision=32790
2010-04-06#include <string.h> not needed.Bill Meier1-1/+0
svn path=/trunk/; revision=32410
2010-01-13From Didier Gautheron:Anders Broman1-1/+0
col_clear.diff Remove calls to col_clear : - called twice. - before functions which also clear the column - by replacing col_clear + col_append_xxx with col_add_xxx https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=4394 svn path=/trunk/; revision=31517
2009-08-09Don't guard col_set_str (COL_PROTOCOL) with col_checkKovarththanan Rajaratnam1-2/+1
svn path=/trunk/; revision=29340
2009-07-07From Kovarththanan Rajaratnam:Stig Bjørlykke1-2/+2
More FT_XXX cleanup. svn path=/trunk/; revision=28971
2009-05-29tvb_new_real_data -> tvb_new_child_real_dataAnders Broman1-1/+1
svn path=/trunk/; revision=28517
2008-12-19Back out r27047 and r27053.Gerald Combs1-0/+1
svn path=/trunk/; revision=27062
2008-12-18Update calls to proto_tree_add_bytes_format to reflect r27047.Gerald Combs1-1/+0
svn path=/trunk/; revision=27053
2008-09-30Minor cleanup related to proto_register, proto_reg_handoffBill Meier1-9/+4
svn path=/trunk/; revision=26307
2008-04-16The right length to use when scanning all the data in a packet is theGuy Harris1-26/+50
*reported* length, so that if the packet was cut short by a snapshot length, we get an exception because we run past the end, and the packet is marked as having been cut short. Do not use DISSECTOR_ASSERT() to check for the validity of packet data; dissectors should try to handle even malformed packets, they shouldn't report malformed packets as dissector bugs (if DISSECTOR_ASSERT(), that is *ipso facto* evidence of a dissector bug, *even if the packet is malformed*). Update the offset when scanning the packet even if we *aren't* building the protocol tree. svn path=/trunk/; revision=25068
2008-04-15Call DISSECTOR_ASSERT instead of g_assert in dissector code.Stig Bjørlykke1-1/+1
This fixes bug 2464. svn path=/trunk/; revision=25039
2008-03-15From http://bugs.wireshark.org/bugzilla/show_bug.cgi?id=1539 :Jeff Morriss1-2/+2
Hexadecimal and octal are unsigned. Don't let dissectors register signed fields (FT_INT*) to be displayed in hexadecimal (including HEX_DEC and DEC_HEX) or octal. Fix dissectors that do that mostly by changing the fields to unsigned though in PANA it appears the fields are meant to be signed so change those fields to be displayed in decimal. This fixes an assertion crash in hfinfo_numeric_format() if/when someone tries to create a filter using one of these mixed signed/unsigned fields (because that routine does not know how to present the user with a signed value in hex). Also add FT_*INT64 to the "make sure it's not BASE_NONE" check. svn path=/trunk/; revision=24643
2008-03-04match_strval() may return NULL so don't blindly pass its return value into ↵Jeff Morriss1-4/+5
col_add_*() or proto_add_*(); use val_to_str() (returning "Unknown (%d)" if no match is found) instead. svn path=/trunk/; revision=24557
2007-10-12Fix bug 1908: strengthen the PANA new-style-dissector heuristics by checking ↵Jeff Morriss1-0/+17
that the length of the first AVP is less than the length of the message. svn path=/trunk/; revision=23167
2007-08-22The reserved field is now 16 bits. Treat it as such.Jaap Keuter1-2/+2
svn path=/trunk/; revision=22585
2007-08-22From Victor Fajardo:Jaap Keuter1-57/+38
Updated patches to support draft-ietf-pana-pana-18.txt. svn path=/trunk/; revision=22583
2007-07-10Fix reserved bits bitmask.Jaap Keuter1-1/+1
svn path=/trunk/; revision=22282
2007-06-14From Victor Fajardo:Jaap Keuter1-74/+39
Attached is a patch file for the PANA protocol dissector. The changes updates the packet-pana.c dissector to support draft-ietf-pana-pana-15.txt. svn path=/trunk/; revision=22098
2007-05-08From Victor Fajardo:Stephen Fisher1-1/+1
The packet-pana.c dissector I have submitted previously [SVN rev 21447] had a minor issue. The following are the fixes: Change packet-pana.c, Line 823: { "Ping","pana.flags.e", to: { "Error","pana.flags.e", svn path=/trunk/; revision=21731
generated by cgit v1.2.3 (git 2.25.1) at 2024-06-29 15:54:18 +0000