Age | Commit message (Collapse) | Author | Files | Lines |
|
svn path=/trunk/; revision=51423
|
|
(https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=9045)
- Expert info for CRC 0x5935 got wrongly attached to Slim SSDO packages
- SPDO Data Requests that fit in the last bytes of a frame got missed
- Slim SSDOs got detected, that actually are not Slim SSDOs, to prevent this in the future, two checks have been added
- The reported length of a Slim SSDO must be larger than 0 (correct
Slim SSDOs always have at least 1 byte)
- Both crc's must differ from another. There is a very unlikely
possibility, that they may collide, but in such a case openSAFETY
in itself would be flawed by design.
svn path=/trunk/; revision=51408
|
|
the same structure.
This is begin of work to split fragment head and fragments items.
svn path=/trunk/; revision=50708
|
|
svn path=/trunk/; revision=50384
|
|
svn path=/trunk/; revision=50368
|
|
svn path=/trunk/; revision=50363
|
|
The final maintenance patch, after excessive testing of the dissection engine.
The last two bugs were:
- FindSafetyFrame did not recognize the correct CRC, which in itself did not
lead to wrongly detected packages, but was inconsistent with the rest.
- CRC == 0 - because 0 is a valid result for the CRC value.
svn path=/trunk/; revision=50312
|
|
In my last patch (bug #8847), I overlooked a place where I had to check for
the old CRC as well, which led to packages that were not detected anymore.
This 4 lines fix it. As usual, the patch was tested and works.
svn path=/trunk/; revision=50294
|
|
8847 (https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=8847)
From Roland Knall
svn path=/trunk/; revision=50166
|
|
Fix openSafety reassembly and dissection when the first package has
a payload length of 0.
svn path=/trunk/; revision=48877
|
|
Numerous improvements and fixes for the OpenSafety dissector (too many to
usefully list here; see the bug).
As noted by Pascal, also fix a copy-paste error in the preferences registration.
svn path=/trunk/; revision=48817
|
|
remove C++ incompatibilities
https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=8416
svn path=/trunk/; revision=48425
|
|
The misspellings were mostly in comments but some were
in text strings visible to the user.
svn path=/trunk/; revision=47899
|
|
unused hf[] entries (which I should have done in the first place).
svn path=/trunk/; revision=47390
|
|
svn path=/trunk/; revision=47302
|
|
proto_tree_add_item().
svn path=/trunk/; revision=46598
|
|
Allow for specific enabling and disabling of heuristic dissectors.
https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=7997
svn path=/trunk/; revision=46085
|
|
Fixes
> OOPS: dissector table "mbtcp.modbus.data" doesn't exist
> Protocol being registered is "openSAFETY"
introduced in revision 45793.
svn path=/trunk/; revision=45807
|
|
during fuzz testing or randpkt testing; somebody might be putting bad
packets on the wire to try to, for example, crash or break into your
protocol implementation.
svn path=/trunk/; revision=45749
|
|
svn path=/trunk/; revision=45017
|
|
Add new parameter 'data' to heur_dissector_t and new_dissector_t, for now it's always NULL
svn path=/trunk/; revision=44860
|
|
svn path=/trunk/; revision=44748
|
|
(COPYING will be updated in next commit)
svn path=/trunk/; revision=43536
|
|
svn path=/trunk/; revision=43177
|
|
openSAFETY - Names for certain SOD objects, automatic SCM UDID detecion.
https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=7335
svn path=/trunk/; revision=43109
|
|
svn path=/trunk/; revision=41825
|
|
openSAFETY - Cleanup SSDO dissection, add additional information, remove logic bug
- rename isRequest to isResponse, which is the right name for it
- clean-up elseif to a better readable stand-alone if-clause
- add sender for response package without valid scm
svn path=/trunk/; revision=41824
|
|
Guards the calledOnce boolean, against malformed traps, using register_frame_end_routine.
Fixes openSAFETY - Malformed packets disable the dissector for the WS session
https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=6950
svn path=/trunk/; revision=41674
|
|
In some cases:
Use val_to_str_const() instead of val_to_str();
Reformat long lines;
Do some general whitespace changes.
svn path=/trunk/; revision=41587
|
|
Rare messages can be malformed as such, that the first part is valid, the
second part fails. For SNMT messages, this patch fixes the problem as such that
it displays a correct column header and adds an expert info explaining the
issue.
svn path=/trunk/; revision=40829
|
|
dereferenced. If g_byte_array_new() can return NULL, then the code should be modified to protect against deferencing the NULL pointer much sooner than this.
svn path=/trunk/; revision=40251
|
|
Clean up indentation.
svn path=/trunk/; revision=40217
|
|
- New Config option to configure the sequence of frames using UDP
- an Info will be added, if the SCM UDID is not configured or if it is wrongly
configured, so that the user can act on it.
- SCM UDID will only be printed if configured correctly, if not a warning will
be added to inform, that the first byte for the UDID will be assumed to be 00
- UDP dissection can enforce the number of sub-package the dissection should
assume
- SSDO: isRequest is determined by it's field not by the message id
- SSDO: Unused code for SNMT Reset Guarding SCM has been removed
- SNMT: error_group and error_code for SN_FAIL have not been dissected
correctly
- Sercos III: bug != instead of ==, is fixed
- dissect_opensafety_udp renamed to dissect_opensafety_udpdata, because of
future dissector called opensafety_udp which will handle transport of
openSAFETY data over UDP
- dissect_opensafety_udpdata enhanced to determine the index of the given frame
in the package. Needed for correct assembly of COL_INFO
- Added heuristic dissector hook for opensafety_udp dissector. The dissector
will be submitted to this list at a future point
- Enhanced description of the dissector to reflect it's capabilities
- Reworked the description for the config options to be more understandable
https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=6672
svn path=/trunk/; revision=40214
|
|
tvb_set_child_real_data_tvbuff().
svn path=/trunk/; revision=40173
|
|
- Remove unneeded #includes;
- Use val_to_str_const() in several places;
- Reformat long lines;
- Fix whitepace and indentation.
svn path=/trunk/; revision=40016
|
|
Use CRC routines from wsutil + some Code-Clang Analysis fixes.
svn path=/trunk/; revision=39730
|
|
Remove stringToBytes and use hex_str_to_bytes instead.
svn path=/trunk/; revision=39725
|
|
Remove the warnings for the Clang-Code-Analysis.
https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=6538
svn path=/trunk/; revision=39717
|
|
- Renaming opensafety.msg.type to opensafety.msg.direction
- Introducing real opensafety.msg.type as opensafety.msg.category and generated
field
- Adding openSAFETY Sender and Receiver field, for all types of messages
- Adding openSAFETY Domain number and Node number as generated fields, which
allows filtering for them
- Rework PACKET_RECEIVED_BY and PACKET_SEND_FROM_TO_ALL to PACKET_RECEIVER and
PACKET_SENDER
- Replaced PACKET_SEND_FROM_TO with calls to PACKET_RECEIVER and PACKET_SENDER
- Added functions, so that the new sender and receiver fields as well as
network information are added as sub-trees
- Removed DISSECTOR_ASSERT in opensafety_get_scm_udid as it is not needed here
anymore
- Added the connection valid bit to the dissection tree ( has been there as
message type, but was never validated )
- Added calculations for Domain Network Addr, depending if a valid UDID for the
SCM is present in SSDO and SPDO
- Corrected error, where sub-tree for spdo dissection used global ssdo_tree
instead of spdo_tree
- Added "Message Type unknown" which leads to PI_MALFORMED marked entry in
dissect_opensafety_message
- Added check for ( length - frameOffset ) is below or equal zero, to avoid
using dissector asserts
- Added check for freak frame start detection, where both frame starts would be
equal (could happen during fuzztest)
- Removed DISSECTOR_ASSERT for both frame starts being different
- Added check, that if the frame address is above 1024, the package get's
marked as PI_MALFORMED (fuzztest)
- Fixed CID 1215, CID 1224 and CID 1246/1247
- Corrected naming issue with openSAFETY/SercosIII dissection using UDP
transport
https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=6528
svn path=/trunk/; revision=39701
|
|
Also: remove trailing whitespace for a number of files.
svn path=/trunk/; revision=39503
|
|
Roland Knall. See http://www.wireshark.org/lists/wireshark-dev/201109/msg00160.html. Also, convert the relatively few tabs to 4-spaces to match the rest of this dissector's white space choice and add modelines.
svn path=/trunk/; revision=39204
|
|
Address Coverty issues CID 1204, CID 1215, CID 1224, CID 1246, CID 1247
https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=6400
svn path=/trunk/; revision=39182
|
|
didn't care to see the "openSAFETY - Profinet IO heuristic dissector cannot be registered, openSAFETY/PNIO native dissection." message when I ran, "tshark -v".
svn path=/trunk/; revision=38676
|
|
svn path=/trunk/; revision=38413
|
|
must not just do a "continue" if the offset into the packet has not been
advanced, as you will get an infinite loop if you do.
svn path=/trunk/; revision=38383
|
|
svn path=/trunk/; revision=38315
|
|
openSAFETY: Cleaning up, removing multiple implementations and cleaning up code
https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=6180
svn path=/trunk/; revision=38307
|
|
Reference: https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=6138
svn path=/trunk/; revision=38213
|
|
svn path=/trunk/; revision=38049
|
|
This patch will add preliminary Profinet IO transport protocol dissection to
the openSAFETY protocol.
https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=6063
svn path=/trunk/; revision=37887
|