aboutsummaryrefslogtreecommitdiffstats
path: root/epan/dissectors/packet-openflow_v5.c
AgeCommit message (Collapse)AuthorFilesLines
2017-05-15Openflow(v5): use BASE_SPECIAL_VALSAlexis La Goutte1-605/+102
for avoid duplicated hf Change-Id: I93ba76e2594e61f8dec9a78540b46025326b1ee6 Reviewed-on: https://code.wireshark.org/review/21660 Petri-Dish: Alexis La Goutte <alexis.lagoutte@gmail.com> Reviewed-by: Michael Mann <mmann78@netscape.net> Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org> Reviewed-by: Anders Broman <a.broman58@gmail.com>
2017-05-14Openflow(v5): fix field typoAlexis La Goutte1-2/+2
Change-Id: I101f760a64e4beec73483eeda93068798b140d69 Reviewed-on: https://code.wireshark.org/review/21640 Reviewed-by: Anders Broman <a.broman58@gmail.com>
2017-02-01Openflow (v5): fix redundant redeclaration of ↵Alexis La Goutte1-5/+0
‘dissect_openflow_message_v5’ [-Wredundant-decls] Change-Id: I6340f0b903af1371e69172b05650c49fc18b8890 Reviewed-on: https://code.wireshark.org/review/19888 Reviewed-by: Michael Mann <mmann78@netscape.net>
2017-01-18OpenFlow (v5/1.4): Add complete dissection of error messagesAlexis La Goutte1-4/+22
Like for OpenFlow (v4/1.3) (g4b7c2781fb) Change-Id: I61cfea015e548e5eaa37856df86e96bd0ba21795 Ping-Bug: 13221 Reviewed-on: https://code.wireshark.org/review/19644 Petri-Dish: Anders Broman <a.broman58@gmail.com> Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org> Reviewed-by: Anders Broman <a.broman58@gmail.com>
2016-11-07Added Dissector for Openflow Experimenter Value field for Openflow 1.3 and 1.4sangodbole1-0/+10
Change-Id: I79d7b9afbde34451b545ac7e67c22b012843d822 Reviewed-on: https://code.wireshark.org/review/18654 Petri-Dish: Alexis La Goutte <alexis.lagoutte@gmail.com> Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org> Reviewed-by: Michael Mann <mmann78@netscape.net>
2016-11-02Openflow (v4/v5): Add vOXM vlan mask fieldAlexis La Goutte1-0/+10
Bug: 12979 Change-Id: I7f0e806081704dfeaf40ce1e4e41271ffd5e3023 Reviewed-on: https://code.wireshark.org/review/18618 Petri-Dish: Alexis La Goutte <alexis.lagoutte@gmail.com> Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org> Reviewed-by: Michael Mann <mmann78@netscape.net>
2016-10-30OpenFlow 1.4: check length to avoid rewinding offsetPascal Quantin1-4/+32
Bug: 13071 Change-Id: Ia9d55212fe8423311222330ed516da35ee9f53de Reviewed-on: https://code.wireshark.org/review/18565 Reviewed-by: Pascal Quantin <pascal.quantin@gmail.com> Petri-Dish: Pascal Quantin <pascal.quantin@gmail.com> Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org> Reviewed-by: Michael Mann <mmann78@netscape.net>
2016-10-04Openflow (v4/v5): Add check if all length is decodedAlexis La Goutte1-0/+8
Change-Id: I7846dd04c45d0398ded8345b6a2794d6f851cb64 Ping-Bug: 12979 Reviewed-on: https://code.wireshark.org/review/18065 Reviewed-by: Alexis La Goutte <alexis.lagoutte@gmail.com> Petri-Dish: Alexis La Goutte <alexis.lagoutte@gmail.com> Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org> Reviewed-by: Michael Mann <mmann78@netscape.net>
2016-06-15Allow control of individual columns to be (un)writable.Michael Mann1-6/+6
Most protocols just want to limit COL_INFO or COL_PROTOCOL so give that level of granularity. Bug: 12144 Bug: 5117 Bug: 11144 Change-Id: I8de9b7d2c69e90d3fbfc0a52c2bd78c3de58e2f8 Reviewed-on: https://code.wireshark.org/review/15894 Reviewed-by: Jeff Morriss <jeff.morriss.ws@gmail.com> Petri-Dish: Anders Broman <a.broman58@gmail.com> Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org> Reviewed-by: Anders Broman <a.broman58@gmail.com>
2016-04-27OpenFlow: fix flow_monitor_request dissectorIWASE Yusuke1-2/+4
This patch fixes: - offset calculation - monitor_id field description Change-Id: I9568b8897ca9ebbc6203db6640b88e1b1676448d Reviewed-on: https://code.wireshark.org/review/15128 Reviewed-by: Guy Harris <guy@alum.mit.edu>
2016-03-20Manually add protocol dependencies derived from find_dissector.Michael Mann1-2/+7
Started by grepping call_dissector_with_data, call_dissector_only and call_dissector and traced the handles passed into them to a find_dissector within the dissector. Then replaced find_dissector with find_dissector_add_dependency and added the protocol id from the dissector. "data" dissector was not considered to be a dependency. Change-Id: I15d0d77301306587ef8e7af5876e74231816890d Reviewed-on: https://code.wireshark.org/review/14509 Petri-Dish: Michael Mann <mmann78@netscape.net> Reviewed-by: Michael Mann <mmann78@netscape.net>
2016-02-26Add free_address_wmem(), fix warnings [-Wcast-qual]João Valverde1-24/+24
Try to improve address API and also fix some constness warnings by not overloading the 'data' pointer to store malloc'ed buffers (use private pointer for that instead). Second try, now passing test suite. Change-Id: Idc101cd866b6d4f13500c9d59da5c7a38847fb7f Reviewed-on: https://code.wireshark.org/review/13946 Petri-Dish: João Valverde <j@v6e.pt> Reviewed-by: Alexis La Goutte <alexis.lagoutte@gmail.com> Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org> Reviewed-by: João Valverde <j@v6e.pt>
2016-02-08Revert "Add free_address_wmem() and other extensions to address API"João Valverde1-24/+24
This reverts commit 13ec77a9fc3af3b0b502820d0b55796c89997896. This commit introduces a segmentation fault for Lua code (uncovered by the test suite). Change-Id: Ibc273d1915cda9632697b9f138f0ae104d3fb65e Reviewed-on: https://code.wireshark.org/review/13813 Reviewed-by: João Valverde <j@v6e.pt>
2016-02-07Add free_address_wmem() and other extensions to address APIJoão Valverde1-24/+24
Try to improve 'address' API (to be easier/safer) and also avoid some constness warnings by not overloading the 'data' pointer to store malloc'ed buffers (use private pointer for that instead). Change-Id: I7456516b12c67620ceadac447907c12f5905bd49 Reviewed-on: https://code.wireshark.org/review/13463 Petri-Dish: João Valverde <j@v6e.pt> Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org> Reviewed-by: João Valverde <j@v6e.pt>
2015-12-09new_register_dissector -> register_dissector for dissector directory.Michael Mann1-1/+1
Change-Id: Ie39ef054a4a942687bd079f3a4d8c2cc55d5f22c Reviewed-on: https://code.wireshark.org/review/12485 Petri-Dish: Michael Mann <mmann78@netscape.net> Reviewed-by: Michael Mann <mmann78@netscape.net>
2015-11-04[OpenFlow] Use correct name for flag OFPMPF_REPLY_MORE in v5 dissectorPavlos Antoniou1-2/+3
Change-Id: Ia8cb88d4d884be95814f4a144a4c3b07b32ffca7 Reviewed-on: https://code.wireshark.org/review/11543 Reviewed-by: Alexis La Goutte <alexis.lagoutte@gmail.com> Petri-Dish: Alexis La Goutte <alexis.lagoutte@gmail.com> Reviewed-by: Anders Broman <a.broman58@gmail.com>
2015-10-19[OpenFlow] Fix a crash caused by the same filter name used for severalAndersBroman1-10/+10
different ftypes. Change-Id: Idf4335b2ab733af74afd23bdde066bff81d13952 Reviewed-on: https://code.wireshark.org/review/11148 Reviewed-by: Anders Broman <a.broman58@gmail.com> Petri-Dish: Anders Broman <a.broman58@gmail.com> Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org> Reviewed-by: Michael Mann <mmann78@netscape.net>
2015-07-15Openflow - prevent infinite loopMichael Mann1-0/+6
Change-Id: I93ce7151467c890c12f7d612b5a7eecf5f91c189 Ping-Bug: 11358 Reviewed-on: https://code.wireshark.org/review/9640 Reviewed-by: Alexis La Goutte <alexis.lagoutte@gmail.com> Petri-Dish: Alexis La Goutte <alexis.lagoutte@gmail.com> Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org> Reviewed-by: Michael Mann <mmann78@netscape.net>
2014-12-27OpenFlow: fix dissection of async_config_prop structurePascal Quantin1-10/+12
Bug: 10808 Change-Id: I5ef46cd6b85c415e23dfdbe7a56c8b332eaae5a3 Reviewed-on: https://code.wireshark.org/review/6078 Reviewed-by: Pascal Quantin <pascal.quantin@gmail.com> Petri-Dish: Pascal Quantin <pascal.quantin@gmail.com> Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org> Reviewed-by: Anders Broman <a.broman58@gmail.com>
2014-12-21Cleanup use of #includes in non-generated epan/dissector/*.cBill Meier1-1/+0
Specifically: - Set packet.h to be the first wireshark #include after config.h and "system" #includes. packet.h added as an #include in some cases when missing. - Remove some #includes included (directly/indirectly) in packet.h. E.g., glib.h. (Done only for those files including packet.h). - As needed, move "system" #includes to be after config.h and before wireshark #includes. - Rework various #include file specifications for consistency. - Misc. Change-Id: Ifaa1a14b50b69fbad38ea4838a49dfe595c54c95 Reviewed-on: https://code.wireshark.org/review/5923 Petri-Dish: Alexis La Goutte <alexis.lagoutte@gmail.com> Reviewed-by: Bill Meier <wmeier@newsguy.com>
2014-11-26openflow: Use (what appear to be the) correct filter names for a few fields.Bill Meier1-4/+4
Change-Id: I2acd93d99942601b34c85177d21bbc2c4a4e2633 Reviewed-on: https://code.wireshark.org/review/5492 Reviewed-by: Anders Broman <a.broman58@gmail.com>
2014-11-25openflow: Minor changesBill Meier1-127/+128
- Remove unneeded/undefined forward declarations; - Create/use some extended value-strings; - Do some whitespace changes. Change-Id: I7961864f0e404e141d2887584751116011f8d941 Reviewed-on: https://code.wireshark.org/review/5490 Reviewed-by: Bill Meier <wmeier@newsguy.com>
2014-09-19Do encoding-arg changes (all benign)Bill Meier1-7/+7
For: - FT_BYTES: Always use just ENC_NA - integral/floating (other than FT_[U]INT8): Do ENC_NA --> ENC_BIG_ENDIAN Also: - FT_UINT... --> FT_UINT8 in a few cases (to match proto_tree_add_item...) - Change one case of incorrect '||' to '|' Change-Id: I427e0e61618ff8faf55691c8a695930f67d455b0 Reviewed-on: https://code.wireshark.org/review/4184 Reviewed-by: Bill Meier <wmeier@newsguy.com>
2014-07-06Widen openflow variables and check for underflowsEvan Huus1-16/+29
As suggested by Alexis reviewing change Ie76c5a810af927b, this issue was scattered throughout the v4/v5 openflow dissectors. Hopefully I got all of them. Original issue found in bug 10259. Change-Id: Idf87deea34132aec5cd4e8f83264906a29b15568 Reviewed-on: https://code.wireshark.org/review/2878 Reviewed-by: Evan Huus <eapache@gmail.com> Reviewed-by: Alexis La Goutte <alexis.lagoutte@gmail.com>
2014-07-05convert to proto_tree_add_subtree[_format]Michael Mann1-94/+38
Change-Id: I8df48b25de784a48a25f0e48aac1e1545ed92c35 Reviewed-on: https://code.wireshark.org/review/2865 Reviewed-by: Michael Mann <mmann78@netscape.net>
2014-06-20Cleanup display filters reported by checkfiltername.plMichael Mann1-1/+1
Also ensured some files have their correct names at the top so they are more easily grepped Change-Id: Ib0f5ddf14eb1616a93dee496107dc0eb09048825 Reviewed-on: https://code.wireshark.org/review/2452 Reviewed-by: Michael Mann <mmann78@netscape.net>
2014-06-19Fix underflow causing infinite loop in openflow dissectorEvan Huus1-4/+9
Bug:10208 Change-Id: I8aff9523fd33cf9e0802153100ea032139966b26 Reviewed-on: https://code.wireshark.org/review/2440 Reviewed-by: Evan Huus <eapache@gmail.com>
2014-06-07tvb_new_subset -> tvb_new_subset_length when length parameters are equal.Michael Mann1-2/+2
tvb_new_subset -> tvb_new_subset_remaining it appears that's what the intention is. Change-Id: I2334bbf3f10475b3c22391392fc8b6864454de2d Reviewed-on: https://code.wireshark.org/review/1999 Reviewed-by: Pascal Quantin <pascal.quantin@gmail.com>
2014-05-28Minor: use VALS macro (as per convention); Add editor modelines; Do ↵Bill Meier1-1/+14
whitespace changes. Change-Id: I6007c1b2098d06e4a892474dd07f06a7538f94ef Reviewed-on: https://code.wireshark.org/review/1843 Reviewed-by: Bill Meier <wmeier@newsguy.com>
2014-05-25Grab-bag of dead initializers and two actual bugs.Evan Huus1-1/+0
All caught by cppcheck. The two (semi)-interesting bugs are: - in asn1/atn-cpdlc/packet-atn-cpdlc-template.c where the break statement should have been inside the brace, causing potential control-flow weirdness with exceptions - in epan/dissectors/packet-ieee80211.c where the bounds check for tag_len did not match the expert info given Change-Id: Ie173fb8d917aabb9b4571435d671d6f16e1c7569 Reviewed-on: https://code.wireshark.org/review/1793 Reviewed-by: Alexis La Goutte <alexis.lagoutte@gmail.com> Reviewed-by: Evan Huus <eapache@gmail.com>
2014-05-05OpenFlow 1.4 OXM field OXM_OF_IPV6_ND_SLL incorrectly dissected (128 bits ↵Alexis La Goutte1-2/+2
read instead of 48) Dissection of OXM_OF_IPV6_ND_SLL triggers "malformed packet" comment in packet list since it makes dissecting of further OXM fields impossible. It is possible that similar issue will be with OXM_OF_IPV6_ND_TLL since its dissecting is basically the same. Issue found by Viktor Closed-bug:10011 Change-Id: I21b85cc0572ffdb8bb8b73cfae0db1d72219fe4b Reviewed-on: https://code.wireshark.org/review/1505 Reviewed-by: Anders Broman <a.broman58@gmail.com>
2014-05-04Update some soft-deprecated APIs.AndersBroman1-1/+1
Change-Id: I0e255e72dd4cd9a94a4f92af409c4b34c0a266ed Reviewed-on: https://code.wireshark.org/review/1491 Reviewed-by: Anders Broman <a.broman58@gmail.com>
2014-04-15Fix typo in packet-openflow_v1 and v5Shu Shen1-1/+1
Change-Id: Iefc02123447edecbd02cd9a31fff0f412edc8461 Signed-off-by: Shu Shen <shu.shen@gmail.com> Reviewed-on: https://code.wireshark.org/review/1148 Reviewed-by: Evan Huus <eapache@gmail.com>
2014-04-06Apply found fix-encoding-args.pl errors in the dissector directory.Michael Mann1-5/+5
I coincidentally found a few files with errors, so I thought it might be time to run it on the whole directory again. Change-Id: Ia32e54b3b1b94e5a418ed758ea79807c8bc7e798 Reviewed-on: https://code.wireshark.org/review/978 Reviewed-by: Michael Mann <mmann78@netscape.net>
2014-03-17Try to fix trivial varningsAndersBroman1-3/+3
Change-Id: I7b09999fe34ffded73f0b26c3e561b39d2120643 Reviewed-on: https://code.wireshark.org/review/714 Reviewed-by: Anders Broman <a.broman58@gmail.com>
2014-03-04Remove all $Id$ from top of fileAlexis La Goutte1-2/+0
(Using sed : sed -i '/^ \* \$Id\$/,+1 d') Fix manually some typo (in export_object_dicom.c and crc16-plain.c) Change-Id: I4c1ae68d1c4afeace8cb195b53c715cf9e1227a8 Reviewed-on: https://code.wireshark.org/review/497 Reviewed-by: Anders Broman <a.broman58@gmail.com>
2014-02-25Remove trailing whitespace.Bill Meier1-1/+1
Change-Id: Ia03a1cd4590aceda30ead4aa93ad413d90c6aea6 Reviewed-on: https://code.wireshark.org/review/372 Reviewed-by: Bill Meier <wmeier@newsguy.com> Tested-by: Bill Meier <wmeier@newsguy.com>
2014-01-29Add newlines at end of files that are missing them.Gilbert Ramirez1-3/+0
gcc 4.1.2 complained with: No newline at end of file Change-Id: I813af88737e725a328713eea4a7096d28942f9b2
2014-01-14Fix unused const variable found by Clang 3.4Alexis La Goutte1-0/+5
svn path=/trunk/; revision=54790
2014-01-07From Zoltán Lajos Kis:Anders Broman1-1040/+2734
OpenFlow 1.4 dissector: add missing features https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=9621 svn path=/trunk/; revision=54625
2013-12-14Remove not needed ';'Jakub Zawadzki1-3/+3
svn path=/trunk/; revision=54088
2013-11-18I guess "v4" is 1.3 and "v5" is 1.4. I'm sure there's a reason why thatGuy Harris1-1/+1
makes sense of a sort.... svn path=/trunk/; revision=53409
2013-11-18You don't get to have three separate protocols all with the nameGuy Harris1-1/+1
"OpenFlow 1.3". svn path=/trunk/; revision=53408
2013-11-18From Zoltán Lajos Kis:Anders Broman1-0/+8164
Start of OpenFlow 1.4 dissector. svn path=/trunk/; revision=53405
generated by cgit v1.2.3 (git 2.25.1) at 2024-09-25 17:28:31 +0000