aboutsummaryrefslogtreecommitdiffstats
path: root/epan/dissectors/packet-openflow_v4.c
AgeCommit message (Collapse)AuthorFilesLines
2019-07-26HTTPS (almost) everywhere.Guy Harris1-1/+1
Change all wireshark.org URLs to use https. Fix some broken links while we're at it. Change-Id: I161bf8eeca43b8027605acea666032da86f5ea1c Reviewed-on: https://code.wireshark.org/review/34089 Reviewed-by: Guy Harris <guy@alum.mit.edu>
2018-04-15openflow: fix decode of experimenter OXM fieldsJaime Caamaño Ruiz1-13/+6
No longer report decoded experimenter values as undecoded which was causing incorrect offset handling. Change-Id: If902f8c8c5b53b8062e88229d67728bb67557062 Signed-off-by: Jaime Caamaño Ruiz <jcaamano@suse.com> Reviewed-on: https://code.wireshark.org/review/26888 Petri-Dish: Alexis La Goutte <alexis.lagoutte@gmail.com> Tested-by: Petri Dish Buildbot Reviewed-by: Anders Broman <a.broman58@gmail.com>
2018-02-12dissectors: use SPDX identifiers.Dario Lombardo1-13/+1
Change-Id: I92c94448e6641716d03158a5f332c8b53709423a Reviewed-on: https://code.wireshark.org/review/25756 Petri-Dish: Dario Lombardo <lomato@gmail.com> Reviewed-by: Anders Broman <a.broman58@gmail.com>
2017-05-16Openflow (v4): use BASE_SPECIAL_VALSAlexis La Goutte1-540/+91
to avoid duplicated hf (like for v5 4b90e93f37cb092472db314ca0df3ce9503e1827) Change-Id: I7658a98c36cc42dc67f85b84fb16f36f5e505032 Reviewed-on: https://code.wireshark.org/review/21672 Reviewed-by: Michael Mann <mmann78@netscape.net> Petri-Dish: Michael Mann <mmann78@netscape.net> Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org> Reviewed-by: Anders Broman <a.broman58@gmail.com>
2017-05-15Openflow(v4): fix field typoAlexis La Goutte1-2/+2
Like for OpenFlow(v5) see a88594b093f29220cb2f8825b5dcc06bcaf91e38 Change-Id: Ifcfd398729a1d102a45de3bf86ec98bab285603f Reviewed-on: https://code.wireshark.org/review/21669 Reviewed-by: Anders Broman <a.broman58@gmail.com>
2017-01-11OpenFlow (v4/1.3): rename dissect_openflow_payload_v4 to ↵Alexis La Goutte1-13/+16
dissect_openflow_message_v4 Like OpenFlow (v5/1.4) dissector and include dissect_openflow_header_v4 Ping-Bug: 13221 Change-Id: I123fad871bcb1c9d54946500505525d55a81f8f3 Reviewed-on: https://code.wireshark.org/review/19602 Petri-Dish: Anders Broman <a.broman58@gmail.com> Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org> Reviewed-by: Anders Broman <a.broman58@gmail.com>
2017-01-01OpenFlow (v4/1.3): Add complete dissection of error messagesAlexis La Goutte1-24/+52
Bug: 13221 Change-Id: Ide3e734fca280a294a993afade2503cd751d78a2 Reviewed-on: https://code.wireshark.org/review/19459 Reviewed-by: Anders Broman <a.broman58@gmail.com> Petri-Dish: Anders Broman <a.broman58@gmail.com> Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org> Reviewed-by: Michael Mann <mmann78@netscape.net>
2016-11-07Added Dissector for Openflow Experimenter Value field for Openflow 1.3 and 1.4sangodbole1-0/+10
Change-Id: I79d7b9afbde34451b545ac7e67c22b012843d822 Reviewed-on: https://code.wireshark.org/review/18654 Petri-Dish: Alexis La Goutte <alexis.lagoutte@gmail.com> Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org> Reviewed-by: Michael Mann <mmann78@netscape.net>
2016-11-02Openflow (v4/v5): Add vOXM vlan mask fieldAlexis La Goutte1-0/+10
Bug: 12979 Change-Id: I7f0e806081704dfeaf40ce1e4e41271ffd5e3023 Reviewed-on: https://code.wireshark.org/review/18618 Petri-Dish: Alexis La Goutte <alexis.lagoutte@gmail.com> Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org> Reviewed-by: Michael Mann <mmann78@netscape.net>
2016-10-04Openflow (v4/v5): Add check if all length is decodedAlexis La Goutte1-0/+8
Change-Id: I7846dd04c45d0398ded8345b6a2794d6f851cb64 Ping-Bug: 12979 Reviewed-on: https://code.wireshark.org/review/18065 Reviewed-by: Alexis La Goutte <alexis.lagoutte@gmail.com> Petri-Dish: Alexis La Goutte <alexis.lagoutte@gmail.com> Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org> Reviewed-by: Michael Mann <mmann78@netscape.net>
2016-06-15Allow control of individual columns to be (un)writable.Michael Mann1-6/+6
Most protocols just want to limit COL_INFO or COL_PROTOCOL so give that level of granularity. Bug: 12144 Bug: 5117 Bug: 11144 Change-Id: I8de9b7d2c69e90d3fbfc0a52c2bd78c3de58e2f8 Reviewed-on: https://code.wireshark.org/review/15894 Reviewed-by: Jeff Morriss <jeff.morriss.ws@gmail.com> Petri-Dish: Anders Broman <a.broman58@gmail.com> Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org> Reviewed-by: Anders Broman <a.broman58@gmail.com>
2016-03-20Manually add protocol dependencies derived from find_dissector.Michael Mann1-2/+7
Started by grepping call_dissector_with_data, call_dissector_only and call_dissector and traced the handles passed into them to a find_dissector within the dissector. Then replaced find_dissector with find_dissector_add_dependency and added the protocol id from the dissector. "data" dissector was not considered to be a dependency. Change-Id: I15d0d77301306587ef8e7af5876e74231816890d Reviewed-on: https://code.wireshark.org/review/14509 Petri-Dish: Michael Mann <mmann78@netscape.net> Reviewed-by: Michael Mann <mmann78@netscape.net>
2016-02-26Add free_address_wmem(), fix warnings [-Wcast-qual]João Valverde1-24/+24
Try to improve address API and also fix some constness warnings by not overloading the 'data' pointer to store malloc'ed buffers (use private pointer for that instead). Second try, now passing test suite. Change-Id: Idc101cd866b6d4f13500c9d59da5c7a38847fb7f Reviewed-on: https://code.wireshark.org/review/13946 Petri-Dish: João Valverde <j@v6e.pt> Reviewed-by: Alexis La Goutte <alexis.lagoutte@gmail.com> Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org> Reviewed-by: João Valverde <j@v6e.pt>
2016-02-08Revert "Add free_address_wmem() and other extensions to address API"João Valverde1-24/+24
This reverts commit 13ec77a9fc3af3b0b502820d0b55796c89997896. This commit introduces a segmentation fault for Lua code (uncovered by the test suite). Change-Id: Ibc273d1915cda9632697b9f138f0ae104d3fb65e Reviewed-on: https://code.wireshark.org/review/13813 Reviewed-by: João Valverde <j@v6e.pt>
2016-02-07Add free_address_wmem() and other extensions to address APIJoão Valverde1-24/+24
Try to improve 'address' API (to be easier/safer) and also avoid some constness warnings by not overloading the 'data' pointer to store malloc'ed buffers (use private pointer for that instead). Change-Id: I7456516b12c67620ceadac447907c12f5905bd49 Reviewed-on: https://code.wireshark.org/review/13463 Petri-Dish: João Valverde <j@v6e.pt> Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org> Reviewed-by: João Valverde <j@v6e.pt>
2015-12-09new_register_dissector -> register_dissector for dissector directory.Michael Mann1-1/+1
Change-Id: Ie39ef054a4a942687bd079f3a4d8c2cc55d5f22c Reviewed-on: https://code.wireshark.org/review/12485 Petri-Dish: Michael Mann <mmann78@netscape.net> Reviewed-by: Michael Mann <mmann78@netscape.net>
2015-10-30[OpenFlow] Use correct name for flag OFPMPF_REPLY_MORE.Pavlos Antoniou1-2/+3
Change-Id: Id190d1a1e24df0c79026bb8dbf62ccd154c1e90d Reviewed-on: https://code.wireshark.org/review/11399 Reviewed-by: Alexis La Goutte <alexis.lagoutte@gmail.com> Petri-Dish: Alexis La Goutte <alexis.lagoutte@gmail.com> Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org> Reviewed-by: Anders Broman <a.broman58@gmail.com>
2015-10-19[OpenFlow] Fix a crash caused by the same filter name used for severalAndersBroman1-10/+10
different ftypes. Change-Id: Idf4335b2ab733af74afd23bdde066bff81d13952 Reviewed-on: https://code.wireshark.org/review/11148 Reviewed-by: Anders Broman <a.broman58@gmail.com> Petri-Dish: Anders Broman <a.broman58@gmail.com> Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org> Reviewed-by: Michael Mann <mmann78@netscape.net>
2015-06-15openflow_v4: oxm_length includes experimenterHiroaki KAWAI1-0/+3
As defined in section 7.2.3.10 "Experimenter Flow Match Fields" of openflow-switch v1.3.5 spec. Change-Id: I7268f614417720f225a22b226c8f21603b7f2d0f Reviewed-on: https://code.wireshark.org/review/8882 Reviewed-by: Alexis La Goutte <alexis.lagoutte@gmail.com> Petri-Dish: Alexis La Goutte <alexis.lagoutte@gmail.com> Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org> Reviewed-by: Anders Broman <a.broman58@gmail.com>
2014-12-21Cleanup use of #includes in non-generated epan/dissector/*.cBill Meier1-1/+0
Specifically: - Set packet.h to be the first wireshark #include after config.h and "system" #includes. packet.h added as an #include in some cases when missing. - Remove some #includes included (directly/indirectly) in packet.h. E.g., glib.h. (Done only for those files including packet.h). - As needed, move "system" #includes to be after config.h and before wireshark #includes. - Rework various #include file specifications for consistency. - Misc. Change-Id: Ifaa1a14b50b69fbad38ea4838a49dfe595c54c95 Reviewed-on: https://code.wireshark.org/review/5923 Petri-Dish: Alexis La Goutte <alexis.lagoutte@gmail.com> Reviewed-by: Bill Meier <wmeier@newsguy.com>
2014-11-26openflow: Use (what appear to be the) correct filter names for a few fields.Bill Meier1-4/+4
Change-Id: I2acd93d99942601b34c85177d21bbc2c4a4e2633 Reviewed-on: https://code.wireshark.org/review/5492 Reviewed-by: Anders Broman <a.broman58@gmail.com>
2014-11-25openflow: Minor changesBill Meier1-5/+6
- Remove unneeded/undefined forward declarations; - Create/use some extended value-strings; - Do some whitespace changes. Change-Id: I7961864f0e404e141d2887584751116011f8d941 Reviewed-on: https://code.wireshark.org/review/5490 Reviewed-by: Bill Meier <wmeier@newsguy.com>
2014-09-19Do encoding-arg changes (all benign)Bill Meier1-3/+3
For: - FT_BYTES: Always use just ENC_NA - integral/floating (other than FT_[U]INT8): Do ENC_NA --> ENC_BIG_ENDIAN Also: - FT_UINT... --> FT_UINT8 in a few cases (to match proto_tree_add_item...) - Change one case of incorrect '||' to '|' Change-Id: I427e0e61618ff8faf55691c8a695930f67d455b0 Reviewed-on: https://code.wireshark.org/review/4184 Reviewed-by: Bill Meier <wmeier@newsguy.com>
2014-07-27Fix yet another openflow underflow issue.Evan Huus1-0/+4
I thought I'd found all of these but I guess I hadn't; good thing the fuzz-bot kept looking. Bug:10314 Change-Id: I2cc209a6c87781d10cae28f2cb91400d759f5091 Reviewed-on: https://code.wireshark.org/review/3205 Reviewed-by: Evan Huus <eapache@gmail.com>
2014-07-06Widen openflow variables and check for underflowsEvan Huus1-10/+15
As suggested by Alexis reviewing change Ie76c5a810af927b, this issue was scattered throughout the v4/v5 openflow dissectors. Hopefully I got all of them. Original issue found in bug 10259. Change-Id: Idf87deea34132aec5cd4e8f83264906a29b15568 Reviewed-on: https://code.wireshark.org/review/2878 Reviewed-by: Evan Huus <eapache@gmail.com> Reviewed-by: Alexis La Goutte <alexis.lagoutte@gmail.com>
2014-07-05convert to proto_tree_add_subtree[_format]Michael Mann1-68/+29
Change-Id: I8df48b25de784a48a25f0e48aac1e1545ed92c35 Reviewed-on: https://code.wireshark.org/review/2865 Reviewed-by: Michael Mann <mmann78@netscape.net>
2014-07-04Expand a variable from 16 to 32 bits (and make it signed).Evan Huus1-1/+1
Fixes an overflow leading to infinite loop. Bug: 10259 Change-Id: Ie76c5a810af927ba092f4067268bd789b3a7d7bf Reviewed-on: https://code.wireshark.org/review/2856 Reviewed-by: Evan Huus <eapache@gmail.com>
2014-06-20Cleanup display filters reported by checkfiltername.plMichael Mann1-1/+1
Also ensured some files have their correct names at the top so they are more easily grepped Change-Id: Ib0f5ddf14eb1616a93dee496107dc0eb09048825 Reviewed-on: https://code.wireshark.org/review/2452 Reviewed-by: Michael Mann <mmann78@netscape.net>
2014-06-07tvb_new_subset -> tvb_new_subset_length when length parameters are equal.Michael Mann1-2/+2
tvb_new_subset -> tvb_new_subset_remaining it appears that's what the intention is. Change-Id: I2334bbf3f10475b3c22391392fc8b6864454de2d Reviewed-on: https://code.wireshark.org/review/1999 Reviewed-by: Pascal Quantin <pascal.quantin@gmail.com>
2014-05-28Minor: use VALS macro (as per convention); Add editor modelines; Do ↵Bill Meier1-1/+14
whitespace changes. Change-Id: I6007c1b2098d06e4a892474dd07f06a7538f94ef Reviewed-on: https://code.wireshark.org/review/1843 Reviewed-by: Bill Meier <wmeier@newsguy.com>
2014-05-05OpenFlow 1.3 OXM field OXM_OF_IPV6_ND_SLL incorrectly dissected (128 bits ↵Alexis La Goutte1-2/+2
read instead of 48) Dissection of OXM_OF_IPV6_ND_SLL triggers "malformed packet" comment in packet list since it makes dissecting of further OXM fields impossible. It is possible that similar issue will be with OXM_OF_IPV6_ND_TLL since its dissecting is basically the same. Issue found by Viktor Closed-bug:10011 Change-Id: I13893710ad4028669e454c6f8485f719b62bcaab Reviewed-on: https://code.wireshark.org/review/1504 Reviewed-by: Anders Broman <a.broman58@gmail.com>
2014-05-04Update some soft-deprecated APIs.AndersBroman1-1/+1
Change-Id: I0e255e72dd4cd9a94a4f92af409c4b34c0a266ed Reviewed-on: https://code.wireshark.org/review/1491 Reviewed-by: Anders Broman <a.broman58@gmail.com>
2014-04-18Fix infinite loop. Bug #10003.Evan Huus1-8/+16
Also do a quick scan for other similar issues and fix them too; this type of underflow has popped up three times now in the openflow dissector in separate bugs. Hopefully this squashes the last of them. Change-Id: Id404433333016f64cdd83d7e0f9e60a3028d2d0b Reviewed-on: https://code.wireshark.org/review/1207 Reviewed-by: Evan Huus <eapache@gmail.com>
2014-04-15Fix typo for packet-openflow_v4.c, Unknown Message TypeShu Shen1-1/+1
Change-Id: I6b416785f99c9a333d799188f06637d6643b4a38 Signed-off-by: Shu Shen <shu.shen@gmail.com> Reviewed-on: https://code.wireshark.org/review/1147 Reviewed-by: Evan Huus <eapache@gmail.com>
2014-04-14Fix infinite loop. Bug 9986Michael Mann1-0/+3
Change-Id: Idbd22522918f0db131945d2a39f38b963ca3e0c2 Reviewed-on: https://code.wireshark.org/review/1093 Reviewed-by: Michael Mann <mmann78@netscape.net>
2014-04-12Adding message type to COL_INFO for multipart messagesShu Shen1-0/+6
Change-Id: I0ae84101c71f31e2d6ab91c7f7b74da81865b8f3 Signed-off-by: Shu Shen <shu.shen@gmail.com> Reviewed-on: https://code.wireshark.org/review/1075 Reviewed-by: Michael Mann <mmann78@netscape.net>
2014-04-10Fix infinite loop. Bug 9970Michael Mann1-2/+4
Change-Id: I4f928187b9ba3e522f63f6b6987587e3638d8ba7 Reviewed-on: https://code.wireshark.org/review/1057 Reviewed-by: Francesco Fondelli <francesco.fondelli@gmail.com> Reviewed-by: Michael Mann <mmann78@netscape.net>
2014-03-04Remove all $Id$ from top of fileAlexis La Goutte1-2/+0
(Using sed : sed -i '/^ \* \$Id\$/,+1 d') Fix manually some typo (in export_object_dicom.c and crc16-plain.c) Change-Id: I4c1ae68d1c4afeace8cb195b53c715cf9e1227a8 Reviewed-on: https://code.wireshark.org/review/497 Reviewed-by: Anders Broman <a.broman58@gmail.com>
2014-02-25Remove trailing whitespace.Bill Meier1-1/+1
Change-Id: Ia03a1cd4590aceda30ead4aa93ad413d90c6aea6 Reviewed-on: https://code.wireshark.org/review/372 Reviewed-by: Bill Meier <wmeier@newsguy.com> Tested-by: Bill Meier <wmeier@newsguy.com>
2013-12-14Remove not needed ';'Jakub Zawadzki1-3/+3
svn path=/trunk/; revision=54088
2013-11-18I guess "v4" is 1.3 and "v5" is 1.4. I'm sure there's a reason why thatGuy Harris1-2/+2
makes sense of a sort.... svn path=/trunk/; revision=53409
2013-11-18You don't get to have three separate protocols all with the nameGuy Harris1-2/+2
"OpenFlow 1.3". svn path=/trunk/; revision=53408
2013-11-12Fix Dead Store (Dead assignement/Dead increment) warning found by ClangAlexis La Goutte1-3/+1
svn path=/trunk/; revision=53267
2013-11-07(re)Fix warning found by fix-encodings-arg toolAlexis La Goutte1-15/+15
svn path=/trunk/; revision=53138
2013-11-06Add Zoltan Lajos Kis as authorMichael Mann1-0/+1
svn path=/trunk/; revision=53119
2013-11-05From Zoltán Lajos Kis:Anders Broman1-0/+20
display present bit for vlan oxm field https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=9283 svn path=/trunk/; revision=53092
2013-11-04From Zoltán Lajos Kis:Anders Broman1-361/+264
tidying some stuff. https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=9283 svn path=/trunk/; revision=53079
2013-11-03NULL terminate a value_strAnders Broman1-1/+2
svn path=/trunk/; revision=53069
2013-11-03From Zoltán Lajos Kis:Anders Broman1-21/+1130
dissect the rest of the messages. https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=9283 svn path=/trunk/; revision=53068
2013-11-02Fix warning found by fix-encodings-arg toolAlexis La Goutte1-66/+66
svn path=/trunk/; revision=53047
generated by cgit v1.2.3 (git 2.25.1) at 2024-07-03 20:51:21 +0000