aboutsummaryrefslogtreecommitdiffstats
path: root/epan/dissectors/packet-ntp.c
AgeCommit message (Collapse)AuthorFilesLines
2022-02-15Tools: Fix fix-encoding-args.pl ASCII string validationJoão Valverde1-7/+7
Do not require a useless ENC_NA parameter for string encodings. FT_STRING and FT_STRINGZ types don't have any ndianness. Follow-up to 6ec429622c9258eefd388caf21ce92ab5b9f54b4.
2021-12-19Replace g_snprintf() with snprintf() (dissectors)João Valverde1-4/+4
Use macros from inttypes.h with format strings.
2021-10-07to_str: scope tvb_ip_to_strEvan Huus1-1/+1
2021-09-23Fix some spelling errors.Martin Mathieson1-1/+1
2021-09-16tvbparse: explicitly memory-scope parserEvan Huus1-1/+1
Avoids the use of the global memory pool in favour of one the compiler actually knows must be in scope. Also delete a few-hundred lines of if-0ed code that hadn't been active in 15+ years.
2021-01-03ntp: remove size constraint for invalid refid.Dario Lombardo1-1/+1
When the refid contains non-ascii chars, the conversion function returns a string longer than 4 chars. This results in an invalid string if the output is limited to 4 bytes. Incidentally this results in an invalid PDML output as well that caught this bug in the first place. Fix: #17112.
2020-09-13More dissector string spelling fixes.Martin Mathieson1-1/+1
Finally, it is becoming difficult to find more.
2020-08-31More spelling fixes, part 2 of 2nd pass of dissectors.Martin Mathieson1-1/+1
There will likely be one for for this pass. Further improvements to the script are possible, i.e. filtering out (usually filter) strings such as 'onetwothree' - may not be worth it though.
2020-08-30More spelling fixes, start of second pass of dissectors.Martin Mathieson1-11/+11
Now easier to find errors due to script improvements and more complete dictionary file.
2020-08-04NTP: fix detection of larger MAC sizes, remove Autokey supportPeter Wu1-155/+117
Autokey was not properly supported, the v2 version check looked at the wrong field (Code instead of Field Type). Since nobody noticed it, let's remove it to simplify the code. Improve the Extension Field (EF) heuristics to ensure that larger digest sizes such as SHA-512 are recognized, and to support messages without MAC. Previously only MD5 and SHA-1 were supported as these are the only ones that are defined by the RFCs. The ntp_ext_field_types array was generated by: curl -s https://www.iana.org/assignments/ntp-parameters/ntp-parameters-3.csv | awk -F, 'NR>=2{printf "{ %s, \"%s\" },\n", $1, $2}' | sort -n Tested with md5_dgrams.pcapng and sha1_dgrams.pcapng (Bug 11580) and NTP-with-mac.pcap (Bug 16640). Also checked against the NTS capture (go_embeded.pcapng, bug 16222), but TCP reassembly is not supported so the last part of the first segment is wrongly dissected as MAC. Bug: 16640 Change-Id: I07fc46c6d8995e6c791952dd7cd84d798cddd21a Reviewed-on: https://code.wireshark.org/review/38037 Petri-Dish: Peter Wu <peter@lekensteyn.nl> Tested-by: Petri Dish Buildbot Reviewed-by: Anders Broman <a.broman58@gmail.com>
2020-06-19Fix the type of arrays of pointers to hf_ values for bitfield routines.Guy Harris1-12/+12
The static arrays are supposed to be arrays of const pointers to int, not arrays of non-const pointers to const int. Fixing that means some bugs (scribbling on what's *supposed* to be a const array) will be caught (see packet-ieee80211-radiotap.c for examples, the first of which inspired this change and the second of which was discovered while testing compiles with this change), and removes the need for some annoying casts. Also make some of those arrays static while we're at it. Update documentation and dissector-generator tools. Change-Id: I789da5fc60aadc15797cefecfd9a9fbe9a130ccc Reviewed-on: https://code.wireshark.org/review/37517 Petri-Dish: Guy Harris <gharris@sonic.net> Tested-by: Petri Dish Buildbot Reviewed-by: Anders Broman <a.broman58@gmail.com>
2020-01-21Put various epoch time deltas into wsutil/epochs.h.Guy Harris1-2/+7
There are some deltas between the UN*X epoch and other epochs that are used in a number of places; put them into a header. Change-Id: Ia2d9d69b9d91352d730d97d9e4897518635b4861 Reviewed-on: https://code.wireshark.org/review/35895 Petri-Dish: Guy Harris <guy@alum.mit.edu> Tested-by: Petri Dish Buildbot Reviewed-by: Guy Harris <guy@alum.mit.edu>
2019-08-29Add proto_tree_add_item_ret_time_stringMichael Mann1-94/+5
A few dissectors need the functionality of adding a time field to a proto_tree while also needing the "time to string" value (typically to show on a tree above). The functionality to do "get value from tvb and convert to string" was being done in packet-ntp.c. Instead proto_tree_add_item_ret_time_string can be used with various encoding to get the necessary functionality with less code duplication. ENC_TIME_MIP6 was added as a result of the refactoring. ABSOLUTE_TIME_NTP_UTC was added as another potential "base" type for time fields. Change-Id: Ie460c33370b0af59ef60bdab893ce9d6eb23b94f Reviewed-on: https://code.wireshark.org/review/34390 Petri-Dish: Anders Broman <a.broman58@gmail.com> Tested-by: Petri Dish Buildbot Reviewed-by: Anders Broman <a.broman58@gmail.com>
2019-07-26HTTPS (almost) everywhere.Guy Harris1-1/+1
Change all wireshark.org URLs to use https. Fix some broken links while we're at it. Change-Id: I161bf8eeca43b8027605acea666032da86f5ea1c Reviewed-on: https://code.wireshark.org/review/34089 Reviewed-by: Guy Harris <guy@alum.mit.edu>
2019-04-04epan: Convert our PROTO_ITEM_ macros to inline functions.Gerald Combs1-11/+11
Convert our various PROTO_ITEM_ macros to inline functions and document them. Change-Id: I070b15d4f70d2189217a177ee8ba2740be36327c Reviewed-on: https://code.wireshark.org/review/32706 Reviewed-by: Gerald Combs <gerald@wireshark.org> Petri-Dish: Gerald Combs <gerald@wireshark.org> Reviewed-by: Anders Broman <a.broman58@gmail.com>
2019-01-11dissectors: remove unused assignments.Dario Lombardo1-1/+0
Found by clang-scan. Change-Id: I46d3be9032c8d34a76ecd844287c36aff733ea2d Reviewed-on: https://code.wireshark.org/review/31482 Reviewed-by: Kenneth Soerensen <knnthsrnsn@gmail.com> Petri-Dish: Dario Lombardo <lomato@gmail.com> Tested-by: Petri Dish Buildbot Reviewed-by: Alexis La Goutte <alexis.lagoutte@gmail.com>
2019-01-08NTP: don't increment offsets that aren't used again.Jeff Morriss1-31/+0
This avoids warnings from Clang. Rewriting this to use the cursor API might be interesting. Change-Id: I8a5459ffbee8d0907757e99eff273d7eff6d1735 Reviewed-on: https://code.wireshark.org/review/31436 Petri-Dish: Jeff Morriss <jeff.morriss.ws@gmail.com> Tested-by: Petri Dish Buildbot Reviewed-by: Anders Broman <a.broman58@gmail.com>
2019-01-05NTP: Adding missing commands of ntpdc mode 7Uli Heilmeier1-85/+1843
Used documentation of bug report. Bug: 15272 Change-Id: I83871b7458c36df711502bc6aa954a8c3c53604d Reviewed-on: https://code.wireshark.org/review/31385 Petri-Dish: Alexis La Goutte <alexis.lagoutte@gmail.com> Tested-by: Petri Dish Buildbot Reviewed-by: Anders Broman <a.broman58@gmail.com>
2018-11-07NTP: fix dissection of authentication parameters in mode 7 packetsPascal Quantin1-12/+14
Based on ntp_request.h header file: - authentication parameters are only present in request messages, not resonse ones - the authentication timestamp is at a fixed position with an offset of 184 bytes in the packet, followed by the encryption keyid and optionally the mac - do not display the authentication timestamp (even if present in the packet) if the authentication bit is not set (as the value 0 translates into a date in 2036) Bug: 15258 Change-Id: Id2e49beeef4a0fdc3082d9b7b09a214fd531a6bb Reviewed-on: https://code.wireshark.org/review/30527 Petri-Dish: Pascal Quantin <pascal.quantin@gmail.com> Tested-by: Petri Dish Buildbot Reviewed-by: Pascal Quantin <pascal.quantin@gmail.com>
2018-11-06NTP: add request/response tracking to mode 7 packetsPascal Quantin1-27/+66
Change-Id: I8cee0b2fb6f371682df045cbae4193e871b485c5 Reviewed-on: https://code.wireshark.org/review/30516 Petri-Dish: Pascal Quantin <pascal.quantin@gmail.com> Tested-by: Petri Dish Buildbot Reviewed-by: Anders Broman <a.broman58@gmail.com>
2018-11-06NTP: fix parsing of NTP mode 7 messagesPascal Quantin1-34/+62
- fix byte used for A and Sequence fields - added missing unused field in MON_GETLIST_1 strcuture - added dissection of MON_GETLIST structure - added dissection of Encryption Keyid and MAC fields Bug: 15258 Change-Id: I7525fcd8daeeeef449294c0d79c2853a852328ed Reviewed-on: https://code.wireshark.org/review/30514 Petri-Dish: Pascal Quantin <pascal.quantin@gmail.com> Tested-by: Petri Dish Buildbot Reviewed-by: Anders Broman <a.broman58@gmail.com>
2018-10-31NTP: add request/response tracking to client, server and control packetsPascal Quantin1-2/+138
Bug: 14659 Change-Id: Ic7faa96765911048931d07e5ec4220ba9b713e9f Reviewed-on: https://code.wireshark.org/review/30442 Petri-Dish: Pascal Quantin <pascal.quantin@gmail.com> Tested-by: Petri Dish Buildbot Reviewed-by: Pascal Quantin <pascal.quantin@gmail.com>
2018-10-21ntp: change root delay and dispersion to integer for fixed precision.Dario Lombardo1-12/+16
dfilter/group_double tests have been removed and need to be replaced by leveraging another protocol. Bug: 15049 Change-Id: I354a27a5217336ee5c9b1d021a2d3226e3532eec Reviewed-on: https://code.wireshark.org/review/29035 Reviewed-by: Peter Wu <peter@lekensteyn.nl> Petri-Dish: Peter Wu <peter@lekensteyn.nl> Tested-by: Petri Dish Buildbot Reviewed-by: Michael Mann <mmann78@netscape.net>
2018-09-04ntp: make ntp.precision an uint8.Dario Lombardo1-3/+3
Change-Id: I7ee0c7fbe5bab90bd1109b2f39feaec033b95621 Reviewed-on: https://code.wireshark.org/review/29178 Petri-Dish: Dario Lombardo <lomato@gmail.com> Tested-by: Petri Dish Buildbot Reviewed-by: Peter Wu <peter@lekensteyn.nl>
2018-08-16ntp: fix mixed indentation.Dario Lombardo1-101/+77
Change-Id: I2575fbe94aeae5a726e7a3f76406d5c90356c8b9 Reviewed-on: https://code.wireshark.org/review/29042 Petri-Dish: Dario Lombardo <lomato@gmail.com> Reviewed-by: Peter Wu <peter@lekensteyn.nl> Tested-by: Petri Dish Buildbot Reviewed-by: Dario Lombardo <lomato@gmail.com>
2018-08-10ntp: use 'seconds' instead of 'sec' for uniformity.Dario Lombardo1-2/+2
Change-Id: I40f34a2d1025fe2baf7c492428e7c8ab934fa63f Ping-Bug: 15049 Reviewed-on: https://code.wireshark.org/review/29037 Petri-Dish: Dario Lombardo <lomato@gmail.com> Tested-by: Petri Dish Buildbot Reviewed-by: Anders Broman <a.broman58@gmail.com>
2018-04-10Add, and use, "fetch signed value" for lengths < 40 bits.Guy Harris1-2/+2
Add 8-bit, 16-bit, 24-bit, and 32-bit "fetch signed value" routines, and use them rather than casting the result of the 8/16/24/32-bit "fetch unsigned value" routines to a signed type (which, BTW, isn't sufficient for 24-bit values, so this appears to fix a bug in epan/dissectors/packet-zbee-zcl.c). Use numbers rather than sizeof()s in various tvb_get_ routines. Change-Id: I0e48a57fac9f70fe42de815c3fa915f1592548bd Reviewed-on: https://code.wireshark.org/review/26844 Petri-Dish: Guy Harris <guy@alum.mit.edu> Tested-by: Petri Dish Buildbot Reviewed-by: Anders Broman <a.broman58@gmail.com>
2018-02-12dissectors: use SPDX identifiers.Dario Lombardo1-13/+1
Change-Id: I92c94448e6641716d03158a5f332c8b53709423a Reviewed-on: https://code.wireshark.org/review/25756 Petri-Dish: Dario Lombardo <lomato@gmail.com> Reviewed-by: Anders Broman <a.broman58@gmail.com>
2018-01-13NTP: Updated system and peer status codesUli Heilmeier1-15/+34
Used reference: https://tools.ietf.org/html/draft-ietf-ntp-mode-6-cmds-03 http://doc.ntp.org/current-stable/decode.html Bug: 14271 Change-Id: Iab829e31206f99b3458f68c6c65cc6188916a3bb Reviewed-on: https://code.wireshark.org/review/25296 Reviewed-by: Michael Mann <mmann78@netscape.net>
2018-01-12NTP: Decode data of opcodes 8,9,10,11,12Uli Heilmeier1-1/+35
Decode additional data of NTP opcodes 8,9,10,11,12 only as one string. There's room for improvement to dissect the string for all the name=value pairs. To do so more samples of different implementations are needed. Used reference: * https://tools.ietf.org/html/draft-ietf-ntp-mode-6-cmds-03 * http://doc.ntp.org/ * sample captures attached to bug Bug: 14270 Change-Id: I4da537bf2a984b673845333714d8a8cb873f3147 Reviewed-on: https://code.wireshark.org/review/25281 Petri-Dish: Anders Broman <a.broman58@gmail.com> Tested-by: Petri Dish Buildbot Reviewed-by: Michael Mann <mmann78@netscape.net>
2018-01-09NTP: Update values for opcodeUli Heilmeier1-18/+28
Used refs: https://github.com/ntp-project/ntp/blob/stable/include/ntp_control.h https://tools.ietf.org/html/draft-ietf-ntp-mode-6-cmds-03#section-4 Ping-Bug: 14270 Change-Id: Ie2a30ef316f85313f6f626772c6544c315db5b68 Reviewed-on: https://code.wireshark.org/review/25232 Petri-Dish: Alexis La Goutte <alexis.lagoutte@gmail.com> Tested-by: Petri Dish Buildbot Reviewed-by: Anders Broman <a.broman58@gmail.com>
2017-12-11NTP: fix authenticator dissection when padding is usedPascal Quantin1-3/+17
Bug: 14269 Change-Id: Ifdc9af7524a0566e33acbedff3757cff416ce8fb Reviewed-on: https://code.wireshark.org/review/24758 Reviewed-by: Pascal Quantin <pascal.quantin@gmail.com> Petri-Dish: Pascal Quantin <pascal.quantin@gmail.com> Tested-by: Petri Dish Buildbot Reviewed-by: Michael Mann <mmann78@netscape.net>
2017-12-11NTP: fix parsing of multiple comma separated identifiersPascal Quantin1-2/+7
Bug: 14268 Change-Id: Id1d6040052d34d3f8bdfe49d20f4f3f8efbe001b Reviewed-on: https://code.wireshark.org/review/24755 Reviewed-by: Pascal Quantin <pascal.quantin@gmail.com> Petri-Dish: Pascal Quantin <pascal.quantin@gmail.com> Tested-by: Petri Dish Buildbot Reviewed-by: Michael Mann <mmann78@netscape.net>
2017-03-05dissectors: fix this statement may fall through ↵Alexis La Goutte1-0/+1
[-Werror=implicit-fallthrough=] found by gcc7 Change-Id: Iba6238988ded675cba328ab512232d1919d93b4a Reviewed-on: https://code.wireshark.org/review/20415 Petri-Dish: Alexis La Goutte <alexis.lagoutte@gmail.com> Reviewed-by: Alexis La Goutte <alexis.lagoutte@gmail.com> Reviewed-by: Michael Mann <mmann78@netscape.net>
2017-02-24Make MIPv6 options into a dissector table.Michael Mann1-5/+1
This provides external access for dissectors and plugins to provide their own implementation of MIPv6 options. Also cleaned up some of the "offset defines" and just went with relative increments for the option functions. Change-Id: I40db0b316eec37ee2045e6d663829ce69e3dac37 Reviewed-on: https://code.wireshark.org/review/20257 Petri-Dish: Michael Mann <mmann78@netscape.net> Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org> Reviewed-by: Anders Broman <a.broman58@gmail.com>
2016-12-13Add support for adding unit names to hf_ fields.Michael Mann1-12/+6
This was inspired by the https://www.wireshark.org/lists/wireshark-dev/201505/msg00029.html thread. Used TCP and NTP dissectors as the guinea pig with sample use. Documentation updates includes some unrelated cleanup just because it was noticed. Change-Id: I59b26e1ca3b95e3473e4757f1759d7ad82976965 Reviewed-on: https://code.wireshark.org/review/19211 Reviewed-by: Alexis La Goutte <alexis.lagoutte@gmail.com> Petri-Dish: Alexis La Goutte <alexis.lagoutte@gmail.com> Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org> Reviewed-by: Michael Mann <mmann78@netscape.net>
2016-10-13Convert most UDP dissectors to use "auto" preferences.Michael Mann1-1/+1
Similar to the "tcp.port" changes in I99604f95d426ad345f4b494598d94178b886eb67, convert dissectors that use "udp.port". More cleanup done on dissectors that use both TCP and UDP dissector tables, so that less preference callbacks exist. Change-Id: If07be9b9e850c244336a7069599cd554ce312dd3 Reviewed-on: https://code.wireshark.org/review/18120 Petri-Dish: Michael Mann <mmann78@netscape.net> Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org> Reviewed-by: Michael Mann <mmann78@netscape.net>
2016-10-08Combine Decode As and port preferences for tcp.port dissector table.Michael Mann1-1/+1
This patch introduces new APIs to allow dissectors to have a preference for a (TCP) port, but the underlying data is actually part of Decode As functionality. For now the APIs are intentionally separate from the regular APIs that register a dissector within a dissector table. It may be possible to eventually combine the two so that all dissectors that register with a dissector table have an opportunity to "automatically" have a preference to adjust the "table value" through the preferences dialog. The tcp.port dissector table was used as the guinea pig. This will eventually be expanded to other dissector tables as well (most notably UDP ports). Some dissectors that "shared" a TCP/UDP port preference were also converted. It also removed the need for some preference callback functions (mostly when the callback function was the proto_reg_handoff function) so there is cleanup around that. Dissectors that has a port preference whose default was 0 were switched to using the dissector_add_for_decode_as_with_preference API rather than dissector_add_uint_with_preference Also added comments for TCP ports used that aren't IANA registered. Change-Id: I99604f95d426ad345f4b494598d94178b886eb67 Reviewed-on: https://code.wireshark.org/review/17724 Reviewed-by: Michael Mann <mmann78@netscape.net>
2016-01-08Fix a lot of typos and misspellingsmoshekaplan1-2/+2
Change-Id: I8512cfa1d424f82a873a0e0e1d22c7b075fdd7f3 Reviewed-on: https://code.wireshark.org/review/13069 Reviewed-by: Alexis La Goutte <alexis.lagoutte@gmail.com> Petri-Dish: Alexis La Goutte <alexis.lagoutte@gmail.com> Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org> Reviewed-by: Michael Mann <mmann78@netscape.net>
2015-12-09new_create_dissector_handle -> create_dissector_handle for dissector directory.Michael Mann1-1/+1
Some of the ASN.1 dissectors still generate a new_create_dissector_handle from the tool itself, so leave those for now. Change-Id: Ic6e5803b1444d7ac24070949f5fd557909a5641f Reviewed-on: https://code.wireshark.org/review/12484 Petri-Dish: Anders Broman <a.broman58@gmail.com> Reviewed-by: Michael Mann <mmann78@netscape.net>
2015-11-16create_dissector_handle -> new_create_dissector_handleMichael Mann1-3/+4
Picking off "easy" dissectors that only have one or two exit points at most. Change-Id: I96aa9cf53533cbb07105aa400d42922baf3016b3 Reviewed-on: https://code.wireshark.org/review/11860 Petri-Dish: Michael Mann <mmann78@netscape.net> Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org> Reviewed-by: Michael Mann <mmann78@netscape.net>
2015-10-12NTP: fix dissection of SHA1 based message authentication codePascal Quantin1-3/+3
The maximum MAC length is 160 bits, not 128. MAX_MAC_LEN can be safely increased as an extension should be > 4 bytes. Bug: 11580 Change-Id: I0ea5a1f85d644e57315f033f09241d7a79dd3a45 Reviewed-on: https://code.wireshark.org/review/10934 Reviewed-by: Pascal Quantin <pascal.quantin@gmail.com> Petri-Dish: Pascal Quantin <pascal.quantin@gmail.com> Reviewed-by: Alexis La Goutte <alexis.lagoutte@gmail.com> Reviewed-by: Anders Broman <a.broman58@gmail.com>
2015-10-04Add NTP authentication dissection.Michael Mann1-341/+350
It just dissects the fields, it doesn't do any decryption. Also general cleanup while in the neighborhood. Bug: 11022 Change-Id: I9acc787473c04730eab6016dce988dd194287894 Reviewed-on: https://code.wireshark.org/review/10759 Petri-Dish: Michael Mann <mmann78@netscape.net> Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org> Reviewed-by: Michael Mann <mmann78@netscape.net>
2015-07-23NTP: fix DISSECTOR_ASSERT when decoding v6_flagsAlexis La Goutte1-2/+2
Issue include in g8d6324f75 Change-Id: I49267b90a4a196409df76cb369d2dfacf42ba8d3 Ping-Bug:11361 Reviewed-on: https://code.wireshark.org/review/9754 Reviewed-by: Michael Mann <mmann78@netscape.net> Petri-Dish: Michael Mann <mmann78@netscape.net> Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org> Reviewed-by: Anders Broman <a.broman58@gmail.com>
2015-04-22Convert proto_tree_add_boolean to ↵Michael Mann1-3/+1
proto_tree_add_bitmask_[value|value_with_flags|list] Part 2 of a few Change-Id: Ic1f1aafe2ed02dce95b15c03a91cbd68807a5cf4 Reviewed-on: https://code.wireshark.org/review/8165 Petri-Dish: Alexis La Goutte <alexis.lagoutte@gmail.com> Reviewed-by: Michael Mann <mmann78@netscape.net>
2015-03-10[GTPv2] Dissect ULI Timestamp.AndersBroman1-0/+40
Change-Id: If257831315423e5654cbbc3f6af99703cfad7f90 Reviewed-on: https://code.wireshark.org/review/7614 Reviewed-by: Anders Broman <a.broman58@gmail.com>
2014-12-21Cleanup use of #includes in non-generated epan/dissector/*.cBill Meier1-4/+0
Specifically: - Set packet.h to be the first wireshark #include after config.h and "system" #includes. packet.h added as an #include in some cases when missing. - Remove some #includes included (directly/indirectly) in packet.h. E.g., glib.h. (Done only for those files including packet.h). - As needed, move "system" #includes to be after config.h and before wireshark #includes. - Rework various #include file specifications for consistency. - Misc. Change-Id: Ifaa1a14b50b69fbad38ea4838a49dfe595c54c95 Reviewed-on: https://code.wireshark.org/review/5923 Petri-Dish: Alexis La Goutte <alexis.lagoutte@gmail.com> Reviewed-by: Bill Meier <wmeier@newsguy.com>
2014-08-28NTP: fix parsing of control assignments with empty valuePascal Quantin1-3/+6
Consider that ',' is a separator between assignments and make value presence optional Bug: 10417 Change-Id: I23f2b4029548a1263d65ee11c6356270e7a89bd7 Reviewed-on: https://code.wireshark.org/review/3884 Reviewed-by: Evan Huus <eapache@gmail.com> Petri-Dish: Alexis La Goutte <alexis.lagoutte@gmail.com> Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org> Reviewed-by: Alexis La Goutte <alexis.lagoutte@gmail.com>
2014-08-18Eliminate proto_tree_add_text from some dissectors.Michael Mann1-32/+39
Other minor cleanup while in the neighborhood. Change-Id: I77cac916d617f56f92f686e9cd9f15fba058facf Reviewed-on: https://code.wireshark.org/review/3675 Reviewed-by: Michael Mann <mmann78@netscape.net> Petri-Dish: Michael Mann <mmann78@netscape.net> Reviewed-by: Anders Broman <a.broman58@gmail.com>
2014-06-19Revert "Fixup: tvb_* -> tvb_captured"Michael Mann1-2/+2
https://www.wireshark.org/lists/wireshark-dev/201406/msg00131.html This reverts commit 246fe2ca4c67d8c98caa84e2f57694f6322e2f96. Change-Id: Ib24bae0198c13a84bd7f731bf4af921212109a8f Reviewed-on: https://code.wireshark.org/review/2430 Reviewed-by: Michael Mann <mmann78@netscape.net>
generated by cgit v1.2.3 (git 2.25.1) at 2024-06-28 12:58:05 +0000