Age | Commit message (Collapse) | Author | Files | Lines |
|
This reverts commit e8e6a2c6df5ffaf983bdc8b4ccb88c340df8b6cf.
This introduced regression of skipping valid target_info blobs.
The next commit will fix
https://gitlab.com/wireshark/wireshark/-/issues/17817
in a better way.
Signed-off-by: Stefan Metzmacher <metze@samba.org>
|
|
if the NTLMv2 Message is of type AUTHENTICATE_MESSAGE,
there are no target fields, according to MS-NLMP 2.2.1.3,
Fixes #17817
|
|
As requested [here][1], help with replacing calls to
`wmem_packet_scope()` with references to `pinfo->pool`.
My principles were:
* Plugins chosen semi-randomly.
* When a calling function already has a `pinfo` argument, just use that.
* Remove `_U_` from its signature if it was there.
* Don't go more than 2 or 3 levels deep of changing signatures.
* If a function is clearly allocing memory to return, change the
function signature to take a `wmem_allocator_t *`. Otherwise, either
that or take a `packet_info *` as seems to make sense.
* No mention of `wmem_packet_scope()` should remain in the files I've
touched.
* I didn't always succeed at this, but I made a dent.
[1]: https://www.wireshark.org/lists/wireshark-dev/202107/msg00052.html
|
|
|
|
This can also be used by packet-dcerpc-netlogon later.
in order to verify authentications.
Change-Id: I2f145ee1197fc83c77efabc180bac52ebbb0cd60
Signed-off-by: Stefan Metzmacher <metze@samba.org>
Reviewed-on: https://code.wireshark.org/review/36400
Petri-Dish: Anders Broman <a.broman58@gmail.com>
Tested-by: Petri Dish Buildbot
Reviewed-by: Anders Broman <a.broman58@gmail.com>
|
|
We only need that logic once.
Change-Id: Ibc3e28c70dd6e52de3cbc8d5dca0316816f70e5d
Signed-off-by: Stefan Metzmacher <metze@samba.org>
Reviewed-on: https://code.wireshark.org/review/36398
Petri-Dish: Anders Broman <a.broman58@gmail.com>
Reviewed-by: Anders Broman <a.broman58@gmail.com>
|
|
Just use proto_tree_add_item() or tvb_get_string_enc(); that way, we
handle full UTF-16, not just the ISO 8859/1 subset thereof.
Change-Id: I8ded392b87522c45902354092d6988965265d3b3
Reviewed-on: https://code.wireshark.org/review/33567
Petri-Dish: Guy Harris <guy@alum.mit.edu>
Tested-by: Petri Dish Buildbot
Reviewed-by: Guy Harris <guy@alum.mit.edu>
|
|
Change-Id: I92c94448e6641716d03158a5f332c8b53709423a
Reviewed-on: https://code.wireshark.org/review/25756
Petri-Dish: Dario Lombardo <lomato@gmail.com>
Reviewed-by: Anders Broman <a.broman58@gmail.com>
|
|
(Using sed : sed -i '/^ \* \$Id\$/,+1 d')
Fix manually some typo (in export_object_dicom.c and crc16-plain.c)
Change-Id: I4c1ae68d1c4afeace8cb195b53c715cf9e1227a8
Reviewed-on: https://code.wireshark.org/review/497
Reviewed-by: Anders Broman <a.broman58@gmail.com>
|
|
fix NTLMSSP Target Info Attribute dissection
https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=9098
svn path=/trunk/; revision=51764
|
|
This patches add some missing things for SMB2/3 and support for decryption
of SMB3 traffic
https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=7645
From me: Change an initializer from C99 to C89 style (since the
Microsoft compiler doesn't support C99).
svn path=/trunk/; revision=44542
|
|
(COPYING will be updated in next commit)
svn path=/trunk/; revision=43536
|
|
svn path=/trunk/; revision=18196
|
|
svn path=/trunk/; revision=16721
|
|
NTLMSSP-related than SMB-related, and documents about NTLMSSP talk about
it, so it's a little more convenient to keep all that stuff together -
and export it through a packet-ntlmssp.h header.
svn path=/trunk/; revision=11585
|